Re: [COMMITTERS] pgsql: Fix saving and restoring umask

2017-09-23 Thread Peter Eisentraut
On 9/22/17 17:48, Tom Lane wrote: > Peter Eisentraut writes: >> Fix saving and restoring umask >> In two cases, we set a different umask for some piece of code and >> restore it afterwards. But if the contained code errors out, the umask >> is not restored. So add TRY/CATCH blocks to fix that. >

Re: [COMMITTERS] pgsql: Fix saving and restoring umask

2017-09-22 Thread Tom Lane
Peter Eisentraut writes: > Fix saving and restoring umask > In two cases, we set a different umask for some piece of code and > restore it afterwards. But if the contained code errors out, the umask > is not restored. So add TRY/CATCH blocks to fix that. Doesn't that need to be back-patched?