Re: [COMMITTERS] pgsql: Refactor Perl test code

2015-12-02 Thread Tom Lane
Alvaro Herrera writes: > Michael Paquier wrote: >> The issue is fixed by the patch attached. This has been visibly >> forgotten in the version pushed. > Yeah. Pushed. "make check-world" passes again here. Thanks. regards, tom lane -- Sent via pgsql-committers mailin

Re: [COMMITTERS] pgsql: Refactor Perl test code

2015-12-02 Thread Alvaro Herrera
Michael Paquier wrote: > Or in more details: > Undefined subroutine &TestLib::run called at > /Users/mpaquier/git/postgres/src/bin/initdb/../../../src/test/perl/TestLib.pm > line 146. > I am seeing the same failure on all the machines in the buildfarm. > > The issue is fixed by the patch attached

Re: [COMMITTERS] pgsql: Refactor Perl test code

2015-12-02 Thread Michael Paquier
On Thu, Dec 3, 2015 at 8:38 AM, Tom Lane wrote: > Test Summary Report > --- > t/001_initdb.pl (Wstat: 6400 Tests: 8 Failed: 0) > Non-zero exit status: 25 > Parse errors: Bad plan. You planned 14 tests but ran 8. > Files=1, Tests=8, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.08

Re: [COMMITTERS] pgsql: Refactor Perl test code

2015-12-02 Thread Tom Lane
Alvaro Herrera writes: > Refactor Perl test code This has broken "make check-world" for me (on RHEL 6.7): make -C src/bin check make[1]: Entering directory `/home/postgres/pgsql/src/bin' make -C initdb check make[2]: Entering directory `/home/postgres/pgsql/src/bin/initdb' rm -rf /home/postgres/