Re: [COMMITTERS] pgsql: Drat, can't fit an additional

2007-01-28 Thread Bruce Momjian
Tom Lane wrote: > Log Message: > --- > Drat, can't fit an additional argument into log_error. Is it worth an > sprintf pushup to be sure we can report something useful for out-of-range > exitstatus? I thought about that, but out-of-range seemed so unlikely that I didn't do it. -- Bruc

[COMMITTERS] pgsql: Fix up plpgsql's "simple expression" evaluation mechanism so that

2007-01-28 Thread Tom Lane
Log Message: --- Fix up plpgsql's "simple expression" evaluation mechanism so that it behaves safely in the presence of subtransactions. To ensure that any ExprContext shutdown callbacks are called at the right times, we have to have a separate EState for each level of subtransaction. Per

[COMMITTERS] pgsql: Fix up plpgsql's "simple expression" evaluation mechanism so that

2007-01-28 Thread Tom Lane
Log Message: --- Fix up plpgsql's "simple expression" evaluation mechanism so that it behaves safely in the presence of subtransactions. To ensure that any ExprContext shutdown callbacks are called at the right times, we have to have a separate EState for each level of subtransaction. Per

[COMMITTERS] pgsql: Add a new builtin type, "uuid".

2007-01-28 Thread Neil Conway
Log Message: --- Add a new builtin type, "uuid". This implements a UUID type, similar to that defined in RFC 4122. This patch includes the basic implementation, plus regression tests. Documentation and perhaps some additional functionality will come later. Catversion bumped. Patch from Gev

[COMMITTERS] pgsql: Fix path problem in MSVC bison wrapper.

2007-01-28 Thread Andrew Dunstan
Log Message: --- Fix path problem in MSVC bison wrapper. per Joachim Wieland. Modified Files: -- pgsql/src/tools/msvc: pgbison.bat (r1.3 -> r1.4) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/tools/msvc/pgbison.bat.diff?r1=1.3&r2=1.4) -

[COMMITTERS] pgsql: Make some small improvements in the accuracy of plpgsql's error

2007-01-28 Thread Tom Lane
Log Message: --- Make some small improvements in the accuracy of plpgsql's error location reports; inspired by the misleading CONTEXT lines shown in recent bug report from Stefan Kaltenbrunner. Also, allow statement-type names shown in these messages to be translated. Modified Files:

[COMMITTERS] plpsm - plpgpsm: plpgpsm doesn't need any core patch.

2007-01-28 Thread User Okbob
Log Message: --- plpgpsm doesn't need any core patch. Modified Files: -- plpgpsm/src: Makefile (r1.3 -> r1.4) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/plpsm/plpgpsm/src/Makefile.diff?r1=1.3&r2=1.4) gram.y (r1.30 -> r1.31) (http://cvs.pg

[COMMITTERS] pgsql: Repair oversight in creation of "append relations": we should set

2007-01-28 Thread Tom Lane
Log Message: --- Repair oversight in creation of "append relations": we should set up rel->tuples as well as rel->rows, since some estimation functions expect both to be valid in every baserel. Per report from Dave Dutcher. Modified Files: -- pgsql/src/backend/optimizer/pa

[COMMITTERS] pgsql: Repair oversight in creation of "append relations": we should set

2007-01-28 Thread Tom Lane
Log Message: --- Repair oversight in creation of "append relations": we should set up rel->tuples as well as rel->rows, since some estimation functions expect both to be valid in every baserel. Per report from Dave Dutcher. Tags: REL8_2_STABLE Modified Files: -- pgsq

[COMMITTERS] pgsql: Remove some unnecessary conversion work in build_regtype_array().

2007-01-28 Thread Tom Lane
Log Message: --- Remove some unnecessary conversion work in build_regtype_array(). Modified Files: -- pgsql/src/backend/commands: prepare.c (r1.67 -> r1.68) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/prepare.c.diff?r1=1.67&r2=1.6

[COMMITTERS] pgsql: Fix plpython MSVC build in non-debug mode.

2007-01-28 Thread Andrew Dunstan
Log Message: --- Fix plpython MSVC build in non-debug mode. Modified Files: -- pgsql/src/pl/plpython: plpython.c (r1.92 -> r1.93) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/plpython.c.diff?r1=1.92&r2=1.93) ---

[COMMITTERS] pgsql: Rename the uuid_t type to pg_uuid_t, to avoid a conflict with any

2007-01-28 Thread Neil Conway
Log Message: --- Rename the uuid_t type to pg_uuid_t, to avoid a conflict with any definitions of uuid_t that may be provided by the system headers. This should hopefully fix the Win32 build problems reported by Magnus. Modified Files: -- pgsql/src/backend/utils/adt:

[COMMITTERS] pgsql: Remove unnecessary checkpoint from PL regression tests.

2007-01-28 Thread Tom Lane
Log Message: --- Remove unnecessary checkpoint from PL regression tests. This was once handy to prevent core dump files from disappearing, but it's useless now because (a) we don't drop core in individual DB subdirectories anymore, and (b) CREATE DATABASE forces an internal checkpoint anyw

[COMMITTERS] pgsql: Improve hash join to discard input tuples immediately if they

2007-01-28 Thread Tom Lane
Log Message: --- Improve hash join to discard input tuples immediately if they can't match because they contain a null join key (and the join operator is known strict). Improves performance significantly when the inner relation contains a lot of nulls, as per bug #2930. Modified Files: --

[COMMITTERS] plpsm - plpgpsm: merge patch: Make some small improvements in the

2007-01-28 Thread User Okbob
Log Message: --- merge patch: Make some small improvements in the accuracy of plpgsql's error Modified Files: -- plpgpsm/src: pl_exec.c (r1.27 -> r1.28) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/plpsm/plpgpsm/src/pl_exec.c.diff?r1=1.27&r2=1.28) p