[COMMITTERS] pgsql: Add support for GSSAPI authentication.

2007-07-10 Thread Magnus Hagander
Log Message: --- Add support for GSSAPI authentication. Documentation still being written, will be committed later. Henry B. Hotz and Magnus Hagander Modified Files: -- pgsql: configure (r1.549 -> r1.550) (http://developer.postgresql.org/cvsweb.cgi/pgsql/

[COMMITTERS] pgsql: Fix misspelling.

2007-07-10 Thread Tom Lane
Log Message: --- Fix misspelling. Modified Files: -- pgsql: configure.in (r1.517 -> r1.518) (http://developer.postgresql.org/cvsweb.cgi/pgsql/configure.in.diff?r1=1.517&r2=1.518) configure (r1.550 -> r1.551) (http://developer.postgresql.org

Re: [COMMITTERS] pgsql: Add support for GSSAPI authentication.

2007-07-10 Thread Tom Lane
[EMAIL PROTECTED] (Magnus Hagander) writes: > Add support for GSSAPI authentication. I looked over this patch and have a few comments, mostly stylistic: + /* errmsg_internal, since translation of the first part must be +* done before calling this function anyway. */ + ereport(

Re: [COMMITTERS] pgsql: Add support for GSSAPI authentication.

2007-07-10 Thread Magnus Hagander
Tom Lane wrote: > [EMAIL PROTECTED] (Magnus Hagander) writes: >> Add support for GSSAPI authentication. > > I looked over this patch and have a few comments, mostly stylistic: Thanks! > + /* errmsg_internal, since translation of the first part must be > + * done before calling this fun

Re: [COMMITTERS] pgsql: Add support for GSSAPI authentication.

2007-07-10 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> The standard locution for purely-internal debugging messages is >> elog(DEBUGn, "msg", ...) --- ereport is just useless notational >> complexity for this. (Quite a few places besides here) > Ok. Want it changed for the lot of them,

Re: [COMMITTERS] pgsql: Add support for GSSAPI authentication.

2007-07-10 Thread Magnus Hagander
Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: >> Tom Lane wrote: >>> The standard locution for purely-internal debugging messages is >>> elog(DEBUGn, "msg", ...) --- ereport is just useless notational >>> complexity for this. (Quite a few places besides here) > >> Ok. Want it chan

Re: [COMMITTERS] pgsql: Add support for GSSAPI authentication.

2007-07-10 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > Anyway. I can live with having it as a DEBUG message, and will change it > to that. What level of debug do you think is reasonable? I'd go with DEBUG2 or so for messages that might be significant to someone wondering "why can't Joe log in?", and 3 or 4

[COMMITTERS] pgsql: Add note that building from CVS requires bison and flex, whereas

2007-07-10 Thread Tom Lane
Log Message: --- Add note that building from CVS requires bison and flex, whereas building from a distribution tarball does not. Modified Files: -- pgsql/doc/src/sgml: cvs.sgml (r1.44 -> r1.45) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/