Re: [COMMITTERS] pgsql: Fix an oversight in the 8.2 patch that improved mergejoin

2008-09-06 Thread Gregory Stark
[EMAIL PROTECTED] (Tom Lane) writes: > (The materialize protects the sort from having to support mark/restore, > allowing it to do its final merge pass on-the-fly.) We neglected to teach > cost_mergejoin about that hack, so it was failing to include the > materialize's costs in the estimated cost

Re: [COMMITTERS] pgsql: Fix an oversight in the 8.2 patch that improved mergejoin

2008-09-06 Thread Simon Riggs
On Sat, 2008-09-06 at 13:06 +0100, Gregory Stark wrote: > [EMAIL PROTECTED] (Tom Lane) writes: > > > (The materialize protects the sort from having to support mark/restore, > > allowing it to do its final merge pass on-the-fly.) We neglected to teach > > cost_mergejoin about that hack, so it was

[COMMITTERS] pgsql: Adjust psql's new \ef command to present an empty CREATE FUNCTION

2008-09-06 Thread Tom Lane
Log Message: --- Adjust psql's new \ef command to present an empty CREATE FUNCTION template for editing if no function name is specified. This seems a much cleaner way to offer that functionality than the original patch had. In passing, de-clutter the error displays that are given for a b

[COMMITTERS] pgsql: Clarify documention workding for xip_list().

2008-09-06 Thread Bruce Momjian
Log Message: --- Clarify documention workding for xip_list(). Simon Riggs Modified Files: -- pgsql/doc/src/sgml: func.sgml (r1.444 -> r1.445) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/func.sgml?r1=1.444&r2=1.445) -- Sent via pgsql-comm

[COMMITTERS] pgsql: Add a few more details in the source-code-formatting

2008-09-06 Thread Tom Lane
Log Message: --- Add a few more details in the source-code-formatting documentation. This isn't exhaustive but it covers some of the more common layout mistakes I've seen in submitted patches. Modified Files: -- pgsql/doc/src/sgml: sources.sgml (r2.30 -> r2.31)

[COMMITTERS] pgsql: Reimplement text_position and related functions to use

2008-09-06 Thread Tom Lane
Log Message: --- Reimplement text_position and related functions to use Boyer-Moore-Horspool searching instead of naive matching. In the worst case this has the same O(M*N) complexity as the naive method, but the worst case is hard to hit, and the average case is very fast, especially with