[COMMITTERS] edb-debugger - server: Support the new DefineCustomStringVariable API in

2011-04-28 Thread Dave Page
Log Message: --- Support the new DefineCustomStringVariable API in 9.1 Modified Files: -- server: plugin_profiler.c (r1.8 - r1.9) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/edb-debugger/server/plugin_profiler.c?r1=1.8r2=1.9) -- Sent via

[COMMITTERS] pgsql: The arguments to pg_ctl kill are not optional - remove brackets

2011-04-28 Thread Heikki Linnakangas
The arguments to pg_ctl kill are not optional - remove brackets in the docs. Fujii Masao Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/9c46b7a14d03af06ee25bbf42bf478795cce566e Modified Files -- doc/src/sgml/ref/pg_ctl-ref.sgml |4 ++-- 1

[COMMITTERS] pgsql: The arguments to pg_ctl kill are not optional - remove brackets

2011-04-28 Thread Heikki Linnakangas
The arguments to pg_ctl kill are not optional - remove brackets in the docs. Fujii Masao Branch -- REL8_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/1aa24e20241710020926a271609811ef96dea6c6 Modified Files -- doc/src/sgml/ref/pg_ctl-ref.sgml |4 ++-- 1

[COMMITTERS] pgsql: The arguments to pg_ctl kill are not optional - remove brackets

2011-04-28 Thread Heikki Linnakangas
The arguments to pg_ctl kill are not optional - remove brackets in the docs. Fujii Masao Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/c02bc6356f26c6b4373fbac0118409b544ea85f0 Modified Files -- doc/src/sgml/ref/pg_ctl-ref.sgml |4 ++-- 1

[COMMITTERS] pgsql: The arguments to pg_ctl kill are not optional - remove brackets

2011-04-28 Thread Heikki Linnakangas
The arguments to pg_ctl kill are not optional - remove brackets in the docs. Fujii Masao Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/cb4fda63808a5fe35a72ed60e3ab7a77c2f16c45 Modified Files -- doc/src/sgml/ref/pg_ctl-ref.sgml |4 ++-- 1

[COMMITTERS] pgsql: The arguments to pg_ctl kill are not optional - remove brackets

2011-04-28 Thread Heikki Linnakangas
The arguments to pg_ctl kill are not optional - remove brackets in the docs. Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/39850c7fdb82bd7c64dbb759c5754e29fc0af5f2 Modified Files -- doc/src/sgml/ref/pg_ctl-ref.sgml |4 ++-- 1 files

[COMMITTERS] pgsql: Use a macro variable PG_PRINTF_ATTRIBUTE for the style used for

2011-04-28 Thread Andrew Dunstan
Use a macro variable PG_PRINTF_ATTRIBUTE for the style used for checking printf type functions. The style is set to printf for backwards compatibility everywhere except on Windows, where it is set to gnu_printf, which eliminates hundreds of false error messages from modern versions of gcc

[COMMITTERS] pgsql: Add some casts to try to silence most of the remaining format wa

2011-04-28 Thread Andrew Dunstan
Add some casts to try to silence most of the remaining format warnings on MinGW-W64. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ab0ba6e73ae9b3c9956126bdcd3c410238a27244 Modified Files -- src/backend/postmaster/postmaster.c |4 ++--

Re: [COMMITTERS] pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64

2011-04-28 Thread Dave Page
On Thu, Apr 28, 2011 at 6:21 AM, Tom Lane t...@sss.pgh.pa.us wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Tom Lane's message of miƩ abr 27 17:10:37 -0300 2011: Alvaro Herrera alvhe...@commandprompt.com writes: Apparently this change is causing Moa's SunStudio compiler

Re: [COMMITTERS] pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64

2011-04-28 Thread Tom Lane
Dave Page dp...@postgresql.org writes: On Thu, Apr 28, 2011 at 6:21 AM, Tom Lane t...@sss.pgh.pa.us wrote: Dave, can you poke at this? I think we may have to award Sun (or whats left of them) the Bizarre compiler bug of the week award here. Yeah. Has anyone filed a report with them? It's

Re: [COMMITTERS] pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64

2011-04-28 Thread Dave Page
On Thu, Apr 28, 2011 at 8:44 PM, Tom Lane t...@sss.pgh.pa.us wrote: Dave Page dp...@postgresql.org writes: On Thu, Apr 28, 2011 at 6:21 AM, Tom Lane t...@sss.pgh.pa.us wrote: Dave, can you poke at this? I think we may have to award Sun (or whats left of them) the Bizarre compiler bug of the

Re: [COMMITTERS] pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64

2011-04-28 Thread Alvaro Herrera
Excerpts from Dave Page's message of jue abr 28 16:33:44 -0300 2011: I think we may have to award Sun (or whats left of them) the Bizarre compiler bug of the week award here. It's actually the val++; that's causing the assertion, but I'm darned if I can get it to work. I've tried spelling out

Re: [COMMITTERS] pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64

2011-04-28 Thread Tom Lane
Dave Page dp...@postgresql.org writes: On Thu, Apr 28, 2011 at 8:44 PM, Tom Lane t...@sss.pgh.pa.us wrote: I was suspicious that it had something to do with the compiler trying to optimize the size / mult and size % mult subexpressions Already did (that was my first assumption). Removing them

Re: [COMMITTERS] pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64

2011-04-28 Thread Dave Page
On Thu, Apr 28, 2011 at 9:05 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Dave Page's message of jue abr 28 16:33:44 -0300 2011: I think we may have to award Sun (or whats left of them) the Bizarre compiler bug of the week award here. It's actually the val++; that's

Re: [COMMITTERS] pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64

2011-04-28 Thread Tom Lane
Please see if the attached version works. regards, tom lane Datum pg_size_pretty(PG_FUNCTION_ARGS) { int64 size = PG_GETARG_INT64(0); charbuf[64]; int64 limit = 10 * 1024; int64 limit2 = limit * 2

[COMMITTERS] pgsql: Use non-literal format for possibly non-standard strftime format

2011-04-28 Thread Andrew Dunstan
Use non-literal format for possibly non-standard strftime formats. Per recent -hackers discussion. The formats in question are %G and %V, and cause warnings on MinGW at least. We assume the ecpg application knows what it's doing if it passes these formats to the library. Branch -- master

[COMMITTERS] reorg - pg_reorg: Fixed database corruption when target tables have

2011-04-28 Thread User Itagaki
Log Message: --- Fixed database corruption when target tables have dropped columns, and there are views or functions depending on columns after dropped ones. The issue was reported by depesz, and original patch by Denish Patel. Improved documentation how to build binaries from source.

[COMMITTERS] pgsql: Rewrite pg_size_pretty() to avoid compiler bug.

2011-04-28 Thread Tom Lane
Rewrite pg_size_pretty() to avoid compiler bug. Convert it to use successive shifts right instead of increasing a divisor. This is probably a tad more efficient than the original coding, and it's nicer-looking than the previous patch because we don't need a special case to avoid overflow in the

[COMMITTERS] pgsql: Rewrite pg_size_pretty() to avoid compiler bug.

2011-04-28 Thread Tom Lane
Rewrite pg_size_pretty() to avoid compiler bug. Convert it to use successive shifts right instead of increasing a divisor. This is probably a tad more efficient than the original coding, and it's nicer-looking than the previous patch because we don't need a special case to avoid overflow in the

[COMMITTERS] pgsql: Rewrite pg_size_pretty() to avoid compiler bug.

2011-04-28 Thread Tom Lane
Rewrite pg_size_pretty() to avoid compiler bug. Convert it to use successive shifts right instead of increasing a divisor. This is probably a tad more efficient than the original coding, and it's nicer-looking than the previous patch because we don't need a special case to avoid overflow in the

[COMMITTERS] pgsql: Rewrite pg_size_pretty() to avoid compiler bug.

2011-04-28 Thread Tom Lane
Rewrite pg_size_pretty() to avoid compiler bug. Convert it to use successive shifts right instead of increasing a divisor. This is probably a tad more efficient than the original coding, and it's nicer-looking than the previous patch because we don't need a special case to avoid overflow in the

[COMMITTERS] pgsql: Rewrite pg_size_pretty() to avoid compiler bug.

2011-04-28 Thread Tom Lane
Rewrite pg_size_pretty() to avoid compiler bug. Convert it to use successive shifts right instead of increasing a divisor. This is probably a tad more efficient than the original coding, and it's nicer-looking than the previous patch because we don't need a special case to avoid overflow in the