Re: [COMMITTERS] pgsql: Move relpath() to libpgcommon

2013-02-22 Thread Tom Lane
Alvaro Herrera writes: > Move relpath() to libpgcommon Buildfarm member frogmouth has a problem with this patch... looks like some confusion about how to do asserts. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make c

[COMMITTERS] pgsql: Adjust postgres_fdw's search path handling.

2013-02-22 Thread Tom Lane
Adjust postgres_fdw's search path handling. Set the remote session's search path to exactly "pg_catalog" at session start, then schema-qualify only names that aren't in that schema. This greatly reduces clutter in the generated SQL commands, as seen in the regression test changes. Per discussion

[COMMITTERS] pgsql: If recovery.conf is created after "pg_ctl stop -m i", do crash r

2013-02-22 Thread Heikki Linnakangas
If recovery.conf is created after "pg_ctl stop -m i", do crash recovery. If you create a base backup using an atomic filesystem snapshot, and try to perform PITR starting from that base backup, or if you just kill a master server and create recovery.conf to put it into standby mode, we don't know

[COMMITTERS] pgsql: If recovery.conf is created after "pg_ctl stop -m i", do crash r

2013-02-22 Thread Heikki Linnakangas
If recovery.conf is created after "pg_ctl stop -m i", do crash recovery. If you create a base backup using an atomic filesystem snapshot, and try to perform PITR starting from that base backup, or if you just kill a master server and create recovery.conf to put it into standby mode, we don't know

[COMMITTERS] pgsql: Fix thinko in previous commit.

2013-02-22 Thread Heikki Linnakangas
Fix thinko in previous commit. We must still initialize minRecoveryPoint if we start straight with archive recovery, e.g when recovering from a normal base backup taken with pg_start/stop_backup. Otherwise we never consider the system consistent. Branch -- REL9_2_STABLE Details --- http:

[COMMITTERS] pgsql: Fix thinko in previous commit.

2013-02-22 Thread Heikki Linnakangas
Fix thinko in previous commit. We must still initialize minRecoveryPoint if we start straight with archive recovery, e.g when recovering from a normal base backup taken with pg_start/stop_backup. Otherwise we never consider the system consistent. Branch -- master Details --- http://git.p

[COMMITTERS] pgsql: Change postgres_fdw to show casts as casts, not underlying funct

2013-02-22 Thread Tom Lane
Change postgres_fdw to show casts as casts, not underlying function calls. On reflection this method seems to be exposing an unreasonable amount of implementation detail. It wouldn't matter when talking to a remote server of the identical Postgres version, but it seems likely to make things worse

[COMMITTERS] pgsql: Get rid of postgres_fdw's assumption that remote type OIDs match

2013-02-22 Thread Tom Lane
Get rid of postgres_fdw's assumption that remote type OIDs match ours. The only place we depended on that was in sending numeric type OIDs in PQexecParams; but we can replace that usage with explicitly casting each Param symbol in the query string, so that the types are specified to the remote by

[COMMITTERS] pgsql: Fix whole-row references in postgres_fdw.

2013-02-22 Thread Tom Lane
Fix whole-row references in postgres_fdw. The optimization to not retrieve unnecessary columns wasn't smart enough. Noted by Thom Brown. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6da378dbc97f1b96bf5778a558e168a0dc405bce Modified Files -- contrib/po

[COMMITTERS] pgsql: Blind attempt at fixing the non-MSVC Windows builds

2013-02-22 Thread Alvaro Herrera
Blind attempt at fixing the non-MSVC Windows builds Apparently, they need -DBUILDING_DLL for the Assert() declarations to work correctly. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/af0a4c5924061869ee3db391900ab745107c966f Modified Files -- src/makef

Re: [COMMITTERS] pgsql: Move relpath() to libpgcommon

2013-02-22 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera writes: > > Move relpath() to libpgcommon > > Buildfarm member frogmouth has a problem with this patch... > looks like some confusion about how to do asserts. Looks like both mingw and cygwin didn't like it. I have pushed a patch, while regretting not having yet

Re: [COMMITTERS] pgsql: Blind attempt at fixing the non-MSVC Windows builds

2013-02-22 Thread Alvaro Herrera
Andres Freund wrote: > On 2013-02-22 14:55:06 +, Alvaro Herrera wrote: > > Blind attempt at fixing the non-MSVC Windows builds > > > > Apparently, they need -DBUILDING_DLL for the Assert() declarations to > > work correctly. > > More specifically, they need that do access any PGDLLIMPORT symb

Re: [COMMITTERS] pgsql: Blind attempt at fixing the non-MSVC Windows builds

2013-02-22 Thread Andres Freund
On 2013-02-22 12:34:19 -0300, Alvaro Herrera wrote: > Andres Freund wrote: > > On 2013-02-22 14:55:06 +, Alvaro Herrera wrote: > > > Blind attempt at fixing the non-MSVC Windows builds > > > > > > Apparently, they need -DBUILDING_DLL for the Assert() declarations to > > > work correctly. > >

[COMMITTERS] pgsql: Fix some planning oversights in postgres_fdw.

2013-02-22 Thread Tom Lane
Fix some planning oversights in postgres_fdw. Include eval costs of local conditions in remote-estimate mode, and don't assume the remote eval cost is zero in local-estimate mode. (The best we can do with that at the moment is to assume a seqscan, which may well be wildly pessimistic ... but zero

[COMMITTERS] pgsql: Add pg_xlogdump contrib program

2013-02-22 Thread Alvaro Herrera
Add pg_xlogdump contrib program This program relies on rm_desc backend routines and the xlogreader infrastructure to emit human-readable rendering of WAL records. Author: Andres Freund, with many reworks by Álvaro Reviewed (in a much earlier version) by Peter Eisentraut Branch -- master Det

[COMMITTERS] pgsql: Fix copy-and-pasteo

2013-02-22 Thread Alvaro Herrera
Fix copy-and-pasteo Harmless, but it's certainly better like this. Noticed by Andres Freund Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f03a779751f6fc8dc87628d021510c4ec9e1e667 Modified Files -- contrib/pg_xlogdump/pg_xlogdump.c |2 +- 1 files ch

Re: [COMMITTERS] pgsql: Add pg_xlogdump contrib program

2013-02-22 Thread Thom Brown
On 22 February 2013 19:58, Alvaro Herrera wrote: > Add pg_xlogdump contrib program > > This program relies on rm_desc backend routines and the xlogreader > infrastructure to emit human-readable rendering of WAL records. > > Author: Andres Freund, with many reworks by Álvaro > Reviewed (in a much e

Re: [COMMITTERS] pgsql: Add pg_xlogdump contrib program

2013-02-22 Thread Peter Geoghegan
On 22 February 2013 19:58, Alvaro Herrera wrote: > Add pg_xlogdump contrib program I feel slightly silly reporting this, but you probably should have updated the copyright years to 2013 before committing. -- Regards, Peter Geoghegan -- Sent via pgsql-committers mailing list (pgsql-committer

Re: [COMMITTERS] pgsql: Add pg_xlogdump contrib program

2013-02-22 Thread Thom Brown
On 22 February 2013 20:09, Peter Geoghegan wrote: > On 22 February 2013 19:58, Alvaro Herrera wrote: >> Add pg_xlogdump contrib program > > I feel slightly silly reporting this, but you probably should have > updated the copyright years to 2013 before committing. And while you're there: "pg_xlo

[COMMITTERS] pgsql: Fix some typos and grammatical mistakes

2013-02-22 Thread Alvaro Herrera
Fix some typos and grammatical mistakes ... as well a update copyrights statements to 2013. Noted by Thom Brown and Peter Geoghegan Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/45919335493291ef43f9b66c81a56d32a562ab5a Modified Files -- contrib/pg_xlo

Re: [COMMITTERS] pgsql: Add pg_xlogdump contrib program

2013-02-22 Thread Alvaro Herrera
Thom Brown escribió: > On 22 February 2013 20:09, Peter Geoghegan > wrote: > > On 22 February 2013 19:58, Alvaro Herrera wrote: > >> Add pg_xlogdump contrib program > > > > I feel slightly silly reporting this, but you probably should have > > updated the copyright years to 2013 before committin

[COMMITTERS] pgsql: contrib/Makefile also needs updated

2013-02-22 Thread Alvaro Herrera
contrib/Makefile also needs updated Erik Rijkers Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/36f697cbba44fd55f23727066c3274fd01919640 Modified Files -- contrib/Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- Sent via pgsql-co

Re: [COMMITTERS] pgsql: Add pg_xlogdump contrib program

2013-02-22 Thread Shigeru Hanada
On Sat, Feb 23, 2013 at 4:58 AM, Alvaro Herrera wrote: > Add pg_xlogdump contrib program I got an error on make after make clean. Should we remove rmgrdesc.c from EXTRA_CLEAN and target? [pg_xlogdump(master)]$ make clean rm -f pg_xlogdump rm -f pg_xlogdump.o compat.o xlogreader.o rmgrdesc.o clo

[COMMITTERS] pgsql: Add quotes to messages

2013-02-22 Thread Peter Eisentraut
Add quotes to messages Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/a70924bcaf14ca6e4c80f5714ab68704d77ece1d Modified Files -- src/backend/replication/basebackup.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) -- Sent via pgs

[COMMITTERS] pgsql: Add quotes to messages

2013-02-22 Thread Peter Eisentraut
Add quotes to messages Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4f362926692631a67cd76b747f92389c8f63478e Modified Files -- src/backend/replication/basebackup.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) -- Sent via pgsql-comm

[COMMITTERS] pgsql: doc: Add more compatibility information for triggers

2013-02-22 Thread Peter Eisentraut
doc: Add more compatibility information for triggers Louis-Claude Canon and Josh Kupershmidt Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8e8d0f7e80d80c61b09346a84059457aeeeae548 Modified Files -- doc/src/sgml/ref/create_trigger.sgml | 13 ++