[COMMITTERS] pgsql: README comments on checksums on page holes.

2013-04-08 Thread Simon Riggs
README comments on checksums on page holes. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a4b94b85156192b839a3c840f8aaf0cf8699a8c8 Modified Files -- src/backend/storage/page/README | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) -

[COMMITTERS] pgsql: Avoid tricky race condition recording XLOG_HINT

2013-04-08 Thread Simon Riggs
Avoid tricky race condition recording XLOG_HINT We copy the buffer before inserting an XLOG_HINT to avoid WAL CRC errors caused by concurrent hint writes to buffer while share locked. To make this work we refactor RestoreBackupBlock() to allow an XLOG_HINT to avoid the normal path for backup blocks

Re: [COMMITTERS] pgsql: README comments on checksums on page holes.

2013-04-08 Thread Thom Brown
On 8 April 2013 08:44, Simon Riggs wrote: > README comments on checksums on page holes. > > Branch > -- > master > > Details > --- > http://git.postgresql.org/pg/commitdiff/a4b94b85156192b839a3c840f8aaf0cf8699a8c8 "Zero bytes" to me means "zero length", which wouldn't make sense for formi

Re: [COMMITTERS] pgsql: README comments on checksums on page holes.

2013-04-08 Thread Simon Riggs
Patches welcome! On 8 April 2013 08:59, Thom Brown wrote: > On 8 April 2013 08:44, Simon Riggs wrote: > > README comments on checksums on page holes. > > > > Branch > > -- > > master > > > > Details > > --- > > > http://git.postgresql.org/pg/commitdiff/a4b94b85156192b839a3c840f8aaf0cf8

Re: [COMMITTERS] pgsql: Get rid of USE_WIDE_UPPER_LOWER dependency in trigram constructi

2013-04-08 Thread Dimitri Fontaine
Tom Lane writes: > If there is anybody still using Postgres on machines without wcstombs() or > towlower(), and they have non-ASCII data indexed by pg_trgm, they'll need > to REINDEX those indexes after pg_upgrade to 9.3, else searches may fail > incorrectly. It seems likely that there are no such

[COMMITTERS] pgsql: Skip extraneous locking in XLogCheckBuffer().

2013-04-08 Thread Simon Riggs
Skip extraneous locking in XLogCheckBuffer(). Heikki reported comment was wrong, so fixed code to match the comment: we only need to take additional locking precautions when we have a shared lock on the buffer. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5787c6730

[COMMITTERS] pgsql: Fix calculation of how many segments to retain for wal_keep_segm

2013-04-08 Thread Heikki Linnakangas
Fix calculation of how many segments to retain for wal_keep_segments. KeepLogSeg function was broken when we switched to use a 64-bit int for the segment number. Per report from Jeff Janes. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/594041311c8263832258d35632aa

Re: [COMMITTERS] pgsql: Avoid tricky race condition recording XLOG_HINT

2013-04-08 Thread Tom Lane
Simon Riggs writes: > Resulting code completely changes layout of XLOG_HINT WAL records, but > this isn't even beta code, so this is a low impact change. > src/include/catalog/catversion.h |2 +- Just for the record, the right way to handle that kind of change is to change XLOG_PAGE_MAG

Re: [COMMITTERS] pgsql: Avoid tricky race condition recording XLOG_HINT

2013-04-08 Thread Simon Riggs
On 8 April 2013 15:29, Tom Lane wrote: > Simon Riggs writes: > > Resulting code completely changes layout of XLOG_HINT WAL records, but > > this isn't even beta code, so this is a low impact change. > > > src/include/catalog/catversion.h |2 +- > > Just for the record, the right way to

Re: [COMMITTERS] pgsql: Avoid tricky race condition recording XLOG_HINT

2013-04-08 Thread Tom Lane
Simon Riggs writes: > On 8 April 2013 15:29, Tom Lane wrote: >> Just for the record, the right way to handle that kind of change is to >> change XLOG_PAGE_MAGIC, not catversion. A database's catalog version >> might not be available to code that is inspecting WAL files and would >> like to know

Re: [COMMITTERS] pgsql: Avoid tricky race condition recording XLOG_HINT

2013-04-08 Thread Andres Freund
On 2013-04-08 10:47:50 -0400, Tom Lane wrote: > Simon Riggs writes: > > On 8 April 2013 15:29, Tom Lane wrote: > >> Just for the record, the right way to handle that kind of change is to > >> change XLOG_PAGE_MAGIC, not catversion. A database's catalog version > >> might not be available to code

Re: [COMMITTERS] pgsql: README comments on checksums on page holes.

2013-04-08 Thread Alvaro Herrera
Thom Brown wrote: > On 8 April 2013 08:44, Simon Riggs wrote: > > README comments on checksums on page holes. > > > > Branch > > -- > > master > > > > Details > > --- > > http://git.postgresql.org/pg/commitdiff/a4b94b85156192b839a3c840f8aaf0cf8699a8c8 > > "Zero bytes" to me means "zero le

[COMMITTERS] pgsql: Minor rewording of README comments

2013-04-08 Thread Simon Riggs
Minor rewording of README comments Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e60d20a35e436cef3c454bfeab34d8ea71b54910 Modified Files -- src/backend/storage/page/README |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-c

Re: [COMMITTERS] pgsql: README comments on checksums on page holes.

2013-04-08 Thread Simon Riggs
On 8 April 2013 17:04, Alvaro Herrera wrote: > > "Zero bytes" to me means "zero length", which wouldn't make sense for > > forming a hole in a page. Is it possible to re-word this to be made > > Thom-friendly? > > "zeroed bytes" perhaps? > Updated -- Simon Riggs http://www

[COMMITTERS] pgsql: Support indexing of regular-expression searches in contrib/pg_tr

2013-04-08 Thread Tom Lane
Support indexing of regular-expression searches in contrib/pg_trgm. This works by extracting trigrams from the given regular expression, in generally the same spirit as the previously-existing support for LIKE searches, though of course the details are far more complicated. Currently, only GIN in