[COMMITTERS] pgsql: Misc GIN refactoring.

2013-11-06 Thread Heikki Linnakangas
Misc GIN refactoring. Merge the isEnoughSpace and placeToPage functions in the b-tree interface into one function that tries to put a tuple on page, and returns false if it doesn't fit. Move createPostingTree function to gindatapage.c, and change its contract so that it can be passed more items t

[COMMITTERS] pgsql: Fix missing argument and function prototypes.

2013-11-06 Thread Heikki Linnakangas
Fix missing argument and function prototypes. Not sure how I missed these in previous commit. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0ea53256a856693dc8e8e1ce5ce26b3438d2e341 Modified Files -- src/backend/access/gin/gininsert.c |3 ++- src/inc

[COMMITTERS] pgsql: Keep heap open until new heap generated in RMV.

2013-11-06 Thread Kevin Grittner
Keep heap open until new heap generated in RMV. Early close became apparent when invalidation messages were processed in a new location under CLOBBER_CACHE_ALWAYS builds, due to additional locking. Back-patch to 9.3 Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commit

[COMMITTERS] pgsql: Keep heap open until new heap generated in RMV.

2013-11-06 Thread Kevin Grittner
Keep heap open until new heap generated in RMV. Early close became apparent when invalidation messages were processed in a new location under CLOBBER_CACHE_ALWAYS builds, due to additional locking. Back-patch to 9.3 Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/58

[COMMITTERS] pgsql: Prevent creating window functions with default arguments.

2013-11-06 Thread Tom Lane
Prevent creating window functions with default arguments. Insertion of default arguments doesn't work for window functions, which is likely to cause a crash at runtime if the implementation code doesn't check the number of actual arguments carefully. It doesn't seem worth working harder than this

[COMMITTERS] pgsql: Prevent creating window functions with default arguments.

2013-11-06 Thread Tom Lane
Prevent creating window functions with default arguments. Insertion of default arguments doesn't work for window functions, which is likely to cause a crash at runtime if the implementation code doesn't check the number of actual arguments carefully. It doesn't seem worth working harder than this

[COMMITTERS] pgsql: Support default arguments and named-argument notation for window

2013-11-06 Thread Tom Lane
Support default arguments and named-argument notation for window functions. These things didn't work because the planner omitted to do the necessary preprocessing of a WindowFunc's argument list. Add the few dozen lines of code needed to handle that. Although this sounds like a feature addition,

[COMMITTERS] pgsql: Prevent creating window functions with default arguments.

2013-11-06 Thread Tom Lane
Prevent creating window functions with default arguments. Insertion of default arguments doesn't work for window functions, which is likely to cause a crash at runtime if the implementation code doesn't check the number of actual arguments carefully. It doesn't seem worth working harder than this

[COMMITTERS] pgsql: Support default arguments and named-argument notation for window

2013-11-06 Thread Tom Lane
Support default arguments and named-argument notation for window functions. These things didn't work because the planner omitted to do the necessary preprocessing of a WindowFunc's argument list. Add the few dozen lines of code needed to handle that. Although this sounds like a feature addition,

[COMMITTERS] pgsql: Support default arguments and named-argument notation for window

2013-11-06 Thread Tom Lane
Support default arguments and named-argument notation for window functions. These things didn't work because the planner omitted to do the necessary preprocessing of a WindowFunc's argument list. Add the few dozen lines of code needed to handle that. Although this sounds like a feature addition,

[COMMITTERS] pgsql: Be more robust when strerror() doesn't give a useful result.

2013-11-06 Thread Tom Lane
Be more robust when strerror() doesn't give a useful result. glibc, at least, is capable of returning "???" instead of anything useful if it doesn't like the setting of LC_CTYPE. If this happens, or in the previously-known case of strerror() returning an empty string, try to print the C macro nam

[COMMITTERS] pgsql: Add #ifdef guards for some POSIX error symbols that Windows does

2013-11-06 Thread Tom Lane
Add #ifdef guards for some POSIX error symbols that Windows doesn't like. Per buildfarm results. It looks like the older the Windows version, the more errno codes it hasn't got ... Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8dace66e0735ca39b779922d02c24ea2686e6