[COMMITTERS] pgsql: Don't require users of src/port/gettimeofday.c to initialize it.

2015-02-21 Thread Robert Haas
Don't require users of src/port/gettimeofday.c to initialize it. Commit 8001fe67a3d66c95861ce1f7075ef03953670d13 introduced this requirement, but per discussion, we want to avoid requirements of this type to make things easier on the calling code. An especially important consideration is that thi

[COMMITTERS] pgsql: Fix misparsing of empty value in conninfo_uri_parse_params().

2015-02-21 Thread Tom Lane
Fix misparsing of empty value in conninfo_uri_parse_params(). After finding an "=" character, the pointer was advanced twice when it should only advance once. This is harmless as long as the value after "=" has at least one character; but if it doesn't, we'd miss the terminator character and incl

[COMMITTERS] pgsql: Fix misparsing of empty value in conninfo_uri_parse_params().

2015-02-21 Thread Tom Lane
Fix misparsing of empty value in conninfo_uri_parse_params(). After finding an "=" character, the pointer was advanced twice when it should only advance once. This is harmless as long as the value after "=" has at least one character; but if it doesn't, we'd miss the terminator character and incl

[COMMITTERS] pgsql: Fix misparsing of empty value in conninfo_uri_parse_params().

2015-02-21 Thread Tom Lane
Fix misparsing of empty value in conninfo_uri_parse_params(). After finding an "=" character, the pointer was advanced twice when it should only advance once. This is harmless as long as the value after "=" has at least one character; but if it doesn't, we'd miss the terminator character and incl

[COMMITTERS] pgsql: Fix misparsing of empty value in conninfo_uri_parse_params().

2015-02-21 Thread Tom Lane
Fix misparsing of empty value in conninfo_uri_parse_params(). After finding an "=" character, the pointer was advanced twice when it should only advance once. This is harmless as long as the value after "=" has at least one character; but if it doesn't, we'd miss the terminator character and incl

[COMMITTERS] pgsql: Minor code beautification in conninfo_uri_parse_params().

2015-02-21 Thread Tom Lane
Minor code beautification in conninfo_uri_parse_params(). Reading this made me itch, so clean the logic a bit. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3d9b6f31eec150b5a6000e0814e81e36d9eb069a Modified Files -- src/interfaces/libpq/fe-connect.c |

[COMMITTERS] pgsql: Use FLEXIBLE_ARRAY_MEMBER for HeapTupleHeaderData.t_bits[].

2015-02-21 Thread Tom Lane
Use FLEXIBLE_ARRAY_MEMBER for HeapTupleHeaderData.t_bits[]. This requires changing quite a few places that were depending on sizeof(HeapTupleHeaderData), but it seems for the best. Michael Paquier, some adjustments by me Branch -- master Details --- http://git.postgresql.org/pg/commitdi

[COMMITTERS] pgsql: Use FLEXIBLE_ARRAY_MEMBER in a number of other places.

2015-02-21 Thread Tom Lane
Use FLEXIBLE_ARRAY_MEMBER in a number of other places. I think we're about done with this... Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2e211211a76782b6084194a5ced94c0795460047 Modified Files -- contrib/hstore/hstore_gist.c |2 +- contri

[COMMITTERS] pgsql: Don't need to explain [1] kluge anymore in xfunc.sgml.

2015-02-21 Thread Tom Lane
Don't need to explain [1] kluge anymore in xfunc.sgml. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0627eff3602c0ce0e8358d48ddb3ffa73963e4d0 Modified Files -- doc/src/sgml/xfunc.sgml | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-)

[COMMITTERS] pgsql: Allow forcing nullness of columns during bootstrap.

2015-02-21 Thread Andres Freund
Allow forcing nullness of columns during bootstrap. Bootstrap determines whether a column is null based on simple builtin rules. Those work surprisingly well, but nonetheless a few existing columns aren't set correctly. Additionally there is at least one patch sent to hackers where forcing the nul

[COMMITTERS] pgsql: Force some system catalog table columns to be marked NOT NULL.

2015-02-21 Thread Andres Freund
Force some system catalog table columns to be marked NOT NULL. In a manual pass over the catalog declaration I found a number of columns which the boostrap automatism didn't mark NOT NULL even though they actually were. Add BKI_FORCE_NOT_NULL markings to them. It's usually not critical if a syste

[COMMITTERS] pgsql: Use FLEXIBLE_ARRAY_MEMBER in Windows-specific code.

2015-02-21 Thread Tom Lane
Use FLEXIBLE_ARRAY_MEMBER in Windows-specific code. Be a tad more paranoid about overlength input, too. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/332f02f88beead6365bc2126c95451520bbfe163 Modified Files -- src/port/dirmod.c | 12 ++-- 1 fil

[COMMITTERS] pgsql: Try to fix busted gettimeofday() code.

2015-02-21 Thread Tom Lane
Try to fix busted gettimeofday() code. Per buildfarm, we have to match the _stdcall property of the system functions. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e9fd5545de3bb4efe163af4a9c957badac86ccd7 Modified Files -- src/port/gettimeofday.c |

[COMMITTERS] pgsql: In array_agg(), don't create a new context for every group.

2015-02-21 Thread Jeff Davis
In array_agg(), don't create a new context for every group. Previously, each new array created a new memory context that started out at 8kB. This is incredibly wasteful when there are lots of small groups of just a few elements each. Change initArrayResult() and friends to accept a "subcontext" a

[COMMITTERS] pgsql: Rename variable in AllocSetContextCreate to be consistent.

2015-02-21 Thread Jeff Davis
Rename variable in AllocSetContextCreate to be consistent. Everywhere else in the file, "context" is of type MemoryContext and "set" is of type AllocSet. AllocSetContextCreate uses a variable of type AllocSet, so rename it from "context" to "set". Branch -- master Details --- http://git.