On 04/15/2015 06:41 AM, Fujii Masao wrote:
On Tue, Apr 14, 2015 at 2:17 AM, Alvaro Herrera
wrote:
Michael Paquier wrote:
On Sun, Apr 12, 2015 at 10:17 AM, Alvaro Herrera wrote:
What pg_basebackup's progress_report() does is have the message in the
translatable part not include the \r; the \r
On Wed, Apr 15, 2015 at 4:55 PM, Heikki Linnakangas wrote:
> On 04/15/2015 06:41 AM, Fujii Masao wrote:
>> Another question is; should we output the progress report to stderr rather
>> than stdout? I thought this because I found that pg_basebackup reports
>> the progress to stderr.
>
>
> Yeah, prob
Fix logic to skip checkpoint if no records have been inserted.
After the WAL format changes, the calculation of the size of a checkpoint
record became incorrect. Instead of trying to fix the math, check that the
previous record, i.e. the xl_prev value that we'd write for the next
record, matches t
Shut down test servers after pg_rewind regression tests.
Now that the test servers are initialized twice in each .pl script,
the single END block is not enough to stop them. Add a new clean_rewind_test
function that is called at the end of each test.
Michael Paquier
Branch
--
master
Details
Minor cleanup of pg_rewind.
Update comments and function names to use the terms "source" and "target"
consistently. Some places were calling them remote and local instead, which
was confusing.
Fix incorrect comment in extractPageInfo on database creation record - it
was wrong on what happens for
Error out in pg_rewind if lstat() fails.
A "file not found" is expected if the source server is running, so don't
complain about that. But any other error is definitely not expected.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/b5e560c24603e5325a81055c8f36cc45d486
On Thu, Apr 16, 2015 at 5:15 AM, Heikki Linnakangas
wrote:
> Error out in pg_rewind if lstat() fails.
>
> A "file not found" is expected if the source server is running, so don't
> complain about that. But any other error is definitely not expected.
Nitpicking: strings of pg_fatal need to have a
Add missing newlines to error messages.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/b5e384e374657ead815a3393ca59333910611a24
Modified Files
--
src/bin/pg_rewind/copy_fetch.c |2 +-
src/bin/pg_rewind/parsexlog.c |6 +++---
2 files changed, 4 ins
On 04/16/2015 04:17 AM, Michael Paquier wrote:
On Thu, Apr 16, 2015 at 5:15 AM, Heikki Linnakangas
wrote:
Error out in pg_rewind if lstat() fails.
A "file not found" is expected if the source server is running, so don't
complain about that. But any other error is definitely not expected.
Nit
