[COMMITTERS] pgsql: Measure string lengths only once

2015-10-27 Thread Alvaro Herrera
Measure string lengths only once Bernd Helmle complained that CreateReplicationSlot() was assigning the same value to the same variable twice, so we could remove one of them. Code inspection reveals that we can actually remove both assignments: according to the author the assignment was there for

[COMMITTERS] pgsql: Measure string lengths only once

2015-10-27 Thread Alvaro Herrera
Measure string lengths only once Bernd Helmle complained that CreateReplicationSlot() was assigning the same value to the same variable twice, so we could remove one of them. Code inspection reveals that we can actually remove both assignments: according to the author the assignment was there for

[COMMITTERS] pgsql: Measure string lengths only once

2015-10-27 Thread Alvaro Herrera
Measure string lengths only once Bernd Helmle complained that CreateReplicationSlot() was assigning the same value to the same variable twice, so we could remove one of them. Code inspection reveals that we can actually remove both assignments: according to the author the assignment was there for

[COMMITTERS] pgsql: Cleanup commit timestamp module activaction, again

2015-10-27 Thread Alvaro Herrera
Cleanup commit timestamp module activaction, again Further tweak commit_ts.c so that on a standby the state is completely consistent with what that in the master, rather than behaving differently in the cases that the settings differ. Now in standby and master the module should always be active o

[COMMITTERS] pgsql: Cleanup commit timestamp module activaction, again

2015-10-27 Thread Alvaro Herrera
Cleanup commit timestamp module activaction, again Further tweak commit_ts.c so that on a standby the state is completely consistent with what that in the master, rather than behaving differently in the cases that the settings differ. Now in standby and master the module should always be active o

[COMMITTERS] pgsql: Fix BRIN free space computations

2015-10-27 Thread Alvaro Herrera
Fix BRIN free space computations A bug in the original free space computation made it possible to return a page which wasn't actually able to fit the item. Since the insertion code isn't prepared to deal with PageAddItem failing, a PANIC resulted ("failed to add BRIN tuple [to new page]"). Add a

[COMMITTERS] pgsql: Fix BRIN free space computations

2015-10-27 Thread Alvaro Herrera
Fix BRIN free space computations A bug in the original free space computation made it possible to return a page which wasn't actually able to fit the item. Since the insertion code isn't prepared to deal with PageAddItem failing, a PANIC resulted ("failed to add BRIN tuple [to new page]"). Add a

[COMMITTERS] pgsql: Document BRIN's inclusion opclass framework

2015-10-27 Thread Alvaro Herrera
Document BRIN's inclusion opclass framework Backpatch to 9.5 -- this should have been part of b0b7be61337, but we didn't have 38b03caebc5de either at the time. Author: Emre Hasegeli Revised by: Ian Barwick Discussion: http://www.postgresql.org/message-id/cae2gyzyb39q9up_-to6fkhh44pcam1x6n_cuj15

[COMMITTERS] pgsql: Document BRIN's inclusion opclass framework

2015-10-27 Thread Alvaro Herrera
Document BRIN's inclusion opclass framework Backpatch to 9.5 -- this should have been part of b0b7be61337, but we didn't have 38b03caebc5de either at the time. Author: Emre Hasegeli Revised by: Ian Barwick Discussion: http://www.postgresql.org/message-id/cae2gyzyb39q9up_-to6fkhh44pcam1x6n_cuj15

[COMMITTERS] pgsql: Make Gather node projection-capable.

2015-10-27 Thread Robert Haas
Make Gather node projection-capable. The original Gather code failed to mark a Gather node as not able to do projection, but it couldn't, even though it did call initialize its projection info via ExecAssignProjectionInfo. There doesn't seem to be any good reason for this node not to have project

[COMMITTERS] pgsql: Fix secondary expected output for commit_ts test

2015-10-27 Thread Alvaro Herrera
Fix secondary expected output for commit_ts test Per red wall in buildfarm Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/dbe6f434ee1852f08c011065467a6cfc5ce10864 Modified Files -- src/test/modules/commit_ts/expected/commit_timestamp_1.out |9 +++---

[COMMITTERS] pgsql: Fix secondary expected output for commit_ts test

2015-10-27 Thread Alvaro Herrera
Fix secondary expected output for commit_ts test Per red wall in buildfarm Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/c56949168cc0aeac703865c3239f7bc7ca670402 Modified Files -- src/test/modules/commit_ts/expected/commit_timestamp_1.out |9