Fix assorted breakage in to_char()'s OF format option.
In HEAD, fix incorrect field width for hours part of OF when tm_gmtoff is
negative. This was introduced by commit 2d87eedc1d4468d3 as a result of
falsely applying a pattern that's correct when + signs are omitted, which
is not the case for OF
On 2016-03-18 16:25, Teodor Sigaev wrote:
Introduce parse_ident()
SQL-layer function to split qualified identifier into array parts.
[...]
Details
---
http://git.postgresql.org/pg/commitdiff/3187d6de0e5a9e805b27c48437897e8c39071d45
Modified Files
--
doc/src/sgml/func.sgml
Add syslog_sequence_numbers parameter
Reviewed-by: Andreas Karlsson
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/f4c454e9ba5262c5614c7637983c83b8c327e231
Modified Files
--
doc/src/sgml/config.sgml | 28 +++
docs: Fix typo'd brin_summarize_new_values
I wrote "brin_summarize_new_pages" instead, in docs as well as in the
commit message of commit ac443d1034d9.
Bug: #14030
Reported-By: Chris Pacejo
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/696684d878747a1a5cfae0188740
Remove useless double calls of make_parsestate().
Aleksander Alekseev
Branch
--
REL9_5_STABLE
Details
---
http://git.postgresql.org/pg/commitdiff/e52e22d93233e46b308c9bb778d17cf9bc5b0970
Modified Files
--
src/backend/commands/policy.c | 4 ++--
1 file changed, 2 insertions(+)
Add idle_in_transaction_session_timeout.
Vik Fearing, reviewed by Stéphane Schildknecht and me, and revised
slightly by me.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/c6dda1f48e573cc60fe25d8d470a05bfabed0252
Modified Files
--
doc/src/sgml/config.sgm
Improve support of Hunspell
- allow to use non-ascii characters as affix flag. Non-numeric affix flags now
are stored as string instead of numeric value of character.
- allow to use 0 as affix flag in numeric encoded affixes
That adds support for arabian, hungarian, turkish and
brazilian portug
Use INT64_FORMAT instead of %ld for int64.
Commit 0011c0091e886b874e485a46ff2c94222ffbf550 introduced this
mistake.
Patch by me. Reported by Andres Freund, who also reviewed the
patch.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/08a6d36dcbe4ebdcdf9d554e5b571748
Teodor Sigaev writes:
>> It should go through SetConfigOption(); compare for example
>> tsa_set_curcfg_byname(). Which would also mean you could drop the
> Seems, also show_limit() should use GetConfigOption()?
Nah, that's overkill. The current contents of similarity_threshold are
always the c
contrib/pg_trgm/pg_trgm--1.1--1.2.sql | 64 -
contrib/pg_trgm/pg_trgm--1.2.sql | 64 +
This is completely, utterly wrong. You do not add stuff to an extension
module by redefining what version 1.2 means. You do it by creating a 1.3
version and providing a 1.2--1.3 update script.
Merge wal_level "archive" and "hot_standby" into new name "replica"
The distinction between "archive" and "hot_standby" existed only because
at the time "hot_standby" was added, there was some uncertainty about
stability. This is now a long time ago. We would like to move forward
with simplifyin
Teodor Sigaev writes:
> Modified Files
> --
> contrib/pg_trgm/pg_trgm--1.1--1.2.sql | 64 -
> contrib/pg_trgm/pg_trgm--1.2.sql | 64 +
This is completely, utterly wrong. You do not add stuff to an extension
module by redefining what version 1.2 means. You do it by creat
Push scan/join target list beneath Gather when possible.
This means that, for example, "SELECT expensive_func(a) FROM bigtab
WHERE something" can compute expensive_func(a) in the workers rather
than the leader if it happens to be parallel-safe, which figures to be
a big win in some practical cases
On Wed, Mar 16, 2016 at 12:40 PM, Tom Lane wrote:
> Teodor Sigaev writes:
>> Modified Files
>> --
>> contrib/pg_trgm/pg_trgm--1.1--1.2.sql | 64 -
>> contrib/pg_trgm/pg_trgm--1.2.sql | 64 +
>
> This is completely, utterly wrong. You do not add stuff to an extension
> mo
Allow SSL server key file to have group read access if owned by root
We used to require the server key file to have permissions 0600 or less
for best security. But some systems (such as Debian) have certificate
and key files managed by the operating system that can be shared with
other services.
> There is also a typo in commit message: s/management/management/
Oops. I meant "mangement" :)
commit c27033ff7c17b5100d02c454a0eebb95ec7b91cc
Author: Robert Haas
Date: Thu Mar 17 16:11:14 2016 -0400
Update tuplesort.c comments for memory mangement improvements.
--
Best regards,
Alek
Fix "pg_bench -C -M prepared".
This didn't work because when we dropped and re-established a database
connection, we did not bother to reset session-specific state such as
the statements-are-prepared flags.
The st->prepared[] array certainly needs to be flushed, and I cleared a
couple of other fi
If that's to be an actual GUC variable, it's not okay for set_limit()
to just do this:
similarity_threshold = nlimit;
It should go through SetConfigOption(); compare for example
tsa_set_curcfg_byname(). Which would also mean you could drop the
range-checking code there, because guc.c wo
Decouple psqlscan.l from surrounding program.
Remove assorted external references from psqlscan.l in preparation for
making it usable by other frontend programs. This mostly involves
getting rid of direct calls to psql_error() and GetVariable() in favor
of introducing a callback-functions struct
It should go through SetConfigOption(); compare for example
tsa_set_curcfg_byname(). Which would also mean you could drop the
Seems, also show_limit() should use GetConfigOption()?
--
Teodor Sigaev E-mail: teo...@sigaev.ru
Fix j2day() to behave sanely for negative Julian dates.
Somebody had apparently once figured that casting to unsigned int would
produce the right output for negative inputs, but that would only be
true if 2^32 were a multiple of 7, which of course it ain't. We need
to use a signed division and th
Fix assorted breakage in to_char()'s OF format option.
In HEAD, fix incorrect field width for hours part of OF when tm_gmtoff is
negative. This was introduced by commit 2d87eedc1d4468d3 as a result of
falsely applying a pattern that's correct when + signs are omitted, which
is not the case for OF
Fix "pg_bench -C -M prepared".
This didn't work because when we dropped and re-established a database
connection, we did not bother to reset session-specific state such as
the statements-are-prepared flags.
The st->prepared[] array certainly needs to be flushed, and I cleared a
couple of other fi
Fix assorted breakage in to_char()'s OF format option.
In HEAD, fix incorrect field width for hours part of OF when tm_gmtoff is
negative. This was introduced by commit 2d87eedc1d4468d3 as a result of
falsely applying a pattern that's correct when + signs are omitted, which
is not the case for OF
Remove unused, and dangerous, TestLatch() macro.
The macro has not seen any in-tree use since latches had been introduced
in 2746e5f, in 2010.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/fad0f9d8c9f6a8e99156b8f01cba54be39f31761
Modified Files
--
src/
Fix "pg_bench -C -M prepared".
This didn't work because when we dropped and re-established a database
connection, we did not bother to reset session-specific state such as
the statements-are-prepared flags.
The st->prepared[] array certainly needs to be flushed, and I cleared a
couple of other fi
pg_trgm's set_limit() now uses SetConfigOption()
Deprecated set_limit() is modified to use SetConfigOption() to set
similarity_threshold which is actually an instance of
pg_trgm.similarity_threshold GUC variable. Previous coding directly sets
similarity_threshold what could cause an inconsistency
> Clean up some misplaced #includes.
In case you are interested here is a patch that fixes some unused
imports I managed to find.
--
Best regards,
Aleksander Alekseev
http://eax.me/
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index f70bb49..ceeb045 100644
-
With ancient gcc, skip pg_attribute_printf() on function pointer.
Buildfarm results show that the ability to attach pg_attribute_printf
decoration to a function pointer appeared somewhere between gcc 2.95.3
and gcc 4.0.1. Guess that it was there in 4.0.
Branch
--
master
Details
---
http
pgbench: Allow changing weights for scripts
Previously, all scripts had the same probability of being chosen when
multiple of them were specified via -b, -f, -N, -S. With this commit,
-b and -f now search for an "@" in the script name and use the integer
found after it as the drawing probability
UCS_to_EUC_JIS_2004.pl: Turn off "test" mode by default
It produces debugging output files that are of no further use, so we
don't need that by default.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/f9e5ed61ed1e27390051e8eb10bd9ec4cb40d7b2
Modified Files
-
Fix typos.
Jim Nasby
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/0218e8b3fa7ec72af441ac6f80927bff0d497334
Modified Files
--
src/backend/optimizer/README | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
Sent via pgsql-committers mailin
Build backend/parser/scan.l and interfaces/ecpg/preproc/pgc.l standalone.
Now that we know about the %top{} trick, we can revert to building flex
lexers as separate .o files. This is worth doing for a couple of reasons
besides sheer cleanliness. We can narrow the scope of the -Wno-error flag
tha
Robert Haas writes:
> On Wed, Mar 16, 2016 at 12:40 PM, Tom Lane wrote:
>> This is completely, utterly wrong. You do not add stuff to an extension
>> module by redefining what version 1.2 means. You do it by creating a 1.3
>> version and providing a 1.2--1.3 update script.
> Uh, did you read h
Error out if waiting on socket readiness without a specified socket.
Previously we just ignored such an attempt, but that seems to serve no
purpose but making things harder to debug.
Discussion: 20160114143931.gg10...@awork2.anarazel.de
20151230173734.hx7jj2fnwyljf...@alap3.anarazel.de
Review
Improve memory management for external sorts.
Introduce a new memory context which stores tuple data, and reset it
at the end of each merge pass; this helps avoid memory fragmentation
and, consequently, overallocation. Also, for the final merge patch,
eliminate memory context chunk header overhea
Sync backend/parser/scan.l with bin/psql/psqlscan.l.
Make some minor formatting adjustments to make it easier to diff these
files and see that they indeed implement the same flex rules (at least
to the extent that we want them to be the same).
(Someday it'd be nice to make ecpg's pgc.l more easil
Typo fix.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/78e7c4439917b01afd645a2ec657008ba6c33d37
Modified Files
--
src/interfaces/ecpg/preproc/pgc.l | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
Sent via pgsql-committers mailing list (pgsql
Add files forgotten in f576b17cd6ba653bdace1f0da9a3b57f4984e460
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/e4b523e5b52a84010a34fc0796904ce39116e56c
Modified Files
--
contrib/pg_trgm/data/trgm2.data | 696 +++
contrib/pg_trgm
pgbench.c:2765: warning: 'ps.stats.lag.sum2' is used uninitialized in this
function
Sorry for the noise.
Strangely, I did not get that warning with gcc 4.8.4.
ISTM that in stack variables are initialized to zero automatically, so
although it is not explicitely initialized, it is not uninit
On 2016-03-19 20:23:03 +0100, Fabien COELHO wrote:
>
> >pgbench.c:2765: warning: 'ps.stats.lag.sum2' is used uninitialized in this
> >function
>
> Sorry for the noise.
>
> Strangely, I did not get that warning with gcc 4.8.4.
>
> ISTM that in stack variables are initialized to zero automatical
pgbench: Silence new compiler warnings
The original coding in 7bafffea647 and previous wasn't all that great
anyway.
Reported by Jeff Janes and Tom Lane
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/1038bc91ca98865bd60bf63db46fc331f308
Modified Files
ISTM that in stack variables are initialized to zero automatically, so
although it is not explicitely initialized, it is not uninitialized...
Uh? They're not.
Indeed, I mixed up with "static", shame on me!
--
Fabien.
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.o
Fix typo.
Amit Langote
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/1c4f001b79878deb9475e5b32ff4ef87773c9f23
Modified Files
--
doc/src/sgml/monitoring.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
Sent via pgsql-committers mailing li
GUC variable pg_trgm.similarity_threshold insead of set_limit()
Use GUC variable pg_trgm.similarity_threshold insead of
set_limit()/show_limit() which was introduced when defining GUC varuables
by modules was absent.
Author: Artur Zakirov
Branch
--
master
Details
---
http://git.postgres
Make pgbench's expression lexer reentrant.
This is a necessary preliminary step for making it play with psqlscan.l
given the way I set up the lexer input-buffer sharing mechanism in commit
0ea9efbe9ec1bf07.
I've not tried to make it *actually* reentrant; there's still some static
variables laying
Alvaro Herrera writes:
> pgbench: Silence new compiler warnings
Fixes it for me, thanks.
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committ
Fix "pg_bench -C -M prepared".
This didn't work because when we dropped and re-established a database
connection, we did not bother to reset session-specific state such as
the statements-are-prepared flags.
The st->prepared[] array certainly needs to be flushed, and I cleared a
couple of other fi
Fix phony .PHONY.
A couple makefiles had misspelled the magic .PHONY target as PHONY.
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/d5351fcb03fc8e20651d5863b88b397a8be68d74
Modified Files
--
contrib/test_decoding/Makefile | 2 +-
src/test/modules/brin/M
Fix phony .PHONY.
A couple makefiles had misspelled the magic .PHONY target as PHONY.
Branch
--
REL9_4_STABLE
Details
---
http://git.postgresql.org/pg/commitdiff/b190fe95bbf9222143c449afdc1c59783653e0b9
Modified Files
--
contrib/test_decoding/Makefile | 2 +-
1 file changed,
Fix phony .PHONY.
A couple makefiles had misspelled the magic .PHONY target as PHONY.
Branch
--
REL9_5_STABLE
Details
---
http://git.postgresql.org/pg/commitdiff/e1936470ea10311614ff893113d40873b630d521
Modified Files
--
contrib/test_decoding/Makefile | 2 +-
src/test/modules
Update tuplesort.c comments for memory mangement improvements.
I'm committing these changes separately so that it's clear what is
Peter's original work versus what I changed. This is a followup to
commit 0011c0091e886b874e485a46ff2c94222ffbf550, and these changes
are all by me.
Branch
--
mas
Add syslog_split_messages parameter
Reviewed-by: Andreas Karlsson
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/fc201dfd95059fd2fef9862a2fd09cfab42c9bf7
Modified Files
--
doc/src/sgml/config.sgml | 33 +++
s
Remove dependency on psed for MSVC builds.
Modern Perl has removed psed from its core distribution, so it might not
be readily available on some build platforms. We therefore replace its
use with a Perl script generated by s2p, which is equivalent to the sed
script. The latter is retained for non-
Remove dependency on psed for MSVC builds.
Modern Perl has removed psed from its core distribution, so it might not
be readily available on some build platforms. We therefore replace its
use with a Perl script generated by s2p, which is equivalent to the sed
script. The latter is retained for non-
Remove dependency on psed for MSVC builds.
Modern Perl has removed psed from its core distribution, so it might not
be readily available on some build platforms. We therefore replace its
use with a Perl script generated by s2p, which is equivalent to the sed
script. The latter is retained for non-
Remove dependency on psed for MSVC builds.
Modern Perl has removed psed from its core distribution, so it might not
be readily available on some build platforms. We therefore replace its
use with a Perl script generated by s2p, which is equivalent to the sed
script. The latter is retained for non-
Remove dependency on psed for MSVC builds.
Modern Perl has removed psed from its core distribution, so it might not
be readily available on some build platforms. We therefore replace its
use with a Perl script generated by s2p, which is equivalent to the sed
script. The latter is retained for non-
Remove dependency on psed for MSVC builds.
Modern Perl has removed psed from its core distribution, so it might not
be readily available on some build platforms. We therefore replace its
use with a Perl script generated by s2p, which is equivalent to the sed
script. The latter is retained for non-
Clean up some misplaced #includes.
Random .h files have no business including postgres-fe.h (or postgres.h).
If that wasn't the first #include done by the calling .c file, it's the
.c file that's broken. Noted while prepping Kyotaro Horiguchi's psql
lexer refactoring patch.
Branch
--
master
Directly modify foreign tables.
postgres_fdw can now sent an UPDATE or DELETE statement directly to
the foreign server in simple cases, rather than sending a SELECT FOR
UPDATE statement and then updating or deleting rows one-by-one.
Etsuro Fujita, reviewed by Rushabh Lathia, Shigeru Hanada, Kyota
Add word_similarity to pg_trgm contrib module.
Patch introduces a concept of similarity over string and just a word from
another string.
Version of extension is not changed because 1.2 was already introduced in 9.6
release cycle, so, there wasn't a public version.
Author: Alexander Korotkov, Art
Make it easier to choose the used waiting primitive in unix_latch.c.
This allows for easier testing of the different primitives; in
preparation for adding a new primitive.
Discussion: 20160114143931.gg10...@awork2.anarazel.de
Reviewed-By: Robert Haas
Branch
--
master
Details
---
http://
Only clear latch self-pipe/event if there is a pending notification.
This avoids a good number of, individually quite fast, system calls in
scenarios with many quick queries. Besides the aesthetic benefit of
seing fewer superflous system calls with strace, it also improves
performance by ~2% measu
Fixed a typo and added 'the' a few times.
Thank you, committed
--
Teodor Sigaev E-mail: teo...@sigaev.ru
WWW: http://www.sigaev.ru/
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
T
Convert psql's flex lexer to be re-entrant, and make it compile standalone.
Change psqlscan.l to specify '%option reentrant', adjust internal APIs
to match, and get rid of its internal static variables. While this is
good cleanup in an abstract sense, the reason to do it right now is that
it seem
On 2016-03-17 20:11:00 +, Robert Haas wrote:
> Improve memory management for external sorts.
>
> Introduce a new memory context which stores tuple data, and reset it
> at the end of each merge pass; this helps avoid memory fragmentation
> and, consequently, overallocation. Also, for the final
There is a typo in a comment. See attachment.
There is also a typo in commit message: s/management/management/. But it
is my understanding that we don't fix such things.diff --git a/src/backend/utils/sort/tuplesort.c b/src/backend/utils/sort/tuplesort.c
index d3070f8..dbedc27 100644
--- a/src/back
Introduce parse_ident()
SQL-layer function to split qualified identifier into array parts.
Author: Pavel Stehule with minor editorization by me and Jim Nasby
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/3187d6de0e5a9e805b27c48437897e8c39071d45
Modified Files
---
Improve script generating unaccent rules
Script now use the standard Unicode transliterator Latin-ASCII.
Author: Leonard Benedetti
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/9a206d063c410df7cd5da01b169b23bff413fef5
Modified Files
--
contrib/unaccen
Make spacing and punctuation consistent
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/9dbcb500cad06f2dd1c699e8dbcfbe23145e61fa
Modified Files
--
src/backend/utils/mb/Unicode/UCS_to_SHIFT_JIS_2004.pl | 4 ++--
src/backend/utils/mb/Unicode/UCS_to_SJIS.pl
71 matches
Mail list logo
