[COMMITTERS] pgsql: Revert no-op changes to BufferGetPage()

2016-04-20 Thread Kevin Grittner
Revert no-op changes to BufferGetPage() The reverted changes were intended to force a choice of whether any newly-added BufferGetPage() calls needed to be accompanied by a test of the snapshot age, to support the "snapshot too old" feature. Such an accompanying test is needed in about 7% of the c

Re: [HACKERS] Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold

2016-04-20 Thread Andres Freund
On 2016-04-19 20:27:31 +0530, Amit Kapila wrote: > On Sun, Apr 17, 2016 at 2:26 AM, Andres Freund wrote: > > > > On 2016-04-16 16:44:52 -0400, Noah Misch wrote: > > > That is more controversial than the potential ~2% regression for > > > old_snapshot_threshold=-1. Alvaro[2] and Robert[3] are okay

[COMMITTERS] pgsql: Fix memory leak and other bugs in ginPlaceToPage() & subroutines

2016-04-20 Thread Tom Lane
Fix memory leak and other bugs in ginPlaceToPage() & subroutines. Commit 36a35c550ac114ca turned the interface between ginPlaceToPage and its subroutines in gindatapage.c and ginentrypage.c into a royal mess: page-update critical sections were started in one place and finished in another place not

[COMMITTERS] pgsql: Fix memory leak and other bugs in ginPlaceToPage() & subroutines

2016-04-20 Thread Tom Lane
Fix memory leak and other bugs in ginPlaceToPage() & subroutines. Commit 36a35c550ac114ca turned the interface between ginPlaceToPage and its subroutines in gindatapage.c and ginentrypage.c into a royal mess: page-update critical sections were started in one place and finished in another place not

[COMMITTERS] pgsql: Fix memory leak and other bugs in ginPlaceToPage() & subroutines

2016-04-20 Thread Tom Lane
Fix memory leak and other bugs in ginPlaceToPage() & subroutines. Commit 36a35c550ac114ca turned the interface between ginPlaceToPage and its subroutines in gindatapage.c and ginentrypage.c into a royal mess: page-update critical sections were started in one place and finished in another place not

[COMMITTERS] pgsql: Update backup documentation for new APIs

2016-04-20 Thread Magnus Hagander
Update backup documentation for new APIs This includes the rest of the documentation that was not included in 7117685. A larger restructure would still be wanted, but with this commit the documentation of the new features is complete. Branch -- master Details --- http://git.postgresql.or

[COMMITTERS] pgsql: Forbid parallel Hash Right Join or Hash Full Join.

2016-04-20 Thread Robert Haas
Forbid parallel Hash Right Join or Hash Full Join. That won't work. You'll get bogus null-extended rows. Mithun Cy Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9c75e1a36b6b2f3ad9f76ae661f42586c92c6f7c Modified Files -- src/backend/optimizer/path/joi

Re: [HACKERS] Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold

2016-04-20 Thread Ants Aasma
On Tue, Apr 19, 2016 at 6:11 PM, Kevin Grittner wrote: > On Tue, Apr 19, 2016 at 9:57 AM, Amit Kapila wrote: >> On Sun, Apr 17, 2016 at 2:26 AM, Andres Freund wrote: >>> >>> On 2016-04-16 16:44:52 -0400, Noah Misch wrote: >>> > That is more controversial than the potential ~2% regression for >>>

[COMMITTERS] pgsql: Add pg_dump support for the new PARALLEL option for aggregates.

2016-04-20 Thread Robert Haas
Add pg_dump support for the new PARALLEL option for aggregates. This was an oversight in commit 41ea0c23761ca108e2f08f6e3151e3cb1f9652a1. Fabrízio de Royes Mello, per a report from Tushar Ahuja Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b4e0f183826e85fd43248d50

[COMMITTERS] pgsql: Honor PGCTLTIMEOUT environment variable for pg_regress' startup

2016-04-20 Thread Tom Lane
Honor PGCTLTIMEOUT environment variable for pg_regress' startup wait. In commit 2ffa86962077c588 we made pg_ctl recognize an environment variable PGCTLTIMEOUT to set the default timeout for starting and stopping the postmaster. However, pg_regress uses pg_ctl only for the "stop" end of that; it h

[COMMITTERS] pgsql: Honor PGCTLTIMEOUT environment variable for pg_regress' startup

2016-04-20 Thread Tom Lane
Honor PGCTLTIMEOUT environment variable for pg_regress' startup wait. In commit 2ffa86962077c588 we made pg_ctl recognize an environment variable PGCTLTIMEOUT to set the default timeout for starting and stopping the postmaster. However, pg_regress uses pg_ctl only for the "stop" end of that; it h

[COMMITTERS] pgsql: Honor PGCTLTIMEOUT environment variable for pg_regress' startup

2016-04-20 Thread Tom Lane
Honor PGCTLTIMEOUT environment variable for pg_regress' startup wait. In commit 2ffa86962077c588 we made pg_ctl recognize an environment variable PGCTLTIMEOUT to set the default timeout for starting and stopping the postmaster. However, pg_regress uses pg_ctl only for the "stop" end of that; it h

[COMMITTERS] pgsql: Honor PGCTLTIMEOUT environment variable for pg_regress' startup

2016-04-20 Thread Tom Lane
Honor PGCTLTIMEOUT environment variable for pg_regress' startup wait. In commit 2ffa86962077c588 we made pg_ctl recognize an environment variable PGCTLTIMEOUT to set the default timeout for starting and stopping the postmaster. However, pg_regress uses pg_ctl only for the "stop" end of that; it h

[COMMITTERS] pgsql: Honor PGCTLTIMEOUT environment variable for pg_regress' startup

2016-04-20 Thread Tom Lane
Honor PGCTLTIMEOUT environment variable for pg_regress' startup wait. In commit 2ffa86962077c588 we made pg_ctl recognize an environment variable PGCTLTIMEOUT to set the default timeout for starting and stopping the postmaster. However, pg_regress uses pg_ctl only for the "stop" end of that; it h

[COMMITTERS] pgsql: Honor PGCTLTIMEOUT environment variable for pg_regress' startup

2016-04-20 Thread Tom Lane
Honor PGCTLTIMEOUT environment variable for pg_regress' startup wait. In commit 2ffa86962077c588 we made pg_ctl recognize an environment variable PGCTLTIMEOUT to set the default timeout for starting and stopping the postmaster. However, pg_regress uses pg_ctl only for the "stop" end of that; it h

[COMMITTERS] pgsql: postgres_fdw: Don't push down certain full joins.

2016-04-20 Thread Robert Haas
postgres_fdw: Don't push down certain full joins. If there's a filter condition on either side of a full outer join, it is neither correct to attach it to the join's ON clause nor to throw it into the toplevel WHERE clause. Just don't push down the join in that case. To maximize the number of ca