[COMMITTERS] pgsql: Fix typo in comment

2016-04-26 Thread Magnus Hagander
Fix typo in comment Author: Daniel Gustafsson Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b7351ced425f3937f0a61adb4ade1d4b93bf751d Modified Files -- src/backend/executor/execProcnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent v

[COMMITTERS] pgsql: Enable parallel query by default.

2016-04-26 Thread Robert Haas
Enable parallel query by default. Change max_parallel_degree default from 0 to 2. It is possible that this is not a good idea, or that we should go with 1 worker rather than 2, but we won't find out without trying it. Along the way, reword the documentation for max_parallel_degree a little bit t

[COMMITTERS] pgsql: Yet more portability hacking for degree-based trig functions.

2016-04-26 Thread Tom Lane
Yet more portability hacking for degree-based trig functions. The true explanation for Peter Eisentraut's report of inexact asind results seems to be that (a) he's compiling into x87 instruction set, which uses wider-than-double float registers, plus (b) the library function asin() on his platform

[COMMITTERS] pgsql: Fix order of shutdown cleanup operations in PostgresNode.pm.

2016-04-26 Thread Tom Lane
Fix order of shutdown cleanup operations in PostgresNode.pm. Previously, database clusters created by a TAP test were shut down by DESTROY methods attached to the PostgresNode objects representing them. The trouble with that is that if the objects survive into the final global destruction phase (w

[COMMITTERS] pgsql: Fix tsearch docs

2016-04-26 Thread Teodor Sigaev
Fix tsearch docs Remove mention of setweight(tsquery) which wasn't included in 9.6. Also replace old forgotten phrase operator to new one. Dmitry Ivanov Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f1e3c76066f0066a8a9bb09b80cd97f11e4b2dc4 Modified Files

Re: [COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-04-26 Thread Christian Ullrich
* Christian Ullrich wrote: wrong even without considering the debug/release split. If we load a compiled extension built with a CRT we have not seen yet, _after_ the first call to pgwin32_putenv(), that module's CRT's view of its environment will be frozen because we will never attempt to update

[COMMITTERS] pgsql: Add a --brief option to git_changelog.

2016-04-26 Thread Tom Lane
Add a --brief option to git_changelog. In commit c0b050192, Andres introduced the idea of including one-line commit references in our major release notes. Teach git_changelog to emit a (lightly adapted) version of that format, so that we don't have to laboriously add it to the notes after the fac

Re: [COMMITTERS] pgsql: pg_upgrade: Convert old visibility map format to new format.

2016-04-26 Thread Bruce Momjian
On Fri, Mar 11, 2016 at 05:36:34PM +, Robert Haas wrote: > pg_upgrade: Convert old visibility map format to new format. > > Commit a892234f830e832110f63fc0a2afce2fb21d1584 added a second bit per > page to the visibility map, but pg_upgrade has been unaware of it up > until now. Therefore, a p

[COMMITTERS] pgsql: pg_dump: Message style improvements

2016-04-26 Thread Peter Eisentraut
pg_dump: Message style improvements forgotten in b6dacc173b6830c515d970698cead9a85663c553 Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3019f432d6fffe6d8e04f5ccc592eb385af96492 Modified Files -- src/bin/pg_dump/pg_dump.c | 2 +- 1 file changed, 1 insert

[COMMITTERS] pgsql: Impose a full barrier in generic-xlc.h atomics functions.

2016-04-26 Thread Noah Misch
Impose a full barrier in generic-xlc.h atomics functions. pg_atomic_compare_exchange_*_impl() were providing only the semantics of an acquire barrier. Buildfarm members hornet and mandrill revealed this deficit beginning with commit 008608b9d51061b1f598c197477b3dc7be9c4a64. While we have no repor

[COMMITTERS] pgsql: Impose a full barrier in generic-xlc.h atomics functions.

2016-04-26 Thread Noah Misch
Impose a full barrier in generic-xlc.h atomics functions. pg_atomic_compare_exchange_*_impl() were providing only the semantics of an acquire barrier. Buildfarm members hornet and mandrill revealed this deficit beginning with commit 008608b9d51061b1f598c197477b3dc7be9c4a64. While we have no repor

[COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co

2016-04-26 Thread Noah Misch
On Fri, Apr 22, 2016 at 03:54:48PM +, Tom Lane wrote: > Convert contrib/seg's bool-returning SQL functions to V1 call convention. > > It appears that we can no longer get away with using V0 call convention > for bool-returning functions in newer versions of MSVC. The compiler > seems to gener

Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co

2016-04-26 Thread Andres Freund
On 2016-04-26 22:38:28 -0400, Noah Misch wrote: > On Fri, Apr 22, 2016 at 03:54:48PM +, Tom Lane wrote: > > Convert contrib/seg's bool-returning SQL functions to V1 call convention. > > > > It appears that we can no longer get away with using V0 call convention > > for bool-returning functions

Re: [COMMITTERS] pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co

2016-04-26 Thread Tom Lane
Noah Misch writes: > On Fri, Apr 22, 2016 at 03:54:48PM +, Tom Lane wrote: >> Convert contrib/seg's bool-returning SQL functions to V1 call convention. >> >> It appears that we can no longer get away with using V0 call convention >> for bool-returning functions in newer versions of MSVC. The

[COMMITTERS] pgsql: Fix pg_get_functiondef to dump parallel-safety markings.

2016-04-26 Thread Robert Haas
Fix pg_get_functiondef to dump parallel-safety markings. Ashutosh Sharma Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2ac3be2e763d9b971352819f285dd51519e0aeb9 Modified Files -- src/backend/utils/adt/ruleutils.c | 13 + 1 file changed, 13 in

Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co

2016-04-26 Thread Tom Lane
Andres Freund writes: > I don't understand why we don't just drop V0. It makes debugging harder, > exploitation easier (call arbitrary functions), and really has no > features making it desirable. What's the argument that it makes debugging harder? Especially if you aren't using it? I don't par

Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co

2016-04-26 Thread Andres Freund
On 2016-04-26 22:59:44 -0400, Tom Lane wrote: > What's the argument that it makes debugging harder? Especially if > you aren't using it? If you try to write a V1 function, but forget or mistype/rename the function in PG_FUNCTION_INFO_V1, you'll get crashes, at least if you're lucky. > I don't p

[COMMITTERS] pgsql: Emit invalidations to standby for transactions without xid.

2016-04-26 Thread Andres Freund
Emit invalidations to standby for transactions without xid. So far, when a transaction with pending invalidations, but without an assigned xid, committed, we simply ignored those invalidation messages. That's problematic, because those are actually sent for a reason. Known symptoms of this includ

[COMMITTERS] pgsql: Don't open formally non-existent segments in _mdfd_getseg().

2016-04-26 Thread Andres Freund
Don't open formally non-existent segments in _mdfd_getseg(). Before this commit _mdfd_getseg(), in contrast to mdnblocks(), did not verify whether all segments leading up to the to-be-opened one, were RELSEG_SIZE sized. That is e.g. not the case after truncating a relation, because later segments

Re: [COMMITTERS] pgsql: Emit invalidations to standby for transactions without xid.

2016-04-26 Thread Andres Freund
Hi, On 2016-04-27 03:35:56 +, Andres Freund wrote: > Emit invalidations to standby for transactions without xid. Damnit. I shouldn't have worked on this while tired. I wanted to rebase to remove this commit after performing my testing for http://archives.postgresql.org/message-id/E1avGGa-00

Re: [COMMITTERS] Re: pgsql: Convert contrib/seg's bool-returning SQL functions to V1 call co

2016-04-26 Thread Michael Paquier
On Wed, Apr 27, 2016 at 12:04 PM, Andres Freund wrote: > On 2016-04-26 22:59:44 -0400, Tom Lane wrote: >> What's the argument that it makes debugging harder? Especially if >> you aren't using it? > > If you try to write a V1 function, but forget or mistype/rename the > function in PG_FUNCTION_INF