[COMMITTERS] pgsql: Remove unused macros.

2016-05-02 Thread Heikki Linnakangas
Remove unused macros. CHECK_PAGE_OFFSET_RANGE() has been unused forever. CHECK_RELATION_BLOCK_RANGE() has been unused in pgstatindex.c ever since bt_page_stats() and bt_page_items() functions were moved from pgstattuple to pageinspect module. It still exists in pageinspect/btreefuncs.c. Daniel Gu

[COMMITTERS] pgsql: Remove unused macros.

2016-05-02 Thread Heikki Linnakangas
Remove unused macros. CHECK_PAGE_OFFSET_RANGE() has been unused forever. CHECK_RELATION_BLOCK_RANGE() has been unused in pgstatindex.c ever since bt_page_stats() and bt_page_items() functions were moved from pgstattuple to pageinspect module. It still exists in pageinspect/btreefuncs.c. Daniel Gu

[COMMITTERS] pgsql: Remove unused macros.

2016-05-02 Thread Heikki Linnakangas
Remove unused macros. CHECK_PAGE_OFFSET_RANGE() has been unused forever. CHECK_RELATION_BLOCK_RANGE() has been unused in pgstatindex.c ever since bt_page_stats() and bt_page_items() functions were moved from pgstattuple to pageinspect module. It still exists in pageinspect/btreefuncs.c. Daniel Gu

[COMMITTERS] pgsql: Remove unused macros.

2016-05-02 Thread Heikki Linnakangas
Remove unused macros. CHECK_PAGE_OFFSET_RANGE() has been unused forever. CHECK_RELATION_BLOCK_RANGE() has been unused in pgstatindex.c ever since bt_page_stats() and bt_page_items() functions were moved from pgstattuple to pageinspect module. It still exists in pageinspect/btreefuncs.c. Daniel Gu

[COMMITTERS] pgsql: Remove unused macros.

2016-05-02 Thread Heikki Linnakangas
Remove unused macros. CHECK_PAGE_OFFSET_RANGE() has been unused forever. CHECK_RELATION_BLOCK_RANGE() has been unused in pgstatindex.c ever since bt_page_stats() and bt_page_items() functions were moved from pgstattuple to pageinspect module. It still exists in pageinspect/btreefuncs.c. Daniel Gu

[COMMITTERS] pgsql: Remove unused macros.

2016-05-02 Thread Heikki Linnakangas
Remove unused macros. CHECK_PAGE_OFFSET_RANGE() has been unused forever. CHECK_RELATION_BLOCK_RANGE() has been unused in pgstatindex.c ever since bt_page_stats() and bt_page_items() functions were moved from pgstattuple to pageinspect module. It still exists in pageinspect/btreefuncs.c. Daniel Gu

[COMMITTERS] pgsql: Again update typedefs.list file in preparation for pgindent run

2016-05-02 Thread Robert Haas
Again update typedefs.list file in preparation for pgindent run This time, use the buildfarm-supplied contents for this file, instead of trying to update it by eyeballing the pgindent output. Per discussion with Tom and Bruce. Branch -- master Details --- http://git.postgresql.org/pg/co

[COMMITTERS] pgsql: Fix parallel safety markings for pg_start_backup.

2016-05-02 Thread Robert Haas
Fix parallel safety markings for pg_start_backup. Commit 7117685461af50f50c03f43e6a622284c8d54694 made pg_start_backup parallel-restricted rather than parallel-safe, because it now relies on backend-private state that won't be synchronized with the parallel worker. However, it didn't update pg_pr

Re: [COMMITTERS] pgsql: Fix parallel safety markings for pg_start_backup.

2016-05-02 Thread Magnus Hagander
Oops, thanks. Need to get used to actually considering this new parallelism flag when adding new functions, and not just copy/paste. /Magnus On May 2, 2016 16:44, "Robert Haas" wrote: > Fix parallel safety markings for pg_start_backup. > > Commit 7117685461af50f50c03f43e6a622284c8d54694 made pg_

[COMMITTERS] pgsql: Fix configure's incorrect version tests for flex and perl.

2016-05-02 Thread Tom Lane
Fix configure's incorrect version tests for flex and perl. awk's equality-comparison operator is "==" not "=". We got this right in many places, but not in configure's checks for supported version numbers of flex and perl. It hadn't been noticed because unsupported versions are so old as to be b

[COMMITTERS] pgsql: Fix configure's incorrect version tests for flex and perl.

2016-05-02 Thread Tom Lane
Fix configure's incorrect version tests for flex and perl. awk's equality-comparison operator is "==" not "=". We got this right in many places, but not in configure's checks for supported version numbers of flex and perl. It hadn't been noticed because unsupported versions are so old as to be b

[COMMITTERS] pgsql: Fix configure's incorrect version tests for flex and perl.

2016-05-02 Thread Tom Lane
Fix configure's incorrect version tests for flex and perl. awk's equality-comparison operator is "==" not "=". We got this right in many places, but not in configure's checks for supported version numbers of flex and perl. It hadn't been noticed because unsupported versions are so old as to be b

[COMMITTERS] pgsql: Fix configure's incorrect version tests for flex and perl.

2016-05-02 Thread Tom Lane
Fix configure's incorrect version tests for flex and perl. awk's equality-comparison operator is "==" not "=". We got this right in many places, but not in configure's checks for supported version numbers of flex and perl. It hadn't been noticed because unsupported versions are so old as to be b

[COMMITTERS] pgsql: Fix configure's incorrect version tests for flex and perl.

2016-05-02 Thread Tom Lane
Fix configure's incorrect version tests for flex and perl. awk's equality-comparison operator is "==" not "=". We got this right in many places, but not in configure's checks for supported version numbers of flex and perl. It hadn't been noticed because unsupported versions are so old as to be b

[COMMITTERS] pgsql: Fix configure's incorrect version tests for flex and perl.

2016-05-02 Thread Tom Lane
Fix configure's incorrect version tests for flex and perl. awk's equality-comparison operator is "==" not "=". We got this right in many places, but not in configure's checks for supported version numbers of flex and perl. It hadn't been noticed because unsupported versions are so old as to be b

[COMMITTERS] pgsql: Docs: improve index entries for new tsvector functions.

2016-05-02 Thread Tom Lane
Docs: improve index entries for new tsvector functions. Fix typos, reword some overly general index entries. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/21c2b1c611d072f1a27defa89803fdd09b132605 Modified Files -- doc/src/sgml/func.sgml | 11 +-

[COMMITTERS] pgsql: Fix code comments regarding logical decoding

2016-05-02 Thread Alvaro Herrera
Fix code comments regarding logical decoding Back in 3b02ea4f0780 I added some comments in various places to explain how logical decoding and other things worked. Not all of the changes were welcome, because they were misleading or wrong. This changes them a little bit to make them more accurate

[COMMITTERS] pgsql: Fix thinko in comment

2016-05-02 Thread Alvaro Herrera
Fix thinko in comment Pointed out by Andres Freund Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6b6091682959adce6d66dcd6a047eb21cb120b16 Modified Files -- src/include/replication/slot.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Se

[COMMITTERS] Re: pgsql: Fix assorted inconsistencies in GIN opclass support function dec

2016-05-02 Thread Alexander Korotkov
On Wed, Jan 20, 2016 at 6:32 AM, Tom Lane wrote: > contrib/hstore/hstore--1.3.sql | 12 - > contrib/intarray/intarray--1.1.sql |8 +++--- > contrib/tsearch2/tsearch2--1.0.sql |4 +-- > Hmm... Is it correct to change function signatures without extension version bump? pg_upgr

Re: [COMMITTERS] pgsql: Fix assorted inconsistencies in GIN opclass support function dec

2016-05-02 Thread Tom Lane
Alexander Korotkov writes: > On Wed, Jan 20, 2016 at 6:32 AM, Tom Lane wrote: >> contrib/hstore/hstore--1.3.sql | 12 - >> contrib/intarray/intarray--1.1.sql |8 +++--- >> contrib/tsearch2/tsearch2--1.0.sql |4 +-- > Hmm... Is it correct to change function signatures without

Re: [COMMITTERS] pgsql: Fix assorted inconsistencies in GIN opclass support function dec

2016-05-02 Thread Andres Freund
On 2016-05-02 17:09:48 -0400, Tom Lane wrote: > But this is likely moot anyway, because of the need to bump all the > contrib modules' versions in order to install parallel-safety labels on > their functions. (I wonder why that isn't on the open-items list.) I think the concensus when discussing

Re: [COMMITTERS] pgsql: Fix assorted inconsistencies in GIN opclass support function dec

2016-05-02 Thread Robert Haas
On Mon, May 2, 2016 at 5:09 PM, Tom Lane wrote: > Alexander Korotkov writes: >> On Wed, Jan 20, 2016 at 6:32 AM, Tom Lane wrote: >>> contrib/hstore/hstore--1.3.sql | 12 - >>> contrib/intarray/intarray--1.1.sql |8 +++--- >>> contrib/tsearch2/tsearch2--1.0.sql |4 +-- > >> Hmm

Re: [COMMITTERS] pgsql: Fix assorted inconsistencies in GIN opclass support function dec

2016-05-02 Thread Andres Freund
On 2016-05-02 17:12:41 -0400, Robert Haas wrote: > On Mon, May 2, 2016 at 5:09 PM, Tom Lane wrote: > > Alexander Korotkov writes: > > But this is likely moot anyway, because of the need to bump all the > > contrib modules' versions in order to install parallel-safety labels on > > their functions