[COMMITTERS] pgsql: Fix typo in ReorderBufferIterTXNInit().

2016-06-30 Thread Tom Lane
Fix typo in ReorderBufferIterTXNInit(). This looks like it would cause changes from subtransactions to be missed by the iterator being constructed, if those changes had been spilled to disk previously. This implies that large subtransactions might be lost (in whole or in part) by logical replicat

[COMMITTERS] pgsql: Fix typo in ReorderBufferIterTXNInit().

2016-06-30 Thread Tom Lane
Fix typo in ReorderBufferIterTXNInit(). This looks like it would cause changes from subtransactions to be missed by the iterator being constructed, if those changes had been spilled to disk previously. This implies that large subtransactions might be lost (in whole or in part) by logical replicat

[COMMITTERS] pgsql: Fix typo in ReorderBufferIterTXNInit().

2016-06-30 Thread Tom Lane
Fix typo in ReorderBufferIterTXNInit(). This looks like it would cause changes from subtransactions to be missed by the iterator being constructed, if those changes had been spilled to disk previously. This implies that large subtransactions might be lost (in whole or in part) by logical replicat

[COMMITTERS] pgsql: Fix several mistakes around parallel workers and client_encoding

2016-06-30 Thread Robert Haas
Fix several mistakes around parallel workers and client_encoding. Previously, workers sent data to the leader using the client encoding. That mostly worked, but the leader the converted the data back to the server encoding. Since not all encoding conversions are reversible, that could provoke fai

Re: [COMMITTERS] pgsql: Fix several mistakes around parallel workers and client_encoding

2016-06-30 Thread Robert Haas
Actually, a significant part of this was derived from Peter's patch. I should have credited him as a co-author as well as a reviewer. I apologize for the oversight. ...Robert > On Jun 30, 2016, at 6:46 PM, Robert Haas wrote: > > Fix several mistakes around parallel workers and client_encoding

Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold

2016-06-30 Thread Noah Misch
On Thu, Jun 16, 2016 at 01:56:44PM -0500, Kevin Grittner wrote: > On Thu, Jun 16, 2016 at 1:32 PM, Andres Freund wrote: > > > With old_snapshot_threshold=1 I indeed can reproduce the issue. I > > disabled autovacuum, to make the scheduling more predictable. But it > > should "work" just as well w

Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold

2016-06-30 Thread Andres Freund
On 2016-06-30 23:51:18 -0400, Noah Misch wrote: > On Thu, Jun 16, 2016 at 01:56:44PM -0500, Kevin Grittner wrote: > > On Thu, Jun 16, 2016 at 1:32 PM, Andres Freund wrote: > > > > > With old_snapshot_threshold=1 I indeed can reproduce the issue. I > > > disabled autovacuum, to make the scheduling