[COMMITTERS] pgsql: Clarify the new Red-Black post-order traversal code a bit.

2016-09-04 Thread Heikki Linnakangas
Clarify the new Red-Black post-order traversal code a bit. Coverity complained about the for(;;) loop, because it never actually iterated. It was used just to be able to use "break" to exit it early. I agree with Coverity, that's a bit confusing, so refactor the code to use if-else instead. While

[COMMITTERS] pgsql: Remove useless pg_strdup() operations.

2016-09-04 Thread Tom Lane
Remove useless pg_strdup() operations. split_to_stringlist() doesn't modify its first argument nor expect it to remain valid after exit, so there's no need to duplicate the optarg string at the call sites. Per Coverity. (This has been wrong all along, but commit 052cc223d changed the useless cal

[COMMITTERS] pgsql: Update release notes to mention need for ALTER EXTENSION UPDATE.

2016-09-04 Thread Tom Lane
Update release notes to mention need for ALTER EXTENSION UPDATE. Maybe we ought to make pg_upgrade do this for you, but it won't happen in 9.6, so call out the need for it as a migration consideration. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5a072244919a92b2c

[COMMITTERS] pgsql: Update release notes to mention need for ALTER EXTENSION UPDATE.

2016-09-04 Thread Tom Lane
Update release notes to mention need for ALTER EXTENSION UPDATE. Maybe we ought to make pg_upgrade do this for you, but it won't happen in 9.6, so call out the need for it as a migration consideration. Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/7bdf63ccdc

[COMMITTERS] pgsql: Remove vestigial references to "zic" in favor of "IANA database"

2016-09-04 Thread Tom Lane
Remove vestigial references to "zic" in favor of "IANA database". Commit b2cbced9e instituted a policy of referring to the timezone database as the "IANA timezone database" in our user-facing documentation. Propagate that wording into a couple of places that were still using "zic" to refer to the

[COMMITTERS] pgsql: Remove vestigial references to "zic" in favor of "IANA database"

2016-09-04 Thread Tom Lane
Remove vestigial references to "zic" in favor of "IANA database". Commit b2cbced9e instituted a policy of referring to the timezone database as the "IANA timezone database" in our user-facing documentation. Propagate that wording into a couple of places that were still using "zic" to refer to the

[COMMITTERS] pgsql: Remove vestigial references to "zic" in favor of "IANA database"

2016-09-04 Thread Tom Lane
Remove vestigial references to "zic" in favor of "IANA database". Commit b2cbced9e instituted a policy of referring to the timezone database as the "IANA timezone database" in our user-facing documentation. Propagate that wording into a couple of places that were still using "zic" to refer to the

[COMMITTERS] pgsql: Remove vestigial references to "zic" in favor of "IANA database"

2016-09-04 Thread Tom Lane
Remove vestigial references to "zic" in favor of "IANA database". Commit b2cbced9e instituted a policy of referring to the timezone database as the "IANA timezone database" in our user-facing documentation. Propagate that wording into a couple of places that were still using "zic" to refer to the

[COMMITTERS] pgsql: Remove vestigial references to "zic" in favor of "IANA database"

2016-09-04 Thread Tom Lane
Remove vestigial references to "zic" in favor of "IANA database". Commit b2cbced9e instituted a policy of referring to the timezone database as the "IANA timezone database" in our user-facing documentation. Propagate that wording into a couple of places that were still using "zic" to refer to the

[COMMITTERS] pgsql: Remove vestigial references to "zic" in favor of "IANA database"

2016-09-04 Thread Tom Lane
Remove vestigial references to "zic" in favor of "IANA database". Commit b2cbced9e instituted a policy of referring to the timezone database as the "IANA timezone database" in our user-facing documentation. Propagate that wording into a couple of places that were still using "zic" to refer to the

[COMMITTERS] pgsql: Remove vestigial references to "zic" in favor of "IANA database"

2016-09-04 Thread Tom Lane
Remove vestigial references to "zic" in favor of "IANA database". Commit b2cbced9e instituted a policy of referring to the timezone database as the "IANA timezone database" in our user-facing documentation. Propagate that wording into a couple of places that were still using "zic" to refer to the

[COMMITTERS] pgsql: Add regression test coverage for non-default timezone abbreviati

2016-09-04 Thread Tom Lane
Add regression test coverage for non-default timezone abbreviation sets. After further reflection about the mess cleaned up in commit 39b691f25, I decided the main bit of test coverage that was still missing was to check that the non-default abbreviation-set files we supply are usable. Add that.

[COMMITTERS] pgsql: Add regression test coverage for non-default timezone abbreviati

2016-09-04 Thread Tom Lane
Add regression test coverage for non-default timezone abbreviation sets. After further reflection about the mess cleaned up in commit 39b691f25, I decided the main bit of test coverage that was still missing was to check that the non-default abbreviation-set files we supply are usable. Add that.

[COMMITTERS] pgsql: Add regression test coverage for non-default timezone abbreviati

2016-09-04 Thread Tom Lane
Add regression test coverage for non-default timezone abbreviation sets. After further reflection about the mess cleaned up in commit 39b691f25, I decided the main bit of test coverage that was still missing was to check that the non-default abbreviation-set files we supply are usable. Add that.

[COMMITTERS] pgsql: Add regression test coverage for non-default timezone abbreviati

2016-09-04 Thread Tom Lane
Add regression test coverage for non-default timezone abbreviation sets. After further reflection about the mess cleaned up in commit 39b691f25, I decided the main bit of test coverage that was still missing was to check that the non-default abbreviation-set files we supply are usable. Add that.

[COMMITTERS] pgsql: Add regression test coverage for non-default timezone abbreviati

2016-09-04 Thread Tom Lane
Add regression test coverage for non-default timezone abbreviation sets. After further reflection about the mess cleaned up in commit 39b691f25, I decided the main bit of test coverage that was still missing was to check that the non-default abbreviation-set files we supply are usable. Add that.

[COMMITTERS] pgsql: Add regression test coverage for non-default timezone abbreviati

2016-09-04 Thread Tom Lane
Add regression test coverage for non-default timezone abbreviation sets. After further reflection about the mess cleaned up in commit 39b691f25, I decided the main bit of test coverage that was still missing was to check that the non-default abbreviation-set files we supply are usable. Add that.

[COMMITTERS] pgsql: Add regression test coverage for non-default timezone abbreviati

2016-09-04 Thread Tom Lane
Add regression test coverage for non-default timezone abbreviation sets. After further reflection about the mess cleaned up in commit 39b691f25, I decided the main bit of test coverage that was still missing was to check that the non-default abbreviation-set files we supply are usable. Add that.

[COMMITTERS] pgsql: Remove duplicate code from ReorderBufferCleanupTXN().

2016-09-04 Thread Tom Lane
Remove duplicate code from ReorderBufferCleanupTXN(). Andres is apparently the only hacker who thinks this code is better as-is. I (tgl) follow some of his logic, but the fact that it's setting off warnings from static code analyzers seems like a sufficient reason to put the complexity into a comm