Re: [COMMITTERS] pgsql: Add a macro templatized hashtable.

2016-10-19 Thread Peter Eisentraut
On 10/14/16 7:21 PM, Andres Freund wrote: > Add a macro templatized hashtable. Could you rename the "private" member in SH_TYPE to avoid the C++ keyword? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent

[COMMITTERS] pgsql: Fix WAL-logging of FSM and VM truncation.

2016-10-19 Thread Heikki Linnakangas
Fix WAL-logging of FSM and VM truncation. When a relation is truncated, it is important that the FSM is truncated as well. Otherwise, after recovery, the FSM can return a page that has been truncated away, leading to errors like: ERROR: could not read block 28991 in file "base/16390/572026": rea

[COMMITTERS] pgsql: Fix WAL-logging of FSM and VM truncation.

2016-10-19 Thread Heikki Linnakangas
Fix WAL-logging of FSM and VM truncation. When a relation is truncated, it is important that the FSM is truncated as well. Otherwise, after recovery, the FSM can return a page that has been truncated away, leading to errors like: ERROR: could not read block 28991 in file "base/16390/572026": rea

[COMMITTERS] pgsql: Fix WAL-logging of FSM and VM truncation.

2016-10-19 Thread Heikki Linnakangas
Fix WAL-logging of FSM and VM truncation. When a relation is truncated, it is important that the FSM is truncated as well. Otherwise, after recovery, the FSM can return a page that has been truncated away, leading to errors like: ERROR: could not read block 28991 in file "base/16390/572026": rea

[COMMITTERS] pgsql: Fix WAL-logging of FSM and VM truncation.

2016-10-19 Thread Heikki Linnakangas
Fix WAL-logging of FSM and VM truncation. When a relation is truncated, it is important that the FSM is truncated as well. Otherwise, after recovery, the FSM can return a page that has been truncated away, leading to errors like: ERROR: could not read block 28991 in file "base/16390/572026": rea

[COMMITTERS] pgsql: Fix WAL-logging of FSM and VM truncation.

2016-10-19 Thread Heikki Linnakangas
Fix WAL-logging of FSM and VM truncation. When a relation is truncated, it is important that the FSM is truncated as well. Otherwise, after recovery, the FSM can return a page that has been truncated away, leading to errors like: ERROR: could not read block 28991 in file "base/16390/572026": rea

[COMMITTERS] pgsql: pg_ctl: Add long options for -w and -W

2016-10-19 Thread Peter Eisentraut
pg_ctl: Add long options for -w and -W From: Vik Fearing Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0be22457d730da8971f761b9c948f742a12b50b2 Modified Files -- doc/src/sgml/ref/pg_ctl-ref.sgml | 2 ++ src/bin/pg_ctl/pg_ctl.c | 6 -- 2 fil

[COMMITTERS] pgsql: initdb pg_basebackup: Rename --noxxx options to --no-xxx

2016-10-19 Thread Peter Eisentraut
initdb pg_basebackup: Rename --noxxx options to --no-xxx --noclean and --nosync were the only options spelled without a hyphen, so change this for consistency with other options. The options in pg_basebackup have not been in a release, so we just rename them. For initdb, we retain the old varian

[COMMITTERS] pgsql: pg_ctl: Add long option for -o

2016-10-19 Thread Peter Eisentraut
pg_ctl: Add long option for -o Now all normally used options are covered by long options as well. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/caf936b09fc7c74844575332b07c667a178cb078 Modified Files -- doc/src/sgml/ref/pg_ctl-ref.sgml | 2 ++ src/bin/p

[COMMITTERS] pgsql: doc: Consistently use = sign in long options synopses

2016-10-19 Thread Peter Eisentraut
doc: Consistently use = sign in long options synopses This was already the predominant form in man pages and help output. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c709c6074083a8cc5f1ba431c741ff04e3a8a906 Modified Files -- doc/src/sgml/ref/clusterd

[COMMITTERS] pgsql: Use pg_ctl promote -w in TAP tests

2016-10-19 Thread Peter Eisentraut
Use pg_ctl promote -w in TAP tests Switch TAP tests to use the new wait mode of pg_ctl promote. This allows avoiding extra logic with poll_query_until() to be sure that a promoted standby is ready for read-write queries. From: Michael Paquier Branch -- master Details --- http://git.po

[COMMITTERS] pgsql: Make getrusage() output a little more readable

2016-10-19 Thread Peter Eisentraut
Make getrusage() output a little more readable Reviewed-by: Robert Haas Reviewed-by: Peter Geoghegan Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9ffe4a8b4cbb713bf8137f8414f02d97b6b2eb08 Modified Files -- doc/src/sgml/ref/vacuum.sgml | 12

[COMMITTERS] packing/alignment annotation for ItemPointerData redux

2016-10-19 Thread Greg Stark
Back in 2001 a hack to add __attribute__((packed)) to ItemPtr was added with a comment "Appropriate whack upside the head for ARM" (dcbbdb1b3ee). I don't know if this is still a factor in 2016 or not but it has already resulted in some collateral damage in 2015 when some compiler took that as licen

Re: [COMMITTERS] pgsql: Make getrusage() output a little more readable

2016-10-19 Thread Peter Geoghegan
On Wed, Oct 19, 2016 at 6:58 AM, Peter Eisentraut wrote: > Make getrusage() output a little more readable BTW, trace_sort is a user-visible, documented GUC, so I guess that means that this will need a release note item. -- Peter Geoghegan -- Sent via pgsql-committers mailing list (pgsql-comm

[COMMITTERS] pgsql: Update time zone data files to tzdata release 2016g.

2016-10-19 Thread Tom Lane
Update time zone data files to tzdata release 2016g. DST law changes in Turkey. Historical corrections for America/Los_Angeles, Europe/Kirov, Europe/Moscow, Europe/Samara, and Europe/Ulyanovsk. Rename Asia/Rangoon to Asia/Yangon, with a backward compatibility link. The IANA crew continue their c

[COMMITTERS] pgsql: Update time zone data files to tzdata release 2016g.

2016-10-19 Thread Tom Lane
Update time zone data files to tzdata release 2016g. DST law changes in Turkey. Historical corrections for America/Los_Angeles, Europe/Kirov, Europe/Moscow, Europe/Samara, and Europe/Ulyanovsk. Rename Asia/Rangoon to Asia/Yangon, with a backward compatibility link. The IANA crew continue their c

[COMMITTERS] pgsql: Update time zone data files to tzdata release 2016g.

2016-10-19 Thread Tom Lane
Update time zone data files to tzdata release 2016g. DST law changes in Turkey. Historical corrections for America/Los_Angeles, Europe/Kirov, Europe/Moscow, Europe/Samara, and Europe/Ulyanovsk. Rename Asia/Rangoon to Asia/Yangon, with a backward compatibility link. The IANA crew continue their c

[COMMITTERS] pgsql: Update time zone data files to tzdata release 2016g.

2016-10-19 Thread Tom Lane
Update time zone data files to tzdata release 2016g. DST law changes in Turkey. Historical corrections for America/Los_Angeles, Europe/Kirov, Europe/Moscow, Europe/Samara, and Europe/Ulyanovsk. Rename Asia/Rangoon to Asia/Yangon, with a backward compatibility link. The IANA crew continue their c

[COMMITTERS] pgsql: Update time zone data files to tzdata release 2016g.

2016-10-19 Thread Tom Lane
Update time zone data files to tzdata release 2016g. DST law changes in Turkey. Historical corrections for America/Los_Angeles, Europe/Kirov, Europe/Moscow, Europe/Samara, and Europe/Ulyanovsk. Rename Asia/Rangoon to Asia/Yangon, with a backward compatibility link. The IANA crew continue their c

[COMMITTERS] pgsql: Update time zone data files to tzdata release 2016g.

2016-10-19 Thread Tom Lane
Update time zone data files to tzdata release 2016g. DST law changes in Turkey. Historical corrections for America/Los_Angeles, Europe/Kirov, Europe/Moscow, Europe/Samara, and Europe/Ulyanovsk. Rename Asia/Rangoon to Asia/Yangon, with a backward compatibility link. The IANA crew continue their c

[COMMITTERS] pgsql: Update time zone data files to tzdata release 2016g.

2016-10-19 Thread Tom Lane
Update time zone data files to tzdata release 2016g. DST law changes in Turkey. Historical corrections for America/Los_Angeles, Europe/Kirov, Europe/Moscow, Europe/Samara, and Europe/Ulyanovsk. Rename Asia/Rangoon to Asia/Yangon, with a backward compatibility link. The IANA crew continue their c

[COMMITTERS] pgsql: Suppress "Factory" zone in pg_timezone_names view for tzdata >=

2016-10-19 Thread Tom Lane
Suppress "Factory" zone in pg_timezone_names view for tzdata >= 2016g. IANA got rid of the really silly "abbreviation" and replaced it with one that's only moderately silly. But it's still pointless, so keep on not showing it. Branch -- REL9_2_STABLE Details --- http://git.postgresql.or

[COMMITTERS] pgsql: Suppress "Factory" zone in pg_timezone_names view for tzdata >=

2016-10-19 Thread Tom Lane
Suppress "Factory" zone in pg_timezone_names view for tzdata >= 2016g. IANA got rid of the really silly "abbreviation" and replaced it with one that's only moderately silly. But it's still pointless, so keep on not showing it. Branch -- REL9_1_STABLE Details --- http://git.postgresql.or

[COMMITTERS] pgsql: Suppress "Factory" zone in pg_timezone_names view for tzdata >=

2016-10-19 Thread Tom Lane
Suppress "Factory" zone in pg_timezone_names view for tzdata >= 2016g. IANA got rid of the really silly "abbreviation" and replaced it with one that's only moderately silly. But it's still pointless, so keep on not showing it. Branch -- master Details --- http://git.postgresql.org/pg/co

[COMMITTERS] pgsql: Suppress "Factory" zone in pg_timezone_names view for tzdata >=

2016-10-19 Thread Tom Lane
Suppress "Factory" zone in pg_timezone_names view for tzdata >= 2016g. IANA got rid of the really silly "abbreviation" and replaced it with one that's only moderately silly. But it's still pointless, so keep on not showing it. Branch -- REL9_3_STABLE Details --- http://git.postgresql.or

[COMMITTERS] pgsql: Suppress "Factory" zone in pg_timezone_names view for tzdata >=

2016-10-19 Thread Tom Lane
Suppress "Factory" zone in pg_timezone_names view for tzdata >= 2016g. IANA got rid of the really silly "abbreviation" and replaced it with one that's only moderately silly. But it's still pointless, so keep on not showing it. Branch -- REL9_6_STABLE Details --- http://git.postgresql.or

[COMMITTERS] pgsql: Suppress "Factory" zone in pg_timezone_names view for tzdata >=

2016-10-19 Thread Tom Lane
Suppress "Factory" zone in pg_timezone_names view for tzdata >= 2016g. IANA got rid of the really silly "abbreviation" and replaced it with one that's only moderately silly. But it's still pointless, so keep on not showing it. Branch -- REL9_4_STABLE Details --- http://git.postgresql.or

[COMMITTERS] pgsql: Suppress "Factory" zone in pg_timezone_names view for tzdata >=

2016-10-19 Thread Tom Lane
Suppress "Factory" zone in pg_timezone_names view for tzdata >= 2016g. IANA got rid of the really silly "abbreviation" and replaced it with one that's only moderately silly. But it's still pointless, so keep on not showing it. Branch -- REL9_5_STABLE Details --- http://git.postgresql.or

[COMMITTERS] pgsql: Sync our copy of the timezone library with IANA release tzcode20

2016-10-19 Thread Tom Lane
Sync our copy of the timezone library with IANA release tzcode2016g. This is mostly to absorb some corner-case fixes in zic for year-2037 timestamps. The other changes that have been made are unlikely to affect our usage, but nonetheless we may as well take 'em. Branch -- REL9_5_STABLE Deta

[COMMITTERS] pgsql: Sync our copy of the timezone library with IANA release tzcode20

2016-10-19 Thread Tom Lane
Sync our copy of the timezone library with IANA release tzcode2016g. This is mostly to absorb some corner-case fixes in zic for year-2037 timestamps. The other changes that have been made are unlikely to affect our usage, but nonetheless we may as well take 'em. Branch -- REL9_6_STABLE Deta

[COMMITTERS] pgsql: Sync our copy of the timezone library with IANA release tzcode20

2016-10-19 Thread Tom Lane
Sync our copy of the timezone library with IANA release tzcode2016g. This is mostly to absorb some corner-case fixes in zic for year-2037 timestamps. The other changes that have been made are unlikely to affect our usage, but nonetheless we may as well take 'em. Branch -- master Details ---

[COMMITTERS] pgsql: Sync our copy of the timezone library with IANA release tzcode20

2016-10-19 Thread Tom Lane
Sync our copy of the timezone library with IANA release tzcode2016g. This is mostly to absorb some corner-case fixes in zic for year-2037 timestamps. The other changes that have been made are unlikely to affect our usage, but nonetheless we may as well take 'em. Branch -- REL9_1_STABLE Deta

[COMMITTERS] pgsql: Sync our copy of the timezone library with IANA release tzcode20

2016-10-19 Thread Tom Lane
Sync our copy of the timezone library with IANA release tzcode2016g. This is mostly to absorb some corner-case fixes in zic for year-2037 timestamps. The other changes that have been made are unlikely to affect our usage, but nonetheless we may as well take 'em. Branch -- REL9_3_STABLE Deta

[COMMITTERS] pgsql: Sync our copy of the timezone library with IANA release tzcode20

2016-10-19 Thread Tom Lane
Sync our copy of the timezone library with IANA release tzcode2016g. This is mostly to absorb some corner-case fixes in zic for year-2037 timestamps. The other changes that have been made are unlikely to affect our usage, but nonetheless we may as well take 'em. Branch -- REL9_4_STABLE Deta

[COMMITTERS] pgsql: Sync our copy of the timezone library with IANA release tzcode20

2016-10-19 Thread Tom Lane
Sync our copy of the timezone library with IANA release tzcode2016g. This is mostly to absorb some corner-case fixes in zic for year-2037 timestamps. The other changes that have been made are unlikely to affect our usage, but nonetheless we may as well take 'em. Branch -- REL9_2_STABLE Deta

[COMMITTERS] pgsql: Windows portability fix.

2016-10-19 Thread Tom Lane
Windows portability fix. Per buildfarm. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/d5911df8a707993e819457a99c76e50a2fe49591 Modified Files -- src/timezone/zic.c | 3 +++ 1 file changed, 3 insertions(+) -- Sent via pgsql-committers mailing l

[COMMITTERS] pgsql: Windows portability fix.

2016-10-19 Thread Tom Lane
Windows portability fix. Per buildfarm. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/c8321040c97f3e23f0b0d2c7e0dcd98de11cfd48 Modified Files -- src/timezone/zic.c | 3 +++ 1 file changed, 3 insertions(+) -- Sent via pgsql-committers mailing l

[COMMITTERS] pgsql: Windows portability fix.

2016-10-19 Thread Tom Lane
Windows portability fix. Per buildfarm. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ad90ac4d671d320ade3c127f215e97cd49c307fb Modified Files -- src/timezone/zic.c | 3 +++ 1 file changed, 3 insertions(+) -- Sent via pgsql-committers mailing list (pg

[COMMITTERS] pgsql: Windows portability fix.

2016-10-19 Thread Tom Lane
Windows portability fix. Per buildfarm. Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/fba888a8779e16ae25c1443e3a7fdea44817c87c Modified Files -- src/timezone/zic.c | 3 +++ 1 file changed, 3 insertions(+) -- Sent via pgsql-committers mailing l

[COMMITTERS] pgsql: Windows portability fix.

2016-10-19 Thread Tom Lane
Windows portability fix. Per buildfarm. Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/ab1c96e19e074264c57c7536d3beabce16fe5198 Modified Files -- src/timezone/zic.c | 3 +++ 1 file changed, 3 insertions(+) -- Sent via pgsql-committers mailing l

[COMMITTERS] pgsql: Windows portability fix.

2016-10-19 Thread Tom Lane
Windows portability fix. Per buildfarm. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/fadfe66497be1253064c1f19c4779a96d49e1ec4 Modified Files -- src/timezone/zic.c | 3 +++ 1 file changed, 3 insertions(+) -- Sent via pgsql-committers mailing l

[COMMITTERS] pgsql: Windows portability fix.

2016-10-19 Thread Tom Lane
Windows portability fix. Per buildfarm. Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/9ee22f1ff66ae3632a4cd0391c487a327ef401ca Modified Files -- src/timezone/zic.c | 3 +++ 1 file changed, 3 insertions(+) -- Sent via pgsql-committers mailing l

Re: [COMMITTERS] pgsql: Sync our copy of the timezone library with IANA release tzcode20

2016-10-19 Thread Thomas Munro
On Thu, Oct 20, 2016 at 11:56 AM, Tom Lane wrote: > Sync our copy of the timezone library with IANA release tzcode2016g. > > This is mostly to absorb some corner-case fixes in zic for year-2037 > timestamps. The other changes that have been made are unlikely to affect > our usage, but nonetheless

Re: [COMMITTERS] pgsql: Sync our copy of the timezone library with IANA release tzcode20

2016-10-19 Thread Tom Lane
Thomas Munro writes: > On Thu, Oct 20, 2016 at 11:56 AM, Tom Lane wrote: >> Sync our copy of the timezone library with IANA release tzcode2016g. > My compiler (Apple LLVM version 8.0.0 (clang-800.0.38)) doesn't like this: > zic.c:427:53: error: implicit conversion from 'unsigned long long' to >

[COMMITTERS] pgsql: Another portability fix for tzcode2016g update.

2016-10-19 Thread Tom Lane
Another portability fix for tzcode2016g update. clang points out that SIZE_MAX wouldn't fit into an int, which means this comparison is pretty useless. Per report from Thomas Munro. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/4d6c7599b65b6bbd2357883662ea6

[COMMITTERS] pgsql: Another portability fix for tzcode2016g update.

2016-10-19 Thread Tom Lane
Another portability fix for tzcode2016g update. clang points out that SIZE_MAX wouldn't fit into an int, which means this comparison is pretty useless. Per report from Thomas Munro. Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/65935033d64cb5ad51f7e5967860d

[COMMITTERS] pgsql: Another portability fix for tzcode2016g update.

2016-10-19 Thread Tom Lane
Another portability fix for tzcode2016g update. clang points out that SIZE_MAX wouldn't fit into an int, which means this comparison is pretty useless. Per report from Thomas Munro. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/0d386bdb6c65c251f9a5952474555

[COMMITTERS] pgsql: Another portability fix for tzcode2016g update.

2016-10-19 Thread Tom Lane
Another portability fix for tzcode2016g update. clang points out that SIZE_MAX wouldn't fit into an int, which means this comparison is pretty useless. Per report from Thomas Munro. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/23ed2ba8121178474f8c51774c6c258cb165

[COMMITTERS] pgsql: Another portability fix for tzcode2016g update.

2016-10-19 Thread Tom Lane
Another portability fix for tzcode2016g update. clang points out that SIZE_MAX wouldn't fit into an int, which means this comparison is pretty useless. Per report from Thomas Munro. Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/f5d177632e6622676ff7fe49962a7

[COMMITTERS] pgsql: Another portability fix for tzcode2016g update.

2016-10-19 Thread Tom Lane
Another portability fix for tzcode2016g update. clang points out that SIZE_MAX wouldn't fit into an int, which means this comparison is pretty useless. Per report from Thomas Munro. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/aee5eb8300ac8e37e5f32b87b499e

[COMMITTERS] pgsql: Another portability fix for tzcode2016g update.

2016-10-19 Thread Tom Lane
Another portability fix for tzcode2016g update. clang points out that SIZE_MAX wouldn't fit into an int, which means this comparison is pretty useless. Per report from Thomas Munro. Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/9937088b26eef7bbe27a9bb5f497a