[COMMITTERS] pgsql: Improve documentation about pg_stat_replication view.

2016-12-06 Thread Fujii Masao
Improve documentation about pg_stat_replication view. Add the descriptions of possible values in "state" and "sync_state" columns of pg_stat_replication view. Author: Michael Paquier, slightly modified by me Discussion: Branch -- master Details --- http://git.postgresql.org/pg/commitdi

[COMMITTERS] pgsql: Bump catversion for restrictive RLS changes

2016-12-06 Thread Stephen Frost
Bump catversion for restrictive RLS changes Mea culpa. Pointed out by Andres. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cb9dcbc1eebd8cccf98d7236b2c9bb82caf8b45d Modified Files -- src/include/catalog/catversion.h | 2 +- 1 file changed, 1 insertion(

Re: [COMMITTERS] pgsql: Add support for restrictive RLS policies

2016-12-06 Thread Stephen Frost
Andres, * Andres Freund ([email protected]) wrote: > On 2016-12-05 20:51:02 +, Stephen Frost wrote: > > Add support for restrictive RLS policies > This is missing a catversion bump. Ewps, apologies and thanks for pointing it out. Fixed. Stephen signature.asc Description: Digital signatu

[COMMITTERS] pgsql: Revert "Permit dump/reload of not-too-large >1GB tuples"

2016-12-06 Thread Alvaro Herrera
Revert "Permit dump/reload of not-too-large >1GB tuples" This reverts commit 646655d264f17cf7fdbc6425ef8bc9a2f9f9ee41. Per Tom Lane, changing the definition of StringInfoData amounts to an ABI break, which is unacceptable in back branches. Branch -- REL9_5_STABLE Details --- http://git.p

[COMMITTERS] pgsql: Revert "Permit dump/reload of not-too-large >1GB tuples"

2016-12-06 Thread Alvaro Herrera
Revert "Permit dump/reload of not-too-large >1GB tuples" This reverts commit 4e01ecae98275298c680c92fdba62daf603dc98e. Per Tom Lane, changing the definition of StringInfoData amounts to an ABI break, which is unacceptable in back branches. Branch -- REL9_6_STABLE Details --- http://git.p

[COMMITTERS] pgsql: Fix interaction of parallel query with prepared statements.

2016-12-06 Thread Robert Haas
Fix interaction of parallel query with prepared statements. Previously, a prepared statement created via a Parse message could get a parallel plan, but one created with a PREPARE statement could not. This state of affairs was due to confusion on my (rhaas) part: I erroneously believed that a CREAT

[COMMITTERS] pgsql: Fix interaction of parallel query with prepared statements.

2016-12-06 Thread Robert Haas
Fix interaction of parallel query with prepared statements. Previously, a prepared statement created via a Parse message could get a parallel plan, but one created with a PREPARE statement could not. This state of affairs was due to confusion on my (rhaas) part: I erroneously believed that a CREAT

Re: [COMMITTERS] pgsql: Replace PostmasterRandom() with a stronger source, second attemp

2016-12-06 Thread Andres Freund
On 2016-12-05 11:44:37 +, Heikki Linnakangas wrote: > Replace PostmasterRandom() with a stronger source, second attempt. Since this went in I've seen 2016-12-06 14:42:17.005 PST [23658][] LOG: wrong key in cancel request for process 23657 2016-12-06 14:42:19.010 PST [23662][] LOG: wrong key

Re: [COMMITTERS] pgsql: Replace PostmasterRandom() with a stronger source, second attemp

2016-12-06 Thread Thomas Munro
On Tue, Dec 6, 2016 at 12:44 AM, Heikki Linnakangas wrote: > src/backend/storage/lmgr/lwlocknames.txt | 1 + Missing one tab? -- Thomas Munro http://www.enterprisedb.com whitespace.patch Description: Binary data -- Sent via pgsql-committers mailing list (pgsql-committers@postgres

Re: [COMMITTERS] pgsql: Replace PostmasterRandom() with a stronger source, second attemp

2016-12-06 Thread Michael Paquier
On Wed, Dec 7, 2016 at 7:46 AM, Andres Freund wrote: > On 2016-12-05 11:44:37 +, Heikki Linnakangas wrote: >> Replace PostmasterRandom() with a stronger source, second attempt. > > Since this went in I've seen > 2016-12-06 14:42:17.005 PST [23658][] LOG: wrong key in cancel request for > pro

[COMMITTERS] pgsql: Put AC_MSG_RESULT() call in the right place.

2016-12-06 Thread Tom Lane
Put AC_MSG_RESULT() call in the right place. Thinko in ecb0d20a9 --- this needs to go one level further out in the "if" nest. As it stood, nothing got printed in the case of selecting named POSIX semaphores. Cosmetic issue only, but a bug. Branch -- master Details --- http://git.postgr

[COMMITTERS] pgsql: Fix unsafe assumption that struct timeval.tv_sec is a "long".

2016-12-06 Thread Tom Lane
Fix unsafe assumption that struct timeval.tv_sec is a "long". It typically is a "long", but it seems possible that on some platforms it wouldn't be. In any case, this silences a compiler warning on OpenBSD (cf buildfarm member curculio). While at it, use snprintf not sprintf. This format string

[COMMITTERS] pgsql: Fix unsafe assumption that struct timeval.tv_sec is a "long".

2016-12-06 Thread Tom Lane
Fix unsafe assumption that struct timeval.tv_sec is a "long". It typically is a "long", but it seems possible that on some platforms it wouldn't be. In any case, this silences a compiler warning on OpenBSD (cf buildfarm member curculio). While at it, use snprintf not sprintf. This format string

[COMMITTERS] pgsql: Silence compiler warnings

2016-12-06 Thread Stephen Frost
Silence compiler warnings Rearrange a bit of code to ensure that 'mode' in LWLockRelease is obviously always set, which seems a bit cleaner and avoids a compiler warning (thanks to Robert for the suggestion!). In GetCachedPlan(), initialize 'plan' to silence a compiler warning, but also add an As

[COMMITTERS] pgsql: Fix whitespace.

2016-12-06 Thread Heikki Linnakangas
Fix whitespace. Thomas Munro Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9790b87f594565c11599b2004466169b8c2fd4af Modified Files -- src/backend/storage/lmgr/lwlocknames.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-com

Re: [COMMITTERS] pgsql: Replace PostmasterRandom() with a stronger source, second attemp

2016-12-06 Thread Heikki Linnakangas
On 12/07/2016 01:56 AM, Thomas Munro wrote: On Tue, Dec 6, 2016 at 12:44 AM, Heikki Linnakangas wrote: src/backend/storage/lmgr/lwlocknames.txt | 1 + Missing one tab? Fixed, thanks. I missed this because my editor is set up to use 4-space tabs for .c and .h files, but not for

[COMMITTERS] pgsql: Fix query cancellation.

2016-12-06 Thread Heikki Linnakangas
Fix query cancellation. In commit fe0a0b59, the datatype used for MyCancelKey and other variables that store cancel keys were changed from long to uint32, but I missed this one. That broke query cancellation on platforms where long is wider than 32 bits. Report by Andres Freund, fix by Michael Pa

Re: [COMMITTERS] pgsql: Replace PostmasterRandom() with a stronger source, second attemp

2016-12-06 Thread Heikki Linnakangas
On 12/07/2016 02:30 AM, Michael Paquier wrote: With the logs complaining as well: [1-1] db=[unknown],user=[unknown],app=[unknown],client=[local] LOG: wrong key in cancel request for process 57361 As far as I can see processCancelRequest uses a long variable, and it gets compared with an int32. M