[COMMITTERS] pgsql: Fix typo in description for pg_replication_origin_advance functi

2017-01-26 Thread Fujii Masao
Fix typo in description for pg_replication_origin_advance function. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bdadf36eb40e88f93a9daf20ecd005595ebec1cd Modified Files -- src/include/catalog/pg_proc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[COMMITTERS] pgsql: Ensure that a tsquery like '!foo' matches empty tsvectors.

2017-01-26 Thread Tom Lane
Ensure that a tsquery like '!foo' matches empty tsvectors. !foo means "the tsvector does not contain foo", and therefore it should match an empty tsvector. ts_match_vq() overenthusiastically supposed that an empty tsvector could never match any query, so it forcibly returned FALSE, the wrong answ

[COMMITTERS] pgsql: Ensure that a tsquery like '!foo' matches empty tsvectors.

2017-01-26 Thread Tom Lane
Ensure that a tsquery like '!foo' matches empty tsvectors. !foo means "the tsvector does not contain foo", and therefore it should match an empty tsvector. ts_match_vq() overenthusiastically supposed that an empty tsvector could never match any query, so it forcibly returned FALSE, the wrong answ

[COMMITTERS] pgsql: Ensure that a tsquery like '!foo' matches empty tsvectors.

2017-01-26 Thread Tom Lane
Ensure that a tsquery like '!foo' matches empty tsvectors. !foo means "the tsvector does not contain foo", and therefore it should match an empty tsvector. ts_match_vq() overenthusiastically supposed that an empty tsvector could never match any query, so it forcibly returned FALSE, the wrong answ

[COMMITTERS] pgsql: Ensure that a tsquery like '!foo' matches empty tsvectors.

2017-01-26 Thread Tom Lane
Ensure that a tsquery like '!foo' matches empty tsvectors. !foo means "the tsvector does not contain foo", and therefore it should match an empty tsvector. ts_match_vq() overenthusiastically supposed that an empty tsvector could never match any query, so it forcibly returned FALSE, the wrong answ

[COMMITTERS] pgsql: Ensure that a tsquery like '!foo' matches empty tsvectors.

2017-01-26 Thread Tom Lane
Ensure that a tsquery like '!foo' matches empty tsvectors. !foo means "the tsvector does not contain foo", and therefore it should match an empty tsvector. ts_match_vq() overenthusiastically supposed that an empty tsvector could never match any query, so it forcibly returned FALSE, the wrong answ

[COMMITTERS] pgsql: Ensure that a tsquery like '!foo' matches empty tsvectors.

2017-01-26 Thread Tom Lane
Ensure that a tsquery like '!foo' matches empty tsvectors. !foo means "the tsvector does not contain foo", and therefore it should match an empty tsvector. ts_match_vq() overenthusiastically supposed that an empty tsvector could never match any query, so it forcibly returned FALSE, the wrong answ

[COMMITTERS] pgsql: Add object_address tests for publications and subscriptions

2017-01-26 Thread Peter Eisentraut
Add object_address tests for publications and subscriptions Add test cases to object_address.sql to test the new logical replication related object classes, and fix some small bugs discovered by that. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2a2bdcab2c5c6081a8

[COMMITTERS] pgsql: Reset hot standby xmin on master after restart

2017-01-26 Thread Simon Riggs
Reset hot standby xmin on master after restart Hot_standby_feedback could be reset by reload and worked correctly, but if the server was restarted rather than reloaded the xmin was not reset. Force reset always if hot_standby_feedback is enabled at startup. Ants Aasma, Craig Ringer Reported-by:

[COMMITTERS] pgsql: Check interrupts during hot standby waits

2017-01-26 Thread Simon Riggs
Check interrupts during hot standby waits Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e8ee3d6b859a18d7f7375ceb9e04d256eb18aaec Modified Files -- src/backend/storage/ipc/standby.c | 2 ++ 1 file changed, 2 insertions(+) -- Sent via pgsql-committers m

[COMMITTERS] pgsql: Reset hot standby xmin after restart

2017-01-26 Thread Simon Riggs
Reset hot standby xmin after restart Hot_standby_feedback could be reset by reload and worked correctly, but if the server was restarted rather than reloaded the xmin was not reset. Force reset always if hot_standby_feedback is enabled at startup. Ants Aasma, Craig Ringer Reported-by: Ants Aasma

[COMMITTERS] pgsql: Reset hot standby xmin after restart

2017-01-26 Thread Simon Riggs
Reset hot standby xmin after restart Hot_standby_feedback could be reset by reload and worked correctly, but if the server was restarted rather than reloaded the xmin was not reset. Force reset always if hot_standby_feedback is enabled at startup. Ants Aasma, Craig Ringer Reported-by: Ants Aasma

[COMMITTERS] pgsql: Reset hot standby xmin after restart

2017-01-26 Thread Simon Riggs
Reset hot standby xmin after restart Hot_standby_feedback could be reset by reload and worked correctly, but if the server was restarted rather than reloaded the xmin was not reset. Force reset always if hot_standby_feedback is enabled at startup. Ants Aasma, Craig Ringer Reported-by: Ants Aasma

[COMMITTERS] pgsql: Reset hot standby xmin after restart

2017-01-26 Thread Simon Riggs
Reset hot standby xmin after restart Hot_standby_feedback could be reset by reload and worked correctly, but if the server was restarted rather than reloaded the xmin was not reset. Force reset always if hot_standby_feedback is enabled at startup. Ants Aasma, Craig Ringer Reported-by: Ants Aasma

[COMMITTERS] pgsql: Simplify sequence test

2017-01-26 Thread Peter Eisentraut
Simplify sequence test We maintained two separate expected files because log_cnt could be one of two values. Rewrite the test so that we only need one file. Reviewed-by: Petr Jelinek Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9c18104c7448a0cdaa46aed1b95044398

[COMMITTERS] pgsql: Fill in no_priv_msg for publications and subscriptions

2017-01-26 Thread Peter Eisentraut
Fill in no_priv_msg for publications and subscriptions Even though these messages are not used yet, we should keep the list complete. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e630faacd8a0c998db105a7d3fca063eb29b0eea Modified Files -- src/backend/c

[COMMITTERS] pgsql: doc: Update privileges documentation

2017-01-26 Thread Peter Eisentraut
doc: Update privileges documentation The CREATE privilege on databases now also enables creating publications. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cdcad6b788a8651af2e48bf7d4160ae591e1f4d7 Modified Files -- doc/src/sgml/ref/grant.sgml | 2 +- 1

[COMMITTERS] pgsql: Remove test for COMMENT ON DATABASE

2017-01-26 Thread Alvaro Herrera
Remove test for COMMENT ON DATABASE Our current DDL only allows a database name to be specified in COMMENT ON DATABASE, which Andrew Dunstan reports to make this test fail on the buildfarm. Remove the line until we gain a DDL command that allows the current database to be operated on without havi

[COMMITTERS] pgsql: Remove test for COMMENT ON DATABASE

2017-01-26 Thread Alvaro Herrera
Remove test for COMMENT ON DATABASE Our current DDL only allows a database name to be specified in COMMENT ON DATABASE, which Andrew Dunstan reports to make this test fail on the buildfarm. Remove the line until we gain a DDL command that allows the current database to be operated on without havi

[COMMITTERS] pgsql: Remove test for COMMENT ON DATABASE

2017-01-26 Thread Alvaro Herrera
Remove test for COMMENT ON DATABASE Our current DDL only allows a database name to be specified in COMMENT ON DATABASE, which Andrew Dunstan reports to make this test fail on the buildfarm. Remove the line until we gain a DDL command that allows the current database to be operated on without havi

[COMMITTERS] pgsql: Add missed update in expected file

2017-01-26 Thread Alvaro Herrera
Add missed update in expected file Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/f90860f339f6bb49a46ae0a2e4cedb109b3c9764 Modified Files -- src/test/modules/test_ddl_deparse/expected/comment_on.out | 2 -- 1 file changed, 2 deletions(-) -- Sent

Re: [COMMITTERS] pgsql: Fill in no_priv_msg for publications and subscriptions

2017-01-26 Thread Alvaro Herrera
Peter Eisentraut wrote: > Fill in no_priv_msg for publications and subscriptions > > Even though these messages are not used yet, we should keep the list > complete. Hmm, should we add a StaticAssert() somewhere that lengthof(msg_no_priv) is somehow consistent with the AclObjectKind enum? Probab

[COMMITTERS] pgsql: Add castNode(type, ptr) for safe casting between NodeTag based t

2017-01-26 Thread Andres Freund
Add castNode(type, ptr) for safe casting between NodeTag based types. The new function allows to cast from one NodeTag based type to another, while asserting that the conversion is valid. This replaces the common pattern of doing a cast and a Assert(IsA(ptr, type)) close-by. As this seems likely

[COMMITTERS] pgsql: Add castNode(type, ptr) for safe casting between NodeTag based t

2017-01-26 Thread Andres Freund
Add castNode(type, ptr) for safe casting between NodeTag based types. The new function allows to cast from one NodeTag based type to another, while asserting that the conversion is valid. This replaces the common pattern of doing a cast and a Assert(IsA(ptr, type)) close-by. As this seems likely

[COMMITTERS] pgsql: Add castNode(type, ptr) for safe casting between NodeTag based t

2017-01-26 Thread Andres Freund
Add castNode(type, ptr) for safe casting between NodeTag based types. The new function allows to cast from one NodeTag based type to another, while asserting that the conversion is valid. This replaces the common pattern of doing a cast and a Assert(IsA(ptr, type)) close-by. As this seems likely

[COMMITTERS] pgsql: Add castNode(type, ptr) for safe casting between NodeTag based t

2017-01-26 Thread Andres Freund
Add castNode(type, ptr) for safe casting between NodeTag based types. The new function allows to cast from one NodeTag based type to another, while asserting that the conversion is valid. This replaces the common pattern of doing a cast and a Assert(IsA(ptr, type)) close-by. As this seems likely

[COMMITTERS] pgsql: Use the new castNode() macro in a number of places.

2017-01-26 Thread Andres Freund
Use the new castNode() macro in a number of places. This is far from a pervasive conversion, but it's a good starting point. Author: Peter Eisentraut, with some minor changes by me Reviewed-By: Tom Lane Discussion: https://postgr.es/m/c5d387d9-3440-f5e0-f9d4-71d53b9fb...@2ndquadrant.com Branch

[COMMITTERS] pgsql: Add castNode(type, ptr) for safe casting between NodeTag based t

2017-01-26 Thread Andres Freund
Add castNode(type, ptr) for safe casting between NodeTag based types. The new function allows to cast from one NodeTag based type to another, while asserting that the conversion is valid. This replaces the common pattern of doing a cast and a Assert(IsA(ptr, type)) close-by. As this seems likely

[COMMITTERS] pgsql: Add castNode(type, ptr) for safe casting between NodeTag based t

2017-01-26 Thread Andres Freund
Add castNode(type, ptr) for safe casting between NodeTag based types. The new function allows to cast from one NodeTag based type to another, while asserting that the conversion is valid. This replaces the common pattern of doing a cast and a Assert(IsA(ptr, type)) close-by. As this seems likely

[COMMITTERS] pgsql: Use castNode() in a bunch of statement-list-related code.

2017-01-26 Thread Tom Lane
Use castNode() in a bunch of statement-list-related code. When I wrote commit ab1f0c822, I really missed the castNode() macro that Peter E. had proposed shortly before. This back-fills the uses I would have put it to. It's probably not all that significant, but there are more assertions here tha