On Fri, Feb 3, 2017 at 9:46 AM, Tom Lane wrote:
> Robert Haas writes:
>> On Thu, Feb 2, 2017 at 11:00 PM, Tom Lane wrote:
>>> I'm about to push a fix that removes the crashes (or at least the ones
>>> I see on dromedary),
>
>> For comparison, a patch I wrote by inspection is attached.
>
> Hm, so
On Fri, Feb 3, 2017 at 4:36 PM, Amit Kapila wrote:
> On Fri, Feb 3, 2017 at 9:46 AM, Tom Lane wrote:
>> Robert Haas writes:
>>> On Thu, Feb 2, 2017 at 11:00 PM, Tom Lane wrote:
I'm about to push a fix that removes the crashes (or at least the ones
I see on dromedary),
>>
>>> For compa
Amit Kapila writes:
> I have gone through all the of the SQL declarations and it seems
> hash_metapage_info(...,OUT procid int4,..) is not consistent. procid
> is unsigned int, so isn't it better to use the corresponding datatype
> as int8 in SQL function hash_metapage_info then use Int64GetDatum
On Thu, Feb 2, 2017 at 11:16 PM, Tom Lane wrote:
> Robert Haas writes:
>> On Thu, Feb 2, 2017 at 11:00 PM, Tom Lane wrote:
>>> I'm about to push a fix that removes the crashes (or at least the ones
>>> I see on dromedary),
>
>> For comparison, a patch I wrote by inspection is attached.
>
> Hm,
On Fri, Feb 3, 2017 at 8:13 PM, Tom Lane wrote:
> Amit Kapila writes:
>> I have gone through all the of the SQL declarations and it seems
>> hash_metapage_info(...,OUT procid int4,..) is not consistent. procid
>> is unsigned int, so isn't it better to use the corresponding datatype
>> as int8 in
Robert Haas writes:
> On Thu, Feb 2, 2017 at 11:16 PM, Tom Lane wrote:
>> I just made the C code agree with what the SQL declarations for the
>> functions say.
> Doesn't look like it to me. You changed a bunch of places that say
> UInt32GetDatum to UInt64GetDatum, but the SQL type certainly is
pageinspect: Remove platform-dependent values from hash tests.
Per a report from Tom Lane, the ffactor reported by hash_metapage_info
and the free_size reported by hash_page_stats vary by platform.
Ashutosh Sharma and Robert Haas
Branch
--
master
Details
---
http://git.postgresql.org/pg
In pageinspect/hashfuncs.c, avoid crashes on alignment-picky machines.
On machines with MAXALIGN = 8, the payload of a bytea is not maxaligned,
since it will start 4 bytes into a palloc'd value. On alignment-picky
hardware, this will cause failures in accesses to 8-byte-wide values
within the pag
Be sure to release LogicalRepLauncherLock in DROP SUBSCRIPTION command.
Previously DROP SUBSCRIPTION command forgot to release the lock at all.
Original patches by Kyotaro Horiguchi and Michael Paquier,
but I didn't use them.
Discussion:
http://postgr.es/m/20170201.173623.66249355.horiguchi.kyot
pgstattuple: Add pgstathashindex.
Since pgstattuple v1.5 hasn't been released yet, no need for a new
extension version. The new function exposes statistics about hash
indexes similar to what other pgstatindex functions return for other
index types.
Ashutosh Sharma, reviewed by Kuntal Ghosh. Sub
pageinspect: More type-sanity surgery on the new hash index code.
Uniformly expose unsigned quantities using the next-wider signed
integer type (since we have no unsigned types at the SQL level).
At the SQL level, this results a change to report itemoffset as
int4 rather than int2. Also at the SQ
Improve grammar of message about two-phase state files.
When there's only one two-phase state file, there's also only one
long-running prepared transaction. Adjust the message text
accordingly.
Nikhil Sontakke
Discussion:
http://postgr.es/m/CAMGcDxcmR_DWZXXndGoPzVQx=B17A5=RviEA1qNaF=fwly5...@m
Remove redundant comment.
Rafia Sabih
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/6f4b4ceefa673dff6563d2d17e2039248f16fe1d
Modified Files
--
src/backend/executor/execMain.c | 4
1 file changed, 4 deletions(-)
--
Sent via pgsql-committers maili
13 matches
Mail list logo
