[COMMITTERS] pgsql: Remove some bogus logic from create_gather_merge_plan.

2017-03-14 Thread Robert Haas
Remove some bogus logic from create_gather_merge_plan. This logic was adapated from create_merge_append_plan, but the two cases aren't really analogous, because create_merge_append_plan is not projection-capable and must therefore have a tlist identical to that of the underlying paths. Overwritin

[COMMITTERS] pgsql: Update overlooked comment for Gather Merge.

2017-03-14 Thread Robert Haas
Update overlooked comment for Gather Merge. Commit 355d3993c53ed62c5b53d020648e4fbcfbf5f155 probably should have done this, but nobody noticed that it was needed. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a82178020de2c4b3576d0a079e11a431e382e4de Modified Files

[COMMITTERS] pgsql: doc: Fix synopsis

2017-03-14 Thread Peter Eisentraut
doc: Fix synopsis Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/37289ffdbfc7319a3cdb271b11227bf682f76d90 Modified Files -- doc/src/sgml/ref/drop_subscription.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers maili

[COMMITTERS] pgsql: Fix failure to mark init buffers as BM_PERMANENT.

2017-03-14 Thread Robert Haas
Fix failure to mark init buffers as BM_PERMANENT. This could result in corruption of the init fork of an unlogged index if the ambuildempty routine for that index used shared buffers to create the init fork, which was true for gin, gist, and hash indexes. Patch by me, based on an earlier patch by

[COMMITTERS] pgsql: Fix failure to mark init buffers as BM_PERMANENT.

2017-03-14 Thread Robert Haas
Fix failure to mark init buffers as BM_PERMANENT. This could result in corruption of the init fork of an unlogged index if the ambuildempty routine for that index used shared buffers to create the init fork, which was true for gin, gist, and hash indexes. Patch by me, based on an earlier patch by

[COMMITTERS] pgsql: Fix failure to mark init buffers as BM_PERMANENT.

2017-03-14 Thread Robert Haas
Fix failure to mark init buffers as BM_PERMANENT. This could result in corruption of the init fork of an unlogged index if the ambuildempty routine for that index used shared buffers to create the init fork, which was true for brin, gin, gist, and hash indexes. Patch by me, based on an earlier pa

[COMMITTERS] pgsql: Fix failure to mark init buffers as BM_PERMANENT.

2017-03-14 Thread Robert Haas
Fix failure to mark init buffers as BM_PERMANENT. This could result in corruption of the init fork of an unlogged index if the ambuildempty routine for that index used shared buffers to create the init fork, which was true for brin, gin, gist, and hash indexes. Patch by me, based on an earlier pa

[COMMITTERS] pgsql: Fix failure to mark init buffers as BM_PERMANENT.

2017-03-14 Thread Robert Haas
Fix failure to mark init buffers as BM_PERMANENT. This could result in corruption of the init fork of an unlogged index if the ambuildempty routine for that index used shared buffers to create the init fork, which was true for brin, gin, gist, and hash indexes. Patch by me, based on an earlier pa

[COMMITTERS] pgsql: Update .gitignore

2017-03-14 Thread Robert Haas
Update .gitignore Commit 42fcad68a9c0e0ebecf6842888723cad1f9d5be2 failed to do this. Michael Paquier Discussion: http://postgr.es/m/cab7npqtxk9qn8tmonpf29jnxgw_ca3ftdarfgnbhcfyr-tx...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c6c099d31abd5ae22

[COMMITTERS] pgsql: Fix failure to mark init buffers as BM_PERMANENT.

2017-03-14 Thread Robert Haas
Fix failure to mark init buffers as BM_PERMANENT. This could result in corruption of the init fork of an unlogged index if the ambuildempty routine for that index used shared buffers to create the init fork, which was true for brin, gin, gist, and hash indexes. Patch by me, based on an earlier pa

[COMMITTERS] pgsql: Make logging about multixact wraparound protection less chatty.

2017-03-14 Thread Tom Lane
Make logging about multixact wraparound protection less chatty. The original messaging design, introduced in commit 068cfadf9, seems too chatty now that some time has elapsed since the bug fix; most installations will be in good shape and don't really need a reminder about this on every postmaster

[COMMITTERS] pgsql: Spelling fixes in code comments

2017-03-14 Thread Peter Eisentraut
Spelling fixes in code comments From: Josh Soref Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f97a028d8ee3e7d64a93285707af94b612c47651 Modified Files -- contrib/pgcrypto/crypt-des.c | 2 +- contrib/spi/timetravel.c | 2

[COMMITTERS] pgsql: Spelling fixes

2017-03-14 Thread Peter Eisentraut
Spelling fixes From: Josh Soref Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a47b38c9ee4960556b0edb76a42171bd281cc1cf Modified Files -- contrib/ltree/ltxtquery_io.c | 2 +- doc/src/sgml/biblio.sgml | 2 +- doc/src/

[COMMITTERS] pgsql: ecpg: Improve some variable names

2017-03-14 Thread Peter Eisentraut
ecpg: Improve some variable names based on patch from Josh Soref Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/100871c2d10f1aca80824a979d926c96db3a0af2 Modified Files -- src/interfaces/ecpg/preproc/type.c | 40 +++--- 1

[COMMITTERS] pgsql: Include port number when logging successful binding to a TCP por

2017-03-14 Thread Tom Lane
Include port number when logging successful binding to a TCP port. Per suggestion from Andres Freund. Discussion: https://postgr.es/m/20170314033842.st7gifec55yig...@alap3.anarazel.de Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2b32ac2a59df18246c3b79e96a209bfdb

[COMMITTERS] pgsql: hash: Add write-ahead logging support.

2017-03-14 Thread Robert Haas
hash: Add write-ahead logging support. The warning about hash indexes not being write-ahead logged and their use being discouraged has been removed. "snapshot too old" is now supported for tables with hash indexes. Most importantly, barring bugs, hash indexes will now be crash-safe and usable on

[COMMITTERS] pgsql: Spelling fixes

2017-03-14 Thread Peter Eisentraut
Spelling fixes From: Josh Soref Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/e0c8bd704c63baccc03e22112d411f7edb5f80c7 Modified Files -- contrib/ltree/ltxtquery_io.c | 2 +- doc/src/sgml/biblio.sgml | 2 +- doc/src

[COMMITTERS] pgsql: Spelling fixes

2017-03-14 Thread Peter Eisentraut
Spelling fixes From: Josh Soref Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/18dc2aee5f303447bef48dee596a664d90f6939a Modified Files -- contrib/ltree/ltxtquery_io.c | 2 +- doc/src/sgml/biblio.sgml | 2 +- doc/src

[COMMITTERS] pgsql: Spelling fixes

2017-03-14 Thread Peter Eisentraut
Spelling fixes From: Josh Soref Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/a7dcd95dab7227753b44c92397c07e94c13348b5 Modified Files -- contrib/ltree/ltxtquery_io.c | 2 +- doc/src/sgml/biblio.sgml | 2 +- doc/src

[COMMITTERS] pgsql: Spelling fixes

2017-03-14 Thread Peter Eisentraut
Spelling fixes From: Josh Soref Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/28fb0f10c9c38a4803b9fc09c5524efe9858a34a Modified Files -- contrib/ltree/ltxtquery_io.c | 2 +- doc/src/sgml/biblio.sgml | 2 +- doc/src

[COMMITTERS] pgsql: Spelling fixes

2017-03-14 Thread Peter Eisentraut
Spelling fixes From: Josh Soref Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/5adec6b54dc3a813a316a3b323cfecdce00cffcb Modified Files -- contrib/ltree/ltxtquery_io.c | 2 +- doc/src/sgml/biblio.sgml | 2 +- doc/src

Re: [COMMITTERS] pgsql: hash: Add write-ahead logging support.

2017-03-14 Thread Tom Lane
Robert Haas writes: > hash: Add write-ahead logging support. This bit in access/hash/README, lines 368ff, appears obsolete: Although we can survive a failure to split a bucket, a crash is likely to corrupt the index, since hash indexes are not yet WAL-logged. Perhaps we can just delete that

Re: [COMMITTERS] pgsql: hash: Add write-ahead logging support.

2017-03-14 Thread Robert Haas
On Tue, Mar 14, 2017 at 1:54 PM, Tom Lane wrote: > Robert Haas writes: >> hash: Add write-ahead logging support. > > This bit in access/hash/README, lines 368ff, appears obsolete: > > Although we can survive a failure to split a bucket, a crash is likely to > corrupt the index, since hash ind

Re: [COMMITTERS] pgsql: hash: Add write-ahead logging support.

2017-03-14 Thread Tom Lane
Robert Haas writes: > On Tue, Mar 14, 2017 at 1:54 PM, Tom Lane wrote: >> Robert Haas writes: >>> hash: Add write-ahead logging support. >> This bit in access/hash/README, lines 368ff, appears obsolete: >> >> Although we can survive a failure to split a bucket, a crash is likely to >> corrupt

Re: [COMMITTERS] pgsql: hash: Add write-ahead logging support.

2017-03-14 Thread Robert Haas
On Tue, Mar 14, 2017 at 2:18 PM, Tom Lane wrote: > Robert Haas writes: >> On Tue, Mar 14, 2017 at 1:54 PM, Tom Lane wrote: >>> Robert Haas writes: hash: Add write-ahead logging support. > >>> This bit in access/hash/README, lines 368ff, appears obsolete: >>> >>> Although we can survive a f

Re: [COMMITTERS] pgsql: hash: Add write-ahead logging support.

2017-03-14 Thread Tom Lane
Robert Haas writes: > On Tue, Mar 14, 2017 at 2:18 PM, Tom Lane wrote: >> You gonna do it, or you want me to? > If you're feeling motivated, have at it. Otherwise, I'll do it in a > day or two after I see what other complaints get reported that might > be addressed at the same time. Nah, long

[COMMITTERS] pgsql: Fix regression in parallel planning against inheritance tables.

2017-03-14 Thread Robert Haas
Fix regression in parallel planning against inheritance tables. Commit 51ee6f3160d2e1515ed6197594bda67eb99dc2cc accidentally changed the behavior around inheritance hierarchies; before, we always considered parallel paths even for very small inheritance children, because otherwise an inheritance h

[COMMITTERS] pgsql: hash: Support WAL consistency checking.

2017-03-14 Thread Robert Haas
hash: Support WAL consistency checking. Kuntal Ghosh, reviewed by Amit Kapila and Ashutosh Sharma, with a few tweaks by me. Discussion: http://postgr.es/m/cagz5qcjlerun_zoo0edv6_y_d0o4tntmper7ivtlbg4rurj...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commit

[COMMITTERS] pgsql: amcheck: Harden tests against concurrent autovacuums.

2017-03-14 Thread Andres Freund
amcheck: Harden tests against concurrent autovacuums. The previous coding of the test was vulnerable against autovacuum triggering work on one of the tables in check_btree.sql. For the purpose of the test it's entirely sufficient to check for locks taken by the current process, so add an appropri

[COMMITTERS] pgsql: Add option to control snapshot export to CREATE_REPLICATION_SLOT

2017-03-14 Thread Peter Eisentraut
Add option to control snapshot export to CREATE_REPLICATION_SLOT We used to export snapshots unconditionally in CREATE_REPLICATION_SLOT in the replication protocol, but several upcoming patches want more control over what happens. Suppress snapshot export in pg_recvlogical, which neither needs no

[COMMITTERS] pgsql: Improve isolation tests infrastructure.

2017-03-14 Thread Andres Freund
Improve isolation tests infrastructure. Previously if a directory had both isolationtester and plain regression tests, they couldn't be run in parallel, because they'd access the same files/directories. That, so far, only affected contrib/test_decoding. Rather than fix that locally in contrib/te

[COMMITTERS] pgsql: Some preliminary refactoring towards partitionwise join.

2017-03-14 Thread Robert Haas
Some preliminary refactoring towards partitionwise join. Partitionwise join proposes add a concept of child join relations, which will have the same relationship with join relations as "other member" relations do with base relations. These relations will need some but not all of the handling that

[COMMITTERS] pgsql: Improve grammar / fix typos in snapbuild.c.

2017-03-14 Thread Andres Freund
Improve grammar / fix typos in snapbuild.c. Author: Erik Rijkers Discussion: https://postgr.es/m/797c6c4496a1ae49cc69e90aa768b...@xs4all.nl Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/61d0c320b55902d321e69de2ec4e9a355959ea2c Modified Files -- src/bac

Re: [COMMITTERS] pgsql: hash: Add write-ahead logging support.

2017-03-14 Thread Amit Kapila
On Tue, Mar 14, 2017 at 11:26 PM, Robert Haas wrote: > On Tue, Mar 14, 2017 at 1:54 PM, Tom Lane wrote: >> Robert Haas writes: >>> hash: Add write-ahead logging support. >> >> This bit in access/hash/README, lines 368ff, appears obsolete: >> >> Although we can survive a failure to split a buck

Re: [COMMITTERS] pgsql: hash: Add write-ahead logging support.

2017-03-14 Thread Thomas Munro
On Wed, Mar 15, 2017 at 3:23 PM, Amit Kapila wrote: > On Tue, Mar 14, 2017 at 11:26 PM, Robert Haas wrote: >> On Tue, Mar 14, 2017 at 1:54 PM, Tom Lane wrote: >>> Robert Haas writes: hash: Add write-ahead logging support. >>> >>> This bit in access/hash/README, lines 368ff, appears obsolet

[COMMITTERS] pgsql: doc: Fix TOC generation for refentries

2017-03-14 Thread Peter Eisentraut
doc: Fix TOC generation for refentries The XSLT stylesheets by default don't show refentries inside sections in table of contents, which for our documentation leads to some regressions compared to the DSSSL output. For example, in the SPI chapter, which is mostly refentries, you don't get any usa

Re: [COMMITTERS] pgsql: hash: Add write-ahead logging support.

2017-03-14 Thread Tom Lane
Thomas Munro writes: > Also the obsolete warning message appears in .po files and the mb tests: The .po files won't get updated until the next import from the translation repo. No need to worry about them. However, we probably do need to fix the src/test/mb/expected/ files. Has anyone tried run

[COMMITTERS] pgsql: doc: Remove useless elements in bibliography

2017-03-14 Thread Peter Eisentraut
doc: Remove useless elements in bibliography Under DSSSL, bibliodiv/para elements didn't show up, but under XSLT they do, but they are kind of useless here, so remove them. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3f6ea5fc8d9c6d7c85827c87a717be0016d06b89 Modi

Re: [COMMITTERS] pgsql: hash: Add write-ahead logging support.

2017-03-14 Thread Amit Kapila
On Wed, Mar 15, 2017 at 8:56 AM, Tom Lane wrote: > Thomas Munro writes: >> Also the obsolete warning message appears in .po files and the mb tests: > > The .po files won't get updated until the next import from the translation > repo. No need to worry about them. > > However, we probably do need

Re: [COMMITTERS] pgsql: hash: Add write-ahead logging support.

2017-03-14 Thread Tom Lane
Amit Kapila writes: > On Wed, Mar 15, 2017 at 8:56 AM, Tom Lane wrote: >> However, we probably do need to fix the src/test/mb/expected/ files. >> Has anyone tried running that test suite? > I haven't tried. Does this run as part of any regression tests or is > the only way is run it manually (s

[COMMITTERS] pgsql: Allow referring to functions without arguments when unique

2017-03-14 Thread Peter Eisentraut
Allow referring to functions without arguments when unique In DDL commands referring to an existing function, allow omitting the argument list if the function name is unique in its schema, per SQL standard. This uses the same logic that the regproc type uses for finding functions by name only. R

Re: [COMMITTERS] pgsql: hash: Add write-ahead logging support.

2017-03-14 Thread Amit Kapila
On Wed, Mar 15, 2017 at 9:18 AM, Tom Lane wrote: > Amit Kapila writes: >> On Wed, Mar 15, 2017 at 8:56 AM, Tom Lane wrote: >>> However, we probably do need to fix the src/test/mb/expected/ files. >>> Has anyone tried running that test suite? > >> I haven't tried. Does this run as part of any re

Re: [COMMITTERS] pgsql: hash: Add write-ahead logging support.

2017-03-14 Thread Amit Kapila
On Wed, Mar 15, 2017 at 9:44 AM, Amit Kapila wrote: > On Wed, Mar 15, 2017 at 9:18 AM, Tom Lane wrote: >> Amit Kapila writes: >>> On Wed, Mar 15, 2017 at 8:56 AM, Tom Lane wrote: However, we probably do need to fix the src/test/mb/expected/ files. Has anyone tried running that test su