[COMMITTERS] pgsql: Repair crash with unsortable data in grouping sets.

2017-04-24 Thread Andrew Gierth
Repair crash with unsortable data in grouping sets. Previously the code would generate incorrect results, assertion failures, or crashes if given unsortable (but hashable) columns in grouping sets. Handle by throwing an error instead. Report and patch by Pavan Deolasee (though I changed the erro

[COMMITTERS] pgsql: Code review for commands/statscmds.c.

2017-04-24 Thread Tom Lane
Code review for commands/statscmds.c. Fix machine-dependent sorting of column numbers. (Odd behavior would only materialize for column numbers above 255, but that's certainly legal.) Fix poor choice of SQLSTATE for some errors, and improve error message wording. (Notably, "is not a scalar type"

[COMMITTERS] pgsql: Fix postmaster's handling of fork failure for a bgworker process

2017-04-24 Thread Tom Lane
Fix postmaster's handling of fork failure for a bgworker process. This corner case didn't behave nicely at all: the postmaster would (partially) update its state as though the process had started successfully, and be quite confused thereafter. Fix it to act like the worker had crashed, instead.

[COMMITTERS] pgsql: Fix postmaster's handling of fork failure for a bgworker process

2017-04-24 Thread Tom Lane
Fix postmaster's handling of fork failure for a bgworker process. This corner case didn't behave nicely at all: the postmaster would (partially) update its state as though the process had started successfully, and be quite confused thereafter. Fix it to act like the worker had crashed, instead.

[COMMITTERS] pgsql: Fix postmaster's handling of fork failure for a bgworker process

2017-04-24 Thread Tom Lane
Fix postmaster's handling of fork failure for a bgworker process. This corner case didn't behave nicely at all: the postmaster would (partially) update its state as though the process had started successfully, and be quite confused thereafter. Fix it to act like the worker had crashed, instead.

[COMMITTERS] pgsql: Fix postmaster's handling of fork failure for a bgworker process

2017-04-24 Thread Tom Lane
Fix postmaster's handling of fork failure for a bgworker process. This corner case didn't behave nicely at all: the postmaster would (partially) update its state as though the process had started successfully, and be quite confused thereafter. Fix it to act like the worker had crashed, instead.

[COMMITTERS] pgsql: Get rid of extern declarations of non-existent functions.

2017-04-24 Thread Fujii Masao
Get rid of extern declarations of non-existent functions. Those extern declartions were mistakenly added by commit 7c4f52409. Author: Petr Jelinek Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cbc2270e3fcfae0831e4aa22f797f1dcac483d46 Modified Files -

[COMMITTERS] pgsql: Run the postmaster's signal handlers without SA_RESTART.

2017-04-24 Thread Tom Lane
Run the postmaster's signal handlers without SA_RESTART. The postmaster keeps signals blocked everywhere except while waiting for something to happen in ServerLoop(). The code expects that the select(2) will be cancelled with EINTR if an interrupt occurs; without that, followup actions that shoul

[COMMITTERS] pgsql: Run the postmaster's signal handlers without SA_RESTART.

2017-04-24 Thread Tom Lane
Run the postmaster's signal handlers without SA_RESTART. The postmaster keeps signals blocked everywhere except while waiting for something to happen in ServerLoop(). The code expects that the select(2) will be cancelled with EINTR if an interrupt occurs; without that, followup actions that shoul

[COMMITTERS] pgsql: Use pselect(2) not select(2), if available, to wait in postmaste

2017-04-24 Thread Tom Lane
Use pselect(2) not select(2), if available, to wait in postmaster's loop. Traditionally we've unblocked signals, called select(2), and then blocked signals again. The code expects that the select() will be cancelled with EINTR if an interrupt occurs; but there's a race condition, which is that an

[COMMITTERS] pgsql: Use pselect(2) not select(2), if available, to wait in postmaste

2017-04-24 Thread Tom Lane
Use pselect(2) not select(2), if available, to wait in postmaster's loop. Traditionally we've unblocked signals, called select(2), and then blocked signals again. The code expects that the select() will be cancelled with EINTR if an interrupt occurs; but there's a race condition, which is that an

[COMMITTERS] pgsql: Revert "Use pselect(2) not select(2), if available, to wait in p

2017-04-24 Thread Tom Lane
Revert "Use pselect(2) not select(2), if available, to wait in postmaster's loop." This reverts commit b9515b62879722e3497236f6e0d6783c3fc059a2. Buildfarm results suggest that some platforms have versions of pselect(2) that are not merely non-atomic, but flat out non-functional. Revert the use-

[COMMITTERS] pgsql: Revert "Use pselect(2) not select(2), if available, to wait in p

2017-04-24 Thread Tom Lane
Revert "Use pselect(2) not select(2), if available, to wait in postmaster's loop." This reverts commit 81069a9efc5a374dd39874a161f456f0fb3afba4. Buildfarm results suggest that some platforms have versions of pselect(2) that are not merely non-atomic, but flat out non-functional. Revert the use-

[COMMITTERS] pgsql: doc: update release doc markup instructions

2017-04-24 Thread Bruce Momjian
doc: update release doc markup instructions Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/66fade8a0447093e6bd5a39ee6fec38790479664 Modified Files -- doc/src/sgml/release.sgml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- Sent via pgs

[COMMITTERS] pgsql: doc: first draft of Postgres 10 release notes

2017-04-24 Thread Bruce Momjian
doc: first draft of Postgres 10 release notes Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1d8573ed5569c014b9fd32e42248e58c7c28386d Modified Files -- doc/src/sgml/filelist.sgml |1 + doc/src/sgml/ref/create_table.sgml |2 +- doc/src/sgm

[COMMITTERS] pgsql: doc: fix attribution of sequence item, order incompatibilities

2017-04-24 Thread Bruce Momjian
doc: fix attribution of sequence item, order incompatibilities Reported-by: Andreas Karlsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a0d932b39da7d7445dfc8da1e9979dd5cf4ea0a1 Modified Files -- doc/src/sgml/release-10.sgml | 150 +

[COMMITTERS] pgsql: doc: several minor PG 10 doc adjustments

2017-04-24 Thread Bruce Momjian
doc: several minor PG 10 doc adjustments Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bba375eb9df037c73af3743521f2b44e6fdf8c3b Modified Files -- doc/src/sgml/release-10.sgml | 69 ++-- 1 file changed, 35 inserti

[COMMITTERS] pgsql: doc: PG 10 fixes

2017-04-24 Thread Bruce Momjian
doc: PG 10 fixes Reported-by: Takayuki Tsunakawa Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6e033c6a9639078501ac1830676ae062ee8a4aca Modified Files -- doc/src/sgml/release-10.sgml | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(

[COMMITTERS] pgsql: postgres_fdw: Fix join push down with extensions

2017-04-24 Thread Peter Eisentraut
postgres_fdw: Fix join push down with extensions Objects in an extension are shippable to a foreign server if the extension is part of the foreign server definition's shippable extensions list. But this was not properly considered in some cases when checking whether a join condition can be pushed

[COMMITTERS] pgsql: doc: merge PG 10 release SysV item

2017-04-24 Thread Bruce Momjian
doc: merge PG 10 release SysV item Reported-by: Takayuki Tsunakawa Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/419a055454dd234b78925e605582caf0def51ecb Modified Files -- doc/src/sgml/release-10.sgml | 2 -- 1 file changed, 2 deletions(-) -- Sent

[COMMITTERS] pgsql: doc: fix PG 10 release note doc markup

2017-04-24 Thread Bruce Momjian
doc: fix PG 10 release note doc markup Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d103e6718bfe4a1f50eb25b94db2cf9f84c69766 Modified Files -- doc/src/sgml/release-10.sgml | 6 -- 1 file changed, 6 deletions(-) -- Sent via pgsql-committers mail

[COMMITTERS] pgsql: doc: add Rafia Sabih to PG 10 release note item

2017-04-24 Thread Bruce Momjian
doc: add Rafia Sabih to PG 10 release note item Reported-by: Amit Kapila Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b007b1af20c3b276d5804b11dc3e471c8045480b Modified Files -- doc/src/sgml/release-10.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2

[COMMITTERS] pgsql: doc: move hash performance item into index section

2017-04-24 Thread Bruce Momjian
doc: move hash performance item into index section The requirement to rebuild pg_upgrade-ed hash indexes was kept in the incompatibilities section. Reported-by: Amit Kapila Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cef5dbbf2b8d8a5e7b536bcbf6d9066588c6173b M