[COMMITTERS] pgsql: Fix docs to not claim ECPG's SET CONNECTION is not thread-aware.

2017-06-06 Thread Michael Meskes
Fix docs to not claim ECPG's SET CONNECTION is not thread-aware. Changed by: Tsunakawa, Takayuki Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0f33ee0e3b7527fb0c88abf0ae8a49a9c38d9c0e Modified Files -- doc/src/sgml/ecpg.sgml | 5 ++--- 1 file changed,

[COMMITTERS] pgsql: Clean up partcollation handling for OID 0.

2017-06-06 Thread Robert Haas
Clean up partcollation handling for OID 0. Consistent with what we do for indexes, we shouldn't try to record dependencies on collation OID 0 or the default collation OID (which is pinned). Also, the fact that indcollation and partcollation can contain zero OIDs when the data type is not collatab

[COMMITTERS] pgsql: Use NIL rather than NULL to represent an empty list.

2017-06-06 Thread Robert Haas
Use NIL rather than NULL to represent an empty list. Just to be tidy. Amit Langote Discussion: http://postgr.es/m/9297f80f-e4ab-7dda-33d4-8580bab6d...@lab.ntt.co.jp Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3106829513ab7c8e46e94db103f1ef8d8dfd379b Modified

[COMMITTERS] pgsql: Fix some cases of "the the" split across two lines.

2017-06-06 Thread Robert Haas
Fix some cases of "the the" split across two lines. Kevin Grittner observed that 2186b608b3cb859fe0ec04015a5c4e4cbf69caed introduced a new occurence of this by copying existing text, and I found a few more cases using grep. Discussion: http://postgr.es/m/cadaechwfg-k+yvochckrxv-ycm+euoaauvfyznon

[COMMITTERS] pgsql: Improve handover logic between sync and apply workers

2017-06-06 Thread Peter Eisentraut
Improve handover logic between sync and apply workers Make apply busy wait check the catalog instead of shmem state to ensure that next transaction will see the expected table synchronization state. Also make the handover always go through same set of steps to make the overall process easier to u

Re: [COMMITTERS] pgsql: Unify SIGHUP handling between normal and walsender backends.

2017-06-06 Thread Andres Freund
On 2017-06-06 02:25:18 +, Andres Freund wrote: > Unify SIGHUP handling between normal and walsender backends. > > Because walsender and normal backends share the same main loop it's > problematic to have two different flag variables, set in signal > handlers, indicating a pending configuration

Re: [COMMITTERS] pgsql: Unify SIGHUP handling between normal and walsender backends.

2017-06-06 Thread Tom Lane
Andres Freund writes: > On 2017-06-06 02:25:18 +, Andres Freund wrote: >> Unify SIGHUP handling between normal and walsender backends. > This commit, or one of its siblings, seemingly caused 'handfish' to fail > with a weird error message: > https://buildfarm.postgresql.org/cgi-bin/show_log.p

Re: [COMMITTERS] pgsql: Unify SIGHUP handling between normal and walsender backends.

2017-06-06 Thread Andres Freund
On 2017-06-06 19:41:10 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2017-06-06 02:25:18 +, Andres Freund wrote: > >> Unify SIGHUP handling between normal and walsender backends. > > > This commit, or one of its siblings, seemingly caused 'handfish' to fail > > with a weird error mess

[COMMITTERS] pgsql: Clean up latch related code.

2017-06-06 Thread Andres Freund
Clean up latch related code. The larger part of this patch replaces usages of MyProc->procLatch with MyLatch. The latter works even early during backend startup, where MyProc->procLatch doesn't yet. While the affected code shouldn't run in cases where it's not initialized, it might get copied in

[COMMITTERS] pgsql: Consistently use subscription name as application name

2017-06-06 Thread Peter Eisentraut
Consistently use subscription name as application name The logical replication apply worker uses the subscription name as application name, except for table sync. This was incorrectly set to use the replication slot name, which might be different, in one case. Also add a comment why the other cas

[COMMITTERS] pgsql: Fix double-free bug in GSS authentication.

2017-06-06 Thread Heikki Linnakangas
Fix double-free bug in GSS authentication. The logic to free the buffer after the gss_init_sec_context() call was always a bit wonky. Because gss_init_sec_context() sets the GSS context variable, conn->gctx, we would in fact always attempt to free the buffer. That only works, because previously co