[COMMITTERS] pgsql: Fix pg_basebackup output to stdout on Windows.

2017-07-14 Thread Heikki Linnakangas
Fix pg_basebackup output to stdout on Windows. When writing a backup to stdout with pg_basebackup on Windows, put stdout to binary mode. Any CR bytes in the output will otherwise be output incorrectly as CR+LF. In the passing, standardize on using "_setmode" instead of "setmode", for the sake of

[COMMITTERS] pgsql: Fix pg_basebackup output to stdout on Windows.

2017-07-14 Thread Heikki Linnakangas
Fix pg_basebackup output to stdout on Windows. When writing a backup to stdout with pg_basebackup on Windows, put stdout to binary mode. Any CR bytes in the output will otherwise be output incorrectly as CR+LF. In the passing, standardize on using "_setmode" instead of "setmode", for the sake of

[COMMITTERS] pgsql: Fix pg_basebackup output to stdout on Windows.

2017-07-14 Thread Heikki Linnakangas
Fix pg_basebackup output to stdout on Windows. When writing a backup to stdout with pg_basebackup on Windows, put stdout to binary mode. Any CR bytes in the output will otherwise be output incorrectly as CR+LF. In the passing, standardize on using "_setmode" instead of "setmode", for the sake of

[COMMITTERS] pgsql: Fix pg_basebackup output to stdout on Windows.

2017-07-14 Thread Heikki Linnakangas
Fix pg_basebackup output to stdout on Windows. When writing a backup to stdout with pg_basebackup on Windows, put stdout to binary mode. Any CR bytes in the output will otherwise be output incorrectly as CR+LF. In the passing, standardize on using "_setmode" instead of "setmode", for the sake of

[COMMITTERS] pgsql: Fix pg_basebackup output to stdout on Windows.

2017-07-14 Thread Heikki Linnakangas
Fix pg_basebackup output to stdout on Windows. When writing a backup to stdout with pg_basebackup on Windows, put stdout to binary mode. Any CR bytes in the output will otherwise be output incorrectly as CR+LF. In the passing, standardize on using "_setmode" instead of "setmode", for the sake of

[COMMITTERS] pgsql: Fix pg_basebackup output to stdout on Windows.

2017-07-14 Thread Heikki Linnakangas
Fix pg_basebackup output to stdout on Windows. When writing a backup to stdout with pg_basebackup on Windows, put stdout to binary mode. Any CR bytes in the output will otherwise be output incorrectly as CR+LF. In the passing, standardize on using "_setmode" instead of "setmode", for the sake of

[COMMITTERS] pgsql: Fix broken link-command-line ordering for libpgfeutils.

2017-07-14 Thread Tom Lane
Fix broken link-command-line ordering for libpgfeutils. In the frontend Makefiles that pull in libpgfeutils, we'd generally done it like this: LDFLAGS += -L$(top_builddir)/src/fe_utils -lpgfeutils $(libpq_pgport) That method is badly broken, as seen in bug #14742 from Chris Ruprecht. The -L flag

[COMMITTERS] pgsql: Fix broken link-command-line ordering for libpgfeutils.

2017-07-14 Thread Tom Lane
Fix broken link-command-line ordering for libpgfeutils. In the frontend Makefiles that pull in libpgfeutils, we'd generally done it like this: LDFLAGS += -L$(top_builddir)/src/fe_utils -lpgfeutils $(libpq_pgport) That method is badly broken, as seen in bug #14742 from Chris Ruprecht. The -L flag

[COMMITTERS] pgsql: Code review for NextValueExpr expression node type.

2017-07-14 Thread Tom Lane
Code review for NextValueExpr expression node type. Add missing infrastructure for this node type, notably in ruleutils.c where its lack could demonstrably cause EXPLAIN to fail. Add outfuncs/readfuncs support. (outfuncs support is useful today for debugging purposes. The readfuncs support may

[COMMITTERS] pgsql: pg_upgrade i18n: Fix "%s server/cluster" wording

2017-07-14 Thread Alvaro Herrera
pg_upgrade i18n: Fix "%s server/cluster" wording The original wording was impossible to translate correctly. Discussion: https://postgr.es/m/20170523002827.lzc2jkzh2gubclqb@alvherre.pgsql Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/837255cc81fb59b12f5a70ac2a8a9