[COMMITTERS] pgsql: Fix up secondary expected files

2017-08-24 Thread Peter Eisentraut
Fix up secondary expected files for commit 237a0b87b1dc90f8789aa5441a2a11e67f46c96e Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/27b89876c0fb08faa17768c68101186cda2e4bef Modified Files -- src/test/regress/expected/geometry_1.out | 2 +- src/test/regre

Re: [COMMITTERS] pgsql: Improve plural handling in error message

2017-08-24 Thread Peter Eisentraut
On 8/24/17 00:37, Tom Lane wrote: > Peter Eisentraut writes: >> Improve plural handling in error message > > You missed at least one expected-file update, see > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=frogmouth&dt=2017-08-24%2002%3A30%3A24 fixed -- Peter Eisentraut

[COMMITTERS] pgsql: Make new regression test case parallel-safe, and improve its out

2017-08-24 Thread Tom Lane
Make new regression test case parallel-safe, and improve its output. The test case added by commit 1f6d515a6 fails on buildfarm members that have force_parallel_mode turned on, because we currently don't report sort performance details from worker processes back to the master. To fix that, just m

[COMMITTERS] pgsql: Increase SCRAM salt length

2017-08-24 Thread Peter Eisentraut
Increase SCRAM salt length The original value 12 was set based on RFC 5802 for SCRAM-SHA-1, but RFC 7677 for SCRAM-SHA-256 uses 16, so use that. (This does not affect the validity of already stored verifiers.) Discussion: https://www.postgresql.org/message-id/flat/12cc9297-7e05-932f-d863-765e56

[COMMITTERS] pgsql: Increase SCRAM salt length

2017-08-24 Thread Peter Eisentraut
Increase SCRAM salt length The original value 12 was set based on RFC 5802 for SCRAM-SHA-1, but RFC 7677 for SCRAM-SHA-256 uses 16, so use that. (This does not affect the validity of already stored verifiers.) Discussion: https://www.postgresql.org/message-id/flat/12cc9297-7e05-932f-d863-765e56

[COMMITTERS] pgsql: pg_upgrade: Remove dead code

2017-08-24 Thread Peter Eisentraut
pg_upgrade: Remove dead code Remove code meant for upgrading to a particular version of PostgreSQL 9.0. Since pg_upgrade only supports upgrading to the current major version, this code is no longer useful. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6ce6a61840c

[COMMITTERS] pgsql: pg_upgrade: Remove dead code

2017-08-24 Thread Peter Eisentraut
pg_upgrade: Remove dead code Remove code meant for upgrading to a particular version of PostgreSQL 9.0. Since pg_upgrade only supports upgrading to the current major version, this code is no longer useful. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8a7b

[COMMITTERS] pgsql: psql: Fix \gx when FETCH_COUNT is used

2017-08-24 Thread Stephen Frost
psql: Fix \gx when FETCH_COUNT is used Set expanded output when requested through \gx in ExecQueryUsingCursor() (used when FETCH_COUNT is set). Discussion: https://www.postgresql.org/message-id/CB7A53AA-5645-4BDD-AB07-4D22CD9D8FF1%40gmx.net Author: Tobias Bussmann Branch -- master Details

[COMMITTERS] pgsql: psql: Fix \gx when FETCH_COUNT is used

2017-08-24 Thread Stephen Frost
psql: Fix \gx when FETCH_COUNT is used Set expanded output when requested through \gx in ExecQueryUsingCursor() (used when FETCH_COUNT is set). Discussion: https://www.postgresql.org/message-id/CB7A53AA-5645-4BDD-AB07-4D22CD9D8FF1%40gmx.net Author: Tobias Bussmann Branch -- REL_10_STABLE D

[COMMITTERS] pgsql: Fix bug that can cause walsender not to terminating at shutdown.

2017-08-24 Thread Andres Freund
Fix bug that can cause walsender not to terminating at shutdown. When backpatching c6c333436 I (Andres Freund) mis-resolved a conflict in the 9.4 branch. Unfortunately that leads to walsenders waiting forever when shutting down with connected standbys, unless immediate mode is used, or the standby

[COMMITTERS] pgsql: Fix harmless thinko in dsa.c.

2017-08-24 Thread Andres Freund
Fix harmless thinko in dsa.c. Commit 16be2fd100199bdf284becfcee02c5eb20d8a11d added DSA_ALLOC_HUGE, DSA_ALLOC_ZERO and DSA_ALLOC_NO_OOM which have the same numerical values and meanings as the similarly named MCXT_... macros. In one place we accidentally used MCXT_ALLOC_NO_OOM when DSA_ALLOC_NO_O

[COMMITTERS] pgsql: Fix harmless thinko in dsa.c.

2017-08-24 Thread Andres Freund
Fix harmless thinko in dsa.c. Commit 16be2fd100199bdf284becfcee02c5eb20d8a11d added DSA_ALLOC_HUGE, DSA_ALLOC_ZERO and DSA_ALLOC_NO_OOM which have the same numerical values and meanings as the similarly named MCXT_... macros. In one place we accidentally used MCXT_ALLOC_NO_OOM when DSA_ALLOC_NO_O

[COMMITTERS] pgsql: Consolidate the function pointer types used by dshash.c.

2017-08-24 Thread Andres Freund
Consolidate the function pointer types used by dshash.c. Commit 8c0d7bafad36434cb08ac2c78e69ae72c194ca20 introduced dshash with hash and compare functions like DynaHash's, and also variants that take a user data pointer instead of size. Simplify the interface by merging them into a single pair of

[COMMITTERS] pgsql: Add minimal regression test for blessed record type transfer.

2017-08-24 Thread Andres Freund
Add minimal regression test for blessed record type transfer. Test that blessed records can be transferred through a TupleQueue and correctly decoded by another backend. While touching the file, make sure that force_parallel_mode settings only cover relevant tests. Author: Thomas Munro, editoria

[COMMITTERS] pgsql: Fix unlikely shared memory leak after failure in dshash_create()

2017-08-24 Thread Andres Freund
Fix unlikely shared memory leak after failure in dshash_create(). Tidy-up for commit 8c0d7bafad36434cb08ac2c78e69ae72c194ca20, based on a complaint from Andres Freund. Author: Thomas Munro Reviewed-By: Andres Freund Discussion: https://postgr.es/m/20170823054644.efuzftxjpfi6wwqs%40alap3.anarazel