[COMMITTERS] pgsql: Fix trivial mistake in README.

2017-09-26 Thread Robert Haas
Fix trivial mistake in README. You might think I (Robert) could manage to count to five without messing it up, but if you did, you would be wrong. Amit Kapila Discussion: http://postgr.es/m/CAA4eK1JxqqcuC5Un7YLQVhOYSZBS+t=3xqzuekt5ryquyux...@mail.gmail.com Branch -- master Details ---

[COMMITTERS] pgsql: Remove lsn from HashScanPosData.

2017-09-26 Thread Robert Haas
Remove lsn from HashScanPosData. This was intended as infrastructure for weakening VACUUM's locking requirements, similar to what was done for btree indexes in commit 2ed5b87f96d473962ec5230fd820abfeaccb2069. However, for hash indexes, it seems that the improvements which are possible are actuall

[COMMITTERS] pgsql: Handle heap rewrites better in logical replication

2017-09-26 Thread Peter Eisentraut
Handle heap rewrites better in logical replication A FOR ALL TABLES publication naturally considers all base tables to be a candidate for replication. This includes transient heaps that are created during a table rewrite during DDL. This causes failures on the subscriber side because it will not

[COMMITTERS] pgsql: Handle heap rewrites better in logical replication

2017-09-26 Thread Peter Eisentraut
Handle heap rewrites better in logical replication A FOR ALL TABLES publication naturally considers all base tables to be a candidate for replication. This includes transient heaps that are created during a table rewrite during DDL. This causes failures on the subscriber side because it will not

[COMMITTERS] pgsql: Sort pg_basebackup options better

2017-09-26 Thread Peter Eisentraut
Sort pg_basebackup options better The --slot option somehow ended up under options controlling the output, and some other options were in a nonsensical place or were not moved after recent renamings, so tidy all that up a bit. Branch -- master Details --- https://git.postgresql.org/pg/co

[COMMITTERS] pgsql: Use a blacklist to distinguish original from add-on enum values.

2017-09-26 Thread Tom Lane
Use a blacklist to distinguish original from add-on enum values. Commit 15bc038f9 allowed ALTER TYPE ADD VALUE to be executed inside transaction blocks, by disallowing the use of the added value later in the same transaction, except under limited circumstances. However, the test for "limited circ

[COMMITTERS] pgsql: Use a blacklist to distinguish original from add-on enum values.

2017-09-26 Thread Tom Lane
Use a blacklist to distinguish original from add-on enum values. Commit 15bc038f9 allowed ALTER TYPE ADD VALUE to be executed inside transaction blocks, by disallowing the use of the added value later in the same transaction, except under limited circumstances. However, the test for "limited circ

[COMMITTERS] pgsql: Remove heuristic same-transaction test from check_safe_enum_use(

2017-09-26 Thread Tom Lane
Remove heuristic same-transaction test from check_safe_enum_use(). The blacklist mechanism added by the preceding commit directly fixes most of the practical cases that the same-transaction test was meant to cover. What remains is use-cases like begin; create type e as enum('x');

[COMMITTERS] pgsql: Remove heuristic same-transaction test from check_safe_enum_use(

2017-09-26 Thread Tom Lane
Remove heuristic same-transaction test from check_safe_enum_use(). The blacklist mechanism added by the preceding commit directly fixes most of the practical cases that the same-transaction test was meant to cover. What remains is use-cases like begin; create type e as enum('x');

[COMMITTERS] pgsql: Fix failure-to-read-man-page in commit 899bd785c.

2017-09-26 Thread Tom Lane
Fix failure-to-read-man-page in commit 899bd785c. posix_fallocate() is not quite a drop-in replacement for fallocate(), because it is defined to return the error code as its function result, not in "errno". I (tgl) missed this because RHEL6's version seems to set errno as well. That is not the c

[COMMITTERS] pgsql: Fix failure-to-read-man-page in commit 899bd785c.

2017-09-26 Thread Tom Lane
Fix failure-to-read-man-page in commit 899bd785c. posix_fallocate() is not quite a drop-in replacement for fallocate(), because it is defined to return the error code as its function result, not in "errno". I (tgl) missed this because RHEL6's version seems to set errno as well. That is not the c

[COMMITTERS] pgsql: Fix failure-to-read-man-page in commit 899bd785c.

2017-09-26 Thread Tom Lane
Fix failure-to-read-man-page in commit 899bd785c. posix_fallocate() is not quite a drop-in replacement for fallocate(), because it is defined to return the error code as its function result, not in "errno". I (tgl) missed this because RHEL6's version seems to set errno as well. That is not the c

[COMMITTERS] pgsql: Fix failure-to-read-man-page in commit 899bd785c.

2017-09-26 Thread Tom Lane
Fix failure-to-read-man-page in commit 899bd785c. posix_fallocate() is not quite a drop-in replacement for fallocate(), because it is defined to return the error code as its function result, not in "errno". I (tgl) missed this because RHEL6's version seems to set errno as well. That is not the c

[COMMITTERS] pgsql: Fix failure-to-read-man-page in commit 899bd785c.

2017-09-26 Thread Tom Lane
Fix failure-to-read-man-page in commit 899bd785c. posix_fallocate() is not quite a drop-in replacement for fallocate(), because it is defined to return the error code as its function result, not in "errno". I (tgl) missed this because RHEL6's version seems to set errno as well. That is not the c

Re: [COMMITTERS] pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu

2017-09-26 Thread Tom Lane
"David G. Johnston" writes: > On Mon, Sep 25, 2017 at 1:50 PM, Peter Eisentraut < > peter.eisentr...@2ndquadrant.com> wrote: >> On 9/25/17 15:09, Tom Lane wrote: >>> Hm, reads fine to me, and I'd still rather include "is" in the >>> revised wording. Anybody else agree with Peter's wording? >> No

[COMMITTERS] pgsql: Improve wording of error message added in commit 714805010.

2017-09-26 Thread Tom Lane
Improve wording of error message added in commit 714805010. Per suggestions from Peter Eisentraut and David Johnston. Back-patch, like the previous commit. Discussion: https://postgr.es/m/e1dv9ji-0006ot...@gemulon.postgresql.org Branch -- master Details --- https://git.postgresql.org/pg

[COMMITTERS] pgsql: Improve wording of error message added in commit 714805010.

2017-09-26 Thread Tom Lane
Improve wording of error message added in commit 714805010. Per suggestions from Peter Eisentraut and David Johnston. Back-patch, like the previous commit. Discussion: https://postgr.es/m/e1dv9ji-0006ot...@gemulon.postgresql.org Branch -- REL9_2_STABLE Details --- https://git.postgresql

[COMMITTERS] pgsql: Improve wording of error message added in commit 714805010.

2017-09-26 Thread Tom Lane
Improve wording of error message added in commit 714805010. Per suggestions from Peter Eisentraut and David Johnston. Back-patch, like the previous commit. Discussion: https://postgr.es/m/e1dv9ji-0006ot...@gemulon.postgresql.org Branch -- REL9_3_STABLE Details --- https://git.postgresql

[COMMITTERS] pgsql: Improve wording of error message added in commit 714805010.

2017-09-26 Thread Tom Lane
Improve wording of error message added in commit 714805010. Per suggestions from Peter Eisentraut and David Johnston. Back-patch, like the previous commit. Discussion: https://postgr.es/m/e1dv9ji-0006ot...@gemulon.postgresql.org Branch -- REL9_6_STABLE Details --- https://git.postgresql

[COMMITTERS] pgsql: Improve wording of error message added in commit 714805010.

2017-09-26 Thread Tom Lane
Improve wording of error message added in commit 714805010. Per suggestions from Peter Eisentraut and David Johnston. Back-patch, like the previous commit. Discussion: https://postgr.es/m/e1dv9ji-0006ot...@gemulon.postgresql.org Branch -- REL9_4_STABLE Details --- https://git.postgresql

[COMMITTERS] pgsql: Improve wording of error message added in commit 714805010.

2017-09-26 Thread Tom Lane
Improve wording of error message added in commit 714805010. Per suggestions from Peter Eisentraut and David Johnston. Back-patch, like the previous commit. Discussion: https://postgr.es/m/e1dv9ji-0006ot...@gemulon.postgresql.org Branch -- REL9_5_STABLE Details --- https://git.postgresql

[COMMITTERS] pgsql: Improve wording of error message added in commit 714805010.

2017-09-26 Thread Tom Lane
Improve wording of error message added in commit 714805010. Per suggestions from Peter Eisentraut and David Johnston. Back-patch, like the previous commit. Discussion: https://postgr.es/m/e1dv9ji-0006ot...@gemulon.postgresql.org Branch -- REL_10_STABLE Details --- https://git.postgresql

[COMMITTERS] pgsql: Turn on log_replication_commands in PostgresNode

2017-09-26 Thread Peter Eisentraut
Turn on log_replication_commands in PostgresNode This is useful for example for the pg_basebackup and related tests. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/43588f58aa045c736af168267e0f1c5934333e15 Modified Files -- src/test/perl/PostgresNode.pm

[COMMITTERS] pgsql: Add some more pg_receivewal tests

2017-09-26 Thread Peter Eisentraut
Add some more pg_receivewal tests Add some more tests for the --create-slot and --drop-slot options, verifying that the right kind of slot was created and that the slot was dropped. While working on an unrelated patch for pg_basebackup, some of this was temporarily broken without any tests notici

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion: https://postgr.es/m/20170831025345.ge3

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion: https://postgr.es/m/20170831025345.ge3

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion: https://postgr.es/m/20170831025345.ge3

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion: https://postgr.es/m/20170831025345.ge3

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion: https://postgr.es/m/20170831025345.ge3

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion: https://postgr.es/m/20170831025345.ge3

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion: https://postgr.es/m/20170831025345.ge3