Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.

2017-10-09 Thread Andrew Dunstan
On 10/09/2017 07:15 PM, Andres Freund wrote: > Hi Andrew, > > On 2017-10-09 22:22:04 +, Andres Freund wrote: >> Add pg_strnlen() a portable implementation of strlen. >> >> As the OS version is likely going to be more optimized, fall back to >> it if available, as detected by configure. > I'm

Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.

2017-10-09 Thread Tom Lane
Andrew Dunstan writes: > frogmouth is using some code not yet released that makes the config > cache persistent. I just identified and fixed a stupid bug in the code > that obsoletes the cache, and I have removed frogmouth's cache file and > set it running again, so we'll see

[COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.

2017-10-09 Thread Andres Freund
Add pg_strnlen() a portable implementation of strlen. As the OS version is likely going to be more optimized, fall back to it if available, as detected by configure. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8a241792f968ed5be6cf4d41e32c0d264f6c0c65 Modified

[COMMITTERS] pgsql: Fix pnstrdup() to not memcpy() the maximum allowed length.

2017-10-09 Thread Andres Freund
Fix pnstrdup() to not memcpy() the maximum allowed length. The previous behaviour was dangerous if the length passed wasn't the size of the underlying buffer, but the maximum size of the underlying buffer. Author: Andres Freund Discussion:

Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.

2017-10-09 Thread Andres Freund
Hi Andrew, On 2017-10-09 22:22:04 +, Andres Freund wrote: > Add pg_strnlen() a portable implementation of strlen. > > As the OS version is likely going to be more optimized, fall back to > it if available, as detected by configure. I'm a bit confused, frogmouth

Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.

2017-10-09 Thread Andres Freund
On 2017-10-10 00:25:52 -0400, Tom Lane wrote: > Andrew Dunstan writes: > > frogmouth is using some code not yet released that makes the config > > cache persistent. I just identified and fixed a stupid bug in the code > > that obsoletes the cache, and I have removed

Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.

2017-10-09 Thread Tom Lane
Andres Freund writes: > I think the current split between common and port isn't particularly > meaningful. But as long as we have it, this probably belongs more in > port than in common. Well, port is supposed to be for stuff that we expect to find in libc on common

[COMMITTERS] pgsql: Remove unused documentation file

2017-10-09 Thread Peter Eisentraut
Remove unused documentation file Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/71c75ddfbb277362bf62dc5b1645c3903e16bc34 Modified Files -- doc/src/sgml/contacts.sgml | 26 -- doc/src/sgml/filelist.sgml | 1 - 2 files changed, 27