[COMMITTERS] pgsql: Use lower-case SGML attribute values

Use lower-case SGML attribute values for DocBook XML compatibility Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/44b3230e821e7a0cc4e9438d1c27305d533edacc Modified Files -- doc/src/sgml/ecpg.sgml| 112 +++---

[COMMITTERS] pgsql: Add missing clean step to src/test/modules/brin/Makefile.

Add missing clean step to src/test/modules/brin/Makefile. I noticed the tmp_check subdirectory wasn't getting cleaned up after a check-world run. Apparently pgxs.mk will only do this for you if you've defined REGRESS. The only other src/test/modules Makefile that does not set that is

[COMMITTERS] pgsql: Add missing clean step to src/test/modules/brin/Makefile.

Add missing clean step to src/test/modules/brin/Makefile. I noticed the tmp_check subdirectory wasn't getting cleaned up after a check-world run. Apparently pgxs.mk will only do this for you if you've defined REGRESS. The only other src/test/modules Makefile that does not set that is

Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.

On 2017-10-09 23:33:36 -0400, Andrew Dunstan wrote: > > > On 10/09/2017 07:15 PM, Andres Freund wrote: > > Hi Andrew, > > > > On 2017-10-09 22:22:04 +, Andres Freund wrote: > >> Add pg_strnlen() a portable implementation of strlen. > >> > >> As the OS version is likely going to be more

Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.

On 2017-10-10 16:37:04 -0400, Tom Lane wrote: > Andres Freund writes: > > (there's definitely fixes to be made to where strnlen's replacement is > > located, but regardless, this needs to be fixed too) > > Given that strnlen is standardized by POSIX, and has been for nigh a >

Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.

Andres Freund writes: > (there's definitely fixes to be made to where strnlen's replacement is > located, but regardless, this needs to be fixed too) Given that strnlen is standardized by POSIX, and has been for nigh a decade, I think it'd be all right for us to treat it as a

Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.

On 2017-10-10 13:53:15 -0700, Andres Freund wrote: > On 2017-10-10 16:51:39 -0400, Tom Lane wrote: > > Andres Freund writes: > > > As far as I can tell it's still somehow using a configure from before > > > the last commits: > > > > No, it's pilot error. The AC_CHECK_FUNCS

Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.

On 2017-10-10 16:51:39 -0400, Tom Lane wrote: > Andres Freund writes: > > As far as I can tell it's still somehow using a configure from before > > the last commits: > > No, it's pilot error. The AC_CHECK_FUNCS call you added strnlen to > is only executed if > AS_IF([test

Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.

Andres Freund writes: > As far as I can tell it's still somehow using a configure from before > the last commits: No, it's pilot error. The AC_CHECK_FUNCS call you added strnlen to is only executed if AS_IF([test "$enable_thread_safety" = yes -a "$PORTNAME" != "win32"], A

Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.

On 10/10/2017 03:48 PM, Andres Freund wrote: > On 2017-10-09 23:33:36 -0400, Andrew Dunstan wrote: >> >> On 10/09/2017 07:15 PM, Andres Freund wrote: >>> Hi Andrew, >>> >>> On 2017-10-09 22:22:04 +, Andres Freund wrote: Add pg_strnlen() a portable implementation of strlen. As

Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.

On 2017-10-10 17:34:17 -0400, Andrew Dunstan wrote: > This test is governed by the test at line 946 of configure.in. You need > to move it somewhere else. Yea, sorry for the noise :(. Greetings, Andres Freund -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make

Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.

Andres Freund writes: > Here's a fix. Not quite sure whether we really need the > HAVE_DECL_STRNLEN test, added it for symmetry. LGTM. I think the DECL test is a good idea; the system definition might be a macro or otherwise weird, in which case we'd cause problems if we

[COMMITTERS] pgsql: Rewrite strnlen replacement implementation from 8a241792f96.

Rewrite strnlen replacement implementation from 8a241792f96. The previous placement of the fallback implementation in libpgcommon was problematic, because libpqport functions need strnlen functionality. Move replacement into libpgport. Provide strnlen() under its posix name, instead of

Re: [COMMITTERS] pgsql: Add pg_strnlen() a portable implementation of strlen.

On 2017-10-10 18:10:15 -0400, Tom Lane wrote: > Andres Freund writes: > > Here's a fix. Not quite sure whether we really need the > > HAVE_DECL_STRNLEN test, added it for symmetry. > > LGTM. Thanks for checking. > I think the DECL test is a good idea; the system definition

[COMMITTERS] pgsql: Regenerate configure script.

Regenerate configure script. Not sure how fffd651e83ccbd6191a76be6ec7c6b1b27888fde ended up probing for "strnlenfrak" rather than "strnlen". My autoconf doesn't do that ... Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f4128ab466aac639387a5dade6647621c87bbb3f

Re: [COMMITTERS] pgsql: Rewrite strnlen replacement implementation from 8a241792f96.

Andres Freund writes: > Rewrite strnlen replacement implementation from 8a241792f96. Hm, did you hand-edit the configure script and then forget to undo it? Cause what was committed was not right. regards, tom lane -- Sent via pgsql-committers

Re: [COMMITTERS] pgsql: Rewrite strnlen replacement implementation from 8a241792f96.

On 2017-10-10 19:15:13 -0400, Tom Lane wrote: > Andres Freund writes: > > Rewrite strnlen replacement implementation from 8a241792f96. > > Hm, did you hand-edit the configure script and then forget to undo it? > Cause what was committed was not right. Yea, that was me