Re: [COMMITTERS] pgsql: Add hash partitioning.

2017-11-12 Thread amul sul
On Sun, Nov 12, 2017 at 3:01 AM, Andreas Seltenreich wrote: > Robert Haas writes: > >> Add hash partitioning. > > sqlsmith triggers coredumps calling satisfies_hash_partition(). > ISTM this function is lacking argument validation. Example: > Thanks for the bug report.

[COMMITTERS] pgsql: MSVC: Rebuild spiexceptions.h when out of date.

2017-11-12 Thread Noah Misch
MSVC: Rebuild spiexceptions.h when out of date. Also, add a warning to catch future instances of naming a nonexistent file as a prerequisite. Back-patch to 9.3 (all supported versions). Branch -- REL9_3_STABLE Details ---

[COMMITTERS] pgsql: MSVC: Rebuild spiexceptions.h when out of date.

2017-11-12 Thread Noah Misch
MSVC: Rebuild spiexceptions.h when out of date. Also, add a warning to catch future instances of naming a nonexistent file as a prerequisite. Back-patch to 9.3 (all supported versions). Branch -- master Details ---

[COMMITTERS] pgsql: MSVC: Rebuild spiexceptions.h when out of date.

2017-11-12 Thread Noah Misch
MSVC: Rebuild spiexceptions.h when out of date. Also, add a warning to catch future instances of naming a nonexistent file as a prerequisite. Back-patch to 9.3 (all supported versions). Branch -- REL_10_STABLE Details ---

[COMMITTERS] pgsql: MSVC: Rebuild spiexceptions.h when out of date.

2017-11-12 Thread Noah Misch
MSVC: Rebuild spiexceptions.h when out of date. Also, add a warning to catch future instances of naming a nonexistent file as a prerequisite. Back-patch to 9.3 (all supported versions). Branch -- REL9_5_STABLE Details ---

[COMMITTERS] pgsql: MSVC: Rebuild spiexceptions.h when out of date.

2017-11-12 Thread Noah Misch
MSVC: Rebuild spiexceptions.h when out of date. Also, add a warning to catch future instances of naming a nonexistent file as a prerequisite. Back-patch to 9.3 (all supported versions). Branch -- REL9_4_STABLE Details ---

[COMMITTERS] pgsql: MSVC: Rebuild spiexceptions.h when out of date.

2017-11-12 Thread Noah Misch
MSVC: Rebuild spiexceptions.h when out of date. Also, add a warning to catch future instances of naming a nonexistent file as a prerequisite. Back-patch to 9.3 (all supported versions). Branch -- REL9_6_STABLE Details ---

[COMMITTERS] pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte

2017-11-12 Thread Noah Misch
Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext. PostgreSQL running as a Windows service crashed upon calling write_stderr() before MemoryContextInit(). This fix completes work started in 5735efee15540765315aa8c1a230575e756037f7. Messages this early contain only ASCII bytes;

[COMMITTERS] pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte

2017-11-12 Thread Noah Misch
Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext. PostgreSQL running as a Windows service crashed upon calling write_stderr() before MemoryContextInit(). This fix completes work started in 5735efee15540765315aa8c1a230575e756037f7. Messages this early contain only ASCII bytes;

[COMMITTERS] pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte

2017-11-12 Thread Noah Misch
Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext. PostgreSQL running as a Windows service crashed upon calling write_stderr() before MemoryContextInit(). This fix completes work started in 5735efee15540765315aa8c1a230575e756037f7. Messages this early contain only ASCII bytes;

[COMMITTERS] pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte

2017-11-12 Thread Noah Misch
Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext. PostgreSQL running as a Windows service crashed upon calling write_stderr() before MemoryContextInit(). This fix completes work started in 5735efee15540765315aa8c1a230575e756037f7. Messages this early contain only ASCII bytes;

[COMMITTERS] pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte

2017-11-12 Thread Noah Misch
Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext. PostgreSQL running as a Windows service crashed upon calling write_stderr() before MemoryContextInit(). This fix completes work started in 5735efee15540765315aa8c1a230575e756037f7. Messages this early contain only ASCII bytes;

[COMMITTERS] pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte

2017-11-12 Thread Noah Misch
Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext. PostgreSQL running as a Windows service crashed upon calling write_stderr() before MemoryContextInit(). This fix completes work started in 5735efee15540765315aa8c1a230575e756037f7. Messages this early contain only ASCII bytes;

[COMMITTERS] pgsql: Install Windows crash dump handler before all else.

2017-11-12 Thread Noah Misch
Install Windows crash dump handler before all else. Apart from calling write_stderr() on failure, the handler depends on no PostgreSQL facilities. We have experienced crashes before reaching the former call site. Given such an early crash, this change cannot hurt and may produce a helpful dump.

[COMMITTERS] pgsql: Install Windows crash dump handler before all else.

2017-11-12 Thread Noah Misch
Install Windows crash dump handler before all else. Apart from calling write_stderr() on failure, the handler depends on no PostgreSQL facilities. We have experienced crashes before reaching the former call site. Given such an early crash, this change cannot hurt and may produce a helpful dump.

[COMMITTERS] pgsql: Install Windows crash dump handler before all else.

2017-11-12 Thread Noah Misch
Install Windows crash dump handler before all else. Apart from calling write_stderr() on failure, the handler depends on no PostgreSQL facilities. We have experienced crashes before reaching the former call site. Given such an early crash, this change cannot hurt and may produce a helpful dump.

[COMMITTERS] pgsql: Install Windows crash dump handler before all else.

2017-11-12 Thread Noah Misch
Install Windows crash dump handler before all else. Apart from calling write_stderr() on failure, the handler depends on no PostgreSQL facilities. We have experienced crashes before reaching the former call site. Given such an early crash, this change cannot hurt and may produce a helpful dump.

[COMMITTERS] pgsql: Install Windows crash dump handler before all else.

2017-11-12 Thread Noah Misch
Install Windows crash dump handler before all else. Apart from calling write_stderr() on failure, the handler depends on no PostgreSQL facilities. We have experienced crashes before reaching the former call site. Given such an early crash, this change cannot hurt and may produce a helpful dump.

[COMMITTERS] pgsql: Install Windows crash dump handler before all else.

2017-11-12 Thread Noah Misch
Install Windows crash dump handler before all else. Apart from calling write_stderr() on failure, the handler depends on no PostgreSQL facilities. We have experienced crashes before reaching the former call site. Given such an early crash, this change cannot hurt and may produce a helpful dump.