[COMMITTERS] pgsql: Fix failure-to-copy bug in commit 6f6b99d13.

Fix failure-to-copy bug in commit 6f6b99d13. The previous coding of get_qual_for_list() was careful to copy everything it was using from the input data structure. The new version missed making a copy of pass-by-ref datum values that it's inserting into Consts. This is not optional, however, as

Re: [COMMITTERS] pgsql: Allow a partitioned table to have a default partition.

On Fri, Sep 8, 2017 at 6:50 PM, Tom Lane wrote: > But it ain't. It's failing on empty partition expressions, and there's > a short-circuit exit from map_partition_varattnos. > > Will fix. Thanks. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise

[COMMITTERS] pgsql: Fix uninitialized-variable bug.

Fix uninitialized-variable bug. map_partition_varattnos() failed to set its found_whole_row output parameter if the given expression list was NIL. This seems to be a pre-existing bug that chanced to be exposed by commit 6f6b99d13. It might be unreachable in v10, but I have little faith in that

[COMMITTERS] pgsql: Fix uninitialized-variable bug.

Fix uninitialized-variable bug. map_partition_varattnos() failed to set its found_whole_row output parameter if the given expression list was NIL. This seems to be a pre-existing bug that chanced to be exposed by commit 6f6b99d13. It might be unreachable in v10, but I have little faith in that

Re: [COMMITTERS] pgsql: Allow a partitioned table to have a default partition.

Thomas Munro writes: > On Sat, Sep 9, 2017 at 10:23 AM, Thomas Munro > wrote: >> map_partition_varattnos() doesn't always write to *found_whole_row, so >> it's uninitialised here in generate_partition_qual(): That was the first thing

Re: [COMMITTERS] pgsql: Allow a partitioned table to have a default partition.

On Sat, Sep 9, 2017 at 10:23 AM, Thomas Munro wrote: > On Sat, Sep 9, 2017 at 9:49 AM, Tom Lane wrote: >> Robert Haas writes: >>> Allow a partitioned table to have a default partition. >> >> Early buildfarm returns not

Re: [COMMITTERS] pgsql: Allow a partitioned table to have a default partition.

On Sat, Sep 9, 2017 at 9:49 AM, Tom Lane wrote: > Robert Haas writes: >> Allow a partitioned table to have a default partition. > > Early buildfarm returns not good. > > It passes here, so the problem isn't obvious. map_partition_varattnos() doesn't

Re: [COMMITTERS] pgsql: Allow a partitioned table to have a default partition.

Robert Haas writes: > Allow a partitioned table to have a default partition. Early buildfarm returns not good. It passes here, so the problem isn't obvious. regards, tom lane -- Sent via pgsql-committers mailing list

[COMMITTERS] pgsql: Fix more portability issues in new pgbench TAP tests.

Fix more portability issues in new pgbench TAP tests. Not completely sure, but I think bowerbird is spitting up on attempting to include ">" in a temporary file name. (Why in the world are we writing this stuff into files at all? A hash would be a better answer.) Branch -- master Details

[COMMITTERS] pgsql: Allow a partitioned table to have a default partition.

Allow a partitioned table to have a default partition. Any tuples that don't route to any other partition will route to the default partition. Jeevan Ladhe, Beena Emerson, Ashutosh Bapat, Rahila Syed, and Robert Haas, with review and testing at various stages by (at least) Rushabh Lathia, Keith

[COMMITTERS] pgsql: Fix pgbench TAP tests to work with --disable-thread-safety.

Fix pgbench TAP tests to work with --disable-thread-safety. Probably matters to nobody but me; but I'd like to still be able to get through the TAP tests on gaur/pademelon, from time to time. Branch -- master Details ---

[COMMITTERS] pgsql: Doc: update v10 release notes through today.

Doc: update v10 release notes through today. Also, another round of copy-editing. I merged a few items that didn't seem to be meaningfully different from a user's perspective. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c1602c7a1b2e49acbba680cb72949d4fa3a8d2ee

[COMMITTERS] pgsql: Doc: update v10 release notes through today.

Doc: update v10 release notes through today. Also, another round of copy-editing. I merged a few items that didn't seem to be meaningfully different from a user's perspective. Branch -- REL_10_STABLE Details ---

[COMMITTERS] pgsql: Remove mention of password_encryption = plain in postgresql.conf

Remove mention of password_encryption = plain in postgresql.conf.sample. Evidently missed in commit eb61136dc. Spotted by Oleg Bartunov. Discussion: https://postgr.es/m/caf4au4wz_ik5r4fntnnd8xqioazqs-p7-vseafivw34zmvp...@mail.gmail.com Branch -- master Details ---

[COMMITTERS] pgsql: Remove mention of password_encryption = plain in postgresql.conf

Remove mention of password_encryption = plain in postgresql.conf.sample. Evidently missed in commit eb61136dc. Spotted by Oleg Bartunov. Discussion: https://postgr.es/m/caf4au4wz_ik5r4fntnnd8xqioazqs-p7-vseafivw34zmvp...@mail.gmail.com Branch -- REL_10_STABLE Details ---

Re: [COMMITTERS] pgsql: Fix more portability issues in new pgbench TAP tests.

Fix more portability issues in new pgbench TAP tests. Sorry for all these issues unforeseen issues. Thanks to the farm! * Remove no-such-user test case, output isn't stable, and we really don't need to be testing such cases here anyway. Ok. * Fix the process exit code test logic to

[COMMITTERS] pgsql: Fix more portability issues in new pgbench TAP tests.

Fix more portability issues in new pgbench TAP tests. Strike two on the --bad-option test. Three strikes and it's out. Fabien Coelho, per buildfarm Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/933851033becf0848e0bb903f310bbd725e19489 Modified Files

Re: [COMMITTERS] pgsql: Fix assorted portability issues in new pgbench TAP tests.

Fabien COELHO writes: > Please find attached "blind" additional fixes for Windows & AIX. > - more nan/inf variants I think we should just drop this. It's not worth the trouble, and I have no faith whatsoever that we've seen every behavior. > - different message on non

[COMMITTERS] pgsql: Fix more portability issues in new pgbench TAP tests.

Fix more portability issues in new pgbench TAP tests. * Remove no-such-user test case, output isn't stable, and we really don't need to be testing such cases here anyway. * Fix the process exit code test logic to match PostgresNode::psql (but I didn't bother with looking at the "core" flag). *

Re: [COMMITTERS] pgsql: Fix assorted portability issues in new pgbench TAP tests.

Hello, Please find attached "blind" additional fixes for Windows & AIX. - more nan/inf variants - different message on non existing user - illegal vs unrecognized options I suspect that $windows_os is not true on "bowerbird", in order to fix it the value of "$Config{osname}" is needed...

[COMMITTERS] pgsql: Remove useless empty string initializations

Remove useless empty string initializations This coding style probably stems from the days of shell scripts. Reviewed-by: Aleksandr Parfenov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8e673801262c66af4a54837f63ff596407835c20

[COMMITTERS] pgsql: Remove useless dead code

Remove useless dead code Reviewed-by: Aleksandr Parfenov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9361bc347c85b685280fad742c519234d6e42bee Modified Files -- .../ecpg/test/expected/pgtypeslib-dt_test.c| 22

[COMMITTERS] pgsql: Clean up excessive code

Clean up excessive code The encoding ID was converted between string and number too many times, probably a remnant from the shell script days. Reviewed-by: Aleksandr Parfenov Branch -- master Details ---

Re: [COMMITTERS] pgsql: Fix assorted portability issues in new pgbench TAP tests.

Fix assorted portability issues in new pgbench TAP tests. Most where hard to guess without having the report. Thanks. * Test was way too optimistic about the platform independence of NaN and Infinity outputs. I rather imagine we might have to lose those tests altogether, but for the moment

[COMMITTERS] pgsql: Fix assorted portability issues in new pgbench TAP tests.

Fix assorted portability issues in new pgbench TAP tests. * Our own version of getopt_long doesn't support abbreviation of long options. * It doesn't do automatic rearrangement of non-option arguments to the end, either. * Test was way too optimistic about the platform independence of NaN and

[COMMITTERS] pgsql: Add much-more-extensive TAP tests for pgbench.

Add much-more-extensive TAP tests for pgbench. Fabien Coelho, reviewed by Nikolay Shaplov and myself Discussion: https://postgr.es/m/alpine.DEB.2.20.1704171422500.4025@lancre Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ed8a7c6fcf92b6b57ed8003bbd4a4eb92a6039bc