Re: [COMMITTERS] pgsql: Adjust basebackup.c to suppress compiler warnings.

2011-01-11 Thread Alvaro Herrera
> Magnus Hagander writes: > > I noticed you didn't create a function prototype at the top of the > > file for this function. Was that intentional, or missed? If it was > > intentional, can you give me a quick lesson in when it should be done > > and whe nit shouldn't? :-) I think normally you ca

[COMMITTERS] pgsql: Increment Py_None refcount for NULL array elements

2011-01-17 Thread Alvaro Herrera
Increment Py_None refcount for NULL array elements Per bug #5835 by Julien Demoor Author: Alex Hunsaker Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=978445bece6ce3df55599ee971a4a5dc217bf34c Modified Files -- src/pl/plpython/pl

[COMMITTERS] pgsql: Increment Py_None refcount for NULL array elements

2011-01-17 Thread Alvaro Herrera
Increment Py_None refcount for NULL array elements Per bug #5835 by Julien Demoor Author: Alex Hunsaker Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=051096d06ece0c553e8ed85bfe45129f488a806d Modified Files -- src/pl/plpy

[COMMITTERS] pgsql: Fix the isolation tester compilation on VPATH builds

2011-02-10 Thread Alvaro Herrera
Fix the isolation tester compilation on VPATH builds Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/289d7306555b2446d145c7e098c91b6ca20bd54c Modified Files -- src/test/isolation/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Se

[COMMITTERS] pgsql: Fix isolation tester Makefile so that it runs in a VPATH build

2011-02-10 Thread Alvaro Herrera
Fix isolation tester Makefile so that it runs in a VPATH build Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/61cf7bcdf76a2a32d2400a116c8da48d5fd4d3a2 Modified Files -- src/test/isolation/Makefile |4 ++-- src/test/isolation/README |2 +- 2 files

[COMMITTERS] pgsql: Fix comment recently obsoleted

2011-02-11 Thread Alvaro Herrera
Fix comment recently obsoleted Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/60141eefaf28e4ff5e406952740423dd6fd16266 Modified Files -- src/backend/parser/parse_type.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) -- Sent via pgsql-comm

[COMMITTERS] pgsql: Make pg_upgrade compile again

2011-02-15 Thread Alvaro Herrera
Make pg_upgrade compile again Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8b2557553c6eeba97d9ebf6f048369cabd25c2b6 Modified Files -- contrib/pg_upgrade/info.c |3 +-- contrib/pg_upgrade/pg_upgrade.c |2 ++ 2 files changed, 3 insertions(+),

[COMMITTERS] pgsql: Cleanup ClusterInfo initialization in pg_upgrade

2011-02-16 Thread Alvaro Herrera
Cleanup ClusterInfo initialization in pg_upgrade Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b4a7e5980b2919d4d2a849d046a8e3a77e06fdb7 Modified Files -- contrib/pg_upgrade/info.c |6 ++ contrib/pg_upgrade/pg_upgrade.c |5 +++-- contrib/

[COMMITTERS] pgsql: Use $INDENT rather than indent throughout the pgindent code

2011-02-17 Thread Alvaro Herrera
Use $INDENT rather than indent throughout the pgindent code This allows the user to change the path to be used more easily. Also, change URL in README. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c4d124365b9b535e8c98e4568ade3e0c15b11810 Modified Files --

[COMMITTERS] pgsql: pgindent run on plperl.c

2011-02-17 Thread Alvaro Herrera
pgindent run on plperl.c Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f7b51d175a02a3b6589f091ca732959618844232 Modified Files -- src/pl/plperl/plperl.c | 149 ++- 1 files changed, 82 insertions(+), 67 deletio

[COMMITTERS] pgsql: Convert Postgres arrays to Perl arrays on PL/perl input argument

2011-02-17 Thread Alvaro Herrera
Convert Postgres arrays to Perl arrays on PL/perl input arguments More generally, arrays are turned in Perl array references, and row and composite types are turned into Perl hash references. This is done recursively, in a way that's natural to every Perl programmer. To avoid a backwards compati

Re: [COMMITTERS] pgsql: Use $INDENT rather than indent throughout the pgindent code

2011-02-18 Thread Alvaro Herrera
Excerpts from Tom Lane's message of vie feb 18 00:34:33 -0300 2011: > Bruce Momjian writes: > > Andrew Dunstan wrote: > >> On 02/17/2011 08:23 PM, Alvaro Herrera wrote: > >>> Use $INDENT rather than indent throughout the pgindent code > >>> +INDENT=`

[COMMITTERS] pgsql: Use $INDENT instead of `which` to find the indent binary

2011-02-18 Thread Alvaro Herrera
Use $INDENT instead of `which` to find the indent binary Per discussion after my commit o yesterday. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a5dfc94c9a2e6c0c7e0ed97d22ebff37cf7d9038 Modified Files -- src/tools/pgindent/pgindent |5 - 1 fil

[COMMITTERS] pgsql: Fix pageinspect's heap_page_item to return infomasks as 32 bit v

2011-02-25 Thread Alvaro Herrera
Fix pageinspect's heap_page_item to return infomasks as 32 bit values HeapTupleHeader's t_infomask and t_infomask2 are defined as 16-bit unsigned integers, so when the 16th bit was set, heap_page_item was returning them as negative values, which was ugly. The change to pageinspect--unpackaged--1.

[COMMITTERS] pgsql: Update pageinspect--1.0.sql to match the upgrade script

2011-02-25 Thread Alvaro Herrera
Update pageinspect--1.0.sql to match the upgrade script Per comment from Tom Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0056066d06067d2d7fc84b31937933b5724347d0 Modified Files -- contrib/pageinspect/pageinspect--1.0.sql |4 ++-- 1 files changed,

Re: [COMMITTERS] pgsql: Fix pageinspect's heap_page_item to return infomasks as 32 bit v

2011-02-25 Thread Alvaro Herrera
Excerpts from Tom Lane's message of vie feb 25 19:31:13 -0300 2011: > Alvaro Herrera writes: > > Fix pageinspect's heap_page_item to return infomasks as 32 bit values > > HeapTupleHeader's t_infomask and t_infomask2 are defined as 16-bit > > unsigned in

[COMMITTERS] pgsql: Fix PL/Python memory leak involving array slices

2011-03-17 Thread Alvaro Herrera
Fix PL/Python memory leak involving array slices Report and patch from Daniel Popowich, bug #5842 (with some debugging help from Alex Hunsaker) Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/38e5124574ae86bf8992c17c176958b0ec4d6ee0 Modified Files ---

[COMMITTERS] pgsql: Fix PL/Python memory leak involving array slices

2011-03-17 Thread Alvaro Herrera
Fix PL/Python memory leak involving array slices Report and patch from Daniel Popowich, bug #5842 (with some debugging help from Alex Hunsaker) Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/7135bc5d6665fb9cf9452b660c0f7c3daa4a439b Modified Files ---

[COMMITTERS] pgsql: Fix PL/Python memory leak involving array slices

2011-03-17 Thread Alvaro Herrera
Fix PL/Python memory leak involving array slices Report and patch from Daniel Popowich, bug #5842 (with some debugging help from Alex Hunsaker) Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/4c1a9ee665761906c774bb2c5bcaa61ae7d6aa87 Modified Files ---

[COMMITTERS] pgsql: Fix PL/Python memory leak involving array slices

2011-03-17 Thread Alvaro Herrera
Fix PL/Python memory leak involving array slices Report and patch from Daniel Popowich, bug #5842 (with some debugging help from Alex Hunsaker) Branch -- REL8_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/151e463c91e0a83a5d277dccae43a7724ffe1e76 Modified Files ---

[COMMITTERS] pgsql: Fix PL/Python memory leak involving array slices

2011-03-17 Thread Alvaro Herrera
Fix PL/Python memory leak involving array slices Report and patch from Daniel Popowich, bug #5842 (with some debugging help from Alex Hunsaker) Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1c249fcfcc331d589a2fa1574e16c0ef3d1547ce Modified Files -- src

[COMMITTERS] pgsql: Fix broken markup, and remove tabs

2011-03-25 Thread Alvaro Herrera
Fix broken markup, and remove tabs Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/01dd34d55ad53117c2d756da7f65b6fa07a303aa Modified Files -- doc/src/sgml/ref/ecpg-ref.sgml | 49 +-- 1 files changed, 26 insertions(+),

[COMMITTERS] pgsql: Add missing #include

2011-03-28 Thread Alvaro Herrera
Add missing #include Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e5948e3504c72fb2b8b32af26bfbb016e7c71bf6 Modified Files -- contrib/sepgsql/sepgsql.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) -- Sent via pgsql-committers mailing li

[COMMITTERS] pgsql: Duplicate expansion of "direction" from FETCH's synopsis into MO

2011-04-04 Thread Alvaro Herrera
Duplicate expansion of "direction" from FETCH's synopsis into MOVE Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8c250f3741f4f897362de32a03f56726cf3f9774 Modified Files -- doc/src/sgml/ref/fetch.sgml |1 + doc/src/sgml/ref/move.sgml | 18 +

[COMMITTERS] pgsql: Uppercase and tags in SGML source

2011-04-04 Thread Alvaro Herrera
Uppercase and tags in SGML source This improves compatibility with external toolchains, such as those used by some documentation translation tools. Gabriele Bartolini Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/fc3459d70c5d842fe6519522649c8a47454f25bb Modifie

[COMMITTERS] pgsql: Update MSVC toolchain to match SGML entity uppercasing

2011-04-04 Thread Alvaro Herrera
Update MSVC toolchain to match SGML entity uppercasing Per Robert Haas Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/34a991619bddf2bfb441cf2d4396b67198326bcd Modified Files -- src/tools/msvc/Solution.pm |4 ++-- 1 files changed, 2 insertions(+), 2 d

[COMMITTERS] pgsql: Change "Id" to "id" in some SGML tags

2011-04-05 Thread Alvaro Herrera
Change "Id" to "id" in some SGML tags Gabriele Bartolini Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/38d15f16511cb9f75ed2b1e1f73117c1bc581538 Modified Files -- doc/src/sgml/config.sgml |2 +- doc/src/sgml/recovery-config.sgml |2 +- do

Re: [COMMITTERS] pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64

2011-04-27 Thread Alvaro Herrera
Excerpts from Tom Lane's message of lun abr 25 17:22:41 -0300 2011: > Fix pg_size_pretty() to avoid overflow for inputs close to INT64_MAX. > > The expression that tried to round the value to the nearest TB could > overflow, leading to bogus output as reported in bug #5993 from Nicola > Cossu. Th

Re: [COMMITTERS] pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64

2011-04-27 Thread Alvaro Herrera
Excerpts from Tom Lane's message of mié abr 27 17:10:37 -0300 2011: > Alvaro Herrera writes: > > Excerpts from Tom Lane's message of lun abr 25 17:22:41 -0300 2011: > >> Fix pg_size_pretty() to avoid overflow for inputs close to INT64_MAX. > > > Apparently t

Re: [COMMITTERS] pgsql: Fix pg_size_pretty() to avoid overflow for inputs close to INT64

2011-04-28 Thread Alvaro Herrera
Excerpts from Dave Page's message of jue abr 28 16:33:44 -0300 2011: > I think we may have to award Sun (or whats left of them) the "Bizarre > compiler bug of the week" award here. It's actually the val++; that's > causing the assertion, but I'm darned if I can get it to work. I've > tried spellin

[COMMITTERS] pgsql: Update some ALTER USER cross-references to ALTER ROLE

2011-05-02 Thread Alvaro Herrera
Update some ALTER USER cross-references to ALTER ROLE Greg Smith Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/52897e54db1000f2fa45b31e02eb252dd0573516 Modified Files -- doc/src/sgml/client-auth.sgml |2 +- doc/src/sgml/config.sgml |6 +++--

[COMMITTERS] pgsql: Add ID attribute to some sect2's missing it

2011-05-02 Thread Alvaro Herrera
Add ID attribute to some sect2's missing it David Fetter Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/155743ad3108cd586d56e864d1209b82f9a716f0 Modified Files -- doc/src/sgml/func.sgml | 22 +++--- 1 files changed, 11 insertions(+), 11

[COMMITTERS] pgsql: Update obsolete mention of Sequoia, now known as Tungsten

2011-05-03 Thread Alvaro Herrera
Update obsolete mention of Sequoia, now known as Tungsten Per http://joomla.aws.continuent.com/community/lab-projects/sequoia Greg Smith Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/04be7ac271c4b6db6ba518225f58f936b3b4435c Modified Files -- doc/src/s

[COMMITTERS] pgsql: Improve description of read/write traffic scalability

2011-05-03 Thread Alvaro Herrera
Improve description of read/write traffic scalability Greg Smith, after a suggestion of James Bruce Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/561485709673f4bc05240e891dd9056bdedbbcbc Modified Files -- doc/src/sgml/high-availability.sgml |7

Re: [COMMITTERS] pgsql: Clarify error message when attempting to create index on foreign

2011-05-05 Thread Alvaro Herrera
Excerpts from Magnus Hagander's message of jue may 05 16:48:07 -0300 2011: > Clarify error message when attempting to create index on foreign table > > Instead of just saying "is not a table", specifically state that > indexes aren't supported on *foreign* tables. Buildfarm broke ... do you need

[COMMITTERS] pgsql: Fix assorted typos

2011-05-12 Thread Alvaro Herrera
Fix assorted typos Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c6eb5740b3c352fb10bf61bb4465332ae6b28ab1 Modified Files -- contrib/pg_standby/pg_standby.c |4 ++-- src/backend/access/transam/clog.c |4 ++-- 2 files changed, 4 insertions(+), 4 d

[COMMITTERS] pgsql: Fix declaration of $_TD in "strict" trigger functions

2011-05-18 Thread Alvaro Herrera
Fix declaration of $_TD in "strict" trigger functions This was broken in commit ef19dc6d39dd2490ff61489da55d95d6941140bf by the Bunce/Hunsaker/Dunstan team, which moved the declaration from plperl_create_sub to plperl_call_perl_trigger_func. This doesn't actually work because the validator code w

[COMMITTERS] pgsql: Remove unused variable

2011-05-27 Thread Alvaro Herrera
Remove unused variable Cédric Villemain Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4c60a77508ee4f4d895629905265d79feaab108c Modified Files -- src/backend/commands/tablecmds.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) -- Sent via

[COMMITTERS] pgsql: Make message more consistent

2011-05-30 Thread Alvaro Herrera
Make message more consistent Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5177dfefc532ea481bf70d1bb8a493f835a9c57c Modified Files -- src/bin/pg_basebackup/pg_basebackup.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-c

[COMMITTERS] pgsql: Remove usage of &PL_sv_undef in hashes and arrays

2011-05-30 Thread Alvaro Herrera
Remove usage of &PL_sv_undef in hashes and arrays According to perlguts, &PL_sv_undef is not the right thing to use in those cases because it doesn't behave the same way as an undef value via Perl code. Seems the intuitive way to deal with undef values is subtly enough broken that it's hard to no

[COMMITTERS] pgsql: Fix pg_get_constraintdef to cope with NOT VALID constraints

2011-06-03 Thread Alvaro Herrera
Fix pg_get_constraintdef to cope with NOT VALID constraints This case was missed when NOT VALID constraints were first introduced in commit 722bf7017bbe796decc79c1fde03e7a83dae9ada by Simon Riggs on 2011-02-08. Among other things, it causes pg_dump to omit the NOT VALID flag when dumping such con

[COMMITTERS] pgsql: Revert psql bits to display NOT VALID for FKs

2011-06-07 Thread Alvaro Herrera
Revert psql bits to display NOT VALID for FKs These are superseded by pg_get_constraintdef's ability to display the same when appropriate, which is a better place to do it anyway. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/135a507991c8ea9eca201cc084294a689ca24ba

[COMMITTERS] pgsql: Use "transient" files for blind writes

2011-06-09 Thread Alvaro Herrera
Use "transient" files for blind writes "Blind writes" are a mechanism to push buffers down to disk when evicting them; since they may belong to different databases than the one a backend is connected to, the backend does not necessarily have a relation to link them to, and thus no way to blow them

[COMMITTERS] pgsql: Revert "Use "transient" files for blind writes"

2011-06-09 Thread Alvaro Herrera
Revert "Use "transient" files for blind writes" This reverts commit 54d9e8c6c19cbefa8fb42ed3442a0a5327590ed3, which caused a failure on the buildfarm. Not a good thing to have just before a beta release. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9261557eb1e19c

Re: [COMMITTERS] pgsql: Use "transient" files for blind writes

2011-06-09 Thread Alvaro Herrera
Excerpts from Tom Lane's message of jue jun 09 17:05:11 -0400 2011: > Alvaro Herrera writes: > > Use "transient" files for blind writes > > The buildfarm doesn't like this patch at all. Please revert, as we > do not have time to debug it before beta2.

[COMMITTERS] pgsql: Use a constant sprintf format to silence compiler warning

2011-06-10 Thread Alvaro Herrera
Use a constant sprintf format to silence compiler warning Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3d114b63b253605eb60055c910aa2e55c98d5ed2 Modified Files -- src/backend/storage/file/fd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[COMMITTERS] pgsql: Use "transient" files for blind writes, take 2

2011-06-10 Thread Alvaro Herrera
Use "transient" files for blind writes, take 2 "Blind writes" are a mechanism to push buffers down to disk when evicting them; since they may belong to different databases than the one a backend is connected to, the backend does not necessarily have a relation to link them to, and thus no way to b

[COMMITTERS] pgsql: Add comment about pg_ctl stop

2011-06-10 Thread Alvaro Herrera
Add comment about pg_ctl stop Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d69149ed71cc4f073f222f11f702a20a6d279e0c Modified Files -- src/tools/pgindent/README |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) -- Sent via pgsql-committers m

[COMMITTERS] pgsql: Expand warnings on locks acquired by CREATE INDEX CONCURRENTLY

2011-06-13 Thread Alvaro Herrera
Expand warnings on locks acquired by CREATE INDEX CONCURRENTLY The previous wording wasn't explicit enough, which could misled readers into thinking that the locks acquired are more restricted in nature than they really are. The resulting optimism can be damaging to morale when confronted with re

[COMMITTERS] pgsql: Expand warnings on locks acquired by CREATE INDEX CONCURRENTLY

2011-06-13 Thread Alvaro Herrera
Expand warnings on locks acquired by CREATE INDEX CONCURRENTLY The previous wording wasn't explicit enough, which could misled readers into thinking that the locks acquired are more restricted in nature than they really are. The resulting optimism can be damaging to morale when confronted with re

[COMMITTERS] pgsql: Expand warnings on locks acquired by CREATE INDEX CONCURRENTLY

2011-06-13 Thread Alvaro Herrera
Expand warnings on locks acquired by CREATE INDEX CONCURRENTLY The previous wording wasn't explicit enough, which could misled readers into thinking that the locks acquired are more restricted in nature than they really are. The resulting optimism can be damaging to morale when confronted with re

[COMMITTERS] pgsql: Fix aboriginal copy-paste mistake in error message

2011-06-13 Thread Alvaro Herrera
Fix aboriginal copy-paste mistake in error message Spotted by Jaime Casanova Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/440a528fa6af9b7ea80b36b4038b3bf0655d54b5 Modified Files -- src/backend/catalog/pg_shdepend.c |3 +-- 1 files changed, 1

[COMMITTERS] pgsql: Fix aboriginal copy-paste mistake in error message

2011-06-13 Thread Alvaro Herrera
Fix aboriginal copy-paste mistake in error message Spotted by Jaime Casanova Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/a03f1d399dbfdc87798742329270d99962216100 Modified Files -- src/backend/catalog/pg_shdepend.c |3 +-- 1 files changed, 1

[COMMITTERS] pgsql: Fix aboriginal copy-paste mistake in error message

2011-06-13 Thread Alvaro Herrera
Fix aboriginal copy-paste mistake in error message Spotted by Jaime Casanova Branch -- REL8_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/8f1eaf884d71106c1516a8f7af4d7beee992da01 Modified Files -- src/backend/catalog/pg_shdepend.c |3 +-- 1 files changed, 1

[COMMITTERS] pgsql: Fix aboriginal copy-paste mistake in error message

2011-06-13 Thread Alvaro Herrera
Fix aboriginal copy-paste mistake in error message Spotted by Jaime Casanova Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8f59e023ef05d4f45e1c10a8bbc96bf8b4a96a89 Modified Files -- src/backend/catalog/pg_shdepend.c |3 +-- 1 files changed, 1 insert

[COMMITTERS] pgsql: Fix aboriginal copy-paste mistake in error message

2011-06-13 Thread Alvaro Herrera
Fix aboriginal copy-paste mistake in error message Spotted by Jaime Casanova Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/eca8674fca67ba3c8fad548bbeea9b0a7bf13bdf Modified Files -- src/backend/catalog/pg_shdepend.c |3 +-- 1 files changed, 1

[COMMITTERS] pgsql: Fix aboriginal copy-paste mistake in error message

2011-06-13 Thread Alvaro Herrera
Fix aboriginal copy-paste mistake in error message Spotted by Jaime Casanova Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/26b10ca6b85cd130ebd5aa86fe24626e00d6ce87 Modified Files -- src/backend/catalog/pg_shdepend.c |3 +-- 1 files changed, 1

[COMMITTERS] pgsql: Mention DROP TABLE as well as ALTER TABLE NO INHERIT

2011-06-14 Thread Alvaro Herrera
Mention DROP TABLE as well as ALTER TABLE NO INHERIT ... when talking about how good they are in replacement of bulk DELETE in partitioned setups. The original wording was a bit confusing. Per an observation from David Wheeler. Branch -- master Details --- http://git.postgresql.org/pg/

[COMMITTERS] pgsql: Mention DROP TABLE as well as ALTER TABLE NO INHERIT

2011-06-14 Thread Alvaro Herrera
Mention DROP TABLE as well as ALTER TABLE NO INHERIT ... when talking about how good they are in replacement of bulk DELETE in partitioned setups. The original wording was a bit confusing. Per an observation from David Wheeler. Branch -- REL9_0_STABLE Details --- http://git.postgresql.

[COMMITTERS] pgsql: Mention DROP TABLE as well as ALTER TABLE NO INHERIT

2011-06-14 Thread Alvaro Herrera
Mention DROP TABLE as well as ALTER TABLE NO INHERIT ... when talking about how good they are in replacement of bulk DELETE in partitioned setups. The original wording was a bit confusing. Per an observation from David Wheeler. Branch -- REL9_1_STABLE Details --- http://git.postgresql.

[COMMITTERS] pgsql: Fix grammatical mistake introduced by previous commit

2011-06-14 Thread Alvaro Herrera
Fix grammatical mistake introduced by previous commit Per note from Tom Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/808aa18b3cc87d81fb5640db0635a8d3db2bad52 Modified Files -- doc/src/sgml/ddl.sgml |2 +- 1 files changed, 1 insertions(+), 1

[COMMITTERS] pgsql: Fix grammatical mistake introduced by previous commit

2011-06-14 Thread Alvaro Herrera
Fix grammatical mistake introduced by previous commit Per note from Tom Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/a2b354afb603ad9b1e527ed6e2f7180271f97fa2 Modified Files -- doc/src/sgml/ddl.sgml |2 +- 1 files changed, 1 insertions(+), 1

[COMMITTERS] pgsql: Fix grammatical mistake introduced by previous commit

2011-06-14 Thread Alvaro Herrera
Fix grammatical mistake introduced by previous commit Per note from Tom Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8cfd59dd65fe992fda0358a4bdca9e610c624a3c Modified Files -- doc/src/sgml/ddl.sgml |2 +- 1 files changed, 1 insertions(+), 1 deletio

[COMMITTERS] pgsql: Fix typo

2011-06-16 Thread Alvaro Herrera
Fix typo Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/bd8137ee117601f93fcd9870e019b3069387a8a2 Modified Files -- src/backend/catalog/heap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (

[COMMITTERS] pgsql: Fix typo

2011-06-16 Thread Alvaro Herrera
Fix typo Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f3008c31f02948290f2edde9c39dc83371acbab9 Modified Files -- src/backend/catalog/heap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-c

[COMMITTERS] pgsql: Remove extra copying of TupleDescs for heap_create_with_catalog

2011-06-20 Thread Alvaro Herrera
Remove extra copying of TupleDescs for heap_create_with_catalog Some callers were creating copies of tuple descriptors to pass to that function, stating in code comments that it was necessary because it modified the passed descriptor. Code inspection reveals this not to be true, and indeed not al

[COMMITTERS] pgsql: Modernise pg_hba.conf token processing

2011-06-28 Thread Alvaro Herrera
. In passing, update historical artifacts in hba.c API. Authors: Brendan Jurd, Alvaro Herrera Reviewed by Pavel Stehule Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e5e2fc842c418432756d8b5825ff107c6c5fc4c3 Modified Files -- src/backend/libpq/auth.c

[COMMITTERS] pgsql: Remove rel.h from objectaddress.h; only relcache.h is necessary.

2011-06-28 Thread Alvaro Herrera
Remove rel.h from objectaddress.h; only relcache.h is necessary. Add rel.h to some files that now need it. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6f3efa76b042cdc457dba5bf8d8257f3ae83fb10 Modified Files -- contrib/dummy_seclabel/dummy_seclabel.c

[COMMITTERS] pgsql: Fix outdated comment

2011-06-29 Thread Alvaro Herrera
Fix outdated comment Extracted from a patch by Bernd Helmle Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b36927fbe922d1aac5d6e42c04eecf65bf37f5f3 Modified Files -- src/backend/parser/parse_utilcmd.c |4 ++-- 1 files changed, 2 insertions(+), 2 dele

[COMMITTERS] pgsql: Enable CHECK constraints to be declared NOT VALID

2011-06-30 Thread Alvaro Herrera
Enable CHECK constraints to be declared NOT VALID This means that they can initially be added to a large existing table without checking its initial contents, but new tuples must comply to them; a separate pass invoked by ALTER TABLE / VALIDATE can verify existing data and ensure it complies with

[COMMITTERS] pgsql: Don't try to use a constraint name as domain name

2011-07-04 Thread Alvaro Herrera
Don't try to use a constraint name as domain name The bug that caused this to be discovered is that the code was trying to dereference a NULL or ill-defined pointer, as reported by Michael Mueller; but what it was doing was wrong anyway, per Heikki. This patch is Heikki's suggested fix. Branch -

[COMMITTERS] pgsql: Move Trigger and TriggerDesc structs out of rel.h into a new rel

2011-07-04 Thread Alvaro Herrera
Move Trigger and TriggerDesc structs out of rel.h into a new reltrigger.h This lets us stop including rel.h into execnodes.h, which is a widely used header. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b93f5a5673b4bb09e14eb80fe28aa21fc20a6271 Modified Files -

[COMMITTERS] pgsql: Add support for blocked commands in isolationtester

2011-07-12 Thread Alvaro Herrera
Add support for blocked commands in isolationtester This enables us to test that blocking commands (such as foreign keys checks that conflict with some other lock) act as intended. The set of tests that this adds is pretty minimal, but can easily be extended by adding new specs. The intention is

[COMMITTERS] pgsql: Blind attempt at fixing isolation_tester on Win32

2011-07-12 Thread Alvaro Herrera
Blind attempt at fixing isolation_tester on Win32 Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0d29c375cc33a7b5a51ef1cb66ff9d7af1f7dfff Modified Files -- src/tools/msvc/Mkvcbuild.pm |1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- Sent v

[COMMITTERS] pgsql: Fix broken markup

2011-07-14 Thread Alvaro Herrera
Fix broken markup Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c529f8800e33bc969a9e5ce18294930837f279a2 Modified Files -- doc/src/sgml/information_schema.sgml |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) -- Sent via pgsql-committers m

[COMMITTERS] pgsql: Set different deadlock_timeout on each session in new isolation

2011-07-15 Thread Alvaro Herrera
Set different deadlock_timeout on each session in new isolation tests This provides deterministic deadlock-detection ordering for new isolation tests, fixing the sporadic failures in them. Author: Noah Misch Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d71197cd35

[COMMITTERS] pgsql: Add expected regress output on stricter isolation levels

2011-07-19 Thread Alvaro Herrera
Add expected regress output on stricter isolation levels These new files allow the new FK tests on isolationtester to pass on the serializable and repeatable read isolation levels (which are untested by the buildfarm). Author: Kevin Grittner Reviewed by Noah Misch Branch -- master Details -

[COMMITTERS] pgsql: Make isolationtester more robust on locked commands

2011-07-19 Thread Alvaro Herrera
Make isolationtester more robust on locked commands Noah Misch diagnosed the buildfarm problems in the isolation tests partly as failure to differentiate backends properly; the old code was using backend IDs, which is not good enough because a new backend might use an already used ID. Use PIDs in

[COMMITTERS] pgsql: Increase deadlock_timeout to 100ms in FK isolation tests

2011-07-19 Thread Alvaro Herrera
Increase deadlock_timeout to 100ms in FK isolation tests The previous value of 20ms is dangerously close to the time actually spent just waiting for the deadlock to happen, so on occasion it causes the test to fail simply because the other session didn't get to run early enough, not managing to ca

Re: [COMMITTERS] pgsql: In documentaiton, clarify which commands have reduced WAL volume

2011-08-04 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of jue ago 04 12:07:15 -0400 2011: > In documentaiton, clarify which commands have reduced WAL volume for > wal_level = minimum. Sorry that I misled you -- my tags were just an example, I wasn't trying to imply that the markup was correct. (A quick make check

Re: [COMMITTERS] pgsql: Properly handle empty arrays returned from plperl functions.

2011-08-17 Thread Alvaro Herrera
Excerpts from Andrew Dunstan's message of mié ago 17 12:41:47 -0400 2011: > > Wow, sorry for the noise. I guess I'll be more careful about reusing a > commit-message file. Happened to me once too (back when we used CVS). It seems the filter to remove unwanted lines is not applied when the file

[COMMITTERS] pgsql: Update FK alternative test output to new whitespace rules

2011-08-24 Thread Alvaro Herrera
Update FK alternative test output to new whitespace rules With these changes, the isolation tests pass again on isolation levels serializable and repeatable read. Author: Kevin Grittner Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f18795e7b74c3c67fb65f253562f241f

[COMMITTERS] pgsql: Add expected isolationtester output when prepared xacts are disa

2011-08-25 Thread Alvaro Herrera
Add expected isolationtester output when prepared xacts are disabled This was deemed unnecessary initially but in later discussion it was agreed otherwise. Original file from Kevin Grittner, allegedly from Dan Ports. I had to clean up whitespace a bit per changes from Heikki. Branch -- REL9_

[COMMITTERS] pgsql: Add expected isolationtester output when prepared xacts are disa

2011-08-25 Thread Alvaro Herrera
Add expected isolationtester output when prepared xacts are disabled This was deemed unnecessary initially but in later discussion it was agreed otherwise. Original file from Kevin Grittner, allegedly from Dan Ports. I had to clean up whitespace a bit per changes from Heikki. Branch -- maste

Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge

2011-09-02 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of vie sep 02 12:20:50 -0300 2011: > The only other idea I have is to try the attached patch which changes > the offsetof() call to mention a struct field name, and not the first > element of the field. However, I see other uses of accessing the > element of

[COMMITTERS] pgsql: Mark some untranslatable messages with errmsg_internal

2011-09-05 Thread Alvaro Herrera
Mark some untranslatable messages with errmsg_internal Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b64f18c583675684766e364754bd3c9f702c549d Modified Files -- src/backend/access/transam/xlog.c | 56 1 files changed

[COMMITTERS] pgsql: Mark some untranslatable messages with errmsg_internal

2011-09-05 Thread Alvaro Herrera
Mark some untranslatable messages with errmsg_internal Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/c729082da46c615e663e7c7f996baff1c4c3d560 Modified Files -- src/backend/access/transam/xlog.c | 56 1 files

[COMMITTERS] pgsql: Adjust translator comment format to xgettext expectations

2011-09-05 Thread Alvaro Herrera
Adjust translator comment format to xgettext expectations Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/7dc956fee3284170db50c343bad9f52cf767894b Modified Files -- src/backend/access/transam/xlog.c |7 +++ src/backend/catalog/dependency.c

[COMMITTERS] pgsql: Adjust translator comment format to xgettext expectations

2011-09-05 Thread Alvaro Herrera
Adjust translator comment format to xgettext expectations Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/56a9ed92b664af191040d848ca923fb3234671ee Modified Files -- src/backend/access/transam/xlog.c |7 +++ src/backend/catalog/dependency.c | 22

[COMMITTERS] pgsql: Tweak string for uniformity

2011-09-08 Thread Alvaro Herrera
Tweak string for uniformity Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/295e7dc929c346d53e0b55aaed539b0b0d59059f Modified Files -- src/backend/replication/basebackup.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-com

[COMMITTERS] pgsql: Split walsender.h in public/private headers

2011-09-13 Thread Alvaro Herrera
Split walsender.h in public/private headers This dramatically cuts short the number of headers the public one brings into whatever includes it. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/86822df9b5d5fe16d2528c7fc9428137414faa4f Modified Files -- src

[COMMITTERS] pgsql: Fix typo

2011-09-27 Thread Alvaro Herrera
Fix typo Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/173499273804f137bbb4a6785d6967b9e2d7e478 Modified Files -- src/test/isolation/isolationtester.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers mailing lis

[COMMITTERS] pgsql: Remove dependency on error ordering in isolation tests

2011-09-27 Thread Alvaro Herrera
Remove dependency on error ordering in isolation tests We now report errors reported by the just-unblocked and unblocking transactions identically; this should fix relatively common buildfarm failures reported by animals that are failing the "wrong" session. Branch -- master Details ---

[COMMITTERS] pgsql: Use callbacks in SlruScanDirectory for the actual action

2011-10-04 Thread Alvaro Herrera
Use callbacks in SlruScanDirectory for the actual action Previously, the code assumed that the only possible action to take was to delete files behind a certain cutoff point. The async notify code was already a crock: it used a different "pagePrecedes" function for truncation than for regular ope

[COMMITTERS] pgsql: Add debugging aid in isolationtester

2011-10-24 Thread Alvaro Herrera
Add debugging aid in isolationtester Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/90d8e8ff7ee94283270cc7b2bc6a986a7cd174fc Modified Files -- src/test/isolation/isolationtester.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- Sent vi

[COMMITTERS] pgsql: Implement a dry-run mode for isolationtester

2011-11-03 Thread Alvaro Herrera
Implement a dry-run mode for isolationtester This mode prints out the permutations that would be run by the given spec file, in the same format used by the permutation lines in spec files. This helps in building new spec files. Author: Alexander Shulgin, with some tweaks by me Branch -- mas

[COMMITTERS] pgsql: Unbreak isolationtester on Win32

2011-11-03 Thread Alvaro Herrera
Unbreak isolationtester on Win32 I broke it in a previous commit because I neglected to install the necessary incantations to have getopt() work on Windows. Per red blots in buildfarm. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e145891c984540a86788f88b604c766c9

[COMMITTERS] pgsql: Don't quote language name

2011-11-17 Thread Alvaro Herrera
Don't quote language name It's been deprecated for ages according to Tom, and it breaks now given the previous patch anyway. Per buildfarm Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b44dda715884487b92f14a0ea4addeaf163af802 Modified Files -- contrib

[COMMITTERS] pgsql: Don't quote language name

2011-11-17 Thread Alvaro Herrera
Don't quote language name Same as previous patch, but give it actual thought this time Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ef27c81d891da7c66740da305c7ec4e5bd584607 Modified Files -- contrib/isn/isn--1.0.sql | 82 ++

Re: [COMMITTERS] pgsql: Don't quote language name

2011-11-17 Thread Alvaro Herrera
Excerpts from Thom Brown's message of jue nov 17 18:33:40 -0300 2011: > On 17 November 2011 21:30, Alvaro Herrera wrote: > > Don't quote language name > > > > It's been deprecated for ages according to Tom, and it breaks now given > > the previous patch

  1   2   3   4   5   6   7   8   9   10   >