[COMMITTERS] pgsql: Unbreak regression tests, apparently broken by commit 4c8e20f

2011-01-11 Thread Andrew Dunstan
Unbreak regression tests, apparently broken by commit 4c8e20f Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=b7a0b42641e764a1e4abc39cc4311b5c779f5955 Modified Files -- src/test/regress/expected/rules.out |2 +- 1 files changed

[COMMITTERS] pgsql: Silence flex warnings about DOS file paths in MSVC builds

2011-01-23 Thread Andrew Dunstan
Silence flex warnings about DOS file paths in MSVC builds Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=6c41cf5977ca3f13159b980d4b216e3bc9df90e8 Modified Files -- src/tools/msvc/pgflex.bat |3 +++ 1 files changed, 3 insertion

[COMMITTERS] pgsql: Enable building with the Mingw64 compiler.

2011-01-30 Thread Andrew Dunstan
Enable building with the Mingw64 compiler. This can be used to build 64 bit Windows binaries, not only on 64 bit Windows but on supported cross-compiling hosts including 32 bit Windows, Cygwin, Darwin and Linux. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.g

[COMMITTERS] pgsql: Fix typo

2011-01-30 Thread Andrew Dunstan
Fix typo Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=48c9de80283d4bbdf9bec2f2f929b23f1676f8f9 Modified Files -- src/include/port/win32.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committer

Re: [COMMITTERS] pgsql: Enable building with the Mingw64 compiler.

2011-01-30 Thread Andrew Dunstan
On 01/30/2011 08:10 PM, Tom Lane wrote: Andrew Dunstan writes: Enable building with the Mingw64 compiler. +#if defined(_WIN32_WINNT)&& _WIN32_WINNT< 0x0501 +#undefine _WIN32_WINNT +#endif Umm ... surely "#undefine" is a typo? Darn,

[COMMITTERS] pgsql: Update docs on building for Windows to accomodate current realit

2011-01-31 Thread Andrew Dunstan
Update docs on building for Windows to accomodate current reality. Document how to build 64 bit Windows binaries using the MinGW64 tool set. Remove recommendation against using Mingw as a build platform. Be more specific about when Cygwin is useful and when it's not, in particular note its useful

[COMMITTERS] pgsql: Set up PLPerl trigger data using C code instead of Perl code.

2011-02-01 Thread Andrew Dunstan
Set up PLPerl trigger data using C code instead of Perl code. This is an efficiency change, and means we now no longer have to run "out $_TD; local $_TD = shift;", which was especially pointless in the case of non-trigger functions where the passed value was always undef anyway. A tiny open issue

[COMMITTERS] pgsql: Add comment on why we're passing a useless 'false' to the plper

2011-02-02 Thread Andrew Dunstan
Add comment on why we're passing a useless 'false' to the plperl function compiler. It's for compatibility with modules like PostgreSQL::PLPerl::NYTProf. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=c73fe72e2735d20aa132640d8fab4e0eca1ced

Re: [COMMITTERS] pgsql: Wrap PL/Python SPI calls into subtransactions

2011-02-02 Thread Andrew Dunstan
On 02/02/2011 03:09 PM, Peter Eisentraut wrote: Wrap PL/Python SPI calls into subtransactions This allows the language-specific try/catch construct to catch and handle exceptions arising from SPI calls, matching the behavior of other PLs. As an additional bonus you no longer get all the ugly

[COMMITTERS] pgsql: Attempt to unbreak MSVC builds after pipe.c move.

2011-02-04 Thread Andrew Dunstan
Attempt to unbreak MSVC builds after pipe.c move. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=895ad83d702ed821f72ec7bdf1fba3db7da9d9d7 Modified Files -- src/tools/msvc/Mkvcbuild.pm |3 ++- 1 files changed, 2 insertions(+),

[COMMITTERS] pgsql: Force strings passed to and from plperl to be in UTF8 encoding.

2011-02-06 Thread Andrew Dunstan
Force strings passed to and from plperl to be in UTF8 encoding. String are converted to UTF8 on the way into perl and to the database encoding on the way back. This avoids a number of observed anomalies, and ensures Perl a consistent view of the world. Some minor code cleanups are also accomplish

[COMMITTERS] pgsql: Supply now required HeUTF8 macro for plperl where it's missing,

2011-02-06 Thread Andrew Dunstan
Supply now required HeUTF8 macro for plperl where it's missing, per buildfarm results. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=c852e95b0bcbe708ba64b9499e50b9cc98bd7b71 Modified Files -- src/pl/plperl/plperl.h |7 +

[COMMITTERS] pgsql: Use correct name and URL for MinGW-w64, error noticed by Gurjeet

2011-02-10 Thread Andrew Dunstan
Use correct name and URL for MinGW-w64, error noticed by Gurjeet Singh. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2ad0348677aebe36260b30fee22892e6519ee7d8 Modified Files -- doc/src/sgml/install-windows.sgml |2 +- doc/src/sgml/installation.sgml

Re: [COMMITTERS] pgsql: Use $INDENT rather than indent throughout the pgindent code

2011-02-17 Thread Andrew Dunstan
On 02/17/2011 08:23 PM, Alvaro Herrera wrote: Use $INDENT rather than indent throughout the pgindent code +INDENT=`which indent` How universally available is "which"? cheers andrew -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subs

Re: [COMMITTERS] pgsql: Use $INDENT rather than indent throughout the pgindent code

2011-02-18 Thread Andrew Dunstan
On 02/18/2011 10:44 AM, Alvaro Herrera wrote: What would actually be useful here is a convenient way to override the script's default value of INDENT, but this coding doesn't offer that. I'd suggest something more like if [ -z "$INDENT" ]; then INDENT=indent fi ... this is certainly bet

Re: [COMMITTERS] pgsql: Fix doc patch --- pg_options_to_table() returns "setof record".

2011-02-26 Thread Andrew Dunstan
On 02/26/2011 12:27 PM, Bruce Momjian wrote: Fix doc patch --- pg_options_to_table() returns "setof record". This doesn't strike me as terribly helpful. Why don't we document what sort of records it returns, since we know perfectly well?: andrew=# \df pg_options_to_table

Re: [COMMITTERS] pgsql: Fix doc patch --- pg_options_to_table() returns "setof record".

2011-02-26 Thread Andrew Dunstan
On 02/26/2011 12:53 PM, Bruce Momjian wrote: Andrew Dunstan wrote: On 02/26/2011 12:27 PM, Bruce Momjian wrote: Fix doc patch --- pg_options_to_table() returns "setof record". This doesn't strike me as terribly helpful. Why don't we document what sort of records it re

[COMMITTERS] pgsql: Add a configure check for Python.h if building with python.

2011-02-26 Thread Andrew Dunstan
Add a configure check for Python.h if building with python. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/42e5223648e7e56f8041bed329929dbd5529ea92 Modified Files -- configure| 148 ++ configure

Re: [COMMITTERS] pgsql: PL/Python custom SPI exceptions

2011-02-28 Thread Andrew Dunstan
On 02/28/2011 11:51 AM, Peter Eisentraut wrote: PL/Python custom SPI exceptions This provides a separate exception class for each error code that the backend defines, as well as the ability to get the SQLSTATE from the exception object. This appears to have broken vpath builds. See frogmo

[COMMITTERS] pgsql: Unbreak vpath builds broken by commit 474a42473adf9b18417242f1fc

2011-02-28 Thread Andrew Dunstan
Unbreak vpath builds broken by commit 474a42473adf9b18417242f1fc0691a857ec578b. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/57e9bda5ec6a032e1e6d51dad5e534a11669c6bf Modified Files -- src/pl/plpython/Makefile |2 +- 1 files changed, 1 insertions(+),

[COMMITTERS] pgsql: Fix plpython breakage detected on certain Fedora machines on bui

2011-03-01 Thread Andrew Dunstan
Fix plpython breakage detected on certain Fedora machines on buildfarm. Patch from Jan Urbański. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4c966d920fb75a5d0366b887c2ef28e6d87c1eda Modified Files -- src/pl/plpython/plpython.c |1 + 1 files change

[COMMITTERS] pgsql: Add a comment explaining the recent fix for plpython breakage in

2011-03-03 Thread Andrew Dunstan
Add a comment explaining the recent fix for plpython breakage in commit 4c966d9. Mostly text supplied by Jan Urbański. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/12bf602f3fe963a9d155778b9385186c3a0b5ed3 Modified Files -- src/pl/plpython/plpython.c |

[COMMITTERS] pgsql: Add PL extension files to MSVC Install procedure.

2011-03-05 Thread Andrew Dunstan
Add PL extension files to MSVC Install procedure. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a956b160261579ae2422b539ccf73d75684351fb Modified Files -- src/tools/msvc/Install.pm | 19 +++ 1 files changed, 19 insertions(+), 0 deletion

Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication.

2011-03-06 Thread Andrew Dunstan
On 03/06/2011 05:51 PM, Simon Riggs wrote: Efficient transaction-controlled synchronous replication. I'm glad this is in, but I thought we agreed NOT to call it "synchronous replication". cheers andrew -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make c

[COMMITTERS] pgsql: Use correct PATH separator for Cygwin in pg_regress.c.

2011-03-16 Thread Andrew Dunstan
Use correct PATH separator for Cygwin in pg_regress.c. This has been broken for years, and I'm not sure why it has not been noticed before, but now a very modern Cygwin breaks on it, and the fix is clearly correct. Backpatching to all live branches. Branch -- master Details --- http://gi

[COMMITTERS] pgsql: Use correct PATH separator for Cygwin in pg_regress.c.

2011-03-16 Thread Andrew Dunstan
Use correct PATH separator for Cygwin in pg_regress.c. This has been broken for years, and I'm not sure why it has not been noticed before, but now a very modern Cygwin breaks on it, and the fix is clearly correct. Backpatching to all live branches. Branch -- REL9_0_STABLE Details --- ht

[COMMITTERS] pgsql: Use correct PATH separator for Cygwin in pg_regress.c.

2011-03-16 Thread Andrew Dunstan
Use correct PATH separator for Cygwin in pg_regress.c. This has been broken for years, and I'm not sure why it has not been noticed before, but now a very modern Cygwin breaks on it, and the fix is clearly correct. Backpatching to all live branches. Branch -- REL8_4_STABLE Details --- ht

[COMMITTERS] pgsql: Use correct PATH separator for Cygwin in pg_regress.c.

2011-03-16 Thread Andrew Dunstan
Use correct PATH separator for Cygwin in pg_regress.c. This has been broken for years, and I'm not sure why it has not been noticed before, but now a very modern Cygwin breaks on it, and the fix is clearly correct. Backpatching to all live branches. Branch -- REL8_3_STABLE Details --- ht

[COMMITTERS] pgsql: Use correct PATH separator for Cygwin in pg_regress.c.

2011-03-16 Thread Andrew Dunstan
Use correct PATH separator for Cygwin in pg_regress.c. This has been broken for years, and I'm not sure why it has not been noticed before, but now a very modern Cygwin breaks on it, and the fix is clearly correct. Backpatching to all live branches. Branch -- REL8_2_STABLE Details --- ht

Re: [COMMITTERS] pgsql: Document the all-balls IPv6 address.

2011-03-18 Thread Andrew Dunstan
On 03/18/2011 06:41 PM, Bruce Momjian wrote: Document the all-balls IPv6 address. + 0.0.0.0/0 (all balls) represents all + IPv4 addresses, and :: represents + all IPv6 addresses. Umm, isn't there a missing netmask there? The IPv6 analog of 0.0.0.0/0 is surely ::/0 (or I would

Re: [COMMITTERS] pgsql: Raise maximum value of several timeout parameters

2011-03-18 Thread Andrew Dunstan
On 03/17/2011 02:25 PM, Peter Eisentraut wrote: Raise maximum value of several timeout parameters The maximum value of deadlock_timeout, max_standby_archive_delay, max_standby_streaming_delay, log_min_duration_statement, and log_autovacuum_min_duration was INT_MAX/1000 milliseconds, which is a

Re: [COMMITTERS] pgsql: Document the all-balls IPv6 address.

2011-03-18 Thread Andrew Dunstan
On 03/18/2011 09:18 PM, Robert Haas wrote: On Fri, Mar 18, 2011 at 6:56 PM, Andrew Dunstan wrote: +0.0.0.0/0 (all balls) represents all + IPv4 addresses, and:: represents + all IPv6 addresses. Umm, isn't there a missing netmask there? The IPv6 analog of 0.0.0.0/0 is s

[COMMITTERS] pgsql: Attempt to unbreak windows builds broken by commit 754baa2.

2011-03-30 Thread Andrew Dunstan
Attempt to unbreak windows builds broken by commit 754baa2. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/382fb6a08f524327b5e3084b3652fba2e12f1ba2 Modified Files -- src/backend/libpq/pqcomm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[COMMITTERS] pgsql: Avoid use of mixed slash style paths in arguments to xcopy in MS

2011-04-07 Thread Andrew Dunstan
Avoid use of mixed slash style paths in arguments to xcopy in MSVC builds. Some versions of xcopy, notably on Windows 7 don't like it. Backpatch to 8.3, where we first used xcopy. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a53112338c2f5b74383ce075fbec098cd06a3ad

[COMMITTERS] pgsql: Avoid use of mixed slash style paths in arguments to xcopy in MS

2011-04-07 Thread Andrew Dunstan
Avoid use of mixed slash style paths in arguments to xcopy in MSVC builds. Some versions of xcopy, notably on Windows 7 don't like it. Backpatch to 8.3, where we first used xcopy. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/a5c629f373a8125cd7682083a290fff4

[COMMITTERS] pgsql: Avoid use of mixed slash style paths in arguments to xcopy in MS

2011-04-07 Thread Andrew Dunstan
Avoid use of mixed slash style paths in arguments to xcopy in MSVC builds. Some versions of xcopy, notably on Windows 7 don't like it. Backpatch to 8.3, where we first used xcopy. Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/5fe33744432f7509a07bccef51d07be6

[COMMITTERS] pgsql: Avoid use of mixed slash style paths in arguments to xcopy in MS

2011-04-07 Thread Andrew Dunstan
Avoid use of mixed slash style paths in arguments to xcopy in MSVC builds. Some versions of xcopy, notably on Windows 7 don't like it. Backpatch to 8.3, where we first used xcopy. Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/502ff05209ad08c50eb4f7ef491ff4d8

[COMMITTERS] pgsql: Latest consolidated typedef list from buildfarm.

2011-04-08 Thread Andrew Dunstan
Latest consolidated typedef list from buildfarm. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/fe1438da8aa8a45f2cee816eb54841f97d3b2f22 Modified Files -- src/tools/pgindent/typedefs.list | 316 +- 1 files changed, 175

[COMMITTERS] pgsql: Backport changes to allow building with MinGW 64 bit compiler.

2011-04-09 Thread Andrew Dunstan
Backport changes to allow building with MinGW 64 bit compiler. These changes have been in HEAD for some time with no ill effect. They are only being backported to 9.0, as the required WINNT version was not high enough before that. Branch -- REL9_0_STABLE Details --- http://git.postgresql

[COMMITTERS] pgsql: Don't make "replication" magical as a user name, only as a datab

2011-04-10 Thread Andrew Dunstan
Don't make "replication" magical as a user name, only as a database name, in pg_hba.conf. Per gripe from Josh Berkus. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ed557a373c406bbb2a1843544ebbd856ca4cac47 Modified Files -- src/backend/libpq/hba.c |

Re: [COMMITTERS] pgsql: Adjust regression tests on cube and ECPG for MinGW 64 bit compil

2011-04-10 Thread Andrew Dunstan
On 04/10/2011 06:07 PM, Tom Lane wrote: Andrew Dunstan writes: Adjust regression tests on cube and ECPG for MinGW 64 bit compiler. This patch seems to have injected a pile of DOS line endings ... please fix. Oh, darnit. sorry. will do cheers andrew -- Sent

[COMMITTERS] pgsql: Remove CRLF line endings in new cube results file.

2011-04-10 Thread Andrew Dunstan
Remove CRLF line endings in new cube results file. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c1d82a936f6783f4b084810ff22ca01706f8054e Modified Files -- contrib/cube/expected/cube_3.out | 2256 +++--- 1 files changed, 1

[COMMITTERS] pgsql: Adjust regression tests on cube and ECPG for MinGW 64 bit compil

2011-04-10 Thread Andrew Dunstan
Adjust regression tests on cube and ECPG for MinGW 64 bit compiler. Backport to 9.0, we're not supporting this compiler on earlier releases. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/0e754ab366e9a200ef7342dc6ada42ae014a6739 Modified Files --

[COMMITTERS] pgsql: Adjust regression tests on cube and ECPG for MinGW 64 bit compil

2011-04-10 Thread Andrew Dunstan
Adjust regression tests on cube and ECPG for MinGW 64 bit compiler. Backport to 9.0, we're not supporting this compiler on earlier releases. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/210f95f1cd59c6fdfe0f84b922c19d8498ac377d Modified Files -- contri

[COMMITTERS] pgsql: Don't make "replication" magical as a user name, only as a datab

2011-04-12 Thread Andrew Dunstan
Don't make "replication" magical as a user name, only as a database name, in pg_hba.conf. Per gripe from Josh Berkus. Backported from commit ed557a373c406bbb2a1843544ebbd856ca4cac47. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/290bb9b61c64afdb7b733837c0a

[COMMITTERS] pgsql: Attempt to remedy buildfarm breakage caused by commit f536d4194.

2011-04-18 Thread Andrew Dunstan
Attempt to remedy buildfarm breakage caused by commit f536d4194. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b7b86924c6da46c774e1ab5d524a6bc4f72627ab Modified Files -- contrib/unaccent/Makefile |5 ++--- 1 files changed, 2 insertions(+), 3 deletion

[COMMITTERS] pgsql: Silence compiler warning about casting HANDLE to long on WIN64.

2011-04-19 Thread Andrew Dunstan
Silence compiler warning about casting HANDLE to long on WIN64. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ca5a75fbaed63f41c6e52e5d4b35470080356bdf Modified Files -- src/test/regress/pg_regress.c |8 +++- 1 files changed, 7 insertions(+), 1 de

Re: [HACKERS] Re: [COMMITTERS] pgsql: setlocale() on Windows doesn't work correctly if the locale name

2011-04-19 Thread Andrew Dunstan
On 04/19/2011 09:42 PM, Hiroshi Inoue wrote: > > bootstrap_template1() in initdb runs the BKI script in bootstrap > mode to create template1. Some symbols (LC_COLLATE, LC_CTYPE in > pg_database etc) in the BKI script are substituted by actual values > using replace_token(). Isn't it correct? > IS

[COMMITTERS] pgsql: Silence a few compiler warnings from gcc on MinGW.

2011-04-23 Thread Andrew Dunstan
Silence a few compiler warnings from gcc on MinGW. Most of these cast DWORD to int or unsigned int for printf type handling. This is safe even on 64 bit architectures because a DWORD is always 32 bits. In one case a variable is initialised to keep the compiler happy. Branch -- master Detail

[COMMITTERS] pgsql: Adjust yywrap macro for non-reentrant scanners for MSVC.

2011-04-25 Thread Andrew Dunstan
Adjust yywrap macro for non-reentrant scanners for MSVC. The MSVC compiler complains if a macro is called with less arguments than its definition provides for. flex generates a macro with one argument for yywrap, but only supplies the argument for reentrant scanners, so we remove the useless argum

[COMMITTERS] pgsql: Give getopt() a prototype and modern style arg specs.

2011-04-25 Thread Andrew Dunstan
Give getopt() a prototype and modern style arg specs. Welcome to the 1990s. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7e0f8f836da9a992c8cbd99c5c06ea40247d6a33 Modified Files -- src/port/getopt.c |7 +++ 1 files changed, 3 insertions(+), 4 de

[COMMITTERS] pgsql: Prevent perl header overriding our *snprintf macros, and give it

2011-04-25 Thread Andrew Dunstan
Prevent perl header overriding our *snprintf macros, and give it a usable PERL_UNUSED_DECL value. This quiets compiler warnings about redefined macros and unused Perl__unused variables. The redefinition of snprintf and vsnprintf is something we want to avoid anyway, if we've gone to the bother

[COMMITTERS] pgsql: Assorted minor changes to silence Windows compiler warnings.

2011-04-25 Thread Andrew Dunstan
Assorted minor changes to silence Windows compiler warnings. Mostly to do with macro redefinitions or object signedness. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/860be17ec3c19a1aeba0bbe7ecaf30be409ea446 Modified Files -- src/backend/main/main.c

[COMMITTERS] pgsql: Use terse mode to avoid variable order dependency output in fore

2011-04-25 Thread Andrew Dunstan
Use terse mode to avoid variable order dependency output in foreign data regression check. Per Tom Lane's suggestion about my gripe about occasional errors noticed on the buildfarm. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/625744ac43360ca3f4a6d3eccecb6f4c999

[COMMITTERS] pgsql: Use an explicit format string to keep the compiler happy.

2011-04-27 Thread Andrew Dunstan
Use an explicit format string to keep the compiler happy. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c43d0791ac5fb765a088d41564cd44747aef42d8 Modified Files -- src/backend/port/win32/security.c |6 +++--- 1 files changed, 3 insertions(+), 3 deleti

[COMMITTERS] pgsql: Force use of "%I64d" format for 64 bit ints on MinGW.

2011-04-27 Thread Andrew Dunstan
Force use of "%I64d" format for 64 bit ints on MinGW. Both this and "%lld" work, but the compiler's format checking doesn't like "%lld", so we get all sorts of spurious warnings. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/52d01c2f52c462d29ae0fdfa44c3cae129148a6d

[COMMITTERS] pgsql: Remove hard coded formats for INT64 and use configured settings

2011-04-27 Thread Andrew Dunstan
Remove hard coded formats for INT64 and use configured settings instead. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9b1508af8971c1627cda5bb65f5e9eddb9a1a55e Modified Files -- src/backend/postmaster/postmaster.c |2 +- src/interfaces/ecpg/ecpglib

[COMMITTERS] pgsql: Revert "Remove hard coded formats for INT64 and use configured s

2011-04-27 Thread Andrew Dunstan
Revert "Remove hard coded formats for INT64 and use configured settings instead." This reverts commit 9b1508af8971c1627cda5bb65f5e9eddb9a1a55e. As requested by Tom. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/348c10efe08f01872daeeb62f32c8e362fcbba69 Modified F

[COMMITTERS] pgsql: Revert "Force use of "%I64d" format for 64 bit ints on MinGW."

2011-04-27 Thread Andrew Dunstan
Revert "Force use of "%I64d" format for 64 bit ints on MinGW." This reverts commit 52d01c2f52c462d29ae0fdfa44c3cae129148a6d. the UINT64_FORMAT bit broke the b uildfarm, so I'm reverting the whole thing pending further investigation. Branch -- master Details --- http://git.postgresql.or

[COMMITTERS] pgsql: Use a macro variable PG_PRINTF_ATTRIBUTE for the style used for

2011-04-28 Thread Andrew Dunstan
Use a macro variable PG_PRINTF_ATTRIBUTE for the style used for checking printf type functions. The style is set to "printf" for backwards compatibility everywhere except on Windows, where it is set to "gnu_printf", which eliminates hundreds of false error messages from modern versions of gcc ari

[COMMITTERS] pgsql: Add some casts to try to silence most of the remaining format wa

2011-04-28 Thread Andrew Dunstan
Add some casts to try to silence most of the remaining format warnings on MinGW-W64. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ab0ba6e73ae9b3c9956126bdcd3c410238a27244 Modified Files -- src/backend/postmaster/postmaster.c |4 ++-- src/backend/po

[COMMITTERS] pgsql: Use non-literal format for possibly non-standard strftime format

2011-04-28 Thread Andrew Dunstan
Use non-literal format for possibly non-standard strftime formats. Per recent -hackers discussion. The formats in question are %G and %V, and cause warnings on MinGW at least. We assume the ecpg application knows what it's doing if it passes these formats to the library. Branch -- master Det

[COMMITTERS] pgsql: Build and run isolation test programs under MSVC.

2011-05-15 Thread Andrew Dunstan
Build and run isolation test programs under MSVC. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/840826e36cd40e63a3af05d9b41dc65250bc7a7a Modified Files -- src/tools/msvc/Mkvcbuild.pm | 22 ++ src/tools/msvc/pgbison.bat |1 + src

[COMMITTERS] pgsql: Add missing check function lookup.

2011-05-15 Thread Andrew Dunstan
Add missing check function lookup. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/20bacc9560b29b33b6cad4e53c6a77e6c8a71c5d Modified Files -- src/tools/msvc/vcregress.pl |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) -- Sent via pgsql-comm

[COMMITTERS] pgsql: Fix bad macro call noticed by MSVC compiler.

2011-05-15 Thread Andrew Dunstan
Fix bad macro call noticed by MSVC compiler. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ec645ef346d2de2fb889f6b8a8d2fc70a4ea4971 Modified Files -- src/test/regress/pg_regress.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via

[COMMITTERS] pgsql: Add required psqldir setting for isolation checks.

2011-05-15 Thread Andrew Dunstan
Add required psqldir setting for isolation checks. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/df15d11cb596fa69d7ffb27cf0b7b070c03ab381 Modified Files -- src/tools/msvc/vcregress.pl |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) --

[COMMITTERS] pgsql: Quote isolationtester command name so Windows will not think dot

2011-05-15 Thread Andrew Dunstan
Quote isolationtester command name so Windows will not think dot is the command. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/78b66cff72d6f337a685355f7ccede1c518681b5 Modified Files -- src/test/isolation/isolation_main.c |2 +- 1 files changed, 1 in

[COMMITTERS] pgsql: Use the right pgsql for isolation tests.

2011-05-22 Thread Andrew Dunstan
Use the right pgsql for isolation tests. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b08ddf8c761cd596c4664dde1125f38a8757756f Modified Files -- src/test/isolation/Makefile |5 - 1 files changed, 4 insertions(+), 1 deletions(-) -- Sent via pg

Re: [COMMITTERS] pgsql: Use the right pgsql for isolation tests.

2011-05-22 Thread Andrew Dunstan
On 05/22/2011 05:58 PM, Andrew Dunstan wrote: Use the right pgsql for isolation tests. Of course, this should say "Use the right psql ...". cheers andrew -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscrip

[COMMITTERS] pgsql: Remove spurious underscore in name of isolation tester on MSVC.

2011-05-22 Thread Andrew Dunstan
Remove spurious underscore in name of isolation tester on MSVC. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a9b6519606a4a95ae8052f8414841d02bcfe4582 Modified Files -- src/tools/msvc/Mkvcbuild.pm |2 +- src/tools/msvc/vcregress.pl |2 +- 2 files

[COMMITTERS] pgsql: Convert builddoc.bat into a perl script that actually works.

2011-05-24 Thread Andrew Dunstan
Convert builddoc.bat into a perl script that actually works. The old .bat file wasn't working for reasons that are unclear, and which it did not seem worth the trouble to ascertain. The new perl script has been tested and is known to work. Soon it will be tested regularly on the buildfarm. The .ba

[COMMITTERS] pgsql: Allow building with perl 5.14.

2011-06-04 Thread Andrew Dunstan
Allow building with perl 5.14. Patch from Alex Hunsaker. Branch -- REL8_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/f604891a06a6662502a2b13607308fef67e4257d Modified Files -- src/pl/plperl/plperl.c |2 +- src/pl/plperl/plperl.h |5 + 2 files change

[COMMITTERS] pgsql: Allow building with perl 5.14.

2011-06-04 Thread Andrew Dunstan
Allow building with perl 5.14. Patch from Alex Hunsaker. Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/8287c4f98ecf8f075064973d032f75ca8373c5c4 Modified Files -- src/pl/plperl/plperl.c |2 +- src/pl/plperl/plperl.h |5 + 2 files change

[COMMITTERS] pgsql: Allow building with perl 5.14.

2011-06-04 Thread Andrew Dunstan
Allow building with perl 5.14. Patch from Alex Hunsaker. Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/c985cf0d12d71b75721031252ab52c75d83492f3 Modified Files -- src/pl/plperl/plperl.c |2 +- src/pl/plperl/plperl.h |5 + 2 files change

[COMMITTERS] pgsql: Allow building with perl 5.14.

2011-06-04 Thread Andrew Dunstan
Allow building with perl 5.14. Patch from Alex Hunsaker. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/cb252c2acd415d304e3254e99f82058d11a69e04 Modified Files -- src/pl/plperl/plperl.c |2 +- src/pl/plperl/plperl.h |5 + 2 files change

[COMMITTERS] pgsql: Allow building with perl 5.14.

2011-06-04 Thread Andrew Dunstan
Allow building with perl 5.14. Patch from Alex Hunsaker. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ccd69b888641441b2332dc928ada1390dd0c318a Modified Files -- src/pl/plperl/plperl.c |2 +- src/pl/plperl/plperl.h |5 + 2 files changed, 6 in

Re: [COMMITTERS] pgsql: Mention "pg_ctl stop" in pgindent README instructions.

2011-06-09 Thread Andrew Dunstan
On 06/09/2011 08:51 PM, Bruce Momjian wrote: Mention "pg_ctl stop" in pgindent README instructions. This change make no sense at all. Why would you be running 'pg_ctl stop' when there is nothing to suggest that there's a postgres running. And even if there is there's not the slightest re

Re: [COMMITTERS] pgsql: Mention "pg_ctl stop" in pgindent README instructions.

2011-06-09 Thread Andrew Dunstan
On 06/09/2011 11:28 PM, Bruce Momjian wrote: Andrew Dunstan wrote: On 06/09/2011 08:51 PM, Bruce Momjian wrote: Mention "pg_ctl stop" in pgindent README instructions. This change make no sense at all. Why would you be running 'pg_ctl stop' when there is nothing to su

[COMMITTERS] pgsql: Define FLEXIBLE_ARRAY_MEMBER for MSVC.

2011-06-16 Thread Andrew Dunstan
Define FLEXIBLE_ARRAY_MEMBER for MSVC. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/236a11dc65906cc200bce4e6db26d20b299cd1b0 Modified Files -- src/include/pg_config.h.win32 |9 + 1 files changed, 9 insertions(+), 0 deletions(-) -- Sent vi

Re: [COMMITTERS] pgsql: Define FLEXIBLE_ARRAY_MEMBER for MSVC.

2011-06-17 Thread Andrew Dunstan
On 06/17/2011 05:40 PM, Tom Lane wrote: Andrew Dunstan writes: Define FLEXIBLE_ARRAY_MEMBER for MSVC. I just noticed that you set the value to 1 not empty. Surely MSVC is modern enough to have this feature? Maybe. I'll check. cheers andrew -- Sent via

[COMMITTERS] pgsql: Set FLEXIBLE_ARRAY_MEMBER to empty for MSVC.

2011-06-17 Thread Andrew Dunstan
Set FLEXIBLE_ARRAY_MEMBER to empty for MSVC. Per gripe from Tom Lane. I have tested this with VC 2008, and assume it will work with earlier versions. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ddef31c15c663626fc1804467f4c2ce420598796 Modified Files

Re: [COMMITTERS] pgsql: Branch refs/heads/REL9_1_STABLE was removed

2011-06-25 Thread Andrew Dunstan
On 06/25/2011 07:07 PM, Joe Conway wrote: On 06/25/2011 04:02 PM, pg...@postgresql.org wrote: Branch refs/heads/REL9_1_STABLE was removed. Umm, I was trying to follow the directions here: http://wiki.postgresql.org/wiki/Committing_with_Git: Making a new release branch and it messed up my loc

Re: [COMMITTERS] pgsql: Branch refs/heads/REL9_1_STABLE was removed

2011-06-28 Thread Andrew Dunstan
On 06/28/2011 01:49 AM, Magnus Hagander wrote: On Sun, Jun 26, 2011 at 02:00, Joe Conway wrote: On 06/25/2011 04:44 PM, Andrew Dunstan wrote: On 06/25/2011 07:07 PM, Joe Conway wrote: On 06/25/2011 04:02 PM, pg...@postgresql.org wrote: Branch refs/heads/REL9_1_STABLE was removed. Umm, I

[COMMITTERS] pgsql: Fix bat file quoting of %ENV.

2011-07-03 Thread Andrew Dunstan
Fix bat file quoting of %ENV. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/19b7fac86d85c89f2c9173906722da70c6eebad2 Modified Files -- src/tools/msvc/install.bat |2 +- src/tools/msvc/pgbison.bat |2 +- src/tools/msvc/pgflex.bat |2 +- 3 files

[COMMITTERS] pgsql: Back-patch Fix bat file quoting of %ENV from commit 19b7fac8.

2011-07-04 Thread Andrew Dunstan
Back-patch Fix bat file quoting of %ENV from commit 19b7fac8. Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/ad3aa1ee14567d64ba0eb71025a7ca76c799a2c2 Modified Files -- src/tools/msvc/builddoc.bat |2 +- src/tools/msvc/install.bat |2 +- src

[COMMITTERS] pgsql: Back-patch Fix bat file quoting of %ENV from commit 19b7fac8.

2011-07-04 Thread Andrew Dunstan
Back-patch Fix bat file quoting of %ENV from commit 19b7fac8. Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/a9ebf827355986416c3e6b6fd915364df22cbc03 Modified Files -- src/tools/msvc/builddoc.bat |2 +- src/tools/msvc/install.bat |2 +- src

[COMMITTERS] pgsql: Back-patch Fix bat file quoting of %ENV from commit 19b7fac8.

2011-07-04 Thread Andrew Dunstan
Back-patch Fix bat file quoting of %ENV from commit 19b7fac8. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/1e8b78e521e2dc12bd1fd5831e5b9b427a07e70c Modified Files -- src/tools/msvc/builddoc.bat |2 +- src/tools/msvc/install.bat |2 +- src

[COMMITTERS] pgsql: Back-patch Fix bat file quoting of %ENV from commit 19b7fac8.

2011-07-04 Thread Andrew Dunstan
Back-patch Fix bat file quoting of %ENV from commit 19b7fac8. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/ffc50e134a7e67bc48bf512a4bb681d46cc1fe31 Modified Files -- src/tools/msvc/install.bat |2 +- src/tools/msvc/pgbison.bat |2 +- src/t

[COMMITTERS] pgsql: Reimplement pgbison and pgflex as perl scripts instead of bat fi

2011-07-06 Thread Andrew Dunstan
Reimplement pgbison and pgflex as perl scripts instead of bat files. In the process, remove almost all knowledge of individual .y and .l files, and instead get invocation settings from the relevant make files. The exception is plpgsql's gram.y, which has a target with a different name. It is hoped

pgsql-committers@postgresql.org

2011-07-07 Thread Andrew Dunstan
Fix comments over eagerly c&p'd. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b2e3be41a604a36d6586c6e24d93349ca098f0c3 Modified Files -- src/tools/msvc/pgbison.bat |2 +- src/tools/msvc/pgflex.bat |2 +- 2 files changed, 2 insertions(+), 2 delet

[COMMITTERS] pgsql: Improve wording of documentation on default privileges.

2011-07-11 Thread Andrew Dunstan
Improve wording of documentation on default privileges. Per recent -hackers discussion. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/75726307e6164673c48d6ce1d143a075b8ce18fa Modified Files -- doc/src/sgml/ref/grant.sgml | 19 ++- 1 fi

[COMMITTERS] pgsql: Unbreak Windows builds broken by EDITOR_LINENUMBER_ARG change.

2011-07-23 Thread Andrew Dunstan
Unbreak Windows builds broken by EDITOR_LINENUMBER_ARG change. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e399eb74d96270bf1d4a0bb9f4503cac3d90c1e2 Modified Files -- src/bin/psql/command.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -

[COMMITTERS] pgsql: Unbreak Windows builds broken by EDITOR_LINENUMBER_ARG change.

2011-07-23 Thread Andrew Dunstan
Unbreak Windows builds broken by EDITOR_LINENUMBER_ARG change. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/552a5c73e08b74968a5f1591c5f09dc8f519a173 Modified Files -- src/bin/psql/command.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

Re: [COMMITTERS] pgsql: Improve libpq's error reporting for SSL failures.

2011-07-24 Thread Andrew Dunstan
On 07/24/2011 04:29 PM, Tom Lane wrote: Improve libpq's error reporting for SSL failures. In many cases, pqsecure_read/pqsecure_write set up useful error messages, which were then overwritten with useless ones by their callers. Fix this by defining the responsibility to set an error message t

[COMMITTERS] pgsql: Silence compiler warning about uninitialized variable.

2011-07-25 Thread Andrew Dunstan
Silence compiler warning about uninitialized variable. It is set correctly on the only path that uses it, but the compiler can't know that. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/74e6d37276564d4be1f60d9edb76d7d066395773 Modified Files -- src/bac

[COMMITTERS] pgsql: Don't build replacement getpeereid function on mingw.

2011-07-25 Thread Andrew Dunstan
Don't build replacement getpeereid function on mingw. Windows doesn't have Unix sockets, so it's not needed, and moreover causes compile warnings. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c9737310d5f9b87b5edb3674b5d34eea2f198a0b Modified Files --

[COMMITTERS] pgsql: Don't build replacement getpeereid function on mingw.

2011-07-25 Thread Andrew Dunstan
Don't build replacement getpeereid function on mingw. Windows doesn't have Unix sockets, so it's not needed, and moreover causes compile warnings. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/5c70cc890dfadb4579c8e96c4b27cce285e75cfc Modified Files ---

[COMMITTERS] pgsql: Restore the primacy of postgres.h in plpython.c.

2011-08-04 Thread Andrew Dunstan
Restore the primacy of postgres.h in plpython.c. To avoid having the python headers hijack various definitions, we now include them after all the system headers we want, having first undefined some of the things they want to define. After that's done we restore the things they scribbled on that ma

[COMMITTERS] pgsql: Correct the lie in pg_config.h.win32 about having inttypes.h.

2011-08-08 Thread Andrew Dunstan
Correct the lie in pg_config.h.win32 about having inttypes.h. This lie has been harmless until now, but has been exposed by the change to include postgres.h before the python headers, which in some versions include inttypes.h if HAVE_INTTYPES_H is set. Branch -- master Details --- http:/

[COMMITTERS] pgsql: Properly handle empty arrays returned from plperl functions.

2011-08-17 Thread Andrew Dunstan
Properly handle empty arrays returned from plperl functions. Bug reported by David Wheeler, fix by Alex Hunsaker. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # On branch master # Changes to be committed: #

  1   2   3   4   5   6   7   8   9   10   >