Re: [COMMITTERS] pgsql: Handle carriage returns and line feeds in COPY

2005-03-13 Thread Andrew Dunstan
Bruce Momjian said: Neil Conway wrote: Bruce Momjian wrote: Handle carriage returns and line feeds in COPY CSV mode. Would it be possible to have some regression tests for this? Yep, Andrew? Sure. I'll turn my test script into a regression test. cheers] andrew

[COMMITTERS] pgsql: Add a note about CSV lines with trailing spaces.

2005-09-05 Thread Andrew Dunstan
Log Message: --- Add a note about CSV lines with trailing spaces. Suggestion by Darcy Buskermolen, reworded by me. Modified Files: -- pgsql/doc/src/sgml/ref: copy.sgml (r1.66 - r1.67)

[COMMITTERS] pgsql: fix nonsensical summary row on example

2005-10-14 Thread Andrew Dunstan
Log Message: --- fix nonsensical summary row on example Modified Files: -- pgsql/doc/src/sgml: xfunc.sgml (r1.104 - r1.105) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/xfunc.sgml.diff?r1=1.104r2=1.105) ---(end

[COMMITTERS] pgsql: replace use of predefined perl vars $a and $b with $x and $y -

2005-10-18 Thread Andrew Dunstan
Log Message: --- replace use of predefined perl vars $a and $b with $x and $y - per Greg Sabino Mullane Modified Files: -- pgsql/doc/src/sgml: plperl.sgml (r2.46 - r2.47)

Re: [COMMITTERS] pgsql: Code review for spi_query/spi_fetchrow patch:

2005-10-19 Thread Andrew Dunstan
Tom Lane wrote: David Fetter [EMAIL PROTECTED] writes: On Tue, Oct 18, 2005 at 02:13:14PM -0300, Tom Lane wrote: Log Message: --- Code review for spi_query/spi_fetchrow patch: handle errors sanely, avoid leaking memory. I would add a regression test for error handling

[COMMITTERS] pgsql: minor code cleanup - replace useless struct timezone argument to

2005-10-22 Thread Andrew Dunstan
Log Message: --- minor code cleanup - replace useless struct timezone argument to gettimeofday with NULL in a few places, making it consistent with usage elsewhere. Modified Files: -- pgsql/src/backend/postmaster: postmaster.c (r1.471 - r1.472)

[COMMITTERS] pgsql: Fix incorrect wording about function failure time on unsafe ops

2005-10-24 Thread Andrew Dunstan
Log Message: --- Fix incorrect wording about function failure time on unsafe ops - these are now caught by the validator. And a small visit from the perl style police: check the return value from open(). Modified Files: -- pgsql/doc/src/sgml: plperl.sgml (r2.47 -

[COMMITTERS] pgsql: Provide a --no-locale option for pg_regress and a corresponding

2005-11-01 Thread Andrew Dunstan
Log Message: --- Provide a --no-locale option for pg_regress and a corresponding NOLOCALE=1 setting for the regression makefile, allowing Windows users to force locale settings since Windows does not get its locale from the environment. Per Petr Jelinek. Modified Files: --

[COMMITTERS] pgsql: Provide a --no-locale option for pg_regress and a corresponding

2005-11-01 Thread Andrew Dunstan
Log Message: --- Provide a --no-locale option for pg_regress and a corresponding NOLOCALE=1 setting for the regression makefile, allowing Windows users to force locale settings since Windows does not get its locale from the environment. Per Petr Jelinek. Tags: REL8_0_STABLE

[COMMITTERS] pgsql: add missing quote mark to ident_file sample line - per Hiroshi

2005-11-10 Thread Andrew Dunstan
Log Message: --- add missing quote mark to ident_file sample line - per Hiroshi Saito Modified Files: -- pgsql/src/backend/utils/misc: postgresql.conf.sample (r1.169 - r1.170)

[COMMITTERS] pgsql: add missing quote mark to ident_file sample line - per Hiroshi

2005-11-10 Thread Andrew Dunstan
Log Message: --- add missing quote mark to ident_file sample line - per Hiroshi Saito Tags: REL8_1_STABLE Modified Files: -- pgsql/src/backend/utils/misc: postgresql.conf.sample (r1.168.2.1 - r1.168.2.2)

[COMMITTERS] pgsql: make psql honor explicit database parameter in -l mode, in case

2005-11-17 Thread Andrew Dunstan
Log Message: --- make psql honor explicit database parameter in -l mode, in case postgres database is missing - per complaint from Philip Yarra. Modified Files: -- pgsql/src/bin/psql: startup.c (r1.126 - r1.127)

[COMMITTERS] pgsql: make psql honor explicit database parameter in -l mode, in case

2005-11-17 Thread Andrew Dunstan
Log Message: --- make psql honor explicit database parameter in -l mode, in case postgres database is missing - per complaint from Philip Yarra. Tags: REL8_1_STABLE Modified Files: -- pgsql/src/bin/psql: startup.c (r1.126 - r1.126.2.1)

[COMMITTERS] pgsql: translate undef to NULL for result arrayref, now that we allow

2005-11-18 Thread Andrew Dunstan
Log Message: --- translate undef to NULL for result arrayref, now that we allow NULLs in arrays. Update plperl regression test accordingly. Modified Files: -- pgsql/src/pl/plperl: plperl.c (r1.94 - r1.95)

[COMMITTERS] pgsql: DROP objecttype IF EXISTS for the following objects: table

2005-11-19 Thread Andrew Dunstan
Log Message: --- DROP objecttype IF EXISTS for the following objects: table view index sequence schema type domain conversion Modified Files: -- pgsql/doc/src/sgml/ref: drop_conversion.sgml (r1.8 - r1.9)

[COMMITTERS] pgsql: DROP DATABASE IF EXISTS variant

2005-11-22 Thread Andrew Dunstan
Log Message: --- DROP DATABASE IF EXISTS variant Modified Files: -- pgsql/doc/src/sgml/ref: drop_database.sgml (r1.20 - r1.21) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ref/drop_database.sgml.diff?r1=1.20r2=1.21)

[COMMITTERS] pgsql: Mark installcheck-parallel, world, install-world and

2010-03-24 Thread Andrew Dunstan
Log Message: --- Mark installcheck-parallel, world, install-world and installcheck-world make targets as PHONY. Fujii Masao. Modified Files: -- pgsql/src: Makefile.global.in (r1.260 - r1.261)

[COMMITTERS] pgsql: Use a file of patterns of filenames to exclude from pgindent

2010-04-01 Thread Andrew Dunstan
Log Message: --- Use a file of patterns of filenames to exclude from pgindent runs, instead if using multiple invocations of egrep. Add perl ppport.h to the current list. Modified Files: -- pgsql/src/tools/pgindent: README (r1.39 - r1.40)

[COMMITTERS] pgsql: Sync perl's ppport.h on all branches back to 7.4 with recent

2010-04-03 Thread Andrew Dunstan
Log Message: --- Sync perl's ppport.h on all branches back to 7.4 with recent update on HEAD, ensuring we can build older branches with modern Perl installations. Tags: REL8_4_STABLE Modified Files: -- pgsql/src/pl/plperl: ppport.h (r1.11 - r1.11.6.1)

[COMMITTERS] pgsql: Sync perl's ppport.h on all branches back to 7.4 with recent

2010-04-03 Thread Andrew Dunstan
Log Message: --- Sync perl's ppport.h on all branches back to 7.4 with recent update on HEAD, ensuring we can build older branches with modern Perl installations. Tags: REL8_3_STABLE Modified Files: -- pgsql/src/pl/plperl: ppport.h (r1.11 - r1.11.4.1)

[COMMITTERS] pgsql: Sync perl's ppport.h on all branches back to 7.4 with recent

2010-04-03 Thread Andrew Dunstan
Log Message: --- Sync perl's ppport.h on all branches back to 7.4 with recent update on HEAD, ensuring we can build older branches with modern Perl installations. Tags: REL8_2_STABLE Modified Files: -- pgsql/src/pl/plperl: ppport.h (r1.11 - r1.11.2.1)

[COMMITTERS] pgsql: Sync perl's ppport.h on all branches back to 7.4 with recent

2010-04-03 Thread Andrew Dunstan
Log Message: --- Sync perl's ppport.h on all branches back to 7.4 with recent update on HEAD, ensuring we can build older branches with modern Perl installations. Tags: REL8_1_STABLE Modified Files: -- pgsql/src/pl/plperl: ppport.h (r1.9.2.2 - r1.9.2.3)

[COMMITTERS] pgsql: Sync perl's ppport.h on all branches back to 7.4 with recent

2010-04-03 Thread Andrew Dunstan
Log Message: --- Sync perl's ppport.h on all branches back to 7.4 with recent update on HEAD, ensuring we can build older branches with modern Perl installations. Tags: REL8_0_STABLE Modified Files: -- pgsql/src/pl/plperl: ppport.h (r1.8.4.1 - r1.8.4.2)

[COMMITTERS] pgsql: Sync perl's ppport.h on all branches back to 7.4 with recent

2010-04-03 Thread Andrew Dunstan
Log Message: --- Sync perl's ppport.h on all branches back to 7.4 with recent update on HEAD, ensuring we can build older branches with modern Perl installations. Tags: REL7_4_STABLE Modified Files: -- pgsql/src/pl/plperl: ppport.h (r1.5 - r1.5.6.1)

[COMMITTERS] pgsql: Make dmetaphone.c safe for pgindent and fussy compilers.

2010-04-04 Thread Andrew Dunstan
Log Message: --- Make dmetaphone.c safe for pgindent and fussy compilers. Still to do: make it properly encoding aware w.r.t. chars U+00C7 and U+00D1. Modified Files: -- pgsql/contrib/fuzzystrmatch: dmetaphone.c (r1.13 - r1.14)

[COMMITTERS] pgsql: Exclude unwanted typedef symbols in pgindent, including FD_SET

2010-04-04 Thread Andrew Dunstan
Log Message: --- Exclude unwanted typedef symbols in pgindent, including FD_SET which is found on some Windows platforms. Also, silence unnecessary messages and make awk happier about literal '*' on some platforms. Modified Files: -- pgsql/src/tools/pgindent:

[COMMITTERS] pgsql: Add missing library and include support for pg_upgrade to MSVC

2010-05-13 Thread Andrew Dunstan
Log Message: --- Add missing library and include support for pg_upgrade to MSVC build system. Modified Files: -- pgsql/src/tools/msvc: Mkvcbuild.pm (r1.54 - r1.55) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/tools/msvc/Mkvcbuild.pm?r1=1.54r2=1.55)

[COMMITTERS] pgsql: Abandon the use of Perl's Safe.pm to enforce restrictions in

2010-05-17 Thread Andrew Dunstan
routines, and that function compilation is significantly faster. Tim Bunce and Andrew Dunstan, with reviews from Alex Hunsaker and Alexey Klyukin. Security: CVE-2010-1169 Tags: REL8_4_STABLE Modified Files: -- pgsql/doc/src/sgml: plperl.sgml (r2.69.2.1 - r2.69.2.2

[COMMITTERS] pgsql: Abandon the use of Perl's Safe.pm to enforce restrictions in

2010-05-17 Thread Andrew Dunstan
routines, and that function compilation is significantly faster. Tim Bunce and Andrew Dunstan, with reviews from Alex Hunsaker and Alexey Klyukin. Security: CVE-2010-1169 Tags: REL8_3_STABLE Modified Files: -- pgsql/doc/src/sgml: plperl.sgml (r2.67 - r2.67.2.1

[COMMITTERS] pgsql: Abandon the use of Perl's Safe.pm to enforce restrictions in

2010-05-17 Thread Andrew Dunstan
routines, and that function compilation is significantly faster. Tim Bunce and Andrew Dunstan, with reviews from Alex Hunsaker and Alexey Klyukin. Security: CVE-2010-1169 Modified Files: -- pgsql/doc/src/sgml: plperl.sgml (r2.83 - r2.84) (http

[COMMITTERS] pgsql: Abandon the use of Perl's Safe.pm to enforce restrictions in

2010-05-17 Thread Andrew Dunstan
routines, and that function compilation is significantly faster. Tim Bunce and Andrew Dunstan, with reviews from Alex Hunsaker and Alexey Klyukin. Security: CVE-2010-1169 Tags: REL8_1_STABLE Modified Files: -- pgsql/doc/src/sgml: plperl.sgml (r2.49.2.1 - r2.49.2.2

[COMMITTERS] pgsql: Abandon the use of Perl's Safe.pm to enforce restrictions in

2010-05-17 Thread Andrew Dunstan
routines, and that function compilation is significantly faster. Tim Bunce and Andrew Dunstan, with reviews from Alex Hunsaker and Alexey Klyukin. Security: CVE-2010-1169 Tags: REL7_4_STABLE Modified Files: -- pgsql/doc/src/sgml: plperl.sgml (r2.20 - r2.20.2.1

[COMMITTERS] pgsql: Abandon the use of Perl's Safe.pm to enforce restrictions in

2010-05-17 Thread Andrew Dunstan
routines, and that function compilation is significantly faster. Tim Bunce and Andrew Dunstan, with reviews from Alex Hunsaker and Alexey Klyukin. Security: CVE-2010-1169 Tags: REL8_0_STABLE Modified Files: -- pgsql/doc/src/sgml: plperl.sgml (r2.37 - r2.37.4.1

[COMMITTERS] pgsql: Abandon the use of Perl's Safe.pm to enforce restrictions in

2010-05-17 Thread Andrew Dunstan
routines, and that function compilation is significantly faster. Tim Bunce and Andrew Dunstan, with reviews from Alex Hunsaker and Alexey Klyukin. Security: CVE-2010-1169 Tags: REL8_2_STABLE Modified Files: -- pgsql/doc/src/sgml: plperl.sgml (r2.59.2.2 - r2.59.2.3

[COMMITTERS] pgsql: Fix MSVC builds for recent plperl changes.

2010-05-17 Thread Andrew Dunstan
Log Message: --- Fix MSVC builds for recent plperl changes. Go back to version 8.2, which is where we started supporting MSVC builds. Security: CVE-2010-1169 Tags: REL8_4_STABLE Modified Files: -- pgsql/src/tools/msvc: Mkvcbuild.pm (r1.40 - r1.40.2.1)

[COMMITTERS] pgsql: Fix MSVC builds for recent plperl changes.

2010-05-17 Thread Andrew Dunstan
Log Message: --- Fix MSVC builds for recent plperl changes. Go back to version 8.2, which is where we started supporting MSVC builds. Security: CVE-2010-1169 Tags: REL8_3_STABLE Modified Files: -- pgsql/src/tools/msvc: Mkvcbuild.pm (r1.25.2.4 - r1.25.2.5)

[COMMITTERS] pgsql: Fix MSVC builds for recent plperl changes.

2010-05-17 Thread Andrew Dunstan
Log Message: --- Fix MSVC builds for recent plperl changes. Go back to version 8.2, which is where we started supporting MSVC builds. Security: CVE-2010-1169 Tags: REL8_2_STABLE Modified Files: -- pgsql/src/tools/msvc: mkvcbuild.pl (r1.8.2.1 - r1.8.2.2)

[COMMITTERS] pgsql: Fix MSVC builds for recent plperl changes.

2010-05-17 Thread Andrew Dunstan
Log Message: --- Fix MSVC builds for recent plperl changes. Go back to version 8.2, which is where we started supporting MSVC builds. Security: CVE-2010-1169 Modified Files: -- pgsql/src/tools/msvc: Mkvcbuild.pm (r1.56 - r1.57)

[COMMITTERS] pgsql: Clarify plperl subroutine name release notes item, remove now

2010-05-17 Thread Andrew Dunstan
Log Message: --- Clarify plperl subroutine name release notes item, remove now redundant Safe.pm item. Modified Files: -- pgsql/doc/src/sgml: release-9.0.sgml (r2.21 - r2.22)

[COMMITTERS] pgsql: Follow up a visit from the style police.

2010-05-17 Thread Andrew Dunstan
Log Message: --- Follow up a visit from the style police. Modified Files: -- pgsql/src/pl/plperl: plperl.c (r1.175 - r1.176) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plperl/plperl.c?r1=1.175r2=1.176) -- Sent via pgsql-committers mailing

[COMMITTERS] pgsql: Follow up a visit from the style police.

2010-05-17 Thread Andrew Dunstan
Log Message: --- Follow up a visit from the style police. Tags: REL7_4_STABLE Modified Files: -- pgsql/src/pl/plperl: plperl.c (r1.40.2.4 - r1.40.2.5) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plperl/plperl.c?r1=1.40.2.4r2=1.40.2.5) --

[COMMITTERS] pgsql: Follow up a visit from the style police.

2010-05-17 Thread Andrew Dunstan
Log Message: --- Follow up a visit from the style police. Tags: REL8_0_STABLE Modified Files: -- pgsql/src/pl/plperl: plperl.c (r1.67.4.12 - r1.67.4.13) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plperl/plperl.c?r1=1.67.4.12r2=1.67.4.13)

[COMMITTERS] pgsql: Follow up a visit from the style police.

2010-05-17 Thread Andrew Dunstan
Log Message: --- Follow up a visit from the style police. Tags: REL8_2_STABLE Modified Files: -- pgsql/src/pl/plperl: plperl.c (r1.123.2.13 - r1.123.2.14)

[COMMITTERS] pgsql: Follow up a visit from the style police.

2010-05-17 Thread Andrew Dunstan
Log Message: --- Follow up a visit from the style police. Tags: REL8_3_STABLE Modified Files: -- pgsql/src/pl/plperl: plperl.c (r1.136.2.9 - r1.136.2.10)

[COMMITTERS] pgsql: Follow up a visit from the style police.

2010-05-17 Thread Andrew Dunstan
Log Message: --- Follow up a visit from the style police. Tags: REL8_1_STABLE Modified Files: -- pgsql/src/pl/plperl: plperl.c (r1.94.2.16 - r1.94.2.17) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plperl/plperl.c?r1=1.94.2.16r2=1.94.2.17)

[COMMITTERS] pgsql: Follow up a visit from the style police.

2010-05-17 Thread Andrew Dunstan
Log Message: --- Follow up a visit from the style police. Tags: REL8_4_STABLE Modified Files: -- pgsql/src/pl/plperl: plperl.c (r1.150.2.7 - r1.150.2.8) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plperl/plperl.c?r1=1.150.2.7r2=1.150.2.8)

Re: [COMMITTERS] pgsql: Follow up a visit from the style police.

2010-05-17 Thread Andrew Dunstan
Tom Lane wrote: aduns...@postgresql.org (Andrew Dunstan) writes: Log Message: --- Follow up a visit from the style police. I think this needs to be back-patched, too. Done, although the commit message got slightly mangled, sorry about

[COMMITTERS] pgsql: Fix regression tests to match error message change

2010-05-17 Thread Andrew Dunstan
Log Message: --- Fix regression tests to match error message change Modified Files: -- pgsql/src/pl/plperl/expected: plperl_init.out (r1.4 - r1.5) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plperl/expected/plperl_init.out?r1=1.4r2=1.5) --

[COMMITTERS] pgsql: Run recently backported plperlu_plperl regression tests when

2010-06-02 Thread Andrew Dunstan
Log Message: --- Run recently backported plperlu_plperl regression tests when building with MSVC on releases 8.4 and 8.3. Regression tests weren't supported before that. Tags: REL8_3_STABLE Modified Files: -- pgsql/src/tools/msvc: vcregress.pl (r1.6.2.1 -

[COMMITTERS] pgsql: Run recently backported plperlu_plperl regression tests when

2010-06-02 Thread Andrew Dunstan
Log Message: --- Run recently backported plperlu_plperl regression tests when building with MSVC on releases 8.4 and 8.3. Regression tests weren't supported before that. Tags: REL8_4_STABLE Modified Files: -- pgsql/src/tools/msvc: vcregress.pl (r1.10.2.1 -

[COMMITTERS] pgsql: Fix regression test name for plperlu_plperl in msvc.

2010-06-03 Thread Andrew Dunstan
Log Message: --- Fix regression test name for plperlu_plperl in msvc. Tags: REL8_4_STABLE Modified Files: -- pgsql/src/tools/msvc: vcregress.pl (r1.10.2.2 - r1.10.2.3)

[COMMITTERS] pgsql: Fix regression test name for plperlu_plperl in msvc.

2010-06-03 Thread Andrew Dunstan
Log Message: --- Fix regression test name for plperlu_plperl in msvc. Tags: REL8_3_STABLE Modified Files: -- pgsql/src/tools/msvc: vcregress.pl (r1.6.2.2 - r1.6.2.3)

[COMMITTERS] pgsql: Unbreak MSVC builds for pg_archivecleanup by linking with

2010-06-15 Thread Andrew Dunstan
Log Message: --- Unbreak MSVC builds for pg_archivecleanup by linking with libpgport Modified Files: -- pgsql/src/tools/msvc: Mkvcbuild.pm (r1.57 - r1.58) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/tools/msvc/Mkvcbuild.pm?r1=1.57r2=1.58) -- Sent

[COMMITTERS] pgsql: Remove perl symbol table additions for plperl functions, and

2010-06-16 Thread Andrew Dunstan
Log Message: --- Remove perl symbol table additions for plperl functions, and mention of it in the release notes, as it is not apparently providing anything useful. Modified Files: -- pgsql/doc/src/sgml: release-9.0.sgml (r2.31 - r2.32)

[COMMITTERS] pgsql: Correct missing/misspelled surname.

2010-06-30 Thread Andrew Dunstan
Log Message: --- Correct missing/misspelled surname. Modified Files: -- pgsql/doc/src/sgml: release-9.0.sgml (r2.36 - r2.37) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/release-9.0.sgml?r1=2.36r2=2.37) -- Sent via pgsql-committers

Re: [COMMITTERS] pgsql: Allow copydir() to be interrupted.

2010-07-02 Thread Andrew Dunstan
Robert Haas wrote: Log Message: --- Allow copydir() to be interrupted. This makes ALTER DATABASE .. SET TABLESPACE and CREATE DATABASE more sensitive to interrupts. Backpatch to 8.4, where ALTER DATABASE .. SET TABLESPACE was introduced. We could go back further, but in the absence

[COMMITTERS] pgsql: Unbreak MSVC builds by removing copydir.c from list of libpgport

2010-07-02 Thread Andrew Dunstan
Log Message: --- Unbreak MSVC builds by removing copydir.c from list of libpgport files Modified Files: -- pgsql/src/tools/msvc: Mkvcbuild.pm (r1.58 - r1.59) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/tools/msvc/Mkvcbuild.pm?r1=1.58r2=1.59) --

[COMMITTERS] pgsql: Unbreak MSVC builds by removing copydir.c from list of libpgport

2010-07-02 Thread Andrew Dunstan
Log Message: --- Unbreak MSVC builds by removing copydir.c from list of libpgport files Tags: REL8_4_STABLE Modified Files: -- pgsql/src/tools/msvc: Mkvcbuild.pm (r1.40.2.1 - r1.40.2.2)

Re: [COMMITTERS] pgsql: Mention why one C file fails pgindent.

2010-07-06 Thread Andrew Dunstan
Bruce Momjian wrote: Log Message: --- Mention why one C file fails pgindent. Modified Files: -- pgsql/src/tools/pgindent: README (r1.41 - r1.42) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/tools/pgindent/README?r1=1.41r2=1.42) Why not add

Re: [HACKERS] [COMMITTERS] pgsql: Add support for TCP keepalives on Windows, both for backend and

2010-07-08 Thread Andrew Dunstan
Tom Lane wrote: Magnus Hagander mag...@hagander.net writes: Seems pretty simple - mingw doesn't have support for this. We have two ways to deal with that I think: 1) Disable it on mingw. 2) Include it in our custom headers. For #2, what we need to include is the define of

Re: [COMMITTERS] pgsql: Make the Windows tcp keepalive support depend on the existance of

2010-07-08 Thread Andrew Dunstan
Magnus Hagander wrote: Log Message: --- Make the Windows tcp keepalive support depend on the existance of the SIO_KEEPALIVE_VALS define instead of just WIN32, since MingW doesn't support this API (yet?). Maybe I misunderstood. I thought you were going to include the required

Re: [HACKERS] Re: [COMMITTERS] pgsql: git_topo_order script, to match up commits across branches.

2010-09-24 Thread Andrew Dunstan
On 09/24/2010 06:53 PM, Gurjeet Singh wrote: If it resembles cvs2cl then why not name it git2cl? Or git_changelog. +1 for git_changelog cheers andrew -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription:

[COMMITTERS] pgsql: Fix MSVC builds for dummy_seclabel breakage.

2010-09-28 Thread Andrew Dunstan
Fix MSVC builds for dummy_seclabel breakage. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=f00847dc012e9c5219ef0e8e212d173d24700275 Modified Files -- src/tools/msvc/vcregress.pl |1 + 1 files changed, 1 insertions(+), 0

[COMMITTERS] pgsql: Remove unnecessary use of trigger flag to hash plperl functions

2010-10-24 Thread Andrew Dunstan
Remove unnecessary use of trigger flag to hash plperl functions Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=2d01ec0708d571eef926f3f5795aa73759df5d9a Modified Files -- src/pl/plperl/plperl.c |8 +--- 1 files changed, 1

[COMMITTERS] pgsql: Allow generic record arguments to plperl functions

2010-10-28 Thread Andrew Dunstan
Allow generic record arguments to plperl functions Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=6c3c7b533e4b73bef6f92da26c7c4124edd3 Modified Files -- src/pl/plperl/plperl.c |9 ++--- 1 files changed, 6

Re: [COMMITTERS] pgsql: Improved parallel make support

2010-11-12 Thread Andrew Dunstan
On 11/12/2010 03:16 PM, Peter Eisentraut wrote: Improved parallel make support Replace for loops in makefiles with proper dependencies. Parallel make can now span across directories. Also, make -k and make -q work properly. GNU make 3.80 or newer is now required. Looks like this patch

[COMMITTERS] pgsql: Attempt to fix MSVC builds broken by parallel make changes.

2010-11-12 Thread Andrew Dunstan
Attempt to fix MSVC builds broken by parallel make changes. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=52e2c12288cdcdcaa46a18937cc051d3322bbc99 Modified Files -- src/tools/msvc/Mkvcbuild.pm |2 +- 1 files changed, 1

[COMMITTERS] pgsql: Require VALUE keyword when extending an enum type. Based on a pa

2010-11-16 Thread Andrew Dunstan
Require VALUE keyword when extending an enum type. Based on a patch from Alvaro Herrera. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=b7fcf68e8632e757a50352c9567bb630ed285201 Modified Files -- doc/src/sgml/ref/alter_type.sgml

Re: [COMMITTERS] pgsql: Speed up conversion of signed integers to C strings.

2010-11-20 Thread Andrew Dunstan
On 11/20/2010 01:10 AM, Robert Haas wrote: On Fri, Nov 19, 2010 at 11:47 PM, Tom Lanet...@sss.pgh.pa.us wrote: I wrote: Robert Haasrh...@postgresql.org writes: Speed up conversion of signed integers to C strings. This patch breaks the build here: ... and while I'm looking at it, the

Re: [COMMITTERS] pgsql: Speed up conversion of signed integers to C strings.

2010-11-20 Thread Andrew Dunstan
On 11/20/2010 07:10 AM, Robert Haas wrote: Ah, the joy of debugging by buildfarm. Nothing better than having the whole world watch your mistakes in painstaking detail! At least this way you get to do it while your memory is fresh. In the old days we only found out some things were broken

Re: [COMMITTERS] pgsql: Improve pg_ctl cannot connect warning, per suggestion from Mag

2010-11-26 Thread Andrew Dunstan
On 11/26/2010 10:04 AM, Bruce Momjian wrote: Tom Lane wrote: Bruce Momjianbr...@momjian.us writes: Tom Lane wrote: Why does this string contain doubled spaces? You mean two spaces after a semicolon? Isn't that normal? This is the string: Normal according to what? In any case

[COMMITTERS] pgsql: Allow the low level COPY routines to read arbitrary numbers of f

2010-12-06 Thread Andrew Dunstan
Allow the low level COPY routines to read arbitrary numbers of fields. This doesn't involve any user-visible change in behavior, but will be useful when the COPY routines are exposed to allow their use by Foreign Data Wrapper routines, which will be able to use these routines to read irregular CSV

[COMMITTERS] pgsql: Backpatch plperl GNUmakefile fixes to allow building release 8.2

2010-12-17 Thread Andrew Dunstan
Backpatch plperl GNUmakefile fixes to allow building release 8.2 on Mingw with a modern perl. Branch -- REL8_2_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=f2f63551cdafcdec416955712259aa2530e8 Modified Files --

[COMMITTERS] pgsql: Work around make changes on modern Mingw to allow release 8.2 re

2010-12-17 Thread Andrew Dunstan
Work around make changes on modern Mingw to allow release 8.2 regression tests to work. Branch -- REL8_2_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=43a7206fcca3f77503be481565b2a855b9044550 Modified Files --

[COMMITTERS] pgsql: Allow vpath builds and regression tests to succeed on Mingw. Bac

2010-12-24 Thread Andrew Dunstan
Allow vpath builds and regression tests to succeed on Mingw. Backpatch to release 8.4 - earlier releases would require more changes and it's not worth the trouble. Branch -- REL8_4_STABLE Details ---

[COMMITTERS] pgsql: Allow vpath builds and regression tests to succeed on Mingw. Bac

2010-12-24 Thread Andrew Dunstan
Allow vpath builds and regression tests to succeed on Mingw. Backpatch to release 8.4 - earlier releases would require more changes and it's not worth the trouble. Branch -- REL9_0_STABLE Details ---

[COMMITTERS] pgsql: Allow vpath builds and regression tests to succeed on Mingw. Bac

2010-12-24 Thread Andrew Dunstan
Allow vpath builds and regression tests to succeed on Mingw. Backpatch to release 8.4 - earlier releases would require more changes and it's not worth the trouble. Branch -- master Details ---

[COMMITTERS] pgsql: Only build in crashdump support on Windows if there's a working

2010-12-26 Thread Andrew Dunstan
Only build in crashdump support on Windows if there's a working dbghelp.h. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=a534728afb7341e1ddf2df16196ed501eaa378c2 Modified Files -- configure | 123

Re: [COMMITTERS] pgsql: Ooops, no DATE_IS_NOBEGIN/DATE_IS_NOEND in 8.3 or 8.2 ...

2010-12-28 Thread Andrew Dunstan
On 12/28/2010 11:39 PM, Robert Haas wrote: On Tue, Dec 28, 2010 at 11:02 PM, Tom Lanet...@sss.pgh.pa.us wrote: Ooops, no DATE_IS_NOBEGIN/DATE_IS_NOEND in 8.3 or 8.2 ... I heard the siren call of git cherry-pick, but should have lashed myself to the mast. Applying the same patch blindly to

Re: [COMMITTERS] pgsql: Ooops, no DATE_IS_NOBEGIN/DATE_IS_NOEND in 8.3 or 8.2 ...

2010-12-28 Thread Andrew Dunstan
On 12/28/2010 11:50 PM, Tom Lane wrote: Robert Haasrobertmh...@gmail.com writes: On Tue, Dec 28, 2010 at 11:02 PM, Tom Lanet...@sss.pgh.pa.us wrote: I heard the siren call of git cherry-pick, but should have lashed myself to the mast. Applying the same patch blindly to every branch can

[COMMITTERS] pgsql: Work around header misdefines in modern Windows SDK when _WIN32_

2011-01-04 Thread Andrew Dunstan
Work around header misdefines in modern Windows SDK when _WIN32_WINNT is less than 0x0501. Only required for versions 8.2, 8.3 and 8.4., as we defined _WIN32_WINNT as 0x0501 after that. Branch -- REL8_4_STABLE Details ---

[COMMITTERS] pgsql: Work around header misdefines in modern Windows SDK when _WIN32_

2011-01-04 Thread Andrew Dunstan
Work around header misdefines in modern Windows SDK when _WIN32_WINNT is less than 0x0501. Only required for versions 8.2, 8.3 and 8.4., as we defined _WIN32_WINNT as 0x0501 after that. Branch -- REL8_3_STABLE Details ---

[COMMITTERS] pgsql: Work around header misdefines in modern Windows SDK when _WIN32_

2011-01-04 Thread Andrew Dunstan
Work around header misdefines in modern Windows SDK when _WIN32_WINNT is less than 0x0501. Only required for versions 8.2, 8.3 and 8.4., as we defined _WIN32_WINNT as 0x0501 after that. Branch -- REL8_2_STABLE Details ---

[COMMITTERS] pgsql: Allow older branches to be built with Visual Studio 2008. This i

2011-01-04 Thread Andrew Dunstan
Allow older branches to be built with Visual Studio 2008. This is a backport of commit df0cdd53 to the 8.2, 8.3 and 8.4 branches. Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=5739935188ca27b5b6e63d72748af733b5813aa9 Modified Files

[COMMITTERS] pgsql: Allow older branches to be built with Visual Studio 2008. This i

2011-01-04 Thread Andrew Dunstan
Allow older branches to be built with Visual Studio 2008. This is a backport of commit df0cdd53 to the 8.2, 8.3 and 8.4 branches. Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=d61d3c39ddcdc890fd9a807f5cb10ce76a340642 Modified Files

[COMMITTERS] pgsql: Allow older branches to be built with Visual Studio 2008. This i

2011-01-04 Thread Andrew Dunstan
Allow older branches to be built with Visual Studio 2008. This is a backport of commit df0cdd53 to the 8.2, 8.3 and 8.4 branches. Branch -- REL8_2_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=ebbf741d5d449f6fdc1983aca54d1f232d866b16 Modified Files

[COMMITTERS] pgsql: Unbreak regression tests, apparently broken by commit 4c8e20f

2011-01-11 Thread Andrew Dunstan
Unbreak regression tests, apparently broken by commit 4c8e20f Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=b7a0b42641e764a1e4abc39cc4311b5c779f5955 Modified Files -- src/test/regress/expected/rules.out |2 +- 1 files

[COMMITTERS] pgsql: Silence flex warnings about DOS file paths in MSVC builds

2011-01-23 Thread Andrew Dunstan
Silence flex warnings about DOS file paths in MSVC builds Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=6c41cf5977ca3f13159b980d4b216e3bc9df90e8 Modified Files -- src/tools/msvc/pgflex.bat |3 +++ 1 files changed, 3

[COMMITTERS] pgsql: Fix typo

2011-01-30 Thread Andrew Dunstan
Fix typo Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=48c9de80283d4bbdf9bec2f2f929b23f1676f8f9 Modified Files -- src/include/port/win32.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via

Re: [COMMITTERS] pgsql: Enable building with the Mingw64 compiler.

2011-01-30 Thread Andrew Dunstan
On 01/30/2011 08:10 PM, Tom Lane wrote: Andrew Dunstanand...@dunslane.net writes: Enable building with the Mingw64 compiler. +#if defined(_WIN32_WINNT) _WIN32_WINNT 0x0501 +#undefine _WIN32_WINNT +#endif Umm ... surely #undefine is a typo? Darn, yes. I even

[COMMITTERS] pgsql: Update docs on building for Windows to accomodate current realit

2011-01-31 Thread Andrew Dunstan
Update docs on building for Windows to accomodate current reality. Document how to build 64 bit Windows binaries using the MinGW64 tool set. Remove recommendation against using Mingw as a build platform. Be more specific about when Cygwin is useful and when it's not, in particular note its

[COMMITTERS] pgsql: Add comment on why we're passing a useless 'false' to the plper

2011-02-02 Thread Andrew Dunstan
Add comment on why we're passing a useless 'false' to the plperl function compiler. It's for compatibility with modules like PostgreSQL::PLPerl::NYTProf. Branch -- master Details ---

Re: [COMMITTERS] pgsql: Wrap PL/Python SPI calls into subtransactions

2011-02-02 Thread Andrew Dunstan
On 02/02/2011 03:09 PM, Peter Eisentraut wrote: Wrap PL/Python SPI calls into subtransactions This allows the language-specific try/catch construct to catch and handle exceptions arising from SPI calls, matching the behavior of other PLs. As an additional bonus you no longer get all the ugly

[COMMITTERS] pgsql: Attempt to unbreak MSVC builds after pipe.c move.

2011-02-04 Thread Andrew Dunstan
Attempt to unbreak MSVC builds after pipe.c move. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=895ad83d702ed821f72ec7bdf1fba3db7da9d9d7 Modified Files -- src/tools/msvc/Mkvcbuild.pm |3 ++- 1 files changed, 2 insertions(+),

[COMMITTERS] pgsql: Force strings passed to and from plperl to be in UTF8 encoding.

2011-02-06 Thread Andrew Dunstan
Force strings passed to and from plperl to be in UTF8 encoding. String are converted to UTF8 on the way into perl and to the database encoding on the way back. This avoids a number of observed anomalies, and ensures Perl a consistent view of the world. Some minor code cleanups are also

[COMMITTERS] pgsql: Supply now required HeUTF8 macro for plperl where it's missing,

2011-02-06 Thread Andrew Dunstan
Supply now required HeUTF8 macro for plperl where it's missing, per buildfarm results. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=c852e95b0bcbe708ba64b9499e50b9cc98bd7b71 Modified Files -- src/pl/plperl/plperl.h |7

[COMMITTERS] pgsql: Use correct name and URL for MinGW-w64, error noticed by Gurjeet

2011-02-10 Thread Andrew Dunstan
Use correct name and URL for MinGW-w64, error noticed by Gurjeet Singh. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2ad0348677aebe36260b30fee22892e6519ee7d8 Modified Files -- doc/src/sgml/install-windows.sgml |2 +- doc/src/sgml/installation.sgml

Re: [COMMITTERS] pgsql: Use $INDENT rather than indent throughout the pgindent code

2011-02-17 Thread Andrew Dunstan
On 02/17/2011 08:23 PM, Alvaro Herrera wrote: Use $INDENT rather than indent throughout the pgindent code +INDENT=`which indent` How universally available is which? cheers andrew -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your

Re: [COMMITTERS] pgsql: Use $INDENT rather than indent throughout the pgindent code

2011-02-18 Thread Andrew Dunstan
On 02/18/2011 10:44 AM, Alvaro Herrera wrote: What would actually be useful here is a convenient way to override the script's default value of INDENT, but this coding doesn't offer that. I'd suggest something more like if [ -z $INDENT ]; then INDENT=indent fi ... this is certainly

Re: [COMMITTERS] pgsql: Fix doc patch --- pg_options_to_table() returns setof record.

2011-02-26 Thread Andrew Dunstan
On 02/26/2011 12:27 PM, Bruce Momjian wrote: Fix doc patch --- pg_options_to_table() returns setof record. This doesn't strike me as terribly helpful. Why don't we document what sort of records it returns, since we know perfectly well?: andrew=# \df pg_options_to_table

  1   2   3   4   5   6   7   8   9   10   >