Re: [COMMITTERS] pgsql-server: Add ALTER INDEX, particularly for

2004-08-21 Thread Christopher Kings-Lynne
Thanks for spotting this sloppy work. Basically, I cropped my diff because there was lots of unrelated code in the work space. But I was a little too hard and culled allfiles.sgml, alter.c, equal/copyfuncs.c and analyze.c. I was wondering if something like that might have happened --- I know you k

Re: [COMMITTERS] pgsql-server: Add ALTER INDEX, particularly for

2004-08-21 Thread Christopher Kings-Lynne
I have a whole separate CVS checkout for every path I'm working on - makes life a lot easier :) Dammit - I meant 'patch'. Chris ---(end of broadcast)--- TIP 9: the planner will ignore your desire to choose an index scan if your joining column's

Re: [COMMITTERS] pgsql: Allow Win32 to support the O_SYNC open flag

2005-03-01 Thread Christopher Kings-Lynne
I think this should be back ported for 8.0.2... Chris Bruce Momjian wrote: Log Message: --- Allow Win32 to support the O_SYNC open flag as an wal_sync_method method. Magnus Hagander Modified Files: -- pgsql/src/include: port.h (r1.69 -> r1.70) (http://develo

Re: [COMMITTERS] pgsql: Make the behavior of HAVING without GROUP

2005-03-10 Thread Christopher Kings-Lynne
I wonder how much back-compatibility and dump reloading problems this might cause? :( Tom Lane wrote: Log Message: --- Make the behavior of HAVING without GROUP BY conform to the SQL spec. Formerly, if such a clause contained no aggregate functions we mistakenly treated it as equivalent t

Re: [COMMITTERS] pgsql: Completion of project to use fixed OIDs for

2005-04-14 Thread Christopher Kings-Lynne
Completion of project to use fixed OIDs for all system catalogs and indexes. Replace all heap_openr and index_openr calls by heap_open and index_open. Remove runtime lookups of catalog OID numbers in various places. Remove relcache's support for looking up system catalogs by name. Bulky but mos

Re: [COMMITTERS] pgsql: Fix NUMERIC modulus to properly truncate

2005-06-04 Thread Christopher Kings-Lynne
Is this a backport? Bruce Momjian wrote: Log Message: --- Fix NUMERIC modulus to properly truncate division in computation. Division rounding was causing incorrect results. Test case: test=> SELECT 12345678901234567890 % 123; ?column? --

Re: [COMMITTERS] pgsql: Fix NUMERIC modulus to properly truncate

2005-06-04 Thread Christopher Kings-Lynne
> No, I don't think so. It doesn't seem to be something that enough people use to risk the change in behavior --- it might break something that was working. But, if folks want it backported we can do it. It is only a change to properly do modulus for numeric. Well, from my point of view it'

Re: [COMMITTERS] pgsql: Update text that stated GiST indexes aren't

2005-06-20 Thread Christopher Kings-Lynne
Don't forget the line in the GiST docs that says basically that WAL logging is a SMOP: http://developer.postgresql.org/docs/postgres/limitations.html Chris Tom Lane wrote: Log Message: --- Update text that stated GiST indexes aren't WAL-logged. Modified Files: -- pgsq

Re: [COMMITTERS] pgsql: Update text that stated GiST indexes aren't

2005-06-20 Thread Christopher Kings-Lynne
You could also mention under limitations that it's not NULL-safe perhaps. Chris Tom Lane wrote: Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: Don't forget the line in the GiST docs that says basically that WAL logging is a SMOP: http://developer.postgresql.o

Re: [COMMITTERS] pgsql: Remove GIST concurrency limitations section.

2005-07-03 Thread Christopher Kings-Lynne
- - The current implementation of GiST within - PostgreSQL has some major limitations: - GiST index access is not concurrent, and the - GiST interface doesn't allow the development of certain - data types, such as digital trees (see papers by Aoki et al). - AFAIK the GiST modifications s

Re: [COMMITTERS] pgsql: Add psql option: -1 or --single-transaction

2006-02-13 Thread Christopher Kings-Lynne
BEGIN; -- -- Name: SCHEMA public; Type: COMMENT; Schema: -; Owner: postgres -- COMMENT ON SCHEMA public IS 'Standard public schema'; That's not what I would call guaranteeing that all the commands execute successfully. What if the client encoding is unrecognized, for instance? How does this

Re: [COMMITTERS] pgsql: Add psql option: -1 or --single-transaction

2006-02-13 Thread Christopher Kings-Lynne
Christopher Kings-Lynne <[EMAIL PROTECTED]> writes: How does this interact with the begin/commit placed around LOB dumps? Good question ... right offhand it looks like there are some broken things there (try grepping bin/pg_dump/ for BEGIN). I suggest you just suppress the begin/comm

Re: [COMMITTERS] pgsql: Add psql option: -1 or --single-transaction

2006-02-13 Thread Christopher Kings-Lynne
Good question ... right offhand it looks like there are some broken things there (try grepping bin/pg_dump/ for BEGIN). I suggest you just suppress the begin/commit for each LOB if --single-transaction is specified, as it'd be in a single transaction anyway... Or...it could create and relea

Re: [COMMITTERS] pgsql: Add psql option: -1 or --single-transaction

2006-02-14 Thread Christopher Kings-Lynne
Or...it could create and release a particular savepoint I suppose...I don't know if there's much point in that though. Didn't seem much point trying to remove it, Huh? But it'll cause a total failure of dump restore? Chris ---(end of broadcast)--

Re: [COMMITTERS] pgsql: Add psql option: -1 or --single-transaction

2006-02-14 Thread Christopher Kings-Lynne
Perhaps you can explain further? My understanding was that the desired functionality was that any failure would cause all aspects of the load to fail also, so I don't see any problem with that; clearly I need to listen to your thoughts. Maybe we're not talking about the same thing? I was talkin

Re: [COMMITTERS] pgsql: Add psql option: -1 or --single-transaction

2006-02-14 Thread Christopher Kings-Lynne
Chris, do you have a set-up to test out the blob behaviour? If your using them in production you'll spot any further slip-ups; they weren't intentionally ignored in the original patch. No sorry - my PostgreSQL contribution these days primary consists of "whining" :D I usually just do this: c

Re: [COMMITTERS] pgsql: GIN: Generalized Inverted iNdex.

2006-05-03 Thread Christopher Kings-Lynne
[EMAIL PROTECTED] (Teodor Sigaev) writes: Log Message: --- GIN: Generalized Inverted iNdex. text[], int4[], Tsearch2 support for GIN. So ... where's the documentation? Will submit soon. Christopher Kings-Lynne kindly agreed to help us with SGML and wording. Just gimme some

Re: [COMMITTERS] pgsql: GIN: Generalized Inverted iNdex.

2006-05-17 Thread Christopher Kings-Lynne
Will submit soon. Christopher Kings-Lynne kindly agreed to help us with SGML and wording. Just gimme some time :) Ok, I can look into this now... I'm not sure really where to being though. What are all the new operators? What does it even mean to use a GIN over an int[] column? I

Re: [COMMITTERS] pgsql-server/src backend/catalog/heap.c backen ...

2003-07-29 Thread Christopher Kings-Lynne
> Log message: > Coerce unknown-literal-constant default values to the column type during > CREATE TABLE (or ALTER TABLE SET DEFAULT), rather than postponing it to > the time that the default is inserted into an INSERT command by the > rewriter. This reverses an old decision that was intended to m

Re: [COMMITTERS] pgsql-server/src/bin/pg_dump dumputils.c

2003-07-31 Thread Christopher Kings-Lynne
> Log message: > Upgrade parsing code for ACLs to be less hokey and more cognizant of > the actual logical structure and quoting rules being used. Fixes bug > reported by Chris K-L on 7/8/03. I vote for pg_get_acldef() class of functions... Chirs ---(end of broadcast)--

Re: [COMMITTERS] pgsql-server/src/backend bootstrap/bootstrap.c ...

2003-09-02 Thread Christopher Kings-Lynne
Cool. That fixes the problem I was having perfectly. Chris - Original Message - From: "Tom Lane" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Wednesday, September 03, 2003 3:04 AM Subject: [COMMITTERS] pgsql-server/src/backend bootstrap/bootstrap.c ... > CVSROOT: /cvsroot > Modul

Re: [COMMITTERS] pgsql-server/ rc/backend/catalog/sql_features. ...

2003-09-20 Thread Christopher Kings-Lynne
Did you deliberately misspell 'mistakes' below? Either way, it's very amusing :P Chris On Sat, 20 Sep 2003, Tom Lane wrote: > CVSROOT: /cvsroot > Module name: pgsql-server > Changes by: [EMAIL PROTECTED] 03/09/20 17:12:05 > > Modified files: > src/backend/catalog: sql_featur

Re: [COMMITTERS] pgsql-server/src backend/executor/execQual.c b ...

2003-09-25 Thread Christopher Kings-Lynne
Cool - I'm glad someone finally fixed that! Chris Tom Lane wrote: CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 03/09/25 20:02:12 Modified files: src/backend/executor: execQual.c nodeFunctionscan.c src/pl/plpgsql/src: gram.y pl_comp.c pl_exec.c

Re: [COMMITTERS] pgsql-server/src/bin/psql describe.c

2003-10-16 Thread Christopher Kings-Lynne
Log message: Use pg_get_constraintdef() rather than pg_constraint.consrc; this is a portion of a patch recently submitted by Christopher Kings-Lynne. Applied by agreement that this is a bug fix. You have actually technically done more than just fix the bug. Because you

Re: [COMMITTERS] pgsql-server/src/bin/psql describe.c

2003-10-16 Thread Christopher Kings-Lynne
You have actually technically done more than just fix the bug. Because you are passing in 'true' as the second parameter to pg_get_constraintdef, you've enabled the 'pretty print' option... I'm not sure it's that big a thing though... Yeah, I know; that was deliberate. Any objections? Not

Re: [COMMITTERS] pgsql-server/doc FAQ src/FAQ/FAQ.html

2003-10-29 Thread Christopher Kings-Lynne
I also notice that the 'Developer's FAQ' on the dev site that I think Larry wrote might be a bit out of date. Talks about elog, and not ereport, etc. Chris Bruce Momjian wrote: CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 03/10/29 16:20:12 Modi

Re: [COMMITTERS] pgsql-server/src/tutorial syscat.source

2003-10-30 Thread Christopher Kings-Lynne
Doh! I forgot all about that. Chris Tom Lane wrote: CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 03/10/30 23:58:16 Modified files: src/tutorial : syscat.source Log message: Small fix to Christopher's recent improvements --- underscor

Re: [COMMITTERS] pgsql-server/src/interfaces/jdbc build.xml org ...

2003-11-03 Thread Christopher Kings-Lynne
Do you have to commit these to the 7_4_STABLE branch as well? Chris Dave Cramer wrote: CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 03/11/03 11:28:26 Modified files: src/interfaces/jdbc: build.xml src/interfaces/jdbc/org/postgresql/jdbc2:

Re: [COMMITTERS] pgsql-server/ oc/src/sgml/mvcc.sgml oc/src/sgm ...

2003-11-06 Thread Christopher Kings-Lynne
Are we going to be making the note in the release notes as we go from now on? Chris Peter Eisentraut - PostgreSQL wrote: CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 03/11/06 18:08:15 Modified files: doc/src/sgml : mvcc.sgml runtime.sgml doc

Re: [COMMITTERS] pgsql-server/ /Tag: /REL7_4_STABLE /HISTORY oc ...

2003-11-16 Thread Christopher Kings-Lynne
Bit late isn't it? I thought the final release was now available? Chris Bruce Momjian wrote: CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 03/11/17 00:52:06 Modified files: . : Tag: REL7_4_STABLE HISTORY doc/src/sgml : Tag: REL7_

Re: [COMMITTERS] pgsql-server/src/bin/pg_dump common.c pg_backu ...

2003-12-08 Thread Christopher Kings-Lynne
That's fixed it for me. Chris Tom Lane wrote: CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 03/12/08 12:39:05 Modified files: src/bin/pg_dump: common.c pg_backup_archiver.h pg_backup_null.c pg_backup_tar.c Log message:

Re: [COMMITTERS] pgsql-server/ ontrib/tablefunc/tablefunc.c oc/ ...

2004-02-03 Thread Christopher Kings-Lynne
Log message: Rename SortMem and VacuumMem to work_mem and maintenance_work_mem. Make btree index creation and initial validation of foreign-key constraints use maintenance_work_mem rather than work_mem as their memory limit. Add some code to guc.c to allow these vari

Re: [COMMITTERS] pgsql-server/src/backend/optimizer/util pathnode.c

2004-03-02 Thread Christopher Kings-Lynne
Teach is_distinct_query to recognize that GROUP BY forces a subquery's output to be distinct, if all the GROUP BY columns appear in the output. Per suggestion from Dennis Haney. Will this have should-be-in-release-notes side effects just as the results of a DISTINCT over a

Re: [COMMITTERS] pgsql-server/ oc/src/sgml/errcodes.sgml rc/bac ...

2004-03-04 Thread Christopher Kings-Lynne
This should also definitely be in the release notes as a warning... Chris Neil Conway wrote: CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 04/03/04 17:47:18 Modified files: doc/src/sgml : errcodes.sgml src/backend/utils/adt: float.c oid.c sr

Re: [COMMITTERS] pgsql-server/contrib/xml Makefile README.pgxml ...

2004-03-04 Thread Christopher Kings-Lynne
Shouldn't we make this a totally new 'xml2' contrib, like we did for tsearch2? Especially since it is backwards incompatible and has a huge security hole? (url fetching) Chris Bruce Momjian wrote: CVSROOT:/cvsroot Module name:pgsql-server Changes by: [EMAIL PROTECTED] 0

Re: [COMMITTERS] pgsql-server/ oc/src/sgml/ref/alter_table.sgml ...

2004-05-04 Thread Christopher Kings-Lynne
* ALTER COLUMN TYPE. You can change a column's datatype to anything you want, so long as you can specify how to convert the old value. Rewrites the table. (Possible future improvement: optimize no-op conversions such as varchar(N) to varchar(N+1).) That seriously

Re: [COMMITTERS] pgsql-server/src backend/access/transam/xact.c ...

2004-05-28 Thread Christopher Kings-Lynne
Commit the reasonably uncontroversial parts of J.R. Nield's PITR patch, to wit: Add a header record to each WAL segment file so that it can be reliably identified. Avoid splitting WAL records across segment files (this is not strictly necessary, but makes it simpler

Re: [COMMITTERS] pgsql-server: Minor catalog cleanups for composite-type

2004-06-06 Thread Christopher Kings-Lynne
Minor catalog cleanups for composite-type stuff. Adjust signatures shown in pg_proc for record_in, record_out, etc to reflect that these routines now make use of the second OID parameter. Remove the ancient SET entry in pg_type, which is now highly unlikely to ever become used again. Adjust type_

Re: [COMMITTERS] pgsql-server: Minor catalog cleanups for composite-type

2004-06-06 Thread Christopher Kings-Lynne
Hm? I think the recent discussion was about contracting not to arbitrarily reassign OIDs for existing types. Nobody said anything about not being able to remove types, especially not ones as dead as this doornail was. Yep, that's fine. I believe someone said that we'd never removed one before,

Re: [COMMITTERS] pgsql-server: Minor catalog cleanups for composite-type

2004-06-06 Thread Christopher Kings-Lynne
Uh, why worry? If you had an application that depended in any way shape or form on the SET type, then I already broke it ... Wasn't it a pg_upgrade consideration or something? Chris ---(end of broadcast)--- TIP 3: if posting/reading through Usenet, p

Re: [COMMITTERS] pgsql-server: Clean up generation of default names

2004-06-10 Thread Christopher Kings-Lynne
Clean up generation of default names for constraints, indexes, and serial sequences, as per recent discussion. All these names are now of the form table_column_type, with digits added if needed to make them unique. Default constraint names are chosen to be unique across their whole schema, not jus

Re: [COMMITTERS] pgsql-server: Fix oversight in recent ALTER TABLE

2004-06-10 Thread Christopher Kings-Lynne
Fix oversight in recent ALTER TABLE improvements. We now support ALTER TABLE tab ADD COLUMN col SERIAL, but we forgot to install the dependency between the column and the sequence, so the sequence would not go away if you dropped the table later. What if you ALTER TABLE / TYPE SERIAL? Chris --

Re: [COMMITTERS] pgsql-server: Check more test points (in fact, every

2004-07-10 Thread Christopher Kings-Lynne
Cool, that fixes the detection for me. Chris Tom Lane wrote: Log Message: --- Check more test points (in fact, every week in 1970..2004) to get a more accurate matching of our time zone to the system's zone. This method is able to distinguish Antarctica/Casey from Australia/Perth, as in Ch

Re: [COMMITTERS] pgsql-server: Have \dn+ show permissions and description

2004-07-13 Thread Christopher Kings-Lynne
With \dp having a schema column, how would we display permissions there? Access privileges for database "test" Schema | Name | Type | Access privileges +--+---+--- public | test | table | (1 row) I don't think it makes se

Re: [COMMITTERS] pgsql-server: Fix incorrect tracking of session

2004-07-19 Thread Christopher Kings-Lynne
Is that the pg_dump half of the 'alter owner breaks non-default privileges' bug fix? Chris Tom Lane wrote: Log Message: --- Fix incorrect tracking of session authorization in the presence of ACLs that contain rights granted by non-owners. Per bug report from Nishad Prakash. Modified File