[COMMITTERS] pgsql: Fix typo in comment.

2008-06-09 Thread Neil Conway
Log Message: --- Fix typo in comment. Modified Files: -- pgsql/src/backend/storage/lmgr: proc.c (r1.199 -> r1.200) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/lmgr/proc.c?r1=1.199&r2=1.200) -- Sent via pgsql-committers mailing list

[COMMITTERS] pgsql: Further tweak for comment in CheckDeadLock(), per Tom.

2008-06-09 Thread Neil Conway
Log Message: --- Further tweak for comment in CheckDeadLock(), per Tom. Modified Files: -- pgsql/src/backend/storage/lmgr: proc.c (r1.200 -> r1.201) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/storage/lmgr/proc.c?r1=1.200&r2=1.201) -- Sent

Re: [COMMITTERS] pgsql: Fix typo in comment.

2008-06-09 Thread Neil Conway
On Mon, 2008-06-09 at 11:12 -0400, Tom Lane wrote: > Perhaps putting a comma after the "have" would have been a better > solution than removing it. Yeah, good point -- fixed. -Neil -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription

[COMMITTERS] pgsql: Editorialization for the text emitted by the "help" psql command.

2008-06-10 Thread Neil Conway
Log Message: --- Editorialization for the text emitted by the "help" psql command. Basically just reuse the same text that psql emitted as part of its startup banner in prior versions, and make some whitespace more consistent with the conventions in other psql command output. Modified File

[COMMITTERS] pgsql: Fix a few typos in the DTrace docs.

2008-06-18 Thread Neil Conway
Log Message: --- Fix a few typos in the DTrace docs. Patch from Euler Taveira de Oliveira, along with an additional typo I noticed along the way. Modified Files: -- pgsql/doc/src/sgml: monitoring.sgml (r1.59 -> r1.60) (http://anoncvs.postgresql.org/cvsweb.c

[COMMITTERS] pgsql: Minor improvements to the Gin internal documentation.

2008-07-07 Thread Neil Conway
Log Message: --- Minor improvements to the Gin internal documentation. Modified Files: -- pgsql/src/backend/access/gin: README (r1.5 -> r1.6) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/gin/README?r1=1.5&r2=1.6) -- Sent via pgsql-co

[COMMITTERS] pgsql: Fix a few typos in comments in snapmgr.c, and sort header

2008-07-10 Thread Neil Conway
Log Message: --- Fix a few typos in comments in snapmgr.c, and sort header inclusions alphabetically. Modified Files: -- pgsql/src/backend/utils/time: snapmgr.c (r1.2 -> r1.3) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/time/snapmgr.c?

Re: [COMMITTERS] pgsql: Allow TRUNCATE foo, foo to succeed, per report from Nikhils.

2008-07-16 Thread Neil Conway
On Wed, 2008-07-16 at 21:39 +0100, Simon Riggs wrote: > TRUNCATE foo; > TRUNCATE foo; > > works well. > > So why do we need > > TRUNCATE foo, foo; For the sake of completeness? Having "TRUNCATE foo, foo" fail would be rather inconsistent. -Neil -- Sent via pgsql-committers mailing list

[COMMITTERS] pgsql: Fix a small memory leak in ExecReScanAgg() in the hashed

2008-10-16 Thread Neil Conway
Log Message: --- Fix a small memory leak in ExecReScanAgg() in the hashed aggregation case. In the previous coding, the list of columns that needed to be hashed on was allocated in the per-query context, but we reallocated every time the Agg node was rescanned. Since this information doesn'

[COMMITTERS] pgsql: Fix a small memory leak in ExecReScanAgg() in the hashed

2008-10-16 Thread Neil Conway
Log Message: --- Fix a small memory leak in ExecReScanAgg() in the hashed aggregation case. In the previous coding, the list of columns that needed to be hashed on was allocated in the per-query context, but we reallocated every time the Agg node was rescanned. Since this information doesn'

[COMMITTERS] pgsql: Fix a small memory leak in ExecReScanAgg() in the hashed

2008-10-16 Thread Neil Conway
Log Message: --- Fix a small memory leak in ExecReScanAgg() in the hashed aggregation case. In the previous coding, the list of columns that needed to be hashed on was allocated in the per-query context, but we reallocated every time the Agg node was rescanned. Since this information doesn'

Re: [COMMITTERS] pgsql: Remove inappropriate memory context switch in

2008-11-30 Thread Neil Conway
On Sun, Nov 30, 2008 at 10:49 AM, Tom Lane <[EMAIL PROTECTED]> wrote: > Remove inappropriate memory context switch in shutdown_MultiFuncCall(). > This was a thinko introduced in a patch from last February; it results > in memory leakage if an SRF is shut down before the actual end of query, > becau

Re: [COMMITTERS] pgsql: Remove inappropriate memory context switch in

2008-11-30 Thread Neil Conway
On Sun, Nov 30, 2008 at 1:09 PM, Tom Lane <[EMAIL PROTECTED]> wrote: > Hm, too bad you didn't respond to my message inquiring about this a > couple days ago. My apologies -- my mail filters were overeager, and I didn't see it. > I'll take a look in a bit. However, the switch in the shutdown func

[COMMITTERS] pgsql: Fix typo.

2009-01-16 Thread Neil Conway
Log Message: --- Fix typo. Modified Files: -- pgsql/doc/src/sgml/ref: create_user_mapping.sgml (r1.1 -> r1.2) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ref/create_user_mapping.sgml?r1=1.1&r2=1.2) -- Sent via pgsql-committers mailing lis

[COMMITTERS] pgsql: Fix an ungrammatical statement.

2009-01-16 Thread Neil Conway
Log Message: --- Fix an ungrammatical statement. Modified Files: -- pgsql/doc/src/sgml/ref: create_server.sgml (r1.1 -> r1.2) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ref/create_server.sgml?r1=1.1&r2=1.2) -- Sent via pgsql-committers m

[COMMITTERS] pgsql: Minor documentation tweak: in the tables of functions and

2006-07-16 Thread Neil Conway
Log Message: --- Minor documentation tweak: in the tables of functions and operators, don't include a space between the function name and the parenthesis that begins its parameter list, for consistency. Modified Files: -- pgsql/doc/src/sgml: func.sgml (r1.326 -> r1.

[COMMITTERS] pgsql: Improve psql's \df slash command to include the argument names

2006-07-16 Thread Neil Conway
Log Message: --- Improve psql's \df slash command to include the argument names and modes (OUT or INOUT) of the function. Patch from David Fetter, editorialization by Neil Conway. Modified Files: -- pgsql/src/bin/psql: describe.c (r1.140 -> r1.141)

[COMMITTERS] pgsql: pgcrypto merge cleanup: - Few README fixes - Keep imath Id

2006-07-19 Thread Neil Conway
Log Message: --- pgcrypto merge cleanup: - Few README fixes - Keep imath Id string, put $PostgreSQL$ separately. Patch from Marko Kreen. Modified Files: -- pgsql/contrib/pgcrypto: README.pgcrypto (r1.15 -> r1.16) (http://developer.postgresql.org/cvswe

[COMMITTERS] pgsql: Fix references to the Options section in the pgcrypto

2006-08-04 Thread Neil Conway
Log Message: --- Fix references to the Options section in the pgcrypto documentation. Patch from Michael Fuhr. Tags: REL8_1_STABLE Modified Files: -- pgsql/contrib/pgcrypto: README.pgcrypto (r1.14 -> r1.14.2.1) (http://developer.postgresql.org/cvsweb.

[COMMITTERS] pgsql: Fix references to the Options section in the pgcrypto

2006-08-04 Thread Neil Conway
Log Message: --- Fix references to the Options section in the pgcrypto documentation. Patch from Michael Fuhr. Modified Files: -- pgsql/contrib/pgcrypto: README.pgcrypto (r1.16 -> r1.17) (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/pgcrypto/REA

Re: [COMMITTERS] pgsql: Add Neil's presentation to FAQ_DEV.

2006-08-11 Thread Neil Conway
On Fri, 2006-08-11 at 16:18 -0300, Bruce Momjian wrote: > Add Neil's presentation to FAQ_DEV. Thanks. (It's actually Gavin's talk as well, I should note.) This commit makes this change to FAQ_DEV.html: If you are adding a new feature, confirm that it has been tested -thoroughly. Try to

[COMMITTERS] pgsql: Make the order of the CASCADE and RESTRICT keywords in the DROP

2006-09-18 Thread Neil Conway
Log Message: --- Make the order of the CASCADE and RESTRICT keywords in the DROP OWNED syntax summary consistent with the other SQL reference pages. Patch from Euler Taveira de Oliveira. Modified Files: -- pgsql/doc/src/sgml/ref: drop_owned.sgml (r1.3 -> r1.4)

[COMMITTERS] pgsql: Minor additions and typo fixes for the backup documentation.

2006-09-19 Thread Neil Conway
Log Message: --- Minor additions and typo fixes for the backup documentation. Patch from Simon Riggs, minor editorialization by Neil Conway. Modified Files: -- pgsql/doc/src/sgml: backup.sgml (r2.86 -> r2.87) (http://developer.postgresql.org/cvsweb.

[COMMITTERS] pgsql: Document how to use psql's --single-transaction option to

2006-09-19 Thread Neil Conway
Log Message: --- Document how to use psql's --single-transaction option to rollback restoring an SQL dump if an error occurs. Along the way, make some improvements and copy-edits to the surrounding text. Patch from Simon Riggs, additional fixes by Neil Conway. Modified

[COMMITTERS] pgsql: Do a round of copy-editing for the release notes: fix some typos

2006-09-19 Thread Neil Conway
Log Message: --- Do a round of copy-editing for the release notes: fix some typos and grammatical errors, improve the description of some new features. Modified Files: -- pgsql/doc/src/sgml: release.sgml (r1.442 -> r1.443) (http://developer.postgresql.org/c

[COMMITTERS] pgsql: Improvements to the partitioning documentation.

2006-09-19 Thread Neil Conway
Log Message: --- Improvements to the partitioning documentation. Original patch from Greg Stark, additional fixes and editorialization by Neil Conway. Greg's patch description: Some more doc patches for partitioned tables. In particular replace the caveat that INCL

[COMMITTERS] pgsql: Minor incremental improvements to the release notes.

2006-09-24 Thread Neil Conway
Log Message: --- Minor incremental improvements to the release notes. Modified Files: -- pgsql/doc/src/sgml: release.sgml (r1.453 -> r1.454) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/release.sgml.diff?r1=1.453&r2=1.454) ---

[COMMITTERS] pgsql: More incremental improvements for the release notes.

2006-09-25 Thread Neil Conway
Log Message: --- More incremental improvements for the release notes. Modified Files: -- pgsql/doc/src/sgml: release.sgml (r1.456 -> r1.457) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/release.sgml.diff?r1=1.456&r2=1.457) ---

[COMMITTERS] pgsql: GiST stands for "Generalized Search Tree", and therefore should

2006-09-26 Thread Neil Conway
Log Message: --- GiST stands for "Generalized Search Tree", and therefore should not be spelled with a capital "I". Modified Files: -- pgsql/doc/src/sgml: release.sgml (r1.459 -> r1.460) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/release

[COMMITTERS] pgsql: Fix a typo.

2006-10-06 Thread Neil Conway
Log Message: --- Fix a typo. Modified Files: -- pgsql/doc/src/sgml: release.sgml (r1.462 -> r1.463) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/release.sgml.diff?r1=1.462&r2=1.463) ---(end of broadcast)---

Re: [COMMITTERS] pgsql: Add main documentation link tags to the

2006-10-06 Thread Neil Conway
On Fri, 2006-10-06 at 23:18 -0300, Bruce Momjian wrote: > Add main documentation link tags to the release notes. This commit introduces a bunch of hard tabs into release.sgml. This needlessly bloats the CVS history, and is inconsistent with the indentation in the rest of the file and in the SGML d

[COMMITTERS] pgsql: In the installation docs, add some links to the documentation on

2006-10-12 Thread Neil Conway
Log Message: --- In the installation docs, add some links to the documentation on LDAP to the discussion of the "--with-ldap" configure option. Patch from Albe Laurenz. Modified Files: -- pgsql/doc/src/sgml: installation.sgml (r1.263 -> r1.264) (http://deve

[COMMITTERS] pgsql: Make some incremental improvements and fixes to the documentation

2006-10-12 Thread Neil Conway
Log Message: --- Make some incremental improvements and fixes to the documentation on Continuous Archiving. Plenty of editorial work remains... Modified Files: -- pgsql/doc/src/sgml: backup.sgml (r2.89 -> r2.90) (http://developer.postgresql.org/cvsweb.cgi/p

[COMMITTERS] pgsql: Fix typo.

2006-10-19 Thread Neil Conway
Log Message: --- Fix typo. Modified Files: -- pgsql/contrib/adminpack: adminpack.c (r1.4 -> r1.5) (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/adminpack/adminpack.c.diff?r1=1.4&r2=1.5) ---(end of broadcast)-

[COMMITTERS] pgsql: Minor doc tweak: make a reference to pg_locks into a link.

2006-10-20 Thread Neil Conway
Log Message: --- Minor doc tweak: make a reference to pg_locks into a link. Modified Files: -- pgsql/doc/src/sgml: mvcc.sgml (r2.63 -> r2.64) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/mvcc.sgml.diff?r1=2.63&r2=2.64) ---

[COMMITTERS] pgsql: Fix typo in backup docs.

2006-10-29 Thread Neil Conway
Log Message: --- Fix typo in backup docs. Patch from Euler Taveira de Oliveira. Modified Files: -- pgsql/doc/src/sgml: backup.sgml (r2.91 -> r2.92) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/backup.sgml.diff?r1=2.91&r2=2.92) ---

[COMMITTERS] pgsql: Add text to the VACUUM, REINDEX, DROP TABLESPACE and CREATE

2006-10-30 Thread Neil Conway
Log Message: --- Add text to the VACUUM, REINDEX, DROP TABLESPACE and CREATE TABLESPACE reference pages documenting that these commands cannot be used within a transaction block. Also make some minor improvements to the psql reference page. Patch from Simon Riggs, minor editorialization by

[COMMITTERS] pgsql: Minor fix for LDAP authentication: if an error occurs, we need to

2006-11-05 Thread Neil Conway
Log Message: --- Minor fix for LDAP authentication: if an error occurs, we need to manually release the LDAP handle via ldap_unbind(). This isn't a significant problem in practice because an error eventually results in exiting the process, but we can cleanup correctly without too much pain.

[COMMITTERS] pgsql: Remove a 15-year old comment questioning behavior that is now

2006-11-07 Thread Neil Conway
Log Message: --- Remove a 15-year old comment questioning behavior that is now well- established: referencing an undefined parameter should result in an error, not NULL. Modified Files: -- pgsql/src/backend/executor: execQual.c (r1.197 -> r1.198) (http://de

[COMMITTERS] pgsql: Fix a memory leak in psql: we'd leak a few PGresult handles if a

2006-11-07 Thread Neil Conway
Log Message: --- Fix a memory leak in psql: we'd leak a few PGresult handles if a connectivity error occurred while executing one of the queries for "\d ". Not serious, but still worth fixing. Patch from Brendan Jurd. Modified Files: -- pgsql/src/bin/psql: describe.

[COMMITTERS] pgsql: Fix two typos.

2006-11-08 Thread Neil Conway
Log Message: --- Fix two typos. Modified Files: -- pgsql/contrib/tsearch2: README.tsearch2 (r1.5 -> r1.6) (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/tsearch2/README.tsearch2.diff?r1=1.5&r2=1.6) ---(end of broadcast)--

[COMMITTERS] pgsql: Minor code cleanup for pgcrypto: for UDFs declared to be strict,

2006-11-09 Thread Neil Conway
Log Message: --- Minor code cleanup for pgcrypto: for UDFs declared to be strict, checking for NULL-ness of function arguments is wasted code. Modified Files: -- pgsql/contrib/pgcrypto: pgcrypto.c (r1.24 -> r1.25) (http://developer.postgresql.org/cvsweb.cgi

[COMMITTERS] pgsql: Minor improvements to the description of archive_timeout.

2006-11-11 Thread Neil Conway
Log Message: --- Minor improvements to the description of archive_timeout. Modified Files: -- pgsql/doc/src/sgml: config.sgml (r1.94 -> r1.95) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/config.sgml.diff?r1=1.94&r2=1.95)

[COMMITTERS] pgsql: Do a round of copy-editing for the system catalog chapter.

2006-11-11 Thread Neil Conway
Log Message: --- Do a round of copy-editing for the system catalog chapter. In particular, consistently capitalize the content of the "Description" column but do not include a terminating period, as is the convention elsewhere in the docs. Also, remove the "References" column from catalog t

[COMMITTERS] pgsql: Fix some typos in comments.

2006-11-11 Thread Neil Conway
Log Message: --- Fix some typos in comments. Modified Files: -- pgsql/src/backend/access/gin: ginbtree.c (r1.5 -> r1.6) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/gin/ginbtree.c.diff?r1=1.5&r2=1.6) gindatapage.c (r1.4 -> r1

[COMMITTERS] pgsql: Remove a bunch of antique information from the appendix in the

2006-11-16 Thread Neil Conway
Log Message: --- Remove a bunch of antique information from the appendix in the docs that discusses CVS. Remove the recommendation to use cvs 1.10. Remove discussion of alleged CVSup binaries on postgresql.org, because they have not existed for several years. Remove discussion of how to bui

[COMMITTERS] pgsql: Fix a typo.

2006-11-17 Thread Neil Conway
Log Message: --- Fix a typo. Modified Files: -- pgsql/doc/src/sgml: failover.sgml (r1.11 -> r1.12) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/failover.sgml.diff?r1=1.11&r2=1.12) ---(end of broadcast)-

[COMMITTERS] pgsql: Fix a typo in recent xfunc addition, do some routine SGML police

2006-11-22 Thread Neil Conway
Log Message: --- Fix a typo in recent xfunc addition, do some routine SGML police work. Modified Files: -- pgsql/doc/src/sgml: xfunc.sgml (r1.118 -> r1.119) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/xfunc.sgml.diff?r1=1.118&r2=1.119) -

[COMMITTERS] pgsql: Add a comment noting that heap_copytuple_with_tuple() results in

2006-11-22 Thread Neil Conway
Log Message: --- Add a comment noting that heap_copytuple_with_tuple() results in a HeapTuple that is no longer allocated as a single palloc() block; if used carelessly, this might result in a subsequent memory leak after heap_freetuple(). Modified Files: -- pgsql/src/backe

[COMMITTERS] pgsql: More minor SGML improvements for xfunc.sgml, including making

2006-11-22 Thread Neil Conway
Log Message: --- More minor SGML improvements for xfunc.sgml, including making some titles more concise. (We usually don't need to repeat the name of a section in the title of one of its subsections.) Modified Files: -- pgsql/doc/src/sgml: xfunc.sgml (r1.119 -> r1.1

[COMMITTERS] pgsql: Spelling and related minor fixes for the GIN docs.

2006-11-22 Thread Neil Conway
Log Message: --- Spelling and related minor fixes for the GIN docs. Modified Files: -- pgsql/doc/src/sgml: gin.sgml (r2.4 -> r2.5) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/gin.sgml.diff?r1=2.4&r2=2.5) ---(end o

[COMMITTERS] pgsql: Cosmetic release note fix.

2006-11-25 Thread Neil Conway
Log Message: --- Cosmetic release note fix. Modified Files: -- pgsql/doc/src/sgml: release.sgml (r1.485 -> r1.486) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/release.sgml.diff?r1=1.485&r2=1.486) ---(end of broadc

[COMMITTERS] pgsql: Fix typos in comments and error messages in HStore.

2006-12-05 Thread Neil Conway
Log Message: --- Fix typos in comments and error messages in HStore. Patch from Filip Rembialkowski, with some additional fixes by myself. Modified Files: -- pgsql/contrib/hstore: hstore_io.c (r1.5 -> r1.6) (http://developer.postgresql.org/cvsweb.cgi/pgsql/

[COMMITTERS] pgsql: Various improvements to the GUC description strings.

2006-12-06 Thread Neil Conway
Log Message: --- Various improvements to the GUC description strings. Punctuate and capitalize the strings like sentences. Remove unnecessarily specific descriptions of the units used by GUC variables, since we now allow any reasonable unit to be specified. Modified Files: --

[COMMITTERS] pgsql: Add a txn_start column to pg_stat_activity.

2006-12-06 Thread Neil Conway
Log Message: --- Add a txn_start column to pg_stat_activity. This makes it easier to identify long-running transactions. Since we already need to record the transaction-start time (e.g. for now()), we don't need any additional system calls to report this information. Catversion bumped, ini

[COMMITTERS] pgsql: Fix the build for when SHOW_MEMORY_STATS is defined.

2006-12-07 Thread Neil Conway
Log Message: --- Fix the build for when SHOW_MEMORY_STATS is defined. The reference to the nonexistent ShowStats variable is simply removed, per Gavin Sherry. Modified Files: -- pgsql/src/backend/tcop: postgres.c (r1.518 -> r1.519) (http://developer.postgre

[COMMITTERS] pgsql: This patch enables verbose output when building all projects.

2007-01-09 Thread Neil Conway
Log Message: --- This patch enables verbose output when building all projects. This is the same output level that was used when building a single project before, and really needed to get reasonable information about what happens (non-verbose just says "starting build of foo" and "done build

[COMMITTERS] pgsql: Attached patch fixes two problems: 1) gendef works from inside

2007-01-09 Thread Neil Conway
Log Message: --- Attached patch fixes two problems: 1) gendef works from inside visual studio - use a tempfile instead of redirection, because for some reason you can't redirect dumpbin from inside (patch from Joachim Wieland) 2) gendef must process only *.obj, or you get weird errors in s

Re: [COMMITTERS] pgsql: Allow for arbitrary data types as content

2007-01-12 Thread Neil Conway
On Fri, 2007-01-12 at 12:29 -0400, Peter Eisentraut wrote: > Allow for arbitrary data types as content in XMLELEMENT. The original > coercion to type xml was a mistake. Escape values so they are valid > XML character data. parse_expr.c: In function 'transformXmlExpr': parse_expr.c:1452: warning:

[COMMITTERS] pgsql: Add a note to the docs describing NaN's equality and ordering

2007-01-14 Thread Neil Conway
Log Message: --- Add a note to the docs describing NaN's equality and ordering behavior. Per recent -hackers thread, this is noteworthy because Postgres behaves differently from most implementations of NaN, including IEEE754. Modified Files: -- pgsql/doc/src/sgml: d

[COMMITTERS] pgsql: Correct a minor inaccuracy in the pg_dumpall reference page: -g

2007-01-15 Thread Neil Conway
Log Message: --- Correct a minor inaccuracy in the pg_dumpall reference page: -g dumps roles and tablespaces, no longer users and groups. Per Dave Page. Backport to 8.2 and 8.1. Tags: REL8_1_STABLE Modified Files: -- pgsql/doc/src/sgml/ref: pg_dumpall.sgml (r

[COMMITTERS] pgsql: Correct a minor inaccuracy in the pg_dumpall reference page: -g

2007-01-15 Thread Neil Conway
Log Message: --- Correct a minor inaccuracy in the pg_dumpall reference page: -g dumps roles and tablespaces, no longer users and groups. Per Dave Page. Backport to 8.2 and 8.1. Tags: REL8_2_STABLE Modified Files: -- pgsql/doc/src/sgml/ref: pg_dumpall.sgml (r

[COMMITTERS] pgsql: Correct a minor inaccuracy in the pg_dumpall reference page: -g

2007-01-15 Thread Neil Conway
Log Message: --- Correct a minor inaccuracy in the pg_dumpall reference page: -g dumps roles and tablespaces, no longer users and groups. Per Dave Page. Backport to 8.2 and 8.1. Modified Files: -- pgsql/doc/src/sgml/ref: pg_dumpall.sgml (r1.58 -> r1.59) (h

[COMMITTERS] pgsql: Minor improvements to the TODO list.

2007-01-16 Thread Neil Conway
Log Message: --- Minor improvements to the TODO list. Add some URLs for some existing TODO items, and re-add a TODO item for an "estimated count" capability. Modified Files: -- pgsql/doc: TODO (r1.2040 -> r1.2041) (http://developer.postgresql.org/cvsweb.cgi

[COMMITTERS] pgsql: Implement width_bucket() for the float8 data type.

2007-01-16 Thread Neil Conway
Log Message: --- Implement width_bucket() for the float8 data type. The implementation is somewhat ugly logic-wise, but I don't see an easy way to make it more concise. When writing this, I noticed that my previous implementation of width_bucket() doesn't handle NaN correctly: postgr

[COMMITTERS] pgsql: vcbuild updates from Magnus: * After Markos patch, now builds

2007-01-16 Thread Neil Conway
Log Message: --- vcbuild updates from Magnus: * After Markos patch, now builds pgcrypto without zlib again * Updates README with xml info * xml requires xslt and iconv * disable unnecessary warning about __cdecl() * Add a buildenv.bat called from all other bat files to set up things like P

[COMMITTERS] pgsql: Tweak the width_bucket() regression tests to avoid an unnecessary

2007-01-17 Thread Neil Conway
Log Message: --- Tweak the width_bucket() regression tests to avoid an unnecessary dependency on the platform's floating point implementation. Per report from Stefan Kaltenbrunner. Modified Files: -- pgsql/src/test/regress/expected: numeric.out (r1.20 -> r1.21)

[COMMITTERS] pgsql: Add missing copyright blurb, make ruleutils.c use the standard

2007-01-19 Thread Neil Conway
Log Message: --- Add missing copyright blurb, make ruleutils.c use the standard layout for its header comment. Modified Files: -- pgsql/src/backend/utils/adt: pg_lzcompress.c (r1.23 -> r1.24) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/uti

[COMMITTERS] pgsql: Teach psql's \lo slash commands to respect quiet mode, and to

2007-01-20 Thread Neil Conway
Log Message: --- Teach psql's \lo slash commands to respect quiet mode, and to output HTML in HTML mode. Patch from Jeremy Drake. Modified Files: -- pgsql/doc/src/sgml/ref: psql-ref.sgml (r1.179 -> r1.180) (http://developer.postgresql.org/cvsweb.cgi/pgsql/d

[COMMITTERS] pgsql: Regression tests for large objects.

2007-01-20 Thread Neil Conway
Log Message: --- Regression tests for large objects. Patch from Jeremy Drake. Modified Files: -- pgsql/src/test/regress: parallel_schedule (r1.36 -> r1.37) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/parallel_schedule.diff?r1=1.36&r2=

[COMMITTERS] pgsql: Refactor the index AM API slightly: move currentItemData and

2007-01-20 Thread Neil Conway
Log Message: --- Refactor the index AM API slightly: move currentItemData and currentMarkData from IndexScanDesc to the opaque structs for the AMs that need this information (currently gist and hash). Patch from Heikki Linnakangas, fixes by Neil Conway. Modified Files

[COMMITTERS] pgsql: List disabled triggers separately in psql's "\d " output.

2007-01-20 Thread Neil Conway
Log Message: --- List disabled triggers separately in psql's "\d " output. Previously, disabled triggers were not displayed any differently than enabled ones, which was quite misleading. Patch from Brendan Jurd. Modified Files: -- pgsql/src/bin/psql: describe.c (r1.

[COMMITTERS] pgsql: Make setseed() return void, rather than an int4 without any use.

2007-01-20 Thread Neil Conway
Log Message: --- Make setseed() return void, rather than an int4 without any use. Per pgsql-patches discussion of September 20, 2006. Bump the catversion. Modified Files: -- pgsql/src/backend/utils/adt: float.c (r1.147 -> r1.148) (http://developer.postgresq

[COMMITTERS] pgsql: Update docs for recent change to setseed() return value.

2007-01-20 Thread Neil Conway
Log Message: --- Update docs for recent change to setseed() return value. Modified Files: -- pgsql/doc/src/sgml: func.sgml (r1.351 -> r1.352) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/func.sgml.diff?r1=1.351&r2=1.352) -

[COMMITTERS] pgsql: Add a setlocal command to the beginning of build.bat.

2007-01-25 Thread Neil Conway
Log Message: --- Add a setlocal command to the beginning of build.bat. This is required to deal with buildenv.bat properly, so that PATH (for example) doesn't expand infintly. Per report from Joachim Wieland, patch from Magnus. Modified Files: -- pgsql/src/tools/msvc:

[COMMITTERS] pgsql: Squelch some VC++ compiler warnings.

2007-01-26 Thread Neil Conway
Log Message: --- Squelch some VC++ compiler warnings. Mark float literals with the "f" suffix, to distinguish them from doubles. Make some function declarations and definitions use the "const" qualifier for arguments consistently. Ignore warning 4102 ("unreferenced label"), because such wa

[COMMITTERS] pgsql: Add a new builtin type, "uuid".

2007-01-28 Thread Neil Conway
Log Message: --- Add a new builtin type, "uuid". This implements a UUID type, similar to that defined in RFC 4122. This patch includes the basic implementation, plus regression tests. Documentation and perhaps some additional functionality will come later. Catversion bumped. Patch from Gev

[COMMITTERS] pgsql: Rename the uuid_t type to pg_uuid_t, to avoid a conflict with any

2007-01-28 Thread Neil Conway
Log Message: --- Rename the uuid_t type to pg_uuid_t, to avoid a conflict with any definitions of uuid_t that may be provided by the system headers. This should hopefully fix the Win32 build problems reported by Magnus. Modified Files: -- pgsql/src/backend/utils/adt:

[COMMITTERS] pgsql: Rewrite uuid input and output routines to avoid dependency on the

2007-01-31 Thread Neil Conway
Log Message: --- Rewrite uuid input and output routines to avoid dependency on the nonportable "hh" sprintf(3) length modifier. Instead, do the parsing and output by hand. The code to do this isn't ideal, but this is an interim measure anyway: the uuid type should probably use the in-memory

[COMMITTERS] pgsql: Add missing Makefile dependencies for the "bigtest" and

2007-01-31 Thread Neil Conway
Log Message: --- Add missing Makefile dependencies for the "bigtest" and "bigcheck" targets, and refactor the tablespace setup code into a separate Makefile target. Modified Files: -- pgsql/src/test/regress: GNUmakefile (r1.64 -> r1.65) (http://developer.po

[COMMITTERS] pgsql: Fix a few typos in comments in GiN.

2007-01-31 Thread Neil Conway
Log Message: --- Fix a few typos in comments in GiN. Modified Files: -- pgsql/src/backend/access/gin: ginbtree.c (r1.7 -> r1.8) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/gin/ginbtree.c.diff?r1=1.7&r2=1.8) ginbulk.c (r1.8 -

[COMMITTERS] pgsql: This patch adds documentation for the long-version parameters

2007-01-31 Thread Neil Conway
Log Message: --- This patch adds documentation for the long-version parameters --username and --password for pg_dump, pg_dumpall and pg_restore, per complaint by Michael Schmidt. Patch from Magnus Hagander. Modified Files: -- pgsql/doc/src/sgml/ref: pg_dump.sgml (r1

[COMMITTERS] pgsql: Fix broken markup.

2007-01-31 Thread Neil Conway
Log Message: --- Fix broken markup. Modified Files: -- pgsql/doc/src/sgml: release.sgml (r1.494 -> r1.495) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/release.sgml.diff?r1=1.494&r2=1.495) ---(end of broadcast)

[COMMITTERS] pgsql: Backpatch last night's fix for broken markup to the 8.2 branch.

2007-02-01 Thread Neil Conway
Log Message: --- Backpatch last night's fix for broken markup to the 8.2 branch. Tags: REL8_2_STABLE Modified Files: -- pgsql/doc/src/sgml: release.sgml (r1.488.2.3 -> r1.488.2.4) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/release.

[COMMITTERS] pgsql: Update some of the "expected" regression test results for Bruce's

2007-02-01 Thread Neil Conway
Log Message: --- Update some of the "expected" regression test results for Bruce's recent may/might cleanup, in the hopes that this will unbreak the buildfarm. Per report from Stefan Kaltenbrunner. Modified Files: -- pgsql/src/pl/plperl/expected: plperl_elog.out (r1

[COMMITTERS] pgsql: Fix two more regression tests whose expected outputs were not

2007-02-01 Thread Neil Conway
Log Message: --- Fix two more regression tests whose expected outputs were not updated for the recent may/might cleanup. Modified Files: -- pgsql/contrib/dblink/expected: dblink.out (r1.18 -> r1.19) (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/

[COMMITTERS] pgsql: Reword suggestion that libpq.dll be installed in WINNT\SYSTEM32

2007-02-02 Thread Neil Conway
Log Message: --- Reword suggestion that libpq.dll be installed in WINNT\SYSTEM32 under Windows. Per Magnus Hagander, this is not recommended. Tags: REL8_0_STABLE Modified Files: -- pgsql/doc/src/sgml: install-win32.sgml (r1.23.4.3 -> r1.23.4.4) (http:

[COMMITTERS] pgsql: Reword suggestion that libpq.dll be installed in WINNT\SYSTEM32

2007-02-02 Thread Neil Conway
Log Message: --- Reword suggestion that libpq.dll be installed in WINNT\SYSTEM32 under Windows. Per Magnus Hagander, this is not recommended. Tags: REL8_1_STABLE Modified Files: -- pgsql/doc/src/sgml: install-win32.sgml (r1.26 -> r1.26.2.1) (http://de

[COMMITTERS] pgsql: Reword suggestion that libpq.dll be installed in WINNT\SYSTEM32

2007-02-02 Thread Neil Conway
Log Message: --- Reword suggestion that libpq.dll be installed in WINNT\SYSTEM32 under Windows. Per Magnus Hagander, this is not recommended. Modified Files: -- pgsql/doc/src/sgml: install-win32.sgml (r1.29 -> r1.30) (http://developer.postgresql.org/cvsweb.

[COMMITTERS] pgsql: Reword suggestion that libpq.dll be installed in WINNT\SYSTEM32

2007-02-02 Thread Neil Conway
Log Message: --- Reword suggestion that libpq.dll be installed in WINNT\SYSTEM32 under Windows. Per Magnus Hagander, this is not recommended. Tags: REL8_2_STABLE Modified Files: -- pgsql/doc/src/sgml: install-win32.sgml (r1.29 -> r1.29.2.1) (http://de

[COMMITTERS] pgsql: This patch changes the installscript for vcbuild to actually

2007-02-02 Thread Neil Conway
Log Message: --- This patch changes the installscript for vcbuild to actually parse the generated solution files for what to install, instead of blindly copying everything as it previously did. With the previous quick-n-dirty version, it would copy old DLLs if you reconfigured in a way that

[COMMITTERS] pgsql: Unbreak the SGML doc build: ":=" is needed to assign to variables

2007-02-09 Thread Neil Conway
Log Message: --- Unbreak the SGML doc build: ":=" is needed to assign to variables if the RHS of the assignment expands to a reference to the LHS. Modified Files: -- pgsql/doc/src/sgml: Makefile (r1.95 -> r1.96) (http://developer.postgresql.org/cvsweb.cgi/p

Re: [COMMITTERS] pgsql: Fix for early log messages during postmaster startup getting lost

2007-02-11 Thread Neil Conway
On Sun, 2007-02-11 at 07:59 -0400, Magnus Hagander wrote: > Fix for early log messages during postmaster startup getting lost when > running as a service on Win32. FYI, it is considered good practise to commit a patch at approximately (or exactly) the same time on all branches, so tools like cvs2c

[COMMITTERS] pgsql: Fix capitalization and punctuation of two more GUC description

2007-02-13 Thread Neil Conway
Log Message: --- Fix capitalization and punctuation of two more GUC description strings. Modified Files: -- pgsql/src/backend/utils/misc: guc.c (r1.373 -> r1.374) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c.diff?r1=1.373&r

[COMMITTERS] pgsql: Add resetStringInfo(), which clears the content of a StringInfo,

2007-03-03 Thread Neil Conway
Log Message: --- Add resetStringInfo(), which clears the content of a StringInfo, and fixup various places in the tree that were clearing a StringInfo by hand. Making this function a part of the API simplifies client code slightly, and avoids needlessly peeking inside the StringInfo interfa

[COMMITTERS] pgsql: Make the newly-added regression tests for lo_truncate()

2007-03-03 Thread Neil Conway
Log Message: --- Make the newly-added regression tests for lo_truncate() consistent with the recent largeobject cosmetic fixes. Jeremy Drake. Modified Files: -- pgsql/src/test/regress/input: largeobject.source (r1.3 -> r1.4) (http://developer.postgresql.org

[COMMITTERS] pgsql: Fix a typo in a comment.

2007-03-05 Thread Neil Conway
Log Message: --- Fix a typo in a comment. Heikki Linnakangas. Modified Files: -- pgsql/src/backend/access/nbtree: nbtinsert.c (r1.153 -> r1.154) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/nbtree/nbtinsert.c.diff?r1=1.153&r2=1.154)

pgsql-committers@postgresql.org

2007-03-17 Thread Neil Conway
Log Message: --- Code cleanup for function prototypes: change two K&R-style prototypes to ANSI-style, and change "()" -> "(void)". Patch from Stefan Huehner. Modified Files: -- pgsql/src/pl/plpgsql/src: pl_funcs.c (r1.57 -> r1.58) (http://developer.postgres

[COMMITTERS] pgsql: Code cleanup: mark some variables with the "const" modifier, when

2007-03-18 Thread Neil Conway
Log Message: --- Code cleanup: mark some variables with the "const" modifier, when they are initialized with a string literal. Patch from Stefan Huehner. Modified Files: -- pgsql/src/backend/utils/adt: ruleutils.c (r1.255 -> r1.256) (http://developer.postgr

Re: [COMMITTERS] pgsql: Bumping catversion due to changes to pg_trigger and pg_rewrite.

2007-03-19 Thread Neil Conway
Jan Wieck wrote: BTW, the comment in this file says that we hope we never have more than 10 catversion changes per day, but to even make this possible we should start counting at zero, shouldn't we? The comment says "hopefully we'll never commit ten independent sets of catalog changes on th

  1   2   3   4   5   6   7   8   9   >