[COMMITTERS] pgsql: Don't emit non-canonical empty arrays in array_remove().

2013-06-02 Thread Noah Misch
Don't emit non-canonical empty arrays in array_remove(). Dean Rasheed Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/97c4d9b7c71519d9dc281394af2c4bcb28bdf136 Modified Files -- src/backend/utils/adt/arrayfuncs.c |8 src/test/regress/expecte

[COMMITTERS] pgsql: Avoid reading below the start of a stack variable in tokenize_fi

2013-06-12 Thread Noah Misch
Avoid reading below the start of a stack variable in tokenize_file(). We would wrongly overwrite the prior stack byte if it happened to contain '\n' or '\r'. New in 9.3, so no back-patch. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3a5d0c55338e6beb4c01ed5fadb146

[COMMITTERS] pgsql: Observe array length in HaveVirtualXIDsDelayingChkpt().

2013-06-12 Thread Noah Misch
Observe array length in HaveVirtualXIDsDelayingChkpt(). Since commit f21bb9cfb5646e1793dcc9c0ea697bab99afa523, this function ignores the caller-provided length and loops until it finds a terminator, which GetVirtualXIDsDelayingChkpt() never adds. Restore the previous loop control logic. In passi

[COMMITTERS] pgsql: Avoid reading past datum end when parsing JSON.

2013-06-12 Thread Noah Misch
Avoid reading past datum end when parsing JSON. Several loops in the JSON parser examined a byte in memory just before checking whether its address was in-bounds, so they could read one byte beyond the datum's allocation. A SIGSEGV is possible. New in 9.3, so no back-patch. Branch -- master

[COMMITTERS] pgsql: Don't use ordinary NULL-terminated strings as Name datums.

2013-06-12 Thread Noah Misch
Don't use ordinary NULL-terminated strings as Name datums. Consumers are entitled to read the full 64 bytes pertaining to a Name; using a shorter NULL-terminated string leads to reading beyond the end its allocation; a SIGSEGV is possible. Use the frequent idiom of copying to a NameData on the st

[COMMITTERS] pgsql: Don't pass oidvector by value.

2013-06-12 Thread Noah Misch
Don't pass oidvector by value. Since the structure ends with a flexible array, doing so truncates any vector having more than one element. New in 9.3, so no back-patch. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/813895e4acfa646c6c0405a0a8c5d05637f42865 Modifie

[COMMITTERS] pgsql: Renovate display of non-ASCII messages on Windows.

2013-06-26 Thread Noah Misch
o Windows event logs and consoles. Alexander Law and Noah Misch Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5f538ad004aa00cf0881f179f0cde789aad4f47e Modified Files -- src/backend/main/main.c |4 ++ src/backend/utils/adt/pg_locale.c | 34

[COMMITTERS] pgsql: Document effect of constant folding on CASE.

2013-06-26 Thread Noah Misch
Document effect of constant folding on CASE. Back-patch to all supported versions. Laurenz Albe Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/d5ce39365f8b014e76277af6f6d9b0cd80691e1d Modified Files -- doc/src/sgml/func.sgml | 10 ++ 1

[COMMITTERS] pgsql: Document effect of constant folding on CASE.

2013-06-26 Thread Noah Misch
Document effect of constant folding on CASE. Back-patch to all supported versions. Laurenz Albe Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d53f7cf11658a3252a6fddf308b992b751379f09 Modified Files -- doc/src/sgml/func.sgml | 10 ++ 1 file ch

[COMMITTERS] pgsql: Document effect of constant folding on CASE.

2013-06-26 Thread Noah Misch
Document effect of constant folding on CASE. Back-patch to all supported versions. Laurenz Albe Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/8356d9498860cd377eb1edd8b64a840b6b411081 Modified Files -- doc/src/sgml/func.sgml | 10 ++ 1

[COMMITTERS] pgsql: Document effect of constant folding on CASE.

2013-06-26 Thread Noah Misch
Document effect of constant folding on CASE. Back-patch to all supported versions. Laurenz Albe Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/1f3fbced6502dbe0427331dfa47fed0f3c50b955 Modified Files -- doc/src/sgml/func.sgml | 10 ++ 1

[COMMITTERS] pgsql: Document effect of constant folding on CASE.

2013-06-26 Thread Noah Misch
Document effect of constant folding on CASE. Back-patch to all supported versions. Laurenz Albe Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/ca1700130be70d6b2c5dfcabbf0717036bf6bded Modified Files -- doc/src/sgml/func.sgml | 10 ++ 1

[COMMITTERS] pgsql: Initialize pad bytes in GinFormTuple().

2013-06-26 Thread Noah Misch
Initialize pad bytes in GinFormTuple(). Every other core buffer page consumer initializes the bytes it furnishes to PageAddItem(). For consistency, do the same here. No back-patch; regardless, we couldn't count on the fix so long as binary upgrade can carry forward affected index builds. Branch

[COMMITTERS] pgsql: Cooperate with the Valgrind instrumentation framework.

2013-06-26 Thread Noah Misch
Cooperate with the Valgrind instrumentation framework. Valgrind "client requests" in aset.c and mcxt.c teach Valgrind and its Memcheck tool about the PostgreSQL allocator. This makes Valgrind roughly as sensitive to memory errors involving palloc chunks as it is to memory errors involving malloc

[COMMITTERS] pgsql: Refactor aset.c and mcxt.c in preparation for Valgrind cooperati

2013-06-26 Thread Noah Misch
Refactor aset.c and mcxt.c in preparation for Valgrind cooperation. Move some repeated debugging code into functions and store intermediates in variables where not presently necessary. No code-generation changes in a production build, and no functional changes. This simplifies and focuses the ma

[COMMITTERS] pgsql: Document effect of constant folding on CASE.

2013-06-26 Thread Noah Misch
Document effect of constant folding on CASE. Back-patch to all supported versions. Laurenz Albe Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/40265e3446b0c037510bb05dfe80e4131e77b754 Modified Files -- doc/src/sgml/func.sgml | 10 ++ 1

[COMMITTERS] pgsql: Permit super-MaxAllocSize allocations with MemoryContextAllocHug

2013-06-27 Thread Noah Misch
Permit super-MaxAllocSize allocations with MemoryContextAllocHuge(). The MaxAllocSize guard is convenient for most callers, because it reduces the need for careful attention to overflow, data type selection, and the SET_VARSIZE() limit. A handful of callers are happy to navigate those hazards in

Re: [COMMITTERS] pgsql: Permit super-MaxAllocSize allocations with MemoryContextAllocHug

2013-07-02 Thread Noah Misch
On Tue, Jul 02, 2013 at 12:08:42PM +0200, Andres Freund wrote: > On 2013-06-27 19:05:22 +0000, Noah Misch wrote: > > Permit super-MaxAllocSize allocations with MemoryContextAllocHuge(). > > > > The MaxAllocSize guard is convenient for most callers, because it > > r

[COMMITTERS] pgsql: Expose object name error fields in PL/pgSQL.

2013-07-03 Thread Noah Misch
. Back-patch to 9.3, where core support for the error fields was introduced. This prevents the confusion of having a release where libpq exposes the fields and PL/pgSQL does not. Pavel Stehule, lexical revisions by Noah Misch. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg

[COMMITTERS] pgsql: Expose object name error fields in PL/pgSQL.

2013-07-03 Thread Noah Misch
. Back-patch to 9.3, where core support for the error fields was introduced. This prevents the confusion of having a release where libpq exposes the fields and PL/pgSQL does not. Pavel Stehule, lexical revisions by Noah Misch. Branch -- master Details --- http://git.postgresql.org/pg

Re: [COMMITTERS] pgsql: Permit super-MaxAllocSize allocations with MemoryContextAllocHug

2013-07-03 Thread Noah Misch
On Tue, Jul 02, 2013 at 10:33:38AM -0400, Noah Misch wrote: > On Tue, Jul 02, 2013 at 12:08:42PM +0200, Andres Freund wrote: > > On 2013-06-27 19:05:22 +0000, Noah Misch wrote: > > > Permit super-MaxAllocSize allocations with MemoryContextAllocHuge(). > > > >

[COMMITTERS] pgsql: Use type "int64" for memory accounting in tuplesort.c/tuplestore

2013-07-04 Thread Noah Misch
Use type "int64" for memory accounting in tuplesort.c/tuplestore.c. Commit 263865a48973767ce8ed7b7788059a38a24a9f37 switched tuplesort.c and tuplestore.c variables representing memory usage from type "long" to type "Size". This was unnecessary; I thought doing so avoided overflow scenarios on 64-

[COMMITTERS] pgsql: Update messages, comments and documentation for materialized vie

2013-07-05 Thread Noah Misch
Update messages, comments and documentation for materialized views. All instances of the verbiage lagging the code. Back-patch to 9.3, where materialized views were introduced. Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/cf183732d2b2bda2f6fd927481f787ecb1

[COMMITTERS] pgsql: Update messages, comments and documentation for materialized vie

2013-07-05 Thread Noah Misch
Update messages, comments and documentation for materialized views. All instances of the verbiage lagging the code. Back-patch to 9.3, where materialized views were introduced. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/02d2b694ee42a9e241d37ce67df122fff43d5bb9

[COMMITTERS] pgsql: Make comments reflect that omission of SPI_gettypmod() is intent

2013-07-12 Thread Noah Misch
Make comments reflect that omission of SPI_gettypmod() is intentional. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/448fee2e238ae4797e68d7d15b49f2fc52691547 Modified Files -- src/backend/executor/spi.c |6 ++ src/pl/plpgsql/src/pl_exec.c |

[COMMITTERS] pgsql: Switch user ID to the object owner when populating a materialize

2013-07-12 Thread Noah Misch
Switch user ID to the object owner when populating a materialized view. This makes superuser-issued REFRESH MATERIALIZED VIEW safe regardless of the object's provenance. REINDEX is an earlier example of this pattern. As a downside, functions called from materialized views must tolerate running in

[COMMITTERS] pgsql: Switch user ID to the object owner when populating a materialize

2013-07-12 Thread Noah Misch
Switch user ID to the object owner when populating a materialized view. This makes superuser-issued REFRESH MATERIALIZED VIEW safe regardless of the object's provenance. REINDEX is an earlier example of this pattern. As a downside, functions called from materialized views must tolerate running in

[COMMITTERS] pgsql: Document the OVER keyword as being unreserved.

2013-07-14 Thread Noah Misch
Document the OVER keyword as being unreserved. It became so in commit 5893ffa79c03824f34ae3d37f211381fd1c17283. David Fetter, extracted from a larger patch. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/01337d46eb34503b81b989885d0aa3e25da5a96d Modified Files

[COMMITTERS] pgsql: Implement the FILTER clause for aggregate function calls.

2013-07-16 Thread Noah Misch
Implement the FILTER clause for aggregate function calls. This is SQL-standard with a few extensions, namely support for subqueries and outer references in clause expressions. catversion bump due to change in Aggref and WindowFunc. David Fetter, reviewed by Dean Rasheed. Branch -- master D

[COMMITTERS] pgsql: Comment on why planagg.c punts "MIN(x ORDER BY y)".

2013-07-16 Thread Noah Misch
Comment on why planagg.c punts "MIN(x ORDER BY y)". Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7a8e9f298e7b8158296e1ea72ca8987323c10edf Modified Files -- src/backend/optimizer/plan/planagg.c | 18 -- 1 file changed, 16 insertions(+),

[COMMITTERS] pgsql: Fix systable_recheck_tuple() for MVCC scan snapshots.

2013-07-16 Thread Noah Misch
Fix systable_recheck_tuple() for MVCC scan snapshots. Since this function assumed non-MVCC snapshots, it broke when commit 568d4138c646cd7cd8a837ac244ef2caf27c6bb8 switched its one caller from SnapshotNow scans to MVCC-snapshot scans. Reviewed by Robert Haas, Tom Lane and Andres Freund. Branch -

[COMMITTERS] pgsql: Restore REINDEX constraint validation.

2013-07-30 Thread Noah Misch
Restore REINDEX constraint validation. Refactoring as part of commit 8ceb24568054232696dddc1166a8563bc78c900a had the unintended effect of making REINDEX TABLE and REINDEX DATABASE no longer validate constraints enforced by the indexes in question; REINDEX INDEX still did so. Indexes marked inval

[COMMITTERS] pgsql: Restore REINDEX constraint validation.

2013-07-30 Thread Noah Misch
Restore REINDEX constraint validation. Refactoring as part of commit 8ceb24568054232696dddc1166a8563bc78c900a had the unintended effect of making REINDEX TABLE and REINDEX DATABASE no longer validate constraints enforced by the indexes in question; REINDEX INDEX still did so. Indexes marked inval

[COMMITTERS] pgsql: Restore REINDEX constraint validation.

2013-07-30 Thread Noah Misch
Restore REINDEX constraint validation. Refactoring as part of commit 8ceb24568054232696dddc1166a8563bc78c900a had the unintended effect of making REINDEX TABLE and REINDEX DATABASE no longer validate constraints enforced by the indexes in question; REINDEX INDEX still did so. Indexes marked inval

[COMMITTERS] pgsql: Restore REINDEX constraint validation.

2013-07-30 Thread Noah Misch
Restore REINDEX constraint validation. Refactoring as part of commit 8ceb24568054232696dddc1166a8563bc78c900a had the unintended effect of making REINDEX TABLE and REINDEX DATABASE no longer validate constraints enforced by the indexes in question; REINDEX INDEX still did so. Indexes marked inval

[COMMITTERS] pgsql: Restore REINDEX constraint validation.

2013-07-30 Thread Noah Misch
Restore REINDEX constraint validation. Refactoring as part of commit 8ceb24568054232696dddc1166a8563bc78c900a had the unintended effect of making REINDEX TABLE and REINDEX DATABASE no longer validate constraints enforced by the indexes in question; REINDEX INDEX still did so. Indexes marked inval

[COMMITTERS] pgsql: Don't VALGRIND_PRINTF() each query string.

2013-09-06 Thread Noah Misch
Don't VALGRIND_PRINTF() each query string. Doing so was helpful for some Valgrind usage and distracting for other usage. One can achieve the same effect by changing log_statement and pointing both PostgreSQL and Valgrind logging to stderr. Per gripe from Andres Freund. Branch -- master Det

[COMMITTERS] pgsql: Ignore interrupts during quickdie().

2013-09-11 Thread Noah Misch
Ignore interrupts during quickdie(). Once the administrator has called for an immediate shutdown or a backend crash has triggered a reinitialization, no mere SIGINT or SIGTERM should change that course. Such derailment remains possible when the signal arrives before quickdie() blocks signals. Th

[COMMITTERS] pgsql: Ignore interrupts during quickdie().

2013-09-11 Thread Noah Misch
Ignore interrupts during quickdie(). Once the administrator has called for an immediate shutdown or a backend crash has triggered a reinitialization, no mere SIGINT or SIGTERM should change that course. Such derailment remains possible when the signal arrives before quickdie() blocks signals. Th

[COMMITTERS] pgsql: Ignore interrupts during quickdie().

2013-09-11 Thread Noah Misch
Ignore interrupts during quickdie(). Once the administrator has called for an immediate shutdown or a backend crash has triggered a reinitialization, no mere SIGINT or SIGTERM should change that course. Such derailment remains possible when the signal arrives before quickdie() blocks signals. Th

[COMMITTERS] pgsql: Ignore interrupts during quickdie().

2013-09-11 Thread Noah Misch
Ignore interrupts during quickdie(). Once the administrator has called for an immediate shutdown or a backend crash has triggered a reinitialization, no mere SIGINT or SIGTERM should change that course. Such derailment remains possible when the signal arrives before quickdie() blocks signals. Th

[COMMITTERS] pgsql: Ignore interrupts during quickdie().

2013-09-11 Thread Noah Misch
Ignore interrupts during quickdie(). Once the administrator has called for an immediate shutdown or a backend crash has triggered a reinitialization, no mere SIGINT or SIGTERM should change that course. Such derailment remains possible when the signal arrives before quickdie() blocks signals. Th

[COMMITTERS] pgsql: Ignore interrupts during quickdie().

2013-09-11 Thread Noah Misch
Ignore interrupts during quickdie(). Once the administrator has called for an immediate shutdown or a backend crash has triggered a reinitialization, no mere SIGINT or SIGTERM should change that course. Such derailment remains possible when the signal arrives before quickdie() blocks signals. Th

[COMMITTERS] pgsql: pgbench: Tweak documentation.

2013-09-23 Thread Noah Misch
pgbench: Tweak documentation. Fabien COELHO Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/825da2aba8ae7a5824e9fb3823125c5c755ea568 Modified Files -- contrib/pgbench/pgbench.c |2 +- doc/src/sgml/pgbench.sgml |2 +- 2 files changed, 2 insertions(+

[COMMITTERS] pgsql: Use @libdir@ in both of regress/{input, output}/security_label.so

2013-09-23 Thread Noah Misch
Use @libdir@ in both of regress/{input,output}/security_label.source Though @libdir@ almost always matches @abs_builddir@ in this context, the test could only fail if they differed. Back-patch to 9.1, where the test was introduced. Hamid Quddus Akhtar Branch -- master Details --- http:

[COMMITTERS] pgsql: Use @libdir@ in both of regress/{input, output}/security_label.so

2013-09-23 Thread Noah Misch
Use @libdir@ in both of regress/{input,output}/security_label.source Though @libdir@ almost always matches @abs_builddir@ in this context, the test could only fail if they differed. Back-patch to 9.1, where the test was introduced. Hamid Quddus Akhtar Branch -- REL9_1_STABLE Details --

[COMMITTERS] pgsql: Use @libdir@ in both of regress/{input, output}/security_label.so

2013-09-23 Thread Noah Misch
Use @libdir@ in both of regress/{input,output}/security_label.source Though @libdir@ almost always matches @abs_builddir@ in this context, the test could only fail if they differed. Back-patch to 9.1, where the test was introduced. Hamid Quddus Akhtar Branch -- REL9_2_STABLE Details --

[COMMITTERS] pgsql: Use @libdir@ in both of regress/{input, output}/security_label.so

2013-09-23 Thread Noah Misch
Use @libdir@ in both of regress/{input,output}/security_label.source Though @libdir@ almost always matches @abs_builddir@ in this context, the test could only fail if they differed. Back-patch to 9.1, where the test was introduced. Hamid Quddus Akhtar Branch -- REL9_3_STABLE Details --

[COMMITTERS] pgsql: pgbench: Correct for bias in --rate schedule generation.

2013-09-25 Thread Noah Misch
pgbench: Correct for bias in --rate schedule generation. Previous code gave a mean delay 0.44% below target. This change also has the effect of increasing the maximum possible delay. Fabien COELHO Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c2df45a37cd9e32815fe

[COMMITTERS] pgsql: pgbench: Remove stray use of "float" math.

2013-10-05 Thread Noah Misch
pgbench: Remove stray use of "float" math. Oversight in commit 4a87f308b33457670f9ab4bc622678e5d285b9c2. Fabien COELHO Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8e00a3850d4a7729a112967c204fa95b40cc54ca Modified Files -- contrib/pgbench/pgbench.c |

[COMMITTERS] pgsql: pgbench: Elaborate latency reporting.

2013-10-05 Thread Noah Misch
pgbench: Elaborate latency reporting. Isolate transaction latency (elapsed time between submitting first command and receiving response to last command) from client-side delays pertaining to the --rate schedule. Under --rate, report schedule lag as defined in the documentation. Report latency st

[COMMITTERS] pgsql: pgbench: Comment on thread timing hazards.

2013-10-06 Thread Noah Misch
pgbench: Comment on thread timing hazards. Reviewed by Fabien COELHO. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7db0dc0eac4512253c2ec0e6bea60ecd2d7bea27 Modified Files -- contrib/pgbench/pgbench.c | 11 ++- 1 file changed, 10 insertions(+)

[COMMITTERS] pgsql: Consistently use unsigned arithmetic for alignment calculations.

2013-10-20 Thread Noah Misch
Consistently use unsigned arithmetic for alignment calculations. This avoids an assumption about the signed number representation. It is anticipated to have no functional changes on supported configurations; many two's complement assumptions remain elsewhere. Per a suggestion from Andres Freund.

[COMMITTERS] pgsql: Add large object functions catering to SQL callers.

2013-10-27 Thread Noah Misch
Add large object functions catering to SQL callers. With these, one need no longer manipulate large object descriptors and extract numeric constants from header files in order to read and write large object contents from SQL. Pavel Stehule, reviewed by Rushabh Lathia. Branch -- master Detai

[COMMITTERS] pgsql: MSVC: Repair libpq.rc generator.

2017-07-09 Thread Noah Misch
MSVC: Repair libpq.rc generator. It generates an empty file, so libpq.dll advertises no version information. Commit facde2a98f0b5f7689b4e30a9e7376e926e733b8 mistranslated "print O;" in this one place. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3381898f983b9d41

[COMMITTERS] pgsql: MSVC: Don't link libpgcommon into pgcrypto.

2017-07-16 Thread Noah Misch
MSVC: Don't link libpgcommon into pgcrypto. Doing so was useful in 273c458a2b3a0fb73968020ea5e9e35eb6928967 but became obsolete when 818fd4a67d610991757b610755e3065fb99d80a5 caused postgres.exe to provide the relevant symbols. No other loadable module links to libpgcommon directly. Branch --

[COMMITTERS] pgsql: MSVC: Accept tcl86.lib in addition to tcl86t.lib.

2017-07-23 Thread Noah Misch
MSVC: Accept tcl86.lib in addition to tcl86t.lib. ActiveTcl8.6.4.1.299124-win32-x86_64-threaded.exe ships just tcl86.lib. Back-patch to 9.2, like the commit recognizing tcl86t.lib. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/71ad8000da5d836c9ca117a164c38d84284a3

[COMMITTERS] pgsql: MSVC: Accept tcl86.lib in addition to tcl86t.lib.

2017-07-23 Thread Noah Misch
MSVC: Accept tcl86.lib in addition to tcl86t.lib. ActiveTcl8.6.4.1.299124-win32-x86_64-threaded.exe ships just tcl86.lib. Back-patch to 9.2, like the commit recognizing tcl86t.lib. Branch -- REL9_2_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4885e5c88b274d8f7da9f4dcbbe000

[COMMITTERS] pgsql: MSVC: Accept tcl86.lib in addition to tcl86t.lib.

2017-07-23 Thread Noah Misch
MSVC: Accept tcl86.lib in addition to tcl86t.lib. ActiveTcl8.6.4.1.299124-win32-x86_64-threaded.exe ships just tcl86.lib. Back-patch to 9.2, like the commit recognizing tcl86t.lib. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bef96e57e0de095a581065f386bc0b

[COMMITTERS] pgsql: MSVC: Accept tcl86.lib in addition to tcl86t.lib.

2017-07-23 Thread Noah Misch
MSVC: Accept tcl86.lib in addition to tcl86t.lib. ActiveTcl8.6.4.1.299124-win32-x86_64-threaded.exe ships just tcl86.lib. Back-patch to 9.2, like the commit recognizing tcl86t.lib. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0328bd1ef3c991d4764d8437d9a407

[COMMITTERS] pgsql: MSVC: Accept tcl86.lib in addition to tcl86t.lib.

2017-07-23 Thread Noah Misch
MSVC: Accept tcl86.lib in addition to tcl86t.lib. ActiveTcl8.6.4.1.299124-win32-x86_64-threaded.exe ships just tcl86.lib. Back-patch to 9.2, like the commit recognizing tcl86t.lib. Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9842c1b559a9041371fb7d30a83cb9

[COMMITTERS] pgsql: MSVC: Accept tcl86.lib in addition to tcl86t.lib.

2017-07-23 Thread Noah Misch
MSVC: Accept tcl86.lib in addition to tcl86t.lib. ActiveTcl8.6.4.1.299124-win32-x86_64-threaded.exe ships just tcl86.lib. Back-patch to 9.2, like the commit recognizing tcl86t.lib. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bcc2c3b4572491fef845de30b0ed36

[COMMITTERS] pgsql: MSVC: Finish clean.bat build artifact coverage.

2017-07-24 Thread Noah Misch
MSVC: Finish clean.bat build artifact coverage. With this, "git clean -dnx" is clear after a "clean dist" following a build. Preserve sql_help.h in non-dist cleans, like the Makefile does. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bbbd9121e63f9f7cf8cc86025d5d

[COMMITTERS] pgsql: Disclaim xmltable() support for non-UTF8 databases.

2017-08-07 Thread Noah Misch
Disclaim xmltable() support for non-UTF8 databases. The xmltable() implementation mirrors xpath(), including its lack of character encoding awareness. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b4a2eea030ba74ea84335c7d5bc999f693ffd9a4 Modified Files --

[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options. Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make pg_user_mappings enforce the qualifications user_mapping_options had been enforcing, but its removal of a longstanding restriction left them distinct when the cu

[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options. Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make pg_user_mappings enforce the qualifications user_mapping_options had been enforcing, but its removal of a longstanding restriction left them distinct when the cu

[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options. Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make pg_user_mappings enforce the qualifications user_mapping_options had been enforcing, but its removal of a longstanding restriction left them distinct when the cu

[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options. Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make pg_user_mappings enforce the qualifications user_mapping_options had been enforcing, but its removal of a longstanding restriction left them distinct when the cu

[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options. Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make pg_user_mappings enforce the qualifications user_mapping_options had been enforcing, but its removal of a longstanding restriction left them distinct when the cu

[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options. Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make pg_user_mappings enforce the qualifications user_mapping_options had been enforcing, but its removal of a longstanding restriction left them distinct when the cu

[COMMITTERS] pgsql: Fix vertical spanning in table "wait_event Description".

2017-08-12 Thread Noah Misch
Fix vertical spanning in table "wait_event Description". Michael Paquier Discussion: https://postgr.es/m/cab7npqqr3keqvxeuunycm7tdk2fb9oluq8du0+y0rzeon_1...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e88928c50dfe2623c899f82b54aad69da248ad07 Mo

[COMMITTERS] pgsql: Inject $(ICU_LIBS) regardless of platform.

2017-08-20 Thread Noah Misch
Inject $(ICU_LIBS) regardless of platform. It appeared in a conditional that excludes AIX, Cygwin and MinGW. Give ICU support a chance to work on those platforms. Back-patch to v10, where ICU support was introduced. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/

[COMMITTERS] pgsql: Inject $(ICU_LIBS) regardless of platform.

2017-08-20 Thread Noah Misch
Inject $(ICU_LIBS) regardless of platform. It appeared in a conditional that excludes AIX, Cygwin and MinGW. Give ICU support a chance to work on those platforms. Back-patch to v10, where ICU support was introduced. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/comm

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion: https://postgr.es/m/20170831025345.ge3

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion: https://postgr.es/m/20170831025345.ge3

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion: https://postgr.es/m/20170831025345.ge3

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion: https://postgr.es/m/20170831025345.ge3

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion: https://postgr.es/m/20170831025345.ge3

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion: https://postgr.es/m/20170831025345.ge3

[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE". It drops objects outside information_schema that depend on objects inside information_schema. For example, it will drop a user-defined view if the view query refers to information_schema. Discussion: https://postgr.es/m/20170831025345.ge3

Re: [COMMITTERS] pgsql: Remove ICU tests from default run

2017-10-06 Thread Noah Misch
On Sat, Mar 25, 2017 at 04:30:45AM +, Peter Eisentraut wrote: > Remove ICU tests from default run > > These tests require the test database to be in UTF8 encoding. Until > there is a better solution, take them out of the default test set and > treat them like the existing collate.linux.utf8 t

Re: [COMMITTERS] pgsql: Improve performance of SendRowDescriptionMessage.

2017-10-12 Thread Noah Misch
On Thu, Oct 12, 2017 at 04:08:44PM -0700, Andres Freund wrote: > So we've two animals (hornet, sungazer) that are: > #define SIZEOF_SIZE_T 8 > #define WORDS_BIGENDIAN 1 > #define restrict __restrict > > one compiled with xlc that fails and one with gcc that succeeds. I'm > hesitant to reach for th

Re: [COMMITTERS] pgsql: Improve performance of SendRowDescriptionMessage.

2017-10-12 Thread Noah Misch
On Thu, Oct 12, 2017 at 04:48:29PM -0700, Andres Freund wrote: > On 2017-10-12 16:08:44 -0700, Andres Freund wrote: > > wrap-gcc -D_THREAD_SAFE=1 -D_LARGE_FILES=1 -maix64 -Wall > > -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement > > -Wendif-labels -Wmissing-format-attribute -Wf

Re: [COMMITTERS] pgsql: Improve performance of SendRowDescriptionMessage.

2017-10-13 Thread Noah Misch
On Thu, Oct 12, 2017 at 10:44:20PM -0400, Tom Lane wrote: > Noah Misch writes: > > On Thu, Oct 12, 2017 at 04:08:44PM -0700, Andres Freund wrote: > >> Noah, any chance you could force restrict to off on that animal? > > > I can confirm it allows "make check&quo

[COMMITTERS] pgsql: In client support of v10 features, use standard schema handling.

2017-11-01 Thread Noah Misch
In client support of v10 features, use standard schema handling. Back-patch to v10. This continues the work of commit 080351466c5a669bf35a323bdec9e296330a5dbb. Discussion: https://postgr.es/m/CAKOSWN=ds66zlw2sqkltm8wbxfgdbc_odkmt3djfpt2me5k...@mail.gmail.com Branch -- REL_10_STABLE Detail

[COMMITTERS] pgsql: In client support of v10 features, use standard schema handling.

2017-11-01 Thread Noah Misch
In client support of v10 features, use standard schema handling. Back-patch to v10. This continues the work of commit 080351466c5a669bf35a323bdec9e296330a5dbb. Discussion: https://postgr.es/m/CAKOSWN=ds66zlw2sqkltm8wbxfgdbc_odkmt3djfpt2me5k...@mail.gmail.com Branch -- master Details -

[COMMITTERS] pgsql: Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

2017-11-05 Thread Noah Misch
Ignore CatalogSnapshot when checking COPY FREEZE prerequisites. This restores the ability, essentially lost in commit ffaa44cb559db332baeee7d25dedd74a61974203, to use COPY FREEZE under REPEATABLE READ isolation. Back-patch to 9.4, like that commit. Reviewed by Tom Lane. Discussion: https://pos

[COMMITTERS] pgsql: Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

2017-11-05 Thread Noah Misch
Ignore CatalogSnapshot when checking COPY FREEZE prerequisites. This restores the ability, essentially lost in commit ffaa44cb559db332baeee7d25dedd74a61974203, to use COPY FREEZE under REPEATABLE READ isolation. Back-patch to 9.4, like that commit. Reviewed by Tom Lane. Discussion: https://pos

[COMMITTERS] pgsql: Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

2017-11-05 Thread Noah Misch
Ignore CatalogSnapshot when checking COPY FREEZE prerequisites. This restores the ability, essentially lost in commit ffaa44cb559db332baeee7d25dedd74a61974203, to use COPY FREEZE under REPEATABLE READ isolation. Back-patch to 9.4, like that commit. Reviewed by Tom Lane. Discussion: https://pos

[COMMITTERS] pgsql: Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

2017-11-05 Thread Noah Misch
Ignore CatalogSnapshot when checking COPY FREEZE prerequisites. This restores the ability, essentially lost in commit ffaa44cb559db332baeee7d25dedd74a61974203, to use COPY FREEZE under REPEATABLE READ isolation. Back-patch to 9.4, like that commit. Reviewed by Tom Lane. Discussion: https://pos

[COMMITTERS] pgsql: Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

2017-11-05 Thread Noah Misch
Ignore CatalogSnapshot when checking COPY FREEZE prerequisites. This restores the ability, essentially lost in commit ffaa44cb559db332baeee7d25dedd74a61974203, to use COPY FREEZE under REPEATABLE READ isolation. Back-patch to 9.4, like that commit. Reviewed by Tom Lane. Discussion: https://pos

[COMMITTERS] pgsql: Add a temp-install prerequisite to "check"-like targets not havi

2017-11-05 Thread Noah Misch
Add a temp-install prerequisite to "check"-like targets not having one. Makefile.global assigns this prerequisite to every target named "check", but similar targets must mention it explicitly. Affected targets failed, tested $PATH binaries, or tested a stale temporary installation. The src/test/m

[COMMITTERS] pgsql: Add a temp-install prerequisite to "check"-like targets not havi

2017-11-05 Thread Noah Misch
Add a temp-install prerequisite to "check"-like targets not having one. Makefile.global assigns this prerequisite to every target named "check", but similar targets must mention it explicitly. Affected targets failed, tested $PATH binaries, or tested a stale temporary installation. The src/test/m

[COMMITTERS] pgsql: Add a temp-install prerequisite to "check"-like targets not havi

2017-11-05 Thread Noah Misch
Add a temp-install prerequisite to "check"-like targets not having one. Makefile.global assigns this prerequisite to every target named "check", but similar targets must mention it explicitly. Affected targets failed, tested $PATH binaries, or tested a stale temporary installation. The src/test/m

[COMMITTERS] pgsql: Add a temp-install prerequisite to "check"-like targets not havi

2017-11-05 Thread Noah Misch
Add a temp-install prerequisite to "check"-like targets not having one. Makefile.global assigns this prerequisite to every target named "check", but similar targets must mention it explicitly. Affected targets failed, tested $PATH binaries, or tested a stale temporary installation. The src/test/m

[COMMITTERS] pgsql: start-scripts: switch to $PGUSER before opening $PGLOG.

2017-11-09 Thread Noah Misch
start-scripts: switch to $PGUSER before opening $PGLOG. By default, $PGUSER has permission to unlink $PGLOG. If $PGUSER replaces $PGLOG with a symbolic link, the server will corrupt the link-targeted file by appending log messages. Since these scripts open $PGLOG as root, the attack works regard

[COMMITTERS] pgsql: start-scripts: switch to $PGUSER before opening $PGLOG.

2017-11-09 Thread Noah Misch
start-scripts: switch to $PGUSER before opening $PGLOG. By default, $PGUSER has permission to unlink $PGLOG. If $PGUSER replaces $PGLOG with a symbolic link, the server will corrupt the link-targeted file by appending log messages. Since these scripts open $PGLOG as root, the attack works regard

[COMMITTERS] pgsql: start-scripts: switch to $PGUSER before opening $PGLOG.

2017-11-09 Thread Noah Misch
start-scripts: switch to $PGUSER before opening $PGLOG. By default, $PGUSER has permission to unlink $PGLOG. If $PGUSER replaces $PGLOG with a symbolic link, the server will corrupt the link-targeted file by appending log messages. Since these scripts open $PGLOG as root, the attack works regard

[COMMITTERS] pgsql: start-scripts: switch to $PGUSER before opening $PGLOG.

2017-11-09 Thread Noah Misch
start-scripts: switch to $PGUSER before opening $PGLOG. By default, $PGUSER has permission to unlink $PGLOG. If $PGUSER replaces $PGLOG with a symbolic link, the server will corrupt the link-targeted file by appending log messages. Since these scripts open $PGLOG as root, the attack works regard

[COMMITTERS] pgsql: start-scripts: switch to $PGUSER before opening $PGLOG.

2017-11-09 Thread Noah Misch
start-scripts: switch to $PGUSER before opening $PGLOG. By default, $PGUSER has permission to unlink $PGLOG. If $PGUSER replaces $PGLOG with a symbolic link, the server will corrupt the link-targeted file by appending log messages. Since these scripts open $PGLOG as root, the attack works regard

  1   2   3   4   5   6   7   8   >