[COMMITTERS] pgsql: Teach SLRU code to avoid replacing I/O-busy pages.

2012-04-08 Thread Robert Haas
Teach SLRU code to avoid replacing I/O-busy pages. Patch by me; review by Tom Lane and others. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3ae5133b1cf478d51f2003bc68ba0edb84c7 Modified Files -- src/backend/access/transam/slru.c | 92

[COMMITTERS] pgsql: Update lazy_scan_heap header comment.

2012-04-13 Thread Robert Haas
Update lazy_scan_heap header comment. The previous comment described how things worked in PostgreSQL 8.2 and prior. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5630eddf1efe7c374fe8e8bdeaba3c70f8cd628b Modified Files --

[COMMITTERS] pgsql: Fix typo in comment.

2012-04-13 Thread Robert Haas
Fix typo in comment. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/61167bfaf2af3bc0bbf3ba9c8ff14f10a483f9ff Modified Files -- src/backend/commands/vacuumlazy.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via pgsql-committers

[COMMITTERS] pgsql: Grammar corrections.

2012-04-13 Thread Robert Haas
Grammar corrections. Christoph Berg Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7167fcd21bc05e9114b1ededb835c5bc8610a6b0 Modified Files -- doc/src/sgml/high-availability.sgml |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- Sent

[COMMITTERS] pgsql: Add Peter Geoghegan as additional author of pg_stat_statements.

2012-04-13 Thread Robert Haas
Add Peter Geoghegan as additional author of pg_stat_statements. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cd93425cd1e9b66ad99cfee819c928b202b63ee6 Modified Files -- doc/src/sgml/pgstatstatements.sgml |5 +++-- 1 files changed, 3 insertions(+), 2

[COMMITTERS] pgsql: Rename synchronous_commit='write' to 'remote_write'.

2012-04-14 Thread Robert Haas
Rename synchronous_commit='write' to 'remote_write'. Fujii Masao, per discussion on pgsql-hackers Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ea6a2d8d47b9368f50fb7f4cca206895e6127a0a Modified Files -- doc/src/sgml/config.sgml |

[COMMITTERS] pgsql: Doc clarification for synchronous_commit.

2012-04-18 Thread Robert Haas
Doc clarification for synchronous_commit. Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/37e666b8b5999fddd556138edd17a5f26384460f Modified Files -- doc/src/sgml/config.sgml |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) --

[COMMITTERS] pgsql: Fix copyfuncs/equalfuncs support for ReassignOwnedStmt.

2012-04-18 Thread Robert Haas
Fix copyfuncs/equalfuncs support for ReassignOwnedStmt. Noah Misch Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/f8c53d5b411da9518876c93161199e38eaaa5118 Modified Files -- src/backend/nodes/copyfuncs.c |2 +- src/backend/nodes/equalfuncs.c

[COMMITTERS] pgsql: Fix copyfuncs/equalfuncs support for ReassignOwnedStmt.

2012-04-18 Thread Robert Haas
Fix copyfuncs/equalfuncs support for ReassignOwnedStmt. Noah Misch Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/8d2ef107e6b0ed1574ab7aaf437480a7473004e7 Modified Files -- src/backend/nodes/copyfuncs.c |2 +- src/backend/nodes/equalfuncs.c

[COMMITTERS] pgsql: Fix various infelicities in node functions.

2012-04-18 Thread Robert Haas
Fix various infelicities in node functions. Mostly, this consists of adding support for fields which exist in the structure but aren't handled by copy/equal/outfuncs; but the create foreign table case can actually produce garbage output. Noah Misch Branch -- master Details ---

[COMMITTERS] pgsql: Fix copyfuncs/equalfuncs support for ReassignOwnedStmt.

2012-04-18 Thread Robert Haas
Fix copyfuncs/equalfuncs support for ReassignOwnedStmt. Noah Misch Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b5eccaef2c05fd0c17f4510001528232b242a88e Modified Files -- src/backend/nodes/copyfuncs.c |2 +- src/backend/nodes/equalfuncs.c |2

[COMMITTERS] pgsql: After PageSetAllVisible, use MarkBufferDirty.

2012-04-18 Thread Robert Haas
After PageSetAllVisible, use MarkBufferDirty. Previously, we used SetBufferCommitInfoNeedsSave, but that's really intended for dirty-marks we can theoretically afford to lose, such as hint bits. As for 9.2, the PD_ALL_VISIBLE mustn't be lost in this way, since we could then end up with a heap

[COMMITTERS] pgsql: Fix incorrect comment in SetBufferCommitInfoNeedsSave().

2012-04-18 Thread Robert Haas
Fix incorrect comment in SetBufferCommitInfoNeedsSave(). Noah Misch spotted the fact that the old comment is in fact incorrect, due to memory ordering hazards. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ab77b2da8bf2cd1c8068f2f90e95c42d426aba3c Modified Files

[COMMITTERS] pgsql: Tighten up error recovery for fast-path locking.

2012-04-18 Thread Robert Haas
Tighten up error recovery for fast-path locking. The previous code could cause a backend crash after BEGIN; SAVEPOINT a; LOCK TABLE foo (interrupted by ^C or statement timeout); ROLLBACK TO SAVEPOINT a; LOCK TABLE foo, and might have leaked strong-lock counts in other situations. Report by

[COMMITTERS] pgsql: Finish rename of FastPathStrongLocks to FastPathStrongRelationLo

2012-04-18 Thread Robert Haas
Finish rename of FastPathStrongLocks to FastPathStrongRelationLocks. Commit 8e5ac74c1249820ca55481223a95b9124b4a4f95 tried to do this renaming, but I relied on gcc to tell me where I needed to make changes, instead of grep. Noted by Jeff Davis. Branch -- master Details ---

[COMMITTERS] pgsql: Minor improvements for CHECK NO INHERIT documentation.

2012-04-23 Thread Robert Haas
Minor improvements for CHECK NO INHERIT documentation. Fix typo spotted by Thom Brown, and improve wording in another area where Thom spotted a typo. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9d435d57e1f8ec7e51d40722854252875d8cc6eb Modified Files

[COMMITTERS] pgsql: Reduce hash size for compute_array_stats, compute_tsvector_stats

2012-04-23 Thread Robert Haas
Reduce hash size for compute_array_stats, compute_tsvector_stats. The size is only a hint, but a big hint chews up a lot of memory without apparently improving performance much. Analysis and patch by Noah Misch. Branch -- master Details ---

[COMMITTERS] pgsql: Rearrange lazy_scan_heap to avoid visibility map race conditions

2012-04-23 Thread Robert Haas
Rearrange lazy_scan_heap to avoid visibility map race conditions. We must set the visibility map bit before releasing our exclusive lock on the heap page; otherwise, someone might clear the heap page bit before we set the visibility map bit, leading to a situation where the visibility map thinks

[COMMITTERS] pgsql: Lots of doc corrections.

2012-04-23 Thread Robert Haas
Lots of doc corrections. Josh Kupershmidt Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5d4b60f2f25bedee257aaf6f2f4ac77028629b87 Modified Files -- contrib/dblink/dblink.c|2 +- contrib/fuzzystrmatch/fuzzystrmatch.c |2

[COMMITTERS] pgsql: Another typographical correction.

2012-04-24 Thread Robert Haas
Another typographical correction. Noted by Guillaume Smet. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e4f06b70c9ac1473591d705990a8b601915ce4bd Modified Files -- contrib/dblink/dblink.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)

Re: [COMMITTERS] pgsql: Lots of doc corrections.

2012-04-24 Thread Robert Haas
On Tue, Apr 24, 2012 at 12:34 AM, Guillaume Smet guillaume.s...@gmail.com wrote: On Tue, Apr 24, 2012 at 4:45 AM, Robert Haas rh...@postgresql.org wrote: contrib/dblink/dblink.c                    |    2 +- Returns /an/ setof record of notifications, or an empty set if none received. should

[COMMITTERS] pgsql: Casts to or from a domain type are ignored; warn and document.

2012-04-24 Thread Robert Haas
Casts to or from a domain type are ignored; warn and document. Prohibiting this outright would break dumps taken from older versions that contain such casts, which would create far more pain than is justified here. Per report by Jaime Casanova and subsequent discussion. Branch -- master

[COMMITTERS] pgsql: Remove prototype for nonexistent function.

2012-04-25 Thread Robert Haas
Remove prototype for nonexistent function. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ca1e1a8da11d188df738ba67632c0805a00d3f27 Modified Files -- src/include/storage/standby.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) -- Sent via

[COMMITTERS] pgsql: Prevent index-only scans from returning wrong answers under Hot

2012-04-26 Thread Robert Haas
Prevent index-only scans from returning wrong answers under Hot Standby. The alternative of disallowing index-only scans in HS operation was discussed, but the consensus was that it was better to treat marking a page all-visible as a recovery conflict for snapshots that could still fail to see

[COMMITTERS] pgsql: Remove duplicate word in comment.

2012-04-30 Thread Robert Haas
Remove duplicate word in comment. Noted by Peter Geoghegan. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0d2235a25bc71848c18f551f992b3eed8cec2399 Modified Files -- src/backend/access/transam/xlog.c |2 +- 1 files changed, 1 insertions(+), 1

[COMMITTERS] pgsql: Tweak psql to print row counts when \x auto chooses non-expanded

2012-05-01 Thread Robert Haas
Tweak psql to print row counts when \x auto chooses non-expanded output. Noah Misch Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9b7a84f2a45322b21b86eb180a869d1ed2937b85 Modified Files -- src/bin/psql/command.c |6 ++-- src/bin/psql/describe.c |

[COMMITTERS] pgsql: More duplicate word removal.

2012-05-02 Thread Robert Haas
More duplicate word removal. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e01e66f808fbd161b2714eab34bb9e9d0db0db53 Modified Files -- contrib/sepgsql/selinux.c |2 +- src/backend/access/gist/gistget.c |2 +-

[COMMITTERS] pgsql: Further corrections from the department of redundancy department

2012-05-02 Thread Robert Haas
Further corrections from the department of redundancy department. Thom Brown Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1b4998fd44bad9f8ab90e741cadd6519f6c94a44 Modified Files -- src/backend/storage/freespace/README|2 +-

Re: [COMMITTERS] pgsql: More duplicate word removal.

2012-05-02 Thread Robert Haas
and a colleague of mine, confirms privately that it's an error. That needs to be fixed through the translations system. Otherwise, the next update from the translations system will overwrite any change we make in git. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise

[COMMITTERS] pgsql: Avoid repeated CLOG access from heap_hot_search_buffer.

2012-05-02 Thread Robert Haas
Avoid repeated CLOG access from heap_hot_search_buffer. At the time we check whether the tuple is dead to all running transactions, we've already verified that it isn't visible to our scan, setting hint bits if appropriate. So there's no need to recheck CLOG for the all-dead test we do just a

[COMMITTERS] pgsql: Add missing parenthesis in comment.

2012-05-02 Thread Robert Haas
Add missing parenthesis in comment. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8e0c5195dff70ffc9c132716d0cf7f3eff45e302 Modified Files -- src/include/storage/proc.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Sent via

[COMMITTERS] pgsql: Prevent loss of init fork when truncating an unlogged table.

2012-05-11 Thread Robert Haas
Prevent loss of init fork when truncating an unlogged table. Fixes bug #6635, reported by Akira Kurosawa. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/2ca6bac892aa650154f591c730359a968bea726a Modified Files -- src/backend/catalog/heap.c

[COMMITTERS] pgsql: Prevent loss of init fork when truncating an unlogged table.

2012-05-11 Thread Robert Haas
Prevent loss of init fork when truncating an unlogged table. Fixes bug #6635, reported by Akira Kurosawa. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1331cc6c1ad2beba7985523508d6722dc865c337 Modified Files -- src/backend/catalog/heap.c | 32

[COMMITTERS] pgsql: Repair out-of-date information in src/backend/storage/buffer/REA

2012-05-22 Thread Robert Haas
Repair out-of-date information in src/backend/storage/buffer/README. In commit d526575f893c1a4e05ebd307e80203536b213a6d, we changed things so that buffer usage counts are incremented when the buffer is pinned, rather than when it is unpinned, but the README file didn't get the memo. Report by

[COMMITTERS] pgsql: Prevent pg_basebackup when integer_datetimes flag doesn't match.

2012-05-22 Thread Robert Haas
Prevent pg_basebackup when integer_datetimes flag doesn't match. Magnus Hagander, reviewed by Fujii Masao, with slight wording changes by me. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/304aa339b20df9f9ba6f4d93175e05098f6fd1c1 Modified Files --

[COMMITTERS] pgsql: Release note improvements.

2012-05-22 Thread Robert Haas
Release note improvements. Document some more things as incompatibilities, and improve wording of another item. Noah Misch Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b536458e73a8d9294817228f06961913f6faa551 Modified Files --

[COMMITTERS] pgsql: Fix error message for COMMENT/SECURITY LABEL ON COLUMN xxx IS 'y

2012-05-22 Thread Robert Haas
Fix error message for COMMENT/SECURITY LABEL ON COLUMN xxx IS 'yyy' When the column name is an unqualified name, rather than table.column, the error message complains about too many dotted names, which is wrong. Report by Peter Eisentraut based on examination of the sepgsql regression test

[COMMITTERS] pgsql: Fix error message for COMMENT/SECURITY LABEL ON COLUMN xxx IS 'y

2012-05-22 Thread Robert Haas
Fix error message for COMMENT/SECURITY LABEL ON COLUMN xxx IS 'yyy' When the column name is an unqualified name, rather than table.column, the error message complains about too many dotted names, which is wrong. Report by Peter Eisentraut based on examination of the sepgsql regression test

[COMMITTERS] pgsql: Fix two more bugs in fast-path relation locking.

2012-05-30 Thread Robert Haas
Fix two more bugs in fast-path relation locking. First, the previous code failed to account for the fact that, during Hot Standby operation, the startup process takes AccessExclusiveLocks on relations without setting MyDatabaseId. This resulted in fast path strong lock counts failing to be

[COMMITTERS] pgsql: Fix more crash-safe visibility map bugs, and improve comments.

2012-06-07 Thread Robert Haas
Fix more crash-safe visibility map bugs, and improve comments. In lazy_scan_heap, we could issue bogus warnings about incorrect information in the visibility map, because we checked the visibility map bit before locking the heap page, creating a race condition. Fix by rechecking the visibility

[COMMITTERS] pgsql: When using libpq URI syntax, error out on invalid parameter name

2012-06-08 Thread Robert Haas
When using libpq URI syntax, error out on invalid parameter names. Dan Farina Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3b5548a3d524e3b37d49f79f707d2119ecdfa303 Modified Files -- src/interfaces/libpq/fe-connect.c |8 +---

[COMMITTERS] pgsql: Copy-editing of release notes.

2012-06-12 Thread Robert Haas
Copy-editing of release notes. Remove a couple of items that were actually back-patched bug fixes. Add additional details to a couple of items which lacked a description. Improve attributions for a couple of items I was involved with. A few other miscellaneous corrections. Branch -- master

[COMMITTERS] pgsql: Mark JSON error detail messages for translation.

2012-06-12 Thread Robert Haas
Mark JSON error detail messages for translation. Per gripe from Tom Lane. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/36b7e3da17bcca4efe5584d95c386cec2a221a13 Modified Files -- src/backend/utils/adt/json.c | 12 ++-- 1 files changed, 6

[COMMITTERS] pgsql: Make \conninfo print SSL information.

2012-06-14 Thread Robert Haas
Make \conninfo print SSL information. Alastair Turner, per suggestion from Bruce Momjian. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7582e0be78bc031803e274d428381e0b6077b810 Modified Files -- src/bin/psql/command.c |1 + 1 files changed, 1

[COMMITTERS] pgsql: Remove RELKIND_UNCATALOGED.

2012-06-14 Thread Robert Haas
Remove RELKIND_UNCATALOGED. This may have been important at some point in the past, but it no longer does anything useful. Review by Tom Lane. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d2c86a1ccd17145eeed2377ff7930e2ccbf5869e Modified Files --

[COMMITTERS] pgsql: Remove misplaced sanity check from heap_create().

2012-06-14 Thread Robert Haas
Remove misplaced sanity check from heap_create(). Even when allow_system_table_mods is not set, we allow creation of any type of SQL object in pg_catalog, except for relations. And you can get relations into pg_catalog, too, by initially creating them in some other schema and then moving them

[COMMITTERS] pgsql: Add new function log_newpage_buffer.

2012-06-14 Thread Robert Haas
Add new function log_newpage_buffer. When I implemented the ginbuildempty() function as part of implementing unlogged tables, I falsified the note in the header comment for log_newpage. Although we could fix that up by changing the comment, it seems cleaner to add a new function which is

[COMMITTERS] pgsql: During transaction cleanup, release locks before deleting files.

2012-06-14 Thread Robert Haas
During transaction cleanup, release locks before deleting files. There's no need to hold onto the locks until the files are needed, and by doing it this way, we reduce the impact on other backends who may be awaiting locks we hold. Noah Misch Branch -- master Details ---

[COMMITTERS] pgsql: New SQL functons pg_backup_in_progress() and pg_backup_start_tim

2012-06-14 Thread Robert Haas
New SQL functons pg_backup_in_progress() and pg_backup_start_time() Darold Gilles, reviewed by Gabriele Bartolini and others, rebased by Marco Nenciarini. Stylistic cleanup and OID fixes by me. Branch -- master Details ---

[COMMITTERS] pgsql: Doc corrections for pg_is_in_backup patch.

2012-06-14 Thread Robert Haas
Doc corrections for pg_is_in_backup patch. Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c616d85f6b6c7bd160c71583e2445b460eee8e3d Modified Files -- doc/src/sgml/func.sgml |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) --

[COMMITTERS] pgsql: Improve readability and error messages in pg_backup_start_time.

2012-06-14 Thread Robert Haas
Improve readability and error messages in pg_backup_start_time. Gurjeet Singh, with corrections by me. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8507c2f8564b709bb6a3cc86e9599f6129f45c8e Modified Files -- src/backend/access/transam/xlogfuncs.c |

[COMMITTERS] pgsql: Document that can be used to search arrays.

2012-06-22 Thread Robert Haas
Document that can be used to search arrays. Also, add some cross-links to the indexing documentation, so it's easier to notice that and other array operators have index support. Ryan Kelly, edited by me. Branch -- master Details ---

[COMMITTERS] pgsql: Make pgbench -i emit only one-tenth as many status messages.

2012-06-22 Thread Robert Haas
Make pgbench -i emit only one-tenth as many status messages. These days, even a wimpy system can insert 1 tuples in the blink of an eye, so there's no real need for this much verbosity. Per complaint from Tatsuo Ishii. Branch -- master Details ---

[COMMITTERS] pgsql: Remove sanity test in XRecOffIsValid.

2012-06-25 Thread Robert Haas
Remove sanity test in XRecOffIsValid. Commit 061e7efb1b4c5b8a5d02122b7780531b8d5bf23d changed the rules for splitting xlog records across pages, but neglected to update this test. It's possible that there's some better action here than just removing the test completely, but this at least appears

[COMMITTERS] pgsql: Fix typo in DEBUG message, introduced by recent WAL refactoring.

2012-06-25 Thread Robert Haas
Fix typo in DEBUG message, introduced by recent WAL refactoring. Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c7d47abd04dc1322fd545370cfeb743680df0e3a Modified Files -- src/backend/replication/walsender.c |6 +++--- 1 files changed, 3

[COMMITTERS] pgsql: Unbreak pg_resetxlog -l.

2012-06-25 Thread Robert Haas
Unbreak pg_resetxlog -l. Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a6427f1f478b0bf43d1b861ee4053e2e8bc6118b Modified Files -- src/bin/pg_resetxlog/pg_resetxlog.c | 25 ++--- 1 files changed, 22 insertions(+), 3

[COMMITTERS] pgsql: Backport fsync queue compaction logic to all supported branches.

2012-06-26 Thread Robert Haas
Backport fsync queue compaction logic to all supported branches. This backports commit 7f242d880b5b5d9642675517466d31373961cf98, except for the counter in pg_stat_bgwriter. The underlying problem (namely, that a full fsync request queue causes terrible checkpoint behavior) continues to be

[COMMITTERS] pgsql: Backport fsync queue compaction logic to all supported branches.

2012-06-26 Thread Robert Haas
Backport fsync queue compaction logic to all supported branches. This backports commit 7f242d880b5b5d9642675517466d31373961cf98, except for the counter in pg_stat_bgwriter. The underlying problem (namely, that a full fsync request queue causes terrible checkpoint behavior) continues to be

[COMMITTERS] pgsql: Backport fsync queue compaction logic to all supported branches.

2012-06-26 Thread Robert Haas
Backport fsync queue compaction logic to all supported branches. This backports commit 7f242d880b5b5d9642675517466d31373961cf98, except for the counter in pg_stat_bgwriter. The underlying problem (namely, that a full fsync request queue causes terrible checkpoint behavior) continues to be

[COMMITTERS] pgsql: Reduce use of heavyweight locking inside hash AM.

2012-06-26 Thread Robert Haas
Reduce use of heavyweight locking inside hash AM. Avoid using LockPage(rel, 0, lockmode) to protect against changes to the bucket mapping. Instead, an exclusive buffer content lock is now viewed as sufficient permission to modify the metapage, and a shared buffer content lock is used when such

[COMMITTERS] pgsql: Make DROP FUNCTION hint more informative.

2012-06-26 Thread Robert Haas
Make DROP FUNCTION hint more informative. If you decide you want to take the hint, this gives you something you can paste right back to the server. Dean Rasheed Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0caa0d04db24d2c571fa7daa410bc6a5b319a2a2 Modified Files

[COMMITTERS] pgsql: When LWLOCK_STATS is defined, count spindelays.

2012-06-26 Thread Robert Haas
When LWLOCK_STATS is defined, count spindelays. When LWLOCK_STATS is *not* defined, the only change is that SpinLockAcquire now returns the number of delays. Patch by me, review by Jeff Janes. Branch -- master Details ---

[COMMITTERS] pgsql: Allow pg_terminate_backend() to be used on backends with matchin

2012-06-26 Thread Robert Haas
Allow pg_terminate_backend() to be used on backends with matching role. A similar change was made previously for pg_cancel_backend, so now it all matches again. Dan Farina, reviewed by Fujii Masao, Noah Misch, and Jeff Davis, with slight kibitzing on the doc changes by me. Branch -- master

[COMMITTERS] pgsql: Allow pg_terminate_backend() to be used on backends with matchin

2012-06-27 Thread Robert Haas
Allow pg_terminate_backend() to be used on backends with matching role. A similar change was made previously for pg_cancel_backend, so now it all matches again. Dan Farina, reviewed by Fujii Masao, Noah Misch, and Jeff Davis, with slight kibitzing on the doc changes by me. Branch --

[COMMITTERS] pgsql: Update release notes for pg_terminate_backend changes.

2012-06-27 Thread Robert Haas
Update release notes for pg_terminate_backend changes. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7700b82e6b071f298e3426042197c13843a5b499 Modified Files -- doc/src/sgml/release-9.2.sgml |9 ++--- 1 files changed, 6 insertions(+), 3

[COMMITTERS] pgsql: Update release notes for pg_terminate_backend changes.

2012-06-27 Thread Robert Haas
Update release notes for pg_terminate_backend changes. Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/5ff9ad664745b5cb2c6562ff2691b9418cd59c88 Modified Files -- doc/src/sgml/release-9.2.sgml |9 ++--- 1 files changed, 6 insertions(+), 3

[COMMITTERS] pgsql: Add missing space in event_source GUC description.

2012-06-28 Thread Robert Haas
Add missing space in event_source GUC description. This has apparently been wrong since event_source was added. Alexander Lakhin Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c5b3451a8e72cb7825933d4f4827f467cb38b498 Modified Files --

[COMMITTERS] pgsql: Dramatically reduce System V shared memory consumption.

2012-06-28 Thread Robert Haas
Dramatically reduce System V shared memory consumption. Except when compiling with EXEC_BACKEND, we'll now allocate only a tiny amount of System V shared memory (as an interlock to protect the data directory) and allocate the rest as anonymous shared memory via mmap. This will hopefully spare

Re: [COMMITTERS] pgsql: Fix install program detection

2012-06-28 Thread Robert Haas
like install -m 644 libpgport.a... -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix broken mmap failure-detection code, and improve error messag

2012-06-28 Thread Robert Haas
Fix broken mmap failure-detection code, and improve error message. Per an observation by Thom Brown that my previous commit made an overly large shmem allocation crash the server, on Linux. Branch -- master Details ---

[COMMITTERS] pgsql: Make walsender more responsive.

2012-07-02 Thread Robert Haas
Make walsender more responsive. Per testing by Andres Freund, this improves replication performance and reduces replication latency and latency jitter. I was a bit concerned about moving more work into XLogInsert, but testing seems to show that it's not a problem in practice. Along the way,

[COMMITTERS] pgsql: Make commit_delay much smarter.

2012-07-02 Thread Robert Haas
Make commit_delay much smarter. Instead of letting every backend participating in a group commit wait independently, have the first one that becomes ready to flush WAL wait for the configured delay, and let all the others wait just long enough for that first process to complete its flush. This

Re: [COMMITTERS] pgsql: Make walsender more responsive.

2012-07-02 Thread Robert Haas
On Mon, Jul 2, 2012 at 10:34 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas rh...@postgresql.org writes: Make walsender more responsive. ... Andres Freund. Review and stylistic cleanup by me. The comments could have used a bit more copy-editing. (I got a good laugh out of the idea

Re: [COMMITTERS] pgsql: Make walsender more responsive.

2012-07-02 Thread Robert Haas
On Mon, Jul 2, 2012 at 11:06 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Mon, Jul 2, 2012 at 10:34 AM, Tom Lane t...@sss.pgh.pa.us wrote: (I got a good laugh out of the idea of contented locks.) Uh... what? I thought the meaning of that was perfectly

[COMMITTERS] pgsql: Work a little harder on comments for walsender wakeup patch.

2012-07-02 Thread Robert Haas
Work a little harder on comments for walsender wakeup patch. Per gripe from Tom Lane. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/82cdd2df759efe2b43183ee954b4a2e10b2c59f4 Modified Files -- src/backend/access/transam/xlog.c | 12 ++-- 1

[COMMITTERS] pgsql: Fix position of WalSndWakeupRequest call.

2012-07-02 Thread Robert Haas
Fix position of WalSndWakeupRequest call. This avoids discriminating against wal_sync_method = open_sync or open_datasync. Fujii Masao, reviewed by Andres Freund Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3bb592bb20d02093d6488a57c7c4ee94803ddc9a Modified

[COMMITTERS] pgsql: Fix a stupid bug I introduced into XLogFlush().

2012-07-02 Thread Robert Haas
Fix a stupid bug I introduced into XLogFlush(). Commit f11e8be3e812cdbbc139c1b4e49141378b118dee broke this; it was right in Peter's original patch, but I messed it up before committing. Branch -- master Details ---

Re: [COMMITTERS] pgsql: Remove misleading hints about reducing the System V request size

2012-07-03 Thread Robert Haas
On Tue, Jul 3, 2012 at 10:45 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas rh...@postgresql.org writes: Remove misleading hints about reducing the System V request size. Removing the hints may be a good idea, but removing the request-size report seems like a very bad idea; especially now

[COMMITTERS] pgsql: Make oid2name, pgbench, and vacuumlo set fallback_application_na

2012-07-04 Thread Robert Haas
Make oid2name, pgbench, and vacuumlo set fallback_application_name. Amit Kapila, reviewed by Shigeru Hanada and Peter Eisentraut, with some modifications by me. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/17676c785a95b2598c5735c0025f7dc7727a96bc Modified Files

[COMMITTERS] pgsql: Increase the maximum initdb-configured value for shared_buffers

2012-07-04 Thread Robert Haas
Increase the maximum initdb-configured value for shared_buffers to 128MB. The old value of 32MB has been around for a very long time, and in the meantime typical system memories have become vastly larger. Also, now that we no longer depend on being able to fit the entirety of our shared memory

[COMMITTERS] pgsql: Documentation cleanups for recent shared memory changes.

2012-07-04 Thread Robert Haas
Documentation cleanups for recent shared memory changes. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/390bfc643de4faf6df8cb40e71b17791ce61a71e Modified Files -- doc/src/sgml/runtime.sgml | 144 - 1 files

[COMMITTERS] pgsql: More doc cleanups for recent shared memory changes.

2012-07-04 Thread Robert Haas
More doc cleanups for recent shared memory changes. Josh Kupershmidt Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/248b5fce0643c5662c60ac7f8bfe4d68b7e96bb4 Modified Files -- doc/src/sgml/config.sgml | 45 -

[COMMITTERS] pgsql: Add wchar - mb conversion routines.

2012-07-04 Thread Robert Haas
Add wchar - mb conversion routines. This is infrastructure for Alexander Korotkov's work on indexing regular expression searches. Alexander Korotkov, with a bit of further hackery on the MULE conversion by me Branch -- master Details ---

[COMMITTERS] pgsql: Fix sample INSTR function to return 0 if third arg is 0.

2012-07-04 Thread Robert Haas
Fix sample INSTR function to return 0 if third arg is 0. Albe Laurenz, per a report by Greg Smith that our sample function doesn't quite match Oracle's behavior. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0fc32c00d74404a9a535e0e1b8d9437dfd8075db Modified Files

[COMMITTERS] pgsql: Reduce messages about implicit indexes and sequences to DEBUG1.

2012-07-04 Thread Robert Haas
Reduce messages about implicit indexes and sequences to DEBUG1. Per recent discussion on pgsql-hackers, these messages are too chatty for most users. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d7c734841b3e6cb44de363a8a3d83c35b75b30d9 Modified Files

[COMMITTERS] pgsql: Fix failure of new wchar-mb functions to advance from pointer.

2012-07-05 Thread Robert Haas
Fix failure of new wchar-mb functions to advance from pointer. Bug spotted by Tom Lane. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f6a05fd973a102f7e66c491d3f854864b8d24844 Modified Files -- src/backend/utils/mb/wchar.c |5 - 1 files changed,

[COMMITTERS] pgsql: Syntax support and documentation for event triggers.

2012-07-18 Thread Robert Haas
Syntax support and documentation for event triggers. They don't actually do anything yet; that will get fixed in a follow-on commit. But this gets the basic infrastructure in place, including CREATE/ALTER/DROP EVENT TRIGGER; support for COMMENT, SECURITY LABEL, and ALTER EXTENSION .. ADD/DROP

[COMMITTERS] pgsql: Make new event trigger facility actually do something.

2012-07-20 Thread Robert Haas
, add a regression test for ALTER LARGE OBJECT, since testing of event triggers reveals that we haven't got one. Dimitri Fontaine and Robert Haas Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3a0e4d36ebd7f477822d5bae41ba121a40d22ccc Modified Files

[COMMITTERS] pgsql: Temporary patch to try to debug why event trigger patch broke Wi

2012-07-20 Thread Robert Haas
Temporary patch to try to debug why event trigger patch broke Windows. Apologies for the ugliness. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0a248208a038d7847ef98996c6b70209d782415c Modified Files -- src/pl/plpgsql/src/pl_comp.c | 15

[COMMITTERS] pgsql: Repair plpgsql_validator breakage.

2012-07-20 Thread Robert Haas
Repair plpgsql_validator breakage. Commit 3a0e4d36ebd7f477822d5bae41ba121a40d22ccc arranged to reference stack-allocated variables after they were out of scope. That's no good, so let's arrange to not do that after all. Branch -- master Details ---

[COMMITTERS] pgsql: Revert temporary patch to debug Windows breakage.

2012-07-20 Thread Robert Haas
Revert temporary patch to debug Windows breakage. This reverts commit 0a248208a038d7847ef98996c6b70209d782415c. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ed0af3324702685cce63aed0641b4cbb45816b50 Modified Files -- src/pl/plpgsql/src/pl_comp.c |

[COMMITTERS] pgsql: Make pgbench vacuum before building indexes.

2012-07-23 Thread Robert Haas
Make pgbench vacuum before building indexes. This is apparently faster than doing things the other way around when the scale factor is large. Along the way, adjust -n to suppress vacuuming during initialization as well as during test runs. Jeff Janes, with some small changes by me. Branch

[COMMITTERS] pgsql: Log a better message when canceling autovacuum.

2012-07-26 Thread Robert Haas
Log a better message when canceling autovacuum. The old message was at DEBUG2, so typically it didn't show up in the log at all. As a result, in most cases where autovacuum was canceled, the only information that was logged was the table being vacuumed, with no indication as to what problem

[COMMITTERS] pgsql: Log a better message when canceling autovacuum.

2012-07-26 Thread Robert Haas
Log a better message when canceling autovacuum. The old message was at DEBUG2, so typically it didn't show up in the log at all. As a result, in most cases where autovacuum was canceled, the only information that was logged was the table being vacuumed, with no indication as to what problem

[COMMITTERS] pgsql: Log a better message when canceling autovacuum.

2012-07-26 Thread Robert Haas
Log a better message when canceling autovacuum. The old message was at DEBUG2, so typically it didn't show up in the log at all. As a result, in most cases where autovacuum was canceled, the only information that was logged was the table being vacuumed, with no indication as to what problem

[COMMITTERS] pgsql: Log a better message when canceling autovacuum.

2012-07-26 Thread Robert Haas
Log a better message when canceling autovacuum. The old message was at DEBUG2, so typically it didn't show up in the log at all. As a result, in most cases where autovacuum was canceled, the only information that was logged was the table being vacuumed, with no indication as to what problem

[COMMITTERS] pgsql: Log a better message when canceling autovacuum.

2012-07-26 Thread Robert Haas
Log a better message when canceling autovacuum. The old message was at DEBUG2, so typically it didn't show up in the log at all. As a result, in most cases where autovacuum was canceled, the only information that was logged was the table being vacuumed, with no indication as to what problem

[COMMITTERS] pgsql: Log a better message when canceling autovacuum.

2012-07-26 Thread Robert Haas
Log a better message when canceling autovacuum. The old message was at DEBUG2, so typically it didn't show up in the log at all. As a result, in most cases where autovacuum was canceled, the only information that was logged was the table being vacuumed, with no indication as to what problem

[COMMITTERS] pgsql: Tab complete table names after ALTER TABLE x [NO] INHERIT.

2012-07-26 Thread Robert Haas
Tab complete table names after ALTER TABLE x [NO] INHERIT. Jeff Janes Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d20cdd31c0f0cd2d94ecb6a5dff4d1f183106541 Modified Files -- src/bin/psql/tab-complete.c | 15 +++ 1 files changed, 15

[COMMITTERS] pgsql: Warn more vigorously about the non-transactional behavior of seq

2012-08-06 Thread Robert Haas
Warn more vigorously about the non-transactional behavior of sequences. Craig Ringer, edited fairly heavily by me Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/16a69120eb4d2728bc7b988aee9fedf86d15be53 Modified Files --

<    4   5   6   7   8   9   10   11   12   13   >