Re: [COMMITTERS] pgsql: Exit from base backups when shutdown is requested

2011-01-14 Thread Simon Riggs
ention that will make life more difficult for testing. Thanks, -- Simon Riggs http://www.2ndQuadrant.com/books/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes

[COMMITTERS] pgsql: Fix error code for canceling statement due to conflict with reco

2011-01-31 Thread Simon Riggs
Fix error code for canceling statement due to conflict with recovery. All retryable conflict errors now have an error code that indicates that a retry is possible, correcting my incomplete fix of 2010/05/12 Tatsuo Ishii and Simon Riggs, input from Robert Haas and Florian Pflug Branch

[COMMITTERS] pgsql: Fix error code for canceling statement due to conflict with reco

2011-01-31 Thread Simon Riggs
Fix error code for canceling statement due to conflict with recovery. All retryable conflict errors now have an error code that indicates that a retry is possible, correcting my incomplete fix of 2010/05/12 Tatsuo Ishii and Simon Riggs, input from Robert Haas and Florian Pflug Branch

[COMMITTERS] pgsql: Create new errcode for recovery conflict caused by db drop on ma

2011-01-31 Thread Simon Riggs
Create new errcode for recovery conflict caused by db drop on master. Previously reported as ERRCODE_ADMIN_SHUTDOWN, this case is now reported as ERRCODE_T_R_DATABASE_DROPPED. No message text change. Unlikely to happen on most servers, so low impact change to allow session poolers to correctly hand

[COMMITTERS] pgsql: Re-classify ERRCODE_DATABASE_DROPPED to 57P04

2011-02-01 Thread Simon Riggs
Re-classify ERRCODE_DATABASE_DROPPED to 57P04 Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=56b21b7ae38bc1efb701e7ebfd208e2e194e7998 Modified Files -- doc/src/sgml/errcodes.sgml | 11 ++- src/backend/tcop/postgres.

[COMMITTERS] pgsql: Create new errcode for recovery conflict caused by db drop on ma

2011-02-01 Thread Simon Riggs
this situation. Tatsuo Ishii and Simon Riggs Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=d6c1dc176a422ed19d698bb8ff9ed7b38c04a320 Modified Files -- doc/src/sgml/errcodes.sgml |6 ++ src/backend/tcop

[COMMITTERS] pgsql: Extend ALTER TABLE to allow Foreign Keys to be added without ini

2011-02-08 Thread Simon Riggs
adding FKs. New state visible from psql. Simon Riggs, with reviews from Marko Tiikkaja and Robert Haas Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=722bf7017bbe796decc79c1fde03e7a83dae9ada Modified Files -- doc/src/sgml/ref

[COMMITTERS] pgsql: Remove rare corner case for data loss when triggering standby se

2011-02-08 Thread Simon Riggs
Remove rare corner case for data loss when triggering standby server. If the standby was streaming when trigger file arrives, check also in the archive for additional WAL files. This is a corner case since it is unlikely that we would trigger a failover while the master is still available and sendi

[COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause,

2011-02-08 Thread Simon Riggs
Basic Recovery Control functions for use in Hot Standby. Pause, Resume, Status check functions only. Also, new recovery.conf parameter to pause_at_recovery_target, default on. Simon Riggs, reviewed by Fujii Masao Branch -- master Details --- http://git.postgresql.org/gitweb?p

[COMMITTERS] pgsql: Named restore points in recovery. Users can record named points,

2011-02-08 Thread Simon Riggs
Named restore points in recovery. Users can record named points, then new recovery.conf parameter recovery_target_name allows PITR to specify named points as recovery targets. Jaime Casanova, reviewed by Euler Taveira de Oliveira, plus minor edits Branch -- master Details --- http://git.

[COMMITTERS] pgsql: Continue long tradition of bumping the catalog version a little

2011-02-08 Thread Simon Riggs
Continue long tradition of bumping the catalog version a little late. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=7a7d36ec3363d10e0450209a9b451d86a2328b47 Modified Files -- src/include/catalog/catversion.h |2 +- 1 files ch

Re: [COMMITTERS] pgsql: Suppress some compiler warnings in recent commits.

2011-02-08 Thread Simon Riggs
On Tue, 2011-02-08 at 23:12 +, Tom Lane wrote: > Also clean up logic in ATExecValidateConstraint to make it easier to read > and less likely to provoke "variable might be used uninitialized in this > function" warnings. Thanks. -- Simon Riggs http://www.2n

[COMMITTERS] pgsql: Add version-sensitive SQL for psql when constraints NOT VALID

2011-02-14 Thread Simon Riggs
Add version-sensitive SQL for psql when constraints NOT VALID Bug report and fix by Andres Freund Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f0b8a79c4bea7bfa89245ee03abf994b027da411 Modified Files -- src/bin/psql/describe.c |2 +- 1 files changed,

[COMMITTERS] pgsql: PITR can stop at a named restore point when recovery target = ti

2011-02-14 Thread Simon Riggs
PITR can stop at a named restore point when recovery target = time though must not update the last transaction timestamp. Plus comment and message cleanup for recent named restore point. Fujii Masao, minor changes by me Branch -- master Details --- http://git.postgresql.org/pg/commitdiff

[COMMITTERS] pgsql: Additional required docs for pg_constraint catalog entry

2011-02-14 Thread Simon Riggs
Additional required docs for pg_constraint catalog entry Noted by Bernd Helmle Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0ff1b7350984b9e4055e9d3a37d3b875c0663ac4 Modified Files -- doc/src/sgml/catalogs.sgml |7 +++ 1 files changed, 7 inserti

[COMMITTERS] pgsql: Hot Standby feedback for avoidance of cleanup conflicts on stand

2011-02-16 Thread Simon Riggs
se cases still exist. Simon Riggs, review comments from Fujii Masao, Heikki Linnakangas, Robert Haas Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bca8b7f16a3e720794cb0afbdb3733be4f8d9c2c Modified Files -- doc/src/sgml/config.sgml

[COMMITTERS] pgsql: Separate messages for standby replies and hot standby feedback.

2011-02-18 Thread Simon Riggs
Separate messages for standby replies and hot standby feedback. Allow messages to be sent at different times, and greatly reduce the frequency of hot standby feedback. Refactor to allow additional message types. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/06828c5f

[COMMITTERS] pgsql: Make a hard state change from catchup to streaming mode.

2011-02-18 Thread Simon Riggs
Make a hard state change from catchup to streaming mode. More useful state change for monitoring purposes, plus a required change for synchronous replication patch. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bc76695c4c44e21aed94ee2bea81c4cdcedf1390 Modified File

Re: [COMMITTERS] pgsql: Separate messages for standby replies and hot standby feedback.

2011-02-18 Thread Simon Riggs
On Fri, 2011-02-18 at 20:22 +0200, Heikki Linnakangas wrote: > On 18.02.2011 13:34, Simon Riggs wrote: > > Separate messages for standby replies and hot standby feedback. > > Allow messages to be sent at different times, and greatly reduce > > the frequency of hot standby

[COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication.

2011-03-06 Thread Simon Riggs
; more relaxed options may be added at a later date. Simon Riggs and Fujii Masao, with reviews by Yeb Havinga, Jaime Casanova, Heikki Linnakangas and Robert Haas, plus the assistance of many other design reviewers. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff

[COMMITTERS] pgsql: Add new files for syncrep missed in previous commit

2011-03-06 Thread Simon Riggs
Add new files for syncrep missed in previous commit Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/966fb05b588ab33a6c99c6a26308941e1b3a1188 Modified Files -- src/backend/replication/syncrep.c | 589 + src/include/repli

[COMMITTERS] pgsql: Catversion increment for pg_stat_replication changes for syncrep

2011-03-06 Thread Simon Riggs
Catversion increment for pg_stat_replication changes for syncrep Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/dcfe3f60c12880c52fd3cb9b5d51ff44c946dd6c Modified Files -- src/include/catalog/catversion.h |2 +- 1 files changed, 1 insertions(+), 1 dele

Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication.

2011-03-06 Thread Simon Riggs
On Sun, 2011-03-06 at 18:28 -0500, Tom Lane wrote: > Simon Riggs writes: > > Efficient transaction-controlled synchronous replication. > > This patch broke the build. Kindly fix or revert at once. I think that's fixed it now. I was in the middle of doing that when your l

[COMMITTERS] pgsql: Dynamic array required within pg_stat_replication.

2011-03-06 Thread Simon Riggs
Dynamic array required within pg_stat_replication. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cae4974e3d4c0cb1237568b55a2cee4482d42f40 Modified Files -- src/backend/replication/walsender.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)

Re: [COMMITTERS] pgsql: Efficient transaction-controlled synchronous replication.

2011-03-07 Thread Simon Riggs
On Mon, 2011-03-07 at 17:27 +0900, Fujii Masao wrote: > On Mon, Mar 7, 2011 at 7:51 AM, Simon Riggs wrote: > And,, I found one bug ;) You seem to have wrongly removed the check > of max_wal_senders in SyncRepWaitForLSN. This can make the > backend wait for replication even if max_wal

Re: [COMMITTERS] pgsql: synchronous_standby_names is a string parameter.

2011-03-09 Thread Simon Riggs
On Wed, 2011-03-09 at 10:50 +, Itagaki Takahiro wrote: > synchronous_standby_names is a string parameter. Thanks! That bug was already fixed earlier, so it must have crept back in when we were chopping patches up into pieces. -- Simon Riggs http://www.2ndQuadrant.com/bo

[COMMITTERS] pgsql: Update docs to say you need fsync to make sync rep work fast.

2011-03-22 Thread Simon Riggs
Update docs to say you need fsync to make sync rep work fast. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6e8e7cc580665ddd43c8ca2acc6d60f345570a57 Modified Files -- doc/src/sgml/high-availability.sgml |8 +++- 1 files changed, 7 insertions(+),

[COMMITTERS] pgsql: Make FKs valid at creation when added as column constraints.

2011-03-22 Thread Simon Riggs
Make FKs valid at creation when added as column constraints. Bug report from Alvaro Herrera Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ec497a5ad6a0849efa3fb2fd05988bd8e0c0865d Modified Files -- src/backend/commands/tablecmds.c |2 +- src/backen

[COMMITTERS] pgsql: Prevent intermittent hang in recovery from bgwriter interaction.

2011-03-23 Thread Simon Riggs
Prevent intermittent hang in recovery from bgwriter interaction. Startup process waited for cleanup lock but when hot_standby = off the pid was not registered, so that the bgwriter would not wake the waiting process as intended. Branch -- master Details --- http://git.postgresql.org/pg/co

[COMMITTERS] pgsql: Prevent intermittent hang in recovery from bgwriter interaction.

2011-03-23 Thread Simon Riggs
Prevent intermittent hang in recovery from bgwriter interaction. Startup process waited for cleanup lock but when hot_standby = off the pid was not registered, so that the bgwriter would not wake the waiting process as intended. Branch -- REL9_0_STABLE Details --- http://git.postgresql.or

[COMMITTERS] pgsql: Minor changes to recovery pause behaviour.

2011-03-23 Thread Simon Riggs
Minor changes to recovery pause behaviour. Change location LOG message so it works each time we pause, not just for final pause. Ensure that we pause only if we are in Hot Standby and can connect to allow us to run resume function. This change supercedes the code to override parameter recoveryPause

[COMMITTERS] pgsql: Additional test for each commit in sync rep path to plug minute

2011-03-26 Thread Simon Riggs
Additional test for each commit in sync rep path to plug minute possibility of race condition that would effect performance only. Requested by Robert Haas. Re-arrange related comments. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/92f4786fa9b730fd12cbfe973eb96addc6e

[COMMITTERS] pgsql: Update comments and credit doc proofreaders

2011-04-04 Thread Simon Riggs
Update comments and credit doc proofreaders Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/35d2a660fea51f8acae6aa0895875757fa09cb26 Modified Files -- doc/src/sgml/release-9.1.sgml | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-

[COMMITTERS] pgsql: Centralise release note items related to recovery and replicatio

2011-04-04 Thread Simon Riggs
Centralise release note items related to recovery and replication Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/479ee1b962ca2d479310af762c21d7c2056fdeca Modified Files -- doc/src/sgml/release-9.1.sgml | 183 +++-- 1 f

[COMMITTERS] pgsql: Avoid assuming there will be only 3 states for synchronous_commi

2011-04-04 Thread Simon Riggs
Avoid assuming there will be only 3 states for synchronous_commit. Also avoid hardcoding the current default state by giving it the name "on" and replace with a meaningful name that reflects its behaviour. Coding only, no change in behaviour. Branch -- master Details --- http://git.postgr

[COMMITTERS] pgsql: Respect Hot Standby controls while recycling btree index pages.

2011-06-16 Thread Simon Riggs
avoid Hot Standby conflicts and so spurious conflicts could be generated in some workload combinations. We now reuse pages only when we reach RecentGlobalXmin, which can be much later in the presence of long running queries and is also controlled by vacuum_defer_cleanup_age. Noah Misch and Simon

[COMMITTERS] pgsql: Respect Hot Standby controls while recycling btree index pages.

2011-06-16 Thread Simon Riggs
. Noah Misch and Simon Riggs Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/758bd2a433d64bed00ca084203b3e5ccfdea4499 Modified Files -- src/backend/access/nbtree/nbtpage.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) -- Sent

[COMMITTERS] pgsql: Respect Hot Standby controls while recycling btree index pages.

2011-06-16 Thread Simon Riggs
. Noah Misch and Simon Riggs Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/9340e643e4cbc11a7a5aaea0297236e9a8c07600 Modified Files -- src/backend/access/nbtree/nbtpage.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions

[COMMITTERS] pgsql: Reduce impact of btree page reuse on Hot Standby by fixing off-b

2011-06-27 Thread Simon Riggs
ise quiet system by Noah Misch. Noah Misch and Simon Riggs Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e1cd66f74862936d84acf3008118d6094c56ad58 Modified Files -- src/backend/access/nbtree/nbtpage.c | 12 +++- 1 files changed, 11 insertions(+)

[COMMITTERS] pgsql: Reduce impact of btree page reuse on Hot Standby by fixing off-b

2011-06-27 Thread Simon Riggs
ise quiet system by Noah Misch. Noah Misch and Simon Riggs Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/ca7e04b0b9943d5c33d2e993ff685d45b5bddbbd Modified Files -- src/backend/access/nbtree/nbtpage.c | 12 +++- 1 files changed, 11 inserti

[COMMITTERS] pgsql: Reduce impact of btree page reuse on Hot Standby by fixing off-b

2011-06-27 Thread Simon Riggs
ise quiet system by Noah Misch. Noah Misch and Simon Riggs Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/5cd81b8df0a9f3e4cb407e815b9a789138fd0356 Modified Files -- src/backend/access/nbtree/nbtpage.c | 12 +++- 1 files changed, 11 inserti

[COMMITTERS] pgsql: Introduce compact WAL record for the common case of commit (non-

2011-06-28 Thread Simon Riggs
. Leonardo Francalanci and Simon Riggs Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/465883b0a2b4236ba6b31b648a9eabef3b7cdddb Modified Files -- src/backend/access/transam/xact.c | 245 +--- src/backend/access/transam/xlog.c

[COMMITTERS] pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case

2011-07-04 Thread Simon Riggs
Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases. Locks on inheritance parent remain at lower level, as they were before. Remove entry from 9.1 release notes. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/1f7056099728035b55efcd8f889c7b705a68b

[COMMITTERS] pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case

2011-07-04 Thread Simon Riggs
Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases. Locks on inheritance parent remain at lower level, as they were before. Remove entry from 9.1 release notes. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2c3d9db56d5d49bdc777b174982251c01348e3d8 Mo

[COMMITTERS] pgsql: Alter test results to comply with new ALTER TABLE behaviour.

2011-07-04 Thread Simon Riggs
Alter test results to comply with new ALTER TABLE behaviour. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/677f146307a95f862c0c7b51819c79a00af61f95 Modified Files -- src/test/regress/expected/alter_table.out | 72 ++--- s

[COMMITTERS] pgsql: Alter test results to comply with new ALTER TABLE behaviour.

2011-07-04 Thread Simon Riggs
Alter test results to comply with new ALTER TABLE behaviour. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f563afd433e07a2eb7db614005141f21613d4d61 Modified Files -- src/test/regress/expected/alter_table.out | 72 ++--- src/test

Re: [COMMITTERS] pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case

2011-07-04 Thread Simon Riggs
On Mon, Jul 4, 2011 at 9:31 AM, Simon Riggs wrote: > Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases. > Locks on inheritance parent remain at lower level, as they were before. > Remove entry from 9.1 release notes. This commit caused pgbuildfarm failures on 15 mach

Re: [COMMITTERS] pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case

2011-07-05 Thread Simon Riggs
On Tue, Jul 5, 2011 at 2:46 PM, Robert Haas wrote: > On Mon, Jul 4, 2011 at 6:14 AM, Simon Riggs wrote: >> On Mon, Jul 4, 2011 at 9:31 AM, Simon Riggs wrote: >>> Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases. >>> Locks on inheritance parent rem

Re: [COMMITTERS] pgsql: Reset ALTER TABLE lock levels to AccessExclusiveLock in all case

2011-07-10 Thread Simon Riggs
On Thu, Jul 7, 2011 at 6:17 PM, Tom Lane wrote: > Robert Haas writes: >> On Mon, Jul 4, 2011 at 6:14 AM, Simon Riggs wrote: >>>> Reset ALTER TABLE lock levels to AccessExclusiveLock in all cases. >>>> Locks on inheritance parent remain at lower level, as they we

[COMMITTERS] pgsql: Cascading replication feature for streaming log-based replicatio

2011-07-18 Thread Simon Riggs
. WALSenders terminated when promote to master. Fujii Masao, review, rework and doc rewrite by Simon Riggs Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5286105800c7d5902f98f32e11b209c471c0c69c Modified Files -- doc/src/sgml/config.sgml | 127

[COMMITTERS] pgsql: Introduce sending servers as new category for replication params

2011-07-19 Thread Simon Riggs
Introduce sending servers as new category for replication params Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4bd8ed31b76fde16ee00c123751e25019e4d9854 Modified Files -- src/backend/utils/misc/guc.c | 10 ++ src/ba

[COMMITTERS] pgsql: Minor doc additions for cascading replication.

2011-07-19 Thread Simon Riggs
Minor doc additions for cascading replication. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6ba77bce9378cb9c5fb89a4d30bf77c2a17b0d64 Modified Files -- doc/src/sgml/config.sgml |2 +- doc/src/sgml/monitoring.sgml |3 ++- 2 files changed, 3 ins

[COMMITTERS] pgsql: Remove O(N^2) performance issue with multiple SAVEPOINTs.

2011-07-19 Thread Simon Riggs
Remove O(N^2) performance issue with multiple SAVEPOINTs. Subtransaction locks now released en masse at main commit, rather than repeatedly re-scanning for locks as we ascend the nested transaction tree. Split transaction state TBLOCK_SUBEND into two states, TBLOCK_SUBCOMMIT and TBLOCK_SUBRELEASE t

Re: [COMMITTERS] pgsql: Fix incorrect initialization of ProcGlobal->startupBufferPinWait

2011-08-02 Thread Simon Riggs
y sessions, should a HS backend be holding pin on buffer number 1 > while trying to acquire a lock. Did I miss a bug report? --  Simon Riggs   http://www.2ndQuadrant.com/  PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers maili

Re: [COMMITTERS] pgsql: Fix incorrect initialization of ProcGlobal->startupBufferPinWait

2011-08-02 Thread Simon Riggs
On Tue, Aug 2, 2011 at 8:23 PM, Tom Lane wrote: > Simon Riggs writes: >> On Tue, Aug 2, 2011 at 6:24 PM, Tom Lane wrote: >>> Fix incorrect initialization of ProcGlobal->startupBufferPinWaitBufId. >>> >>> It was initialized in the wrong place and to the wro

[COMMITTERS] pgsql: Emit cascaded standby message on shutdown only when appropriate.

2011-09-07 Thread Simon Riggs
Emit cascaded standby message on shutdown only when appropriate. Adds additional test for active walsenders and closes a race condition for when we failover when a new walsender was connecting. Reported and fixed bu Fujii Masao. Review by Heikki Linnakangas Branch -- master Details --- h

[COMMITTERS] pgsql: Partially revoke attempt to improve performance with many savepo

2011-09-07 Thread Simon Riggs
Partially revoke attempt to improve performance with many savepoints. Maintain difference between subtransaction release and commit introduced by earlier patch. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/df383b03e6f761c9b5bb12aa2339795ab44aa054 Modified Files --

[COMMITTERS] pgsql: PublishStartupProcessInformation() to avoid rare hang in recover

2011-09-08 Thread Simon Riggs
PublishStartupProcessInformation() to avoid rare hang in recovery. Bgwriter could cause hang in recovery during page concurrent cleaning. Bug report and testing by Bernd Helmle, fix by me Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/7c24bac64c3828d651abfd5e

[COMMITTERS] pgsql: synchronous_commit is an enum not a boolean.

2011-09-23 Thread Simon Riggs
synchronous_commit is an enum not a boolean. Jaime Casanova Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/8ab067da917398e6bcf733fcb835c5d4852ff03b Modified Files -- doc/src/sgml/config.sgml |2 +- 1 files changed, 1 insertions(+), 1 deletions

[COMMITTERS] pgsql: synchronous_commit is an enum not a boolean.

2011-09-23 Thread Simon Riggs
synchronous_commit is an enum not a boolean. Jaime Casanova Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e5e2f7b0546c0409323af262bdd17a8e19ca3836 Modified Files -- doc/src/sgml/config.sgml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -

Re: [COMMITTERS] pgsql: More cleanup after failed reduced-lock-levels-for-DDL feature.

2011-10-22 Thread Simon Riggs
e is in the 9.1 branch too. > Alvaro found one of them, I found the other two. Very cool, thanks. --  Simon Riggs   http://www.2ndQuadrant.com/  PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-committers mailing list (pgsql-commi

[COMMITTERS] pgsql: Split work of bgwriter between 2 processes: bgwriter and checkpo

2011-11-01 Thread Simon Riggs
Split work of bgwriter between 2 processes: bgwriter and checkpointer. bgwriter is now a much less important process, responsible for page cleaning duties only. checkpointer is now responsible for checkpoints and so has a key role in shutdown. Later patches will correct doc references to the now ol

[COMMITTERS] pgsql: Comment changes to show bgwriter no longer performs checkpoints.

2011-11-01 Thread Simon Riggs
Comment changes to show bgwriter no longer performs checkpoints. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f3ebaad45b473f3a53de2cd2a5252cd653aa46f3 Modified Files -- src/backend/access/transam/xlog.c |6 +++--- src/backend/commands/dbcommands.c |

[COMMITTERS] pgsql: Add new file for checkpointer.c

2011-11-01 Thread Simon Riggs
Add new file for checkpointer.c Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bf405ba8e460051e715d0a91442b579e590328ce Modified Files -- src/backend/postmaster/checkpointer.c | 1236 + 1 files changed, 1236 insertions(+),

[COMMITTERS] pgsql: Have checkpointer send stats once each processing loop.

2011-11-01 Thread Simon Riggs
Have checkpointer send stats once each processing loop. Noted by Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3ba182056faac66012aad8dedf2cb50ba511d989 Modified Files -- src/backend/postmaster/checkpointer.c |5 + 1 files changed, 5

[COMMITTERS] pgsql: Fix timing of Startup CLOG and MultiXact during Hot Standby

2011-11-02 Thread Simon Riggs
Fix timing of Startup CLOG and MultiXact during Hot Standby Patch by me, bug report by Chris Redekop, analysis by Florian Pflug Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/2f55c535e1f026929cf20855b3790d3632062d42 Modified Files -- src/backend/

[COMMITTERS] pgsql: Fix timing of Startup CLOG and MultiXact during Hot Standby

2011-11-02 Thread Simon Riggs
Fix timing of Startup CLOG and MultiXact during Hot Standby Patch by me, bug report by Chris Redekop, analysis by Florian Pflug Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/9e5fe4d49227c5c5297410d54d6551a726814adc Modified Files -- src/backend/

[COMMITTERS] pgsql: Fix timing of Startup CLOG and MultiXact during Hot Standby

2011-11-02 Thread Simon Riggs
Fix timing of Startup CLOG and MultiXact during Hot Standby Patch by me, bug report by Chris Redekop, analysis by Florian Pflug Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f8409b39d1dae28f063b378b9edee1a657845503 Modified Files -- src/backend/access/

[COMMITTERS] pgsql: Start Hot Standby faster when initial snapshot is incomplete.

2011-11-02 Thread Simon Riggs
Start Hot Standby faster when initial snapshot is incomplete. If the initial snapshot had overflowed then we can start whenever the latest snapshot is empty, not overflowed or as we did already, start when the xmin on primary was higher than xmax of our starting snapshot, which proves we have full

[COMMITTERS] pgsql: Remove spurious entry from missed catch while patch juggling

2011-11-02 Thread Simon Riggs
Remove spurious entry from missed catch while patch juggling Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2296e62a326dfd16ecae590f2f29773fd4348e7f Modified Files -- src/backend/utils/init/postinit.c |1 - 1 files changed, 0 insertions(+), 1 deletion

[COMMITTERS] pgsql: Start Hot Standby faster when initial snapshot is incomplete.

2011-11-02 Thread Simon Riggs
Start Hot Standby faster when initial snapshot is incomplete. If the initial snapshot had overflowed then we can start whenever the latest snapshot is empty, not overflowed or as we did already, start when the xmin on primary was higher than xmax of our starting snapshot, which proves we have full

[COMMITTERS] pgsql: Start Hot Standby faster when initial snapshot is incomplete.

2011-11-02 Thread Simon Riggs
Start Hot Standby faster when initial snapshot is incomplete. If the initial snapshot had overflowed then we can start whenever the latest snapshot is empty, not overflowed or as we did already, start when the xmin on primary was higher than xmax of our starting snapshot, which proves we have full

[COMMITTERS] pgsql: Derive oldestActiveXid at correct time for Hot Standby.

2011-11-02 Thread Simon Riggs
Derive oldestActiveXid at correct time for Hot Standby. There was a timing window between when oldestActiveXid was derived and when it should have been derived that only shows itself under heavy load. Move code around to ensure correct timing of derivation. No change to StartupSUBTRANS() code, whic

[COMMITTERS] pgsql: Derive oldestActiveXid at correct time for Hot Standby.

2011-11-02 Thread Simon Riggs
Derive oldestActiveXid at correct time for Hot Standby. There was a timing window between when oldestActiveXid was derived and when it should have been derived that only shows itself under heavy load. Move code around to ensure correct timing of derivation. No change to StartupSUBTRANS() code, whic

[COMMITTERS] pgsql: Derive oldestActiveXid at correct time for Hot Standby.

2011-11-02 Thread Simon Riggs
Derive oldestActiveXid at correct time for Hot Standby. There was a timing window between when oldestActiveXid was derived and when it should have been derived that only shows itself under heavy load. Move code around to ensure correct timing of derivation. No change to StartupSUBTRANS() code, whic

[COMMITTERS] pgsql: Refactor xlog.c to create src/backend/postmaster/startup.c

2011-11-02 Thread Simon Riggs
Refactor xlog.c to create src/backend/postmaster/startup.c Startup process now has its own dedicated file, just like all other special/background processes. Reduces role and size of xlog.c Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9aceb6ab3c202a5bf00d5f00436bb6a

[COMMITTERS] pgsql: Reduce checkpoints and WAL traffic on low activity database serv

2011-11-02 Thread Simon Riggs
Reduce checkpoints and WAL traffic on low activity database server Previously, we skipped a checkpoint if no WAL had been written since last checkpoint, though this does not appear in user documentation. As of now, we skip a checkpoint until we have written at least one enough WAL to switch the nex

Re: [COMMITTERS] pgsql: Reduce checkpoints and WAL traffic on low activity database serv

2011-11-02 Thread Simon Riggs
On Wed, Nov 2, 2011 at 4:15 PM, Robert Haas wrote: > On Wed, Nov 2, 2011 at 11:39 AM, Simon Riggs wrote: >> Reduce checkpoints and WAL traffic on low activity database server >> Previously, we skipped a checkpoint if no WAL had been written since >> last checkpoint, though

[COMMITTERS] pgsql: Update more comments about checkpoints being done by bgwriter

2011-11-02 Thread Simon Riggs
Update more comments about checkpoints being done by bgwriter Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/750f70b0fe91258f9f99b1d04a510e5b035e9249 Modified Files -- src/backend/access/transam/xlog.c | 20 ++-- 1 files changed, 10 inse

[COMMITTERS] pgsql: Improve docs for timing and skipping of checkpoints

2011-11-03 Thread Simon Riggs
Improve docs for timing and skipping of checkpoints Greg Smith Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/43342891861cc2d08dea2b1c8b190e15e5a36551 Modified Files -- doc/src/sgml/wal.sgml | 11 +-- 1 files changed, 9 insertions(+), 2 deletio

[COMMITTERS] pgsql: Move user functions related to WAL into xlogfuncs.c

2011-11-04 Thread Simon Riggs
Move user functions related to WAL into xlogfuncs.c Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a030bfa6e41edae8a9a68dc8cef7fc7813f69a0a Modified Files -- src/backend/access/transam/Makefile|3 +- src/backend/access/transam/xlog.c | 470 +

[COMMITTERS] pgsql: Wakeup WALWriter as needed for asynchronous commit performance.

2011-11-13 Thread Simon Riggs
Wakeup WALWriter as needed for asynchronous commit performance. Previously we waited for wal_writer_delay before flushing WAL. Now we also wake WALWriter as soon as a WAL buffer page has filled. Significant effect observed on performance of asynchronous commits by Robert Haas, attributed to the abi

[COMMITTERS] pgsql: Avoid marking buffer dirty when VACUUM has no work to do.

2011-11-18 Thread Simon Riggs
Avoid marking buffer dirty when VACUUM has no work to do. When wal_level = 'hot_standby' we touched the last page of the relation during a VACUUM, even if nothing else had happened. That would alter the LSN of the last block and set the mtime of the relation file unnecessarily. Noted by Thom Brown.

[COMMITTERS] pgsql: Continue to allow VACUUM to mark last block of index dirty

2011-11-22 Thread Simon Riggs
Continue to allow VACUUM to mark last block of index dirty even when there is no work to do. Further analysis required. Revert of patch c1458cc495ff800cd176a1c2e56d8b62680d9b71 Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2d2841a56c8fa37a5dd5c6d33488ba6ca37116ff M

[COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers.

2011-12-31 Thread Simon Riggs
Send new protocol keepalive messages to standby servers. Allows streaming replication users to calculate transfer latency and apply delay via internal functions. No external functions yet. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/64233902d22ba42846397cb75518942

[COMMITTERS] pgsql: Minor but necessary improvements to WAL keepalives

2012-01-13 Thread Simon Riggs
Minor but necessary improvements to WAL keepalives Fujii Masao Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3f1787c253967617a0e34fa4bfb7b2ab184ad484 Modified Files -- src/backend/replication/walreceiver.c |3 ++- src/backend/replication/walsender.c

[COMMITTERS] pgsql: Correctly initialise shared recoveryLastRecPtr in recovery.

2012-01-13 Thread Simon Riggs
Correctly initialise shared recoveryLastRecPtr in recovery. Previously we used ReadRecPtr rather than EndRecPtr, which was not a serious error but caused pg_stat_replication to report incorrect replay_location until at least one WAL record is replayed. Fujii Masao Branch -- master Details --

Re: [COMMITTERS] pgsql: Typo fix.

2012-01-13 Thread Simon Riggs
On Fri, Jan 13, 2012 at 1:22 PM, Robert Haas wrote: > Typo fix. Hmm, how strange. I fixed that bug immediately before commit, so must have skipped a step while committing. Thanks. --  Simon Riggs   http://www.2ndQuadrant.com/  PostgreSQL Development, 24x7 Support, Train

Re: [COMMITTERS] pgsql: Typo fix.

2012-01-13 Thread Simon Riggs
On Fri, Jan 13, 2012 at 1:39 PM, Dave Page wrote: > On Fri, Jan 13, 2012 at 1:29 PM, Simon Riggs wrote: >> On Fri, Jan 13, 2012 at 1:22 PM, Robert Haas wrote: >> >>> Typo fix. >> >> Hmm, how strange. I fixed that bug immediately before commit, so must >

Re: [COMMITTERS] pgsql: Typo fix.

2012-01-13 Thread Simon Riggs
t;patch". > > But I am very much a fan of keeping the repos separate for just that > reason - don't want to accidentally commit dev code. OK thanks. My patch foo seems occasionally faulty, but git merge --disaster is something I'm happy to avoid. I'll work on my h

Re: [COMMITTERS] pgsql: Typo fix.

2012-01-13 Thread Simon Riggs
o be scared of some of the options that git gives us, but > after experimentation I found some of them to be hugely useful and safe > enough that I now very rarely run use patches anymore. Gets better and better - very positive. OK, will give it a try. Thanks guys. --  Simon Riggs 

[COMMITTERS] pgsql: ALTER [IF EXISTS] ... allows silent DDL if required,

2012-01-23 Thread Simon Riggs
ALTER [IF EXISTS] ... allows silent DDL if required, e.g. ALTER FOREIGN TABLE IF EXISTS foo RENAME TO bar Pavel Stehule Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/b8a91d9d1c7ec75aaecf13df687ec7b5b0ed35a6 Modified Files -- doc/src/sgml/ref/alter_for

[COMMITTERS] pgsql: Resolve timing issue with logging locks for Hot Standby.

2012-01-23 Thread Simon Riggs
we avoid applying locks made by transactions with InvalidXid. Simon Riggs, bug report Tom Lane, diagnosis Pavan Deolasee Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c172b7b02e6f6008d6dad66ddee8f67faf223c5b Modified Files -- src/backend/storage/ipc

[COMMITTERS] pgsql: Add new replication mode synchronous_commit = 'write'.

2012-01-24 Thread Simon Riggs
Add new replication mode synchronous_commit = 'write'. Replication occurs only to memory on standby, not to disk, so provides additional performance if user wishes to reduce durability level slightly. Adds concept of multiple independent sync rep queues. Fujii Masao and Simon Rig

[COMMITTERS] pgsql: Allow pg_basebackup from standby node with safety checking.

2012-01-25 Thread Simon Riggs
Allow pg_basebackup from standby node with safety checking. Base backup follows recommended procedure, plus goes to great lengths to ensure that partial page writes are avoided. Jun Ishizuka and Fujii Masao, with minor modifications Branch -- master Details --- http://git.postgresql.org/

Re: [COMMITTERS] pgsql: Resolve timing issue with logging locks for Hot Standby.

2012-01-30 Thread Simon Riggs
On Mon, Jan 30, 2012 at 12:30 AM, Tom Lane wrote: > Simon Riggs writes: >> Resolve timing issue with logging locks for Hot Standby. >> We log AccessExclusiveLocks for replay onto standby nodes, >> but because of timing issues on ProcArray it is possible to >> log a l

[COMMITTERS] pgsql: Various minor comments changes from bgwriter to checkpointer.

2012-01-30 Thread Simon Riggs
Various minor comments changes from bgwriter to checkpointer. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/73f617f13f4ca185977d9f7b09bf9edc491cd12f Modified Files -- src/backend/postmaster/checkpointer.c | 18 +- src/backend/repl

[COMMITTERS] pgsql: Minor bug fix and cleanup from self-review of sync rep queues pa

2012-01-30 Thread Simon Riggs
Minor bug fix and cleanup from self-review of sync rep queues patch. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ba1868ba3138b2119f8290969b9a3936fbc297ce Modified Files -- src/backend/postmaster/checkpointer.c |2 +- src/backend/postmaster/postmast

Re: [COMMITTERS] pgsql: Resolve timing issue with logging locks for Hot Standby.

2012-01-31 Thread Simon Riggs
l occur that way, however. Responsibility for any such errors is still mine so there may be times where that outweighs other thoughts, but as policy I'm happy to make apply-all-at-once the default. --  Simon Riggs   http://www.2ndQuadrant.com/  PostgreSQL Development, 24x7 S

[COMMITTERS] pgsql: Resolve timing issue with logging locks for Hot Standby.

2012-02-01 Thread Simon Riggs
we avoid applying locks made by transactions with InvalidXid. Simon Riggs, bug report Tom Lane, diagnosis Pavan Deolasee Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/8572cc495cd07d4f4a59624d275a75b45340a3b2 Modified Files -- src/backend/storage

  1   2   3   4   5   6   7   8   9   >