[COMMITTERS] pgsql: Tweak create_index_paths()'s test for whether to consider a bitm

2011-01-11 Thread Tom Lane
Tweak create_index_paths()'s test for whether to consider a bitmap scan. Per my note of a couple days ago, create_index_paths would refuse to consider any path at all for GIN indexes if the selectivity estimate came out as 1.0; not even if you tried to force it with enable_seqscan. While this isn

[COMMITTERS] pgsql: Adjust basebackup.c to suppress compiler warnings.

2011-01-11 Thread Tom Lane
Adjust basebackup.c to suppress compiler warnings. Some versions of gcc complain about "variable `tablespaces' might be clobbered by `longjmp' or `vfork'" with the original coding. Fix by moving the PG_TRY block into a separate subroutine. Branch -- master Details --- http://git.postgre

Re: [COMMITTERS] pgsql: Adjust basebackup.c to suppress compiler warnings.

2011-01-11 Thread Tom Lane
Magnus Hagander writes: > On Tue, Jan 11, 2011 at 19:42, Tom Lane wrote: >> Some versions of gcc complain about "variable `tablespaces' might be >> clobbered by `longjmp' or `vfork'" with the original coding.  Fix by >> moving the PG_TRY block into

[COMMITTERS] pgsql: Fix PlanRowMark/ExecRowMark structures to handle inheritance cor

2011-01-12 Thread Tom Lane
Fix PlanRowMark/ExecRowMark structures to handle inheritance correctly. In an inherited UPDATE/DELETE, each target table has its own subplan, because it might have a column set different from other targets. This means that the resjunk columns we add to support EvalPlanQual might be at different p

[COMMITTERS] pgsql: Fix PlanRowMark/ExecRowMark structures to handle inheritance cor

2011-01-12 Thread Tom Lane
Fix PlanRowMark/ExecRowMark structures to handle inheritance correctly. In an inherited UPDATE/DELETE, each target table has its own subplan, because it might have a column set different from other targets. This means that the resjunk columns we add to support EvalPlanQual might be at different p

[COMMITTERS] pgsql: Revert incorrect memory-conservation hack in inheritance_planner

2011-01-13 Thread Tom Lane
Revert incorrect memory-conservation hack in inheritance_planner(). This reverts commit d1001a78ce612a16ea622b558f5fc2b68c45ab4c of 2010-12-05, which was broken as reported by Jeff Davis. The problem is that the individual planning steps may have side-effects on substructures of PlannerGlobal, no

[COMMITTERS] pgsql: Code review for postmaster.pid contents changes.

2011-01-13 Thread Tom Lane
Code review for postmaster.pid contents changes. Fix broken test for pre-existing postmaster, caused by wrong code for appending lines to the lockfile; don't write a failed listen_address setting into the lockfile; don't arbitrarily change the location of the data directory in the lockfile compare

[COMMITTERS] pgsql: Add .gitignore to silence git complaints about parser/scanner ou

2011-01-15 Thread Tom Lane
Add .gitignore to silence git complaints about parser/scanner output files. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=36750dcef58550c652cfff861f9aad057a391fb9 Modified Files -- src/backend/replication/.gitignore |3 +++ 1

[COMMITTERS] pgsql: Move a couple of declarations to reflect where the routines real

2011-01-15 Thread Tom Lane
Move a couple of declarations to reflect where the routines really are. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=6ca452ba7fca14dad16425a56ffa1c8a93496b5f Modified Files -- src/include/commands/defrem.h |6 +++--- 1 files

[COMMITTERS] pgsql: Fix miscalculation of itemsafter in array_set_slice().

2011-01-17 Thread Tom Lane
Fix miscalculation of itemsafter in array_set_slice(). If the slice to be assigned to was before the existing array lower bound (requiring at least one null element to spring into existence to fill the gap), the code miscalculated how many entries needed to be copied from the old array's null bitm

[COMMITTERS] pgsql: Fix miscalculation of itemsafter in array_set_slice().

2011-01-17 Thread Tom Lane
Fix miscalculation of itemsafter in array_set_slice(). If the slice to be assigned to was before the existing array lower bound (requiring at least one null element to spring into existence to fill the gap), the code miscalculated how many entries needed to be copied from the old array's null bitm

[COMMITTERS] pgsql: Fix miscalculation of itemsafter in array_set_slice().

2011-01-17 Thread Tom Lane
Fix miscalculation of itemsafter in array_set_slice(). If the slice to be assigned to was before the existing array lower bound (requiring at least one null element to spring into existence to fill the gap), the code miscalculated how many entries needed to be copied from the old array's null bitm

[COMMITTERS] pgsql: Fix miscalculation of itemsafter in array_set_slice().

2011-01-17 Thread Tom Lane
Fix miscalculation of itemsafter in array_set_slice(). If the slice to be assigned to was before the existing array lower bound (requiring at least one null element to spring into existence to fill the gap), the code miscalculated how many entries needed to be copied from the old array's null bitm

[COMMITTERS] pgsql: Fix miscalculation of itemsafter in array_set_slice().

2011-01-17 Thread Tom Lane
Fix miscalculation of itemsafter in array_set_slice(). If the slice to be assigned to was before the existing array lower bound (requiring at least one null element to spring into existence to fill the gap), the code miscalculated how many entries needed to be copied from the old array's null bitm

[COMMITTERS] pgsql: Avoid detoast in texteq/textne/byteaeq/byteane for unequal-lengt

2011-01-18 Thread Tom Lane
Avoid detoast in texteq/textne/byteaeq/byteane for unequal-length strings. We can get the length of a compressed or out-of-line datum without actually detoasting it. If the lengths of two strings are unequal, we can then conclude they are unequal without detoasting. That saves considerable work

[COMMITTERS] pgsql: Show correct datatype for pg_class.relpersistence, plus a typo f

2011-01-19 Thread Tom Lane
Show correct datatype for pg_class.relpersistence, plus a typo fix. Thom Brown Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=357faea82e93712937cd109b48ce006789ec7a8f Modified Files -- doc/src/sgml/catalogs.sgml |2

[COMMITTERS] pgsql: Fix pg_restore to do the right thing when escaping large objects

2011-01-21 Thread Tom Lane
Fix pg_restore to do the right thing when escaping large objects. Specifically, this makes the workflow pg_dump -Fc -> pg_restore -> file produce correct output for BLOBs when the source database has standard_conforming_strings turned on. It was already okay when that was off, or if pg_restore wa

[COMMITTERS] pgsql: Fix pg_restore to do the right thing when escaping large objects

2011-01-21 Thread Tom Lane
Fix pg_restore to do the right thing when escaping large objects. Specifically, this makes the workflow pg_dump -Fc -> pg_restore -> file produce correct output for BLOBs when the source database has standard_conforming_strings turned on. It was already okay when that was off, or if pg_restore wa

[COMMITTERS] pgsql: Fix pg_restore to do the right thing when escaping large objects

2011-01-21 Thread Tom Lane
Fix pg_restore to do the right thing when escaping large objects. Specifically, this makes the workflow pg_dump -Fc -> pg_restore -> file produce correct output for BLOBs when the source database has standard_conforming_strings turned on. It was already okay when that was off, or if pg_restore wa

[COMMITTERS] pgsql: Fix broken markup, also minor copy-editing.

2011-01-21 Thread Tom Lane
Fix broken markup, also minor copy-editing. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=0cf3db2175ec770097b9c44d9a8e1e8c281ee5a6 Modified Files -- doc/src/sgml/pgtestfsync.sgml | 24 ++-- 1 files changed,

[COMMITTERS] pgsql: Clean up pg_test_fsync commit.

2011-01-21 Thread Tom Lane
Clean up pg_test_fsync commit. Actually rename the program, rather than just claiming we did. Hook it into the build system. Get rid of useless dependency on libpq. Clean up #include list and messy whitespace. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.

[COMMITTERS] pgsql: More pg_test_fsync cleanup.

2011-01-21 Thread Tom Lane
More pg_test_fsync cleanup. Un-break Windows build (I hope) by making the HAVE_FSYNC_WRITETHROUGH code match the backend. Fix incorrect program help message. static-ize all functions. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=cb38ab6d

[COMMITTERS] pgsql: Suppress unused-variables warning when OPEN_SYNC_FLAG isn't defi

2011-01-22 Thread Tom Lane
Suppress unused-variables warning when OPEN_SYNC_FLAG isn't defined. Per buildfarm. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=3ae28ce8c437811bba47c09d1212c2d3c41cb7ff Modified Files -- contrib/pg_test_fsync/pg_test_fsync.c

[COMMITTERS] pgsql: More pg_test_fsync fixups.

2011-01-22 Thread Tom Lane
More pg_test_fsync fixups. Reduce #includes to minimum actually needed; in particular include postgres_fe.h not postgres.h, so as to stop build failures on some platforms. Use get_progname() instead of hardwired program name; improve error checking for command line syntax; bring error messages in

Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state

2011-01-22 Thread Tom Lane
Peter Eisentraut writes: > Get rid of the global variable holding the error state The buildfarm doesn't like this patch one bit. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscripti

[COMMITTERS] pgsql: Suppress possibly-uninitialized-variable warnings from gcc 4.5.

2011-01-22 Thread Tom Lane
Suppress possibly-uninitialized-variable warnings from gcc 4.5. It appears that gcc 4.5 can issue such warnings for whole structs, not just scalar variables as in the past. Refactor some pg_dump code slightly so that the OutputContext local variables are always initialized, even if they won't be

[COMMITTERS] pgsql: Suppress "control reaches end of non-void function" warning from

2011-01-22 Thread Tom Lane
Suppress "control reaches end of non-void function" warning from gcc 4.5. Not sure why I'm seeing this on Fedora 14 and not earlier versions. Seems like a regression that gcc no longer knows that DIE() doesn't return. Still, adding a dummy return is harmless enough. Branch -- master Details

[COMMITTERS] pgsql: Allow the wal_buffers setting to be auto-tuned to a reasonable v

2011-01-22 Thread Tom Lane
Allow the wal_buffers setting to be auto-tuned to a reasonable value. If wal_buffers is initially set to -1 (which is now the default), it's replaced by 1/32nd of shared_buffers, with a minimum of 8 (the old default) and a maximum of the XLOG segment size. The allowed range for manual settings is

[COMMITTERS] pgsql: Quick hack to un-break plpython regression tests.

2011-01-22 Thread Tom Lane
Quick hack to un-break plpython regression tests. It's not clear to me what should happen to the other plpython_unicode variant expected files, but this patch gets things passing on my own machines and at least some of the buildfarm. Branch -- master Details --- http://git.postgresql.org

Re: [COMMITTERS] pgsql: Add pg_basebackup tool for streaming base backups

2011-01-23 Thread Tom Lane
Magnus Hagander writes: > Add pg_basebackup tool for streaming base backups The Windows buildfarm members would like this patch better if you used pg_strcasecmp not strcasecmp. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.

Re: [COMMITTERS] pgsql: Add pg_basebackup tool for streaming base backups

2011-01-23 Thread Tom Lane
Magnus Hagander writes: > On Sun, Jan 23, 2011 at 18:14, Tom Lane wrote: >> The Windows buildfarm members would like this patch better if you used >> pg_strcasecmp not strcasecmp. > Yeah, I've applied a patch for that already. Ah, yes, see it no

[COMMITTERS] pgsql: Add .gitignore file to silence complaints about pg_basebackup.

2011-01-23 Thread Tom Lane
Add .gitignore file to silence complaints about pg_basebackup. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=10e99f15d423b1730929af1992593c6649952fd5 Modified Files -- src/bin/pg_basebackup/.gitignore |1 + 1 files changed, 1

[COMMITTERS] pgsql: Suppress uninitialized-variable warning.

2011-01-23 Thread Tom Lane
Suppress uninitialized-variable warning. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=b3cfcdaad27bea9bb86d6de6cbf8d184c16fbceb Modified Files -- src/bin/pg_basebackup/pg_basebackup.c |2 +- 1 files changed, 1 insertions(+),

[COMMITTERS] pgsql: Revert "Factor out functions responsible for caching I/O routine

2011-01-23 Thread Tom Lane
Revert "Factor out functions responsible for caching I/O routines". This reverts commit 740e54ca84c437fd67524f97a3ea9ddea752e208, which seems to have tickled an optimization bug in gcc 4.5.x, as reported upstream at https://bugzilla.redhat.com/show_bug.cgi?id=671899 Since this patch had no purpose

Re: [COMMITTERS] pgsql: Suppress uninitialized-variable warning.

2011-01-23 Thread Tom Lane
regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Suppress uninitialized-variable warning.

2011-01-23 Thread Tom Lane
Magnus Hagander writes: > On Sun, Jan 23, 2011 at 19:21, Tom Lane wrote: >> Magnus Hagander writes: >>> Which compiler did that come out of? I don't think I saw it on any of >>> the ones I tried.. >> gcc 4.4.5, standard on Fedora 13.  I'm surprised

[COMMITTERS] pgsql: Improve getObjectDescription's display of pg_amop and pg_amproc

2011-01-23 Thread Tom Lane
ke it clearer that it's a referenced object and not the amop or amproc item itself. Per extensive discussion of Andreas Karlsson's original patch. Andreas Karlsson, Tom Lane Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git

[COMMITTERS] pgsql: Fix another portability issue in pg_basebackup.

2011-01-23 Thread Tom Lane
Fix another portability issue in pg_basebackup. The target of sscanf with a %o format had better be of integer width, but "mode_t" conceivably isn't that. Another compiler warning seen only on some platforms; this one I think is potentially a real bug and not just a warning. Branch -- master

[COMMITTERS] pgsql: Implement ALTER TABLE ADD UNIQUE/PRIMARY KEY USING INDEX.

2011-01-25 Thread Tom Lane
that didn't have one before. Gurjeet Singh, reviewed by Steve Singer and Tom Lane Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=88452d5ba6b3e8ad49133ac1a660ce0725710f8c Modified Files -- doc/src/sgml/ref/alter_table.sgml

[COMMITTERS] pgsql: Replace pg_class.relhasexclusion with pg_index.indisexclusion.

2011-01-25 Thread Tom Lane
Replace pg_class.relhasexclusion with pg_index.indisexclusion. There isn't any need to track this state on a table-wide basis, and trying to do so introduces undesirable semantic fuzziness. Move the flag to pg_index, where it clearly describes just a single index and can be immutable after index

[COMMITTERS] pgsql: Remove old claim that ExclusiveLock is sometimes taken on system

2011-01-25 Thread Tom Lane
Remove old claim that ExclusiveLock is sometimes taken on system catalogs. We used to do that on pg_listener, but pg_listener is no more. Also add a bit more documentation for ShareRowExclusive mode. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commit

Re: [COMMITTERS] pgsql: Use XLOG_BLCKSZ in pg_test_fsync, rather than our own define, bu

2011-01-25 Thread Tom Lane
't you aware that XLOG_BLCKSZ is settable from a configure option? You just broke the ability to build the tree with a non-default configuration setting. If you aren't willing to deal with a variable value for the block size, please revert this patch. regards, to

Re: [COMMITTERS] pgsql: Use XLOG_BLCKSZ in pg_test_fsync, rather than our own define, bu

2011-01-25 Thread Tom Lane
Bruce Momjian writes: > Tom Lane wrote: >> If you aren't willing to deal with a variable value for the block size, >> please revert this patch. > The problem is that I have hard-coded 8k into various text strings and I > didn't want to make that variable. H

Re: [COMMITTERS] pgsql: Use XLOG_BLCKSZ in pg_test_fsync, rather than our own define, bu

2011-01-25 Thread Tom Lane
Bruce Momjian writes: > Sure I am willing to fix it. Should I have it always use the value of > XLOG_BLCKSZ for its tests, and adjust the output text accordingly? Makes sense to me. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-comm

[COMMITTERS] pgsql: Change inv_truncate() to not repeat its systable_getnext_ordered

2011-01-26 Thread Tom Lane
Change inv_truncate() to not repeat its systable_getnext_ordered() scan. In the case where the initial call of systable_getnext_ordered() returned NULL, this function would nonetheless call it again. That's undefined behavior that only by chance failed to not give visibly incorrect results. Put a

[COMMITTERS] pgsql: Improve grammar and spelling in durability discussion.

2011-01-27 Thread Tom Lane
Improve grammar and spelling in durability discussion. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=85f345bec2d7f2ccb67b98b06342c86372ecf3b1 Modified Files -- doc/src/sgml/perform.sgml | 11 ++- 1 files changed, 6 inse

[COMMITTERS] pgsql: Update release notes for releases 9.0.3, 8.4.7, 8.3.14, and 8.2.

2011-01-27 Thread Tom Lane
Update release notes for releases 9.0.3, 8.4.7, 8.3.14, and 8.2.20. Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=a84c4eee2fb16a6e896b6f37c08aae63e671b4c0 Modified Files -- doc/src/sgml/release-8.2.sgml | 119 +++

[COMMITTERS] pgsql: Update release notes for releases 9.0.3, 8.4.7, 8.3.14, and 8.2.

2011-01-27 Thread Tom Lane
Update release notes for releases 9.0.3, 8.4.7, 8.3.14, and 8.2.20. Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=dea0a74cb231fff77e8c4b982b42d7a672247eb2 Modified Files -- doc/src/sgml/release-8.2.sgml | 119 +++

[COMMITTERS] pgsql: Update release notes for releases 9.0.3, 8.4.7, 8.3.14, and 8.2.

2011-01-27 Thread Tom Lane
Update release notes for releases 9.0.3, 8.4.7, 8.3.14, and 8.2.20. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=af9e2ed29b51e08e5cc597ddc8d58cde05d83212 Modified Files -- doc/src/sgml/release-8.2.sgml | 119 +++

[COMMITTERS] pgsql: Update release notes for releases 9.0.3, 8.4.7, 8.3.14, and 8.2.

2011-01-27 Thread Tom Lane
Update release notes for releases 9.0.3, 8.4.7, 8.3.14, and 8.2.20. Branch -- REL8_2_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=85dfc488bedb53e40cf2e871182aa5fb9689bee7 Modified Files -- doc/src/sgml/release-8.2.sgml | 119 +++

[COMMITTERS] pgsql: Update release notes for releases 9.0.3, 8.4.7, 8.3.14, and 8.2.

2011-01-27 Thread Tom Lane
Update release notes for releases 9.0.3, 8.4.7, 8.3.14, and 8.2.20. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=29d442199ac978b2272d1d96648585943f499fe6 Modified Files -- doc/src/sgml/release-8.2.sgml | 119 ++

[COMMITTERS] pgsql: Don't include unnecessarily.

2011-01-27 Thread Tom Lane
Don't include unnecessarily. We only need that header when compiling with icc, since the gcc variant of ia64_get_bsp() uses in-line assembly code. Per report from Frank Brendel, the header doesn't exist on all IA64 platforms; so don't include it unless we need it. Branch -- REL9_0_STABLE D

[COMMITTERS] pgsql: Don't include unnecessarily.

2011-01-27 Thread Tom Lane
Don't include unnecessarily. We only need that header when compiling with icc, since the gcc variant of ia64_get_bsp() uses in-line assembly code. Per report from Frank Brendel, the header doesn't exist on all IA64 platforms; so don't include it unless we need it. Branch -- REL8_4_STABLE D

[COMMITTERS] pgsql: Don't include unnecessarily.

2011-01-27 Thread Tom Lane
Don't include unnecessarily. We only need that header when compiling with icc, since the gcc variant of ia64_get_bsp() uses in-line assembly code. Per report from Frank Brendel, the header doesn't exist on all IA64 platforms; so don't include it unless we need it. Branch -- REL8_2_STABLE D

[COMMITTERS] pgsql: Don't include unnecessarily.

2011-01-27 Thread Tom Lane
Don't include unnecessarily. We only need that header when compiling with icc, since the gcc variant of ia64_get_bsp() uses in-line assembly code. Per report from Frank Brendel, the header doesn't exist on all IA64 platforms; so don't include it unless we need it. Branch -- master Details

[COMMITTERS] pgsql: Don't include unnecessarily.

2011-01-27 Thread Tom Lane
Don't include unnecessarily. We only need that header when compiling with icc, since the gcc variant of ia64_get_bsp() uses in-line assembly code. Per report from Frank Brendel, the header doesn't exist on all IA64 platforms; so don't include it unless we need it. Branch -- REL8_3_STABLE D

[COMMITTERS] pgsql: Rephrase pg_conversion description to avoid splitting link acros

2011-01-27 Thread Tom Lane
Rephrase pg_conversion description to avoid splitting link across page. The link to the CREATE CONVERSION manual page was split across a page boundary in the PDF output, leading to "\pdfendlink ended up in different nesting level than \pdfstartlink" error while building PDFs. It wouldn't be worth

[COMMITTERS] pgsql: Update release notes.

2011-01-28 Thread Tom Lane
Update release notes. Security: CVE-2010-4015 Branch -- REL8_2_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=f6ba576114171c36fbaad06640192c25a5f71229 Modified Files -- doc/src/sgml/release-8.2.sgml | 13 + 1 files changed, 1

[COMMITTERS] pgsql: Update release notes.

2011-01-28 Thread Tom Lane
Update release notes. Security: CVE-2010-4015 Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=b29720f99744cb0cb1ca649f3e22ede979554957 Modified Files -- doc/src/sgml/release-8.2.sgml | 13 + doc/src/sgml/relea

[COMMITTERS] pgsql: Update release notes.

2011-01-28 Thread Tom Lane
Update release notes. Security: CVE-2010-4015 Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=aefb8d9198926e9f7717d6420b802ae4b6352293 Modified Files -- doc/src/sgml/release-8.2.sgml | 13 + doc/src/sgml/relea

[COMMITTERS] pgsql: Update release notes.

2011-01-28 Thread Tom Lane
Update release notes. Security: CVE-2010-4015 Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=da61f86011e8af49207a23156d10b323416c7f7e Modified Files -- doc/src/sgml/release-8.2.sgml | 13 + doc/src/sgml/relea

[COMMITTERS] pgsql: Copy-edit a paragraph in the contrib/seg documentation.

2011-01-28 Thread Tom Lane
Copy-edit a paragraph in the contrib/seg documentation. Although this improves the style, an ulterior motive is to keep the two table links from breaking across lines in PDF output, per complaint from Josh Kupershmidt. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postg

[COMMITTERS] pgsql: Make installation.sgml build standalone again.

2011-01-29 Thread Tom Lane
Make installation.sgml build standalone again. We must not try to link to sections that aren't part of the standalone "make INSTALL" build. Corrects build failure introduced in commit 159e3d86292cfec2a2828f9f69ac7a6cb1be242d. Branch -- master Details --- http://git.postgresql.org/gitweb

[COMMITTERS] pgsql: Make reduce_outer_joins() smarter about semijoins.

2011-01-30 Thread Tom Lane
Make reduce_outer_joins() smarter about semijoins. reduce_outer_joins() mistakenly treated a semijoin like a left join for purposes of deciding whether not-null constraints created by the join's quals could be passed down into the join's left-hand side (possibly resulting in outer-join simplificat

[COMMITTERS] pgsql: Make reduce_outer_joins() smarter about semijoins.

2011-01-30 Thread Tom Lane
Make reduce_outer_joins() smarter about semijoins. reduce_outer_joins() mistakenly treated a semijoin like a left join for purposes of deciding whether not-null constraints created by the join's quals could be passed down into the join's left-hand side (possibly resulting in outer-join simplificat

[COMMITTERS] pgsql: Make reduce_outer_joins() smarter about semijoins.

2011-01-30 Thread Tom Lane
Make reduce_outer_joins() smarter about semijoins. reduce_outer_joins() mistakenly treated a semijoin like a left join for purposes of deciding whether not-null constraints created by the join's quals could be passed down into the join's left-hand side (possibly resulting in outer-join simplificat

Re: [COMMITTERS] pgsql: Enable building with the Mingw64 compiler.

2011-01-30 Thread Tom Lane
Andrew Dunstan writes: > Enable building with the Mingw64 compiler. > +#if defined(_WIN32_WINNT) && _WIN32_WINNT < 0x0501 > +#undefine _WIN32_WINNT > +#endif Umm ... surely "#undefine" is a typo? regards, tom lane -- Sent via pgs

[COMMITTERS] pgsql: Support LIKE and ILIKE index searches via contrib/pg_trgm indexe

2011-01-31 Thread Tom Lane
Support LIKE and ILIKE index searches via contrib/pg_trgm indexes. Unlike Btree-based LIKE optimization, this works for non-left-anchored search patterns. The effectiveness of the search depends on how many trigrams can be extracted from the pattern. (The worst case, with no trigrams, degrades t

[COMMITTERS] pgsql: Prevent buffer overrun while parsing an integer in a "query_int"

2011-02-01 Thread Tom Lane
Prevent buffer overrun while parsing an integer in a "query_int" value. contrib/intarray's gettoken() uses a fixed-size buffer to collect an integer's digits, and did not guard against overrunning the buffer. This is at least a backend crash risk, and in principle might allow arbitrary code execut

[COMMITTERS] pgsql: Prevent buffer overrun while parsing an integer in a "query_int"

2011-02-01 Thread Tom Lane
Prevent buffer overrun while parsing an integer in a "query_int" value. contrib/intarray's gettoken() uses a fixed-size buffer to collect an integer's digits, and did not guard against overrunning the buffer. This is at least a backend crash risk, and in principle might allow arbitrary code execut

[COMMITTERS] pgsql: Prevent buffer overrun while parsing an integer in a "query_int"

2011-02-01 Thread Tom Lane
Prevent buffer overrun while parsing an integer in a "query_int" value. contrib/intarray's gettoken() uses a fixed-size buffer to collect an integer's digits, and did not guard against overrunning the buffer. This is at least a backend crash risk, and in principle might allow arbitrary code execut

[COMMITTERS] pgsql: Prevent buffer overrun while parsing an integer in a "query_int"

2011-02-01 Thread Tom Lane
Prevent buffer overrun while parsing an integer in a "query_int" value. contrib/intarray's gettoken() uses a fixed-size buffer to collect an integer's digits, and did not guard against overrunning the buffer. This is at least a backend crash risk, and in principle might allow arbitrary code execut

[COMMITTERS] pgsql: Update release notes.

2011-02-01 Thread Tom Lane
Update release notes. Security: CVE-2010-4015 Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=43054624979de3205fbc432f15defd4b9d5922e9 Modified Files -- doc/src/sgml/release-8.2.sgml | 13 + doc/src/sgml/release-8.3.

[COMMITTERS] pgsql: Prevent buffer overrun while parsing an integer in a "query_int"

2011-02-01 Thread Tom Lane
Prevent buffer overrun while parsing an integer in a "query_int" value. contrib/intarray's gettoken() uses a fixed-size buffer to collect an integer's digits, and did not guard against overrunning the buffer. This is at least a backend crash risk, and in principle might allow arbitrary code execut

[COMMITTERS] pgsql: Clean up missed change to plpython expected files.

2011-02-02 Thread Tom Lane
Clean up missed change to plpython expected files. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=907855ac759a221f95b502cd7cbf2ec851fe9523 Modified Files -- src/pl/plpython/expected/plpython_unicode_3.out |2 -- 1 files change

Re: [COMMITTERS] pgsql: Wrap PL/Python SPI calls into subtransactions

2011-02-02 Thread Tom Lane
so I pushed a fix. Not all the red is Peter's fault though :-( regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Repair multiple breakage in Windows-specific code for appending

2011-02-02 Thread Tom Lane
Repair multiple breakage in Windows-specific code for appending '.exe'. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=cd7d748d51df3c5dedcc49a3603e6fa9c050f237 Modified Files -- contrib/pg_upgrade/exec.c | 12 +++- 1 fil

Re: [COMMITTERS] pgsql: remove tags.

2011-02-06 Thread Tom Lane
Bruce Momjian writes: > Bruce Momjian wrote: >> remove tags. > Sorry, vague commit message (I forgot squash). > Can I will use git ammend to improve this message? How about git revert, instead? It's not apparent to me that these changes were improvements.

[COMMITTERS] pgsql: Fix merge conflict.

2011-02-08 Thread Tom Lane
Fix merge conflict. Branch -- master Details --- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=0bc0bd07d41169d6de513967615ad9cb3d0f322e Modified Files -- src/test/regress/expected/sanity_check.out |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[COMMITTERS] pgsql: Core support for "extensions", which are packages of SQL objects

2011-02-08 Thread Tom Lane
he contrib modules depend on this feature. In passing, fix a disturbingly large amount of breakage in AlterObjectNamespace() and callers. Dimitri Fontaine, reviewed by Anssi Kääriäinen, Itagaki Takahiro, Tom Lane, and numerous others Branch -- master Details --- http://git.postgresql.or

[COMMITTERS] pgsql: Suppress some compiler warnings in recent commits.

2011-02-08 Thread Tom Lane
Suppress some compiler warnings in recent commits. Older versions of gcc tend to throw "variable might be clobbered by `longjmp' or `vfork'" warnings whenever a variable is assigned in more than one place and then used after the end of a PG_TRY block. That's reasonably easy to work around in exec

[COMMITTERS] pgsql: Implement "ALTER EXTENSION ADD object".

2011-02-09 Thread Tom Lane
Implement "ALTER EXTENSION ADD object". This is an essential component of making the extension feature usable; first because it's needed in the process of converting an existing installation containing "loose" objects of an old contrib module into the extension-based world, and second because we'l

[COMMITTERS] pgsql: Rethink order of operations for dumping extension member objects

2011-02-09 Thread Tom Lane
Rethink order of operations for dumping extension member objects. My original idea of doing extension member identification during getDependencies() didn't work correctly: we have to mark member tables as not-to-be-dumped rather earlier than that, else their subsidiary objects like indexes get dum

[COMMITTERS] pgsql: Fix pg_upgrade to handle extensions.

2011-02-09 Thread Tom Lane
Fix pg_upgrade to handle extensions. This follows my proposal of yesterday, namely that we try to recreate the previous state of the extension exactly, instead of allowing CREATE EXTENSION to run a SQL script that might create some entirely-incompatible on-disk state. In --binary-upgrade mode, pg

[COMMITTERS] pgsql: Fix improper matching of resjunk column names for FOR UPDATE in

2011-02-09 Thread Tom Lane
Fix improper matching of resjunk column names for FOR UPDATE in subselect. Flattening of subquery range tables during setrefs.c could lead to the rangetable indexes in PlanRowMark nodes not matching up with the column names previously assigned to the corresponding resjunk ctid (resp. tableoid or w

[COMMITTERS] pgsql: Fix improper matching of resjunk column names for FOR UPDATE in

2011-02-09 Thread Tom Lane
Fix improper matching of resjunk column names for FOR UPDATE in subselect. Flattening of subquery range tables during setrefs.c could lead to the rangetable indexes in PlanRowMark nodes not matching up with the column names previously assigned to the corresponding resjunk ctid (resp. tableoid or w

[COMMITTERS] pgsql: Extend "ALTER EXTENSION ADD object" to permit "DROP object" as w

2011-02-10 Thread Tom Lane
Extend "ALTER EXTENSION ADD object" to permit "DROP object" as well. Per discussion, this is something we should have sooner rather than later, and it doesn't take much additional code to support it. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/01467d3e4f51fe304c0

[COMMITTERS] pgsql: Add support for multiple versions of an extension and ALTER EXTE

2011-02-11 Thread Tom Lane
with it. This is still just core code. I'll start converting contrib modules shortly. Dimitri Fontaine and Tom Lane Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1214749901fc3c66732cfd9f276b989635c01360 Modified Files -- contri

[COMMITTERS] pgsql: Clean up installation directory choices for extensions.

2011-02-11 Thread Tom Lane
Clean up installation directory choices for extensions. Arrange for the control files to be in $SHAREDIR/extension not $SHAREDIR/contrib, since we're generally trying to deprecate the term "contrib" and this is a once-in-many-moons opportunity to get rid of it in install paths. Fix PGXS to instal

Re: [COMMITTERS] pgsql: DDL support for collations

2011-02-12 Thread Tom Lane
mly-chosen existing type. The effect of what you've done is that collations and extensions will be intermixed in the dump output, which is ugly. Give collations their own place in the sort order and renumber the existing entries as necessary to support that. regards,

Re: [COMMITTERS] pgsql: Properly handle Win32 paths of 'E:abc', which can be either abso

2011-02-12 Thread Tom Lane
ew code is more robust. Surely this test is backwards? +bool +path_is_relative_and_below_cwd(const char *path) +{ + if (!is_absolute_path(path)) + return false; regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make change

[COMMITTERS] pgsql: Refactor ALTER EXTENSION UPDATE to have cleaner multi-step seman

2011-02-12 Thread Tom Lane
Refactor ALTER EXTENSION UPDATE to have cleaner multi-step semantics. This change causes a multi-step update sequence to behave exactly as if the updates had been commanded one at a time, including updating the "requires" dependencies afresh at each step. The initial implementation took the short

[COMMITTERS] pgsql: Change the naming convention for extension files to use double d

2011-02-13 Thread Tom Lane
Change the naming convention for extension files to use double dashes. This allows us to have an unambiguous rule for deconstructing the names of script files and secondary control files, without having to forbid extension and version names from containing any dashes. We do have to forbid them fr

[COMMITTERS] pgsql: Support replacing MODULE_PATHNAME during extension script file e

2011-02-13 Thread Tom Lane
Support replacing MODULE_PATHNAME during extension script file execution. This avoids the need to find a way to make PGXS' .sql.in-to-.sql rule insert the right thing. We'll just deprecate use of that hack for extensions. Branch -- master Details --- http://git.postgresql.org/pg/commitd

[COMMITTERS] pgsql: Convert contrib modules to use the extension facility.

2011-02-13 Thread Tom Lane
use it seems to require a very nonstandard installation process. Dimitri Fontaine and Tom Lane Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/629b3af27d5c2bc9d6e16b22b943ad651d4ecb56 Modified Files -- contrib/adminpack/.gitignore |

[COMMITTERS] pgsql: Avoid use of CREATE OR REPLACE FUNCTION in extension installatio

2011-02-13 Thread Tom Lane
Avoid use of CREATE OR REPLACE FUNCTION in extension installation files. It was never terribly consistent to use OR REPLACE (because of the lack of comparable functionality for data types, operators, etc), and experimentation shows that it's now positively pernicious in the extension world. We re

[COMMITTERS] pgsql: Assorted fixups for "unpackaged" conversion scripts.

2011-02-13 Thread Tom Lane
Assorted fixups for "unpackaged" conversion scripts. From first pass of testing. Notably, there seems to be no need for adminpack--unpackaged--1.0.sql because none of the objects that the old module creates would ever be dumped by pg_dump anyway (they are all in pg_catalog). Branch -- master

[COMMITTERS] pgsql: More fixups for "unpackaged" conversion scripts.

2011-02-13 Thread Tom Lane
More fixups for "unpackaged" conversion scripts. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/de06cfe834dfff283deddfe1eb2945ba8a4fde2a Modified Files -- contrib/sslinfo/sslinfo--unpackaged--1.0.sql | 12 ++-- contrib/xml2/xml2--unpackaged--1.0

[COMMITTERS] pgsql: Remove no-longer-needed special case hacks in MSVC build scripts

2011-02-13 Thread Tom Lane
Remove no-longer-needed special case hacks in MSVC build scripts. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/2ee69ff65de6e8626784d4a263953158ef480ab4 Modified Files -- src/tools/msvc/Install.pm |3 --- src/tools/msvc/Mkvcbuild.pm |5 - 2

[COMMITTERS] pgsql: Fix obsolete references to old-style contrib installation method

2011-02-13 Thread Tom Lane
Fix obsolete references to old-style contrib installation methods. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f1fb4b0e63a677cdc86de667c75142b88a4edb65 Modified Files -- doc/src/sgml/contrib-spi.sgml | 15 +++ doc/src/sgml/contrib.sgml

  1   2   3   4   5   6   7   8   9   10   >