[COMMITTERS] pgsql: Improve eqjoinsel's ndistinct clamping to work for multiple leve

2011-08-31 Thread Tom Lane
Improve eqjoinsel's ndistinct clamping to work for multiple levels of join. This patch fixes an oversight in my commit 7f3eba30c9d622d1981b1368f2d79ba0999cdff2 of 2008-10-23. That patch accounted for baserel restriction clauses that reduced the number of rows coming out of a table (and hence the

[COMMITTERS] pgsql: Improve eqjoinsel's ndistinct clamping to work for multiple leve

2011-08-31 Thread Tom Lane
Improve eqjoinsel's ndistinct clamping to work for multiple levels of join. This patch fixes an oversight in my commit 7f3eba30c9d622d1981b1368f2d79ba0999cdff2 of 2008-10-23. That patch accounted for baserel restriction clauses that reduced the number of rows coming out of a table (and hence the

Re: [COMMITTERS] pgsql: Allow more include files to be compiled in their own by adding m

2011-08-31 Thread Tom Lane
acro provided by the file must be expandable with no further includes". In the end, the point of what you are doing is to ensure that header files can be included in any order. It is not to ensure some sort of unclearly-defined closure rule about how many headers need be included to make use of

[COMMITTERS] pgsql: Further repair of eqjoinsel ndistinct-clamping logic.

2011-08-31 Thread Tom Lane
Further repair of eqjoinsel ndistinct-clamping logic. Examination of examples provided by Mark Kirkwood and others has convinced me that actually commit 7f3eba30c9d622d1981b1368f2d79ba0999cdff2 was quite a few bricks shy of a load. The useful part of that patch was clamping ndistinct for the inne

[COMMITTERS] pgsql: Further repair of eqjoinsel ndistinct-clamping logic.

2011-08-31 Thread Tom Lane
Further repair of eqjoinsel ndistinct-clamping logic. Examination of examples provided by Mark Kirkwood and others has convinced me that actually commit 7f3eba30c9d622d1981b1368f2d79ba0999cdff2 was quite a few bricks shy of a load. The useful part of that patch was clamping ndistinct for the inne

[COMMITTERS] pgsql: Further repair of eqjoinsel ndistinct-clamping logic.

2011-08-31 Thread Tom Lane
Further repair of eqjoinsel ndistinct-clamping logic. Examination of examples provided by Mark Kirkwood and others has convinced me that actually commit 7f3eba30c9d622d1981b1368f2d79ba0999cdff2 was quite a few bricks shy of a load. The useful part of that patch was clamping ndistinct for the inne

[COMMITTERS] pgsql: Further repair of eqjoinsel ndistinct-clamping logic.

2011-08-31 Thread Tom Lane
Further repair of eqjoinsel ndistinct-clamping logic. Examination of examples provided by Mark Kirkwood and others has convinced me that actually commit 7f3eba30c9d622d1981b1368f2d79ba0999cdff2 was quite a few bricks shy of a load. The useful part of that patch was clamping ndistinct for the inne

Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge

2011-09-01 Thread Tom Lane
Bruce Momjian writes: > Remove "fmgr.h" include in cube contrib --- caused crash on a Gentoo > builfarm member. mongoose is still crashing, so it must have been some other aspect of commit 4bd7333 that caused this. regards, tom lane -- Sent via pgsql-co

[COMMITTERS] pgsql: Put back improperly removed #include.

2011-09-01 Thread Tom Lane
Put back improperly removed #include. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e5b012b788800470f3b670e013e9e52b615a018c Modified Files -- src/backend/utils/adt/inet_net_pton.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- Sent via

Re: [COMMITTERS] pgsql: libpq compiles various pgport files like ecpg does, and needs si

2011-09-01 Thread Tom Lane
Heikki Linnakangas writes: > libpq compiles various pgport files like ecpg does, and needs similar Makefile > changes for the win32 setlocale() wrapper I put into ecpg, to make it compile > on MinGW. The comma added in OBJS macro looks wrong. regards, tom lane

Re: [COMMITTERS] pgsql: In ecpglib restore LC_NUMERIC in case of an error.

2011-09-01 Thread Tom Lane
Michael Meskes writes: > In ecpglib restore LC_NUMERIC in case of an error. The 8.3 version of this patch doesn't compile, according to the buildfarm. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes

Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge

2011-09-02 Thread Tom Lane
ne of cube_f8_f8 looks in both broken and non-broken cases? What I see on a Fedora box is size = __builtin_offsetof (NDBOX, x[0]) +sizeof(double) * 2; but I'm thinking you might be getting something different. regards, tom lane -- Sent via pgsq

Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge

2011-09-02 Thread Tom Lane
Bruce Momjian writes: > Tom Lane wrote: >> Alvaro Herrera writes: >>> instead. Don't use 'offsetof (struct s, d[0])', as this doesn't work with >>> MSVC and with C++ compilers. */ >> D'oh ... I bet that last sentence is pointing us at

[COMMITTERS] pgsql: Teach ANALYZE to clear pg_class.relhassubclass when appropriate.

2011-09-02 Thread Tom Lane
Teach ANALYZE to clear pg_class.relhassubclass when appropriate. In the past, relhassubclass always remained true if a relation had ever had child relations, even if the last subclass was long gone. While this had only marginal performance implications in most cases, it was annoying, and I'm now

Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge

2011-09-03 Thread Tom Lane
obviously affect CurrentMemoryContext. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Rearrange planner to save the whole PlannerInfo (subroot) for a

2011-09-03 Thread Tom Lane
Rearrange planner to save the whole PlannerInfo (subroot) for a subquery. Formerly, set_subquery_pathlist and other creators of plans for subqueries saved only the rangetable and rowMarks lists from the lower-level PlannerInfo. But there's no reason not to remember the whole PlannerInfo, and inde

[COMMITTERS] pgsql: Fix typo in pg_srand48 (srand48 in older branches).

2011-09-03 Thread Tom Lane
Fix typo in pg_srand48 (srand48 in older branches). ">" should be ">>". This typo results in failure to use all of the bits of the provided seed. This might rise to the level of a security bug if we were relying on srand48 for any security-critical purposes, but we are not --- in fact, it's not

[COMMITTERS] pgsql: Fix typo in pg_srand48 (srand48 in older branches).

2011-09-03 Thread Tom Lane
Fix typo in pg_srand48 (srand48 in older branches). ">" should be ">>". This typo results in failure to use all of the bits of the provided seed. This might rise to the level of a security bug if we were relying on srand48 for any security-critical purposes, but we are not --- in fact, it's not

[COMMITTERS] pgsql: Fix typo in pg_srand48 (srand48 in older branches).

2011-09-03 Thread Tom Lane
Fix typo in pg_srand48 (srand48 in older branches). ">" should be ">>". This typo results in failure to use all of the bits of the provided seed. This might rise to the level of a security bug if we were relying on srand48 for any security-critical purposes, but we are not --- in fact, it's not

[COMMITTERS] pgsql: Fix typo in pg_srand48 (srand48 in older branches).

2011-09-03 Thread Tom Lane
Fix typo in pg_srand48 (srand48 in older branches). ">" should be ">>". This typo results in failure to use all of the bits of the provided seed. This might rise to the level of a security bug if we were relying on srand48 for any security-critical purposes, but we are not --- in fact, it's not

[COMMITTERS] pgsql: Fix typo in pg_srand48 (srand48 in older branches).

2011-09-03 Thread Tom Lane
Fix typo in pg_srand48 (srand48 in older branches). ">" should be ">>". This typo results in failure to use all of the bits of the provided seed. This might rise to the level of a security bug if we were relying on srand48 for any security-critical purposes, but we are not --- in fact, it's not

[COMMITTERS] pgsql: Fix typo in pg_srand48 (srand48 in older branches).

2011-09-03 Thread Tom Lane
Fix typo in pg_srand48 (srand48 in older branches). ">" should be ">>". This typo results in failure to use all of the bits of the provided seed. This might rise to the level of a security bug if we were relying on srand48 for any security-critical purposes, but we are not --- in fact, it's not

[COMMITTERS] pgsql: Remove unnecessary and circular #include.

2011-09-03 Thread Tom Lane
Remove unnecessary and circular #include. storage/proc.h should not include replication/syncrep.h, especially not when the latter includes storage/proc.h; but in any case this was a pretty poor thing from a modular layering standpoint. Branch -- master Details --- http://git.postgresql.o

[COMMITTERS] pgsql: Clean up the #include mess a little.

2011-09-03 Thread Tom Lane
Clean up the #include mess a little. walsender.h should depend on xlog.h, not vice versa. (Actually, the inclusion was circular until a couple hours ago, which was even sillier; but Bruce broke it in the expedient rather than logically correct direction.) Because of that poor decision, plus blin

Re: [COMMITTERS] pgsql: Clean up the #include mess a little.

2011-09-03 Thread Tom Lane
alsender.h in xlog.h was what broke it ... but why? As I said before, I don't like black magic. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Change get_variable_numdistinct's API to flag default estimates

2011-09-04 Thread Tom Lane
Change get_variable_numdistinct's API to flag default estimates explicitly. Formerly, callers tested for DEFAULT_NUM_DISTINCT, which had the problem that a perfectly solid estimate might be mistaken for a content-free default. Branch -- master Details --- http://git.postgresql.org/pg/com

[COMMITTERS] pgsql: Can't print PlannerGlobal's subroots list in outfuncs.

2011-09-04 Thread Tom Lane
Can't print PlannerGlobal's subroots list in outfuncs. Since the subroots will surely link back to the same glob struct, this necessarily leads to infinite recursion. Doh. Found while trying to debug some other code. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/

[COMMITTERS] pgsql: Dig down into sub-selects to look for column statistics.

2011-09-04 Thread Tom Lane
Dig down into sub-selects to look for column statistics. If a sub-select's output column is a simple Var, recursively look for statistics applying to that Var, and use them if available. The need for this was foreseen ages ago, but we didn't have enough infrastructure to do it with reasonable spe

[COMMITTERS] pgsql: Fix #include problems in 9.1 branch.

2011-09-04 Thread Tom Lane
Fix #include problems in 9.1 branch. Remove unnecessary and circular #include of syncrep.h from proc.h. Add htup.h to tablecmds.h so it will compile without prerequisites. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/1ae019f04b95771293f9a649c298aaeb0d3155a2

[COMMITTERS] pgsql: Guard against using plperl's Makefile without specifying --with-

2011-09-04 Thread Tom Lane
Guard against using plperl's Makefile without specifying --with-perl. The $(PERL) macro will be set by configure if it finds perl at all, but $(perl_privlibexp) isn't configured unless you said --with-perl. This results in confusing error messages if someone cd's into src/pl/plperl and tries to bu

[COMMITTERS] pgsql: Guard against using plperl's Makefile without specifying --with-

2011-09-04 Thread Tom Lane
Guard against using plperl's Makefile without specifying --with-perl. The $(PERL) macro will be set by configure if it finds perl at all, but $(perl_privlibexp) isn't configured unless you said --with-perl. This results in confusing error messages if someone cd's into src/pl/plperl and tries to bu

[COMMITTERS] pgsql: Guard against using plperl's Makefile without specifying --with-

2011-09-04 Thread Tom Lane
Guard against using plperl's Makefile without specifying --with-perl. The $(PERL) macro will be set by configure if it finds perl at all, but $(perl_privlibexp) isn't configured unless you said --with-perl. This results in confusing error messages if someone cd's into src/pl/plperl and tries to bu

[COMMITTERS] pgsql: Update time zone data files to tzdata release 2011i.

2011-09-05 Thread Tom Lane
Update time zone data files to tzdata release 2011i. DST law changes in Canada, Egypt, Russia, Samoa, South Sudan. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/e6d4288c514bc7bab1d48bc5a733606d1f57dba9 Modified Files -- src/timezone/data/africa

[COMMITTERS] pgsql: Update time zone data files to tzdata release 2011i.

2011-09-05 Thread Tom Lane
Update time zone data files to tzdata release 2011i. DST law changes in Canada, Egypt, Russia, Samoa, South Sudan. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0b88af150e3a26f9e41da89da0c507eac550e46b Modified Files -- src/timezone/data/africa |

[COMMITTERS] pgsql: Update time zone data files to tzdata release 2011i.

2011-09-05 Thread Tom Lane
Update time zone data files to tzdata release 2011i. DST law changes in Canada, Egypt, Russia, Samoa, South Sudan. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/33c371b4f5ac3b3975e57beaf7481f736e53c031 Modified Files -- src/timezone/data/africa

[COMMITTERS] pgsql: Update time zone data files to tzdata release 2011i.

2011-09-05 Thread Tom Lane
Update time zone data files to tzdata release 2011i. DST law changes in Canada, Egypt, Russia, Samoa, South Sudan. Branch -- REL8_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/4816dbdb2d9af0ebdd1cacbd5cca5d7d7b29b105 Modified Files -- src/timezone/data/africa

[COMMITTERS] pgsql: Update time zone data files to tzdata release 2011i.

2011-09-05 Thread Tom Lane
Update time zone data files to tzdata release 2011i. DST law changes in Canada, Egypt, Russia, Samoa, South Sudan. Branch -- REL8_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/c2042d04ac3aeacfd83d60222cdfc47bbb58b4b6 Modified Files -- src/timezone/data/africa

[COMMITTERS] pgsql: Update time zone data files to tzdata release 2011i.

2011-09-05 Thread Tom Lane
Update time zone data files to tzdata release 2011i. DST law changes in Canada, Egypt, Russia, Samoa, South Sudan. Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/67efa666a5b29ecd19e0f3191a1433fbd5b75b8f Modified Files -- src/timezone/data/africa

[COMMITTERS] pgsql: Update type-conversion documentation for long-ago changes.

2011-09-06 Thread Tom Lane
Update type-conversion documentation for long-ago changes. This example wasn't updated when we changed the behavior of bpcharlen() in 8.0, nor when we changed the number of parameters taken by the bpchar() cast function in 7.3. Per report from lsliang. Branch -- REL8_4_STABLE Details --

[COMMITTERS] pgsql: Update type-conversion documentation for long-ago changes.

2011-09-06 Thread Tom Lane
Update type-conversion documentation for long-ago changes. This example wasn't updated when we changed the behavior of bpcharlen() in 8.0, nor when we changed the number of parameters taken by the bpchar() cast function in 7.3. Per report from lsliang. Branch -- REL9_0_STABLE Details --

[COMMITTERS] pgsql: Update type-conversion documentation for long-ago changes.

2011-09-06 Thread Tom Lane
Update type-conversion documentation for long-ago changes. This example wasn't updated when we changed the behavior of bpcharlen() in 8.0, nor when we changed the number of parameters taken by the bpchar() cast function in 7.3. Per report from lsliang. Branch -- REL8_2_STABLE Details --

[COMMITTERS] pgsql: Update type-conversion documentation for long-ago changes.

2011-09-06 Thread Tom Lane
Update type-conversion documentation for long-ago changes. This example wasn't updated when we changed the behavior of bpcharlen() in 8.0, nor when we changed the number of parameters taken by the bpchar() cast function in 7.3. Per report from lsliang. Branch -- REL8_3_STABLE Details --

[COMMITTERS] pgsql: Update type-conversion documentation for long-ago changes.

2011-09-06 Thread Tom Lane
Update type-conversion documentation for long-ago changes. This example wasn't updated when we changed the behavior of bpcharlen() in 8.0, nor when we changed the number of parameters taken by the bpchar() cast function in 7.3. Per report from lsliang. Branch -- master Details --- http:

[COMMITTERS] pgsql: Update type-conversion documentation for long-ago changes.

2011-09-06 Thread Tom Lane
Update type-conversion documentation for long-ago changes. This example wasn't updated when we changed the behavior of bpcharlen() in 8.0, nor when we changed the number of parameters taken by the bpchar() cast function in 7.3. Per report from lsliang. Branch -- REL9_1_STABLE Details --

[COMMITTERS] pgsql: Add an "incompatibility" entry to 9.1 release notes about CREATE

2011-09-06 Thread Tom Lane
Add an "incompatibility" entry to 9.1 release notes about CREATE EXTENSION. We've now seen more than one gripe from somebody who didn't get the memo about how to install contrib modules in 9.1. Try to make it a little more prominent that you aren't supposed to call the scripts directly anymore.

[COMMITTERS] pgsql: Add an "incompatibility" entry to 9.1 release notes about CREATE

2011-09-06 Thread Tom Lane
Add an "incompatibility" entry to 9.1 release notes about CREATE EXTENSION. We've now seen more than one gripe from somebody who didn't get the memo about how to install contrib modules in 9.1. Try to make it a little more prominent that you aren't supposed to call the scripts directly anymore.

[COMMITTERS] pgsql: Avoid possibly accessing off the end of memory in examine_attrib

2011-09-06 Thread Tom Lane
Avoid possibly accessing off the end of memory in examine_attribute(). Since the last couple of columns of pg_type are often NULL, sizeof(FormData_pg_type) can be an overestimate of the actual size of the tuple data part. Therefore memcpy'ing that much out of the catalog cache, as analyze.c was d

[COMMITTERS] pgsql: Avoid possibly accessing off the end of memory in examine_attrib

2011-09-06 Thread Tom Lane
Avoid possibly accessing off the end of memory in examine_attribute(). Since the last couple of columns of pg_type are often NULL, sizeof(FormData_pg_type) can be an overestimate of the actual size of the tuple data part. Therefore memcpy'ing that much out of the catalog cache, as analyze.c was d

[COMMITTERS] pgsql: Avoid possibly accessing off the end of memory in examine_attrib

2011-09-06 Thread Tom Lane
Avoid possibly accessing off the end of memory in examine_attribute(). Since the last couple of columns of pg_type are often NULL, sizeof(FormData_pg_type) can be an overestimate of the actual size of the tuple data part. Therefore memcpy'ing that much out of the catalog cache, as analyze.c was d

[COMMITTERS] pgsql: Avoid possibly accessing off the end of memory in examine_attrib

2011-09-06 Thread Tom Lane
Avoid possibly accessing off the end of memory in examine_attribute(). Since the last couple of columns of pg_type are often NULL, sizeof(FormData_pg_type) can be an overestimate of the actual size of the tuple data part. Therefore memcpy'ing that much out of the catalog cache, as analyze.c was d

[COMMITTERS] pgsql: Avoid possibly accessing off the end of memory in examine_attrib

2011-09-06 Thread Tom Lane
Avoid possibly accessing off the end of memory in examine_attribute(). Since the last couple of columns of pg_type are often NULL, sizeof(FormData_pg_type) can be an overestimate of the actual size of the tuple data part. Therefore memcpy'ing that much out of the catalog cache, as analyze.c was d

[COMMITTERS] pgsql: Avoid possibly accessing off the end of memory in examine_attrib

2011-09-06 Thread Tom Lane
Avoid possibly accessing off the end of memory in examine_attribute(). Since the last couple of columns of pg_type are often NULL, sizeof(FormData_pg_type) can be an overestimate of the actual size of the tuple data part. Therefore memcpy'ing that much out of the catalog cache, as analyze.c was d

[COMMITTERS] pgsql: Avoid possibly accessing off the end of memory in SJIS2004 conve

2011-09-06 Thread Tom Lane
Avoid possibly accessing off the end of memory in SJIS2004 conversion. The code in shift_jis_20042euc_jis_2004() would fetch two bytes even when only one remained in the string. Since conversion functions aren't supposed to assume null-terminated input, this poses a small risk of fetching past th

[COMMITTERS] pgsql: Avoid possibly accessing off the end of memory in SJIS2004 conve

2011-09-06 Thread Tom Lane
Avoid possibly accessing off the end of memory in SJIS2004 conversion. The code in shift_jis_20042euc_jis_2004() would fetch two bytes even when only one remained in the string. Since conversion functions aren't supposed to assume null-terminated input, this poses a small risk of fetching past th

[COMMITTERS] pgsql: Avoid possibly accessing off the end of memory in SJIS2004 conve

2011-09-06 Thread Tom Lane
Avoid possibly accessing off the end of memory in SJIS2004 conversion. The code in shift_jis_20042euc_jis_2004() would fetch two bytes even when only one remained in the string. Since conversion functions aren't supposed to assume null-terminated input, this poses a small risk of fetching past th

[COMMITTERS] pgsql: Avoid possibly accessing off the end of memory in SJIS2004 conve

2011-09-06 Thread Tom Lane
Avoid possibly accessing off the end of memory in SJIS2004 conversion. The code in shift_jis_20042euc_jis_2004() would fetch two bytes even when only one remained in the string. Since conversion functions aren't supposed to assume null-terminated input, this poses a small risk of fetching past th

[COMMITTERS] pgsql: Avoid possibly accessing off the end of memory in SJIS2004 conve

2011-09-06 Thread Tom Lane
Avoid possibly accessing off the end of memory in SJIS2004 conversion. The code in shift_jis_20042euc_jis_2004() would fetch two bytes even when only one remained in the string. Since conversion functions aren't supposed to assume null-terminated input, this poses a small risk of fetching past th

Re: [COMMITTERS] pgsql: Add C comment about why we send cache invalidation messages for

2011-09-06 Thread Tom Lane
Bruce Momjian writes: > Add C comment about why we send cache invalidation messages for > session-local objects. This comment seems inaccurate and bizarrely placed. What question were you trying to answer? regards, tom lane -- Sent via pgsql-committers mailin

[COMMITTERS] pgsql: Improve comment about handling of temp tables in shared-inval co

2011-09-06 Thread Tom Lane
Improve comment about handling of temp tables in shared-inval code. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/db10f01baa2148f1773cacfcbadc7158ae94c081 Modified Files -- src/backend/utils/cache/inval.c | 13 + 1 files changed, 9 insertio

Re: [COMMITTERS] pgsql: Add C comment about why we send cache invalidation messages for

2011-09-06 Thread Tom Lane
Bruce Momjian writes: > Tom Lane wrote: >> This comment seems inaccurate and bizarrely placed. What question >> were you trying to answer? > It was in response to my email where I asked why we are sending cache > invalidation messages for temporary tables that can

[COMMITTERS] pgsql: Fix get_name_for_var_field() to deal with RECORD Params.

2011-09-07 Thread Tom Lane
Fix get_name_for_var_field() to deal with RECORD Params. With 9.1's use of Params to pass down values from NestLoop join nodes to their inner plans, it is possible for a Param to have type RECORD, in which case the set of fields comprising the value isn't determinable by inspection of the Param al

[COMMITTERS] pgsql: Fix get_name_for_var_field() to deal with RECORD Params.

2011-09-07 Thread Tom Lane
Fix get_name_for_var_field() to deal with RECORD Params. With 9.1's use of Params to pass down values from NestLoop join nodes to their inner plans, it is possible for a Param to have type RECORD, in which case the set of fields comprising the value isn't determinable by inspection of the Param al

[COMMITTERS] pgsql: Fix typo in error message.

2011-09-07 Thread Tom Lane
Fix typo in error message. Per Euler Taveira de Oliveira. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/99155aaa33f417daabd38c8b225c09a3c6da71ba Modified Files -- src/backend/commands/collationcmds.c |2 +- 1 files changed, 1 insertions(+), 1 deleti

[COMMITTERS] pgsql: Fix typo in error message.

2011-09-07 Thread Tom Lane
Fix typo in error message. Per Euler Taveira de Oliveira. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/673dfe9690a54889bdb434321552f227806209fa Modified Files -- src/backend/commands/collationcmds.c |2 +- 1 files changed, 1 insertions(+), 1

[COMMITTERS] pgsql: Fix corner case bug in numeric to_char().

2011-09-07 Thread Tom Lane
Fix corner case bug in numeric to_char(). Trailing-zero stripping applied by the FM specifier could strip zeroes to the left of the decimal point, for a format with no digit positions after the decimal point (such as "FM999."). Reported and diagnosed by Marti Raudsepp, though I didn't use his pat

[COMMITTERS] pgsql: Fix corner case bug in numeric to_char().

2011-09-07 Thread Tom Lane
Fix corner case bug in numeric to_char(). Trailing-zero stripping applied by the FM specifier could strip zeroes to the left of the decimal point, for a format with no digit positions after the decimal point (such as "FM999."). Reported and diagnosed by Marti Raudsepp, though I didn't use his pat

[COMMITTERS] pgsql: Fix corner case bug in numeric to_char().

2011-09-07 Thread Tom Lane
Fix corner case bug in numeric to_char(). Trailing-zero stripping applied by the FM specifier could strip zeroes to the left of the decimal point, for a format with no digit positions after the decimal point (such as "FM999."). Reported and diagnosed by Marti Raudsepp, though I didn't use his pat

[COMMITTERS] pgsql: Fix corner case bug in numeric to_char().

2011-09-07 Thread Tom Lane
Fix corner case bug in numeric to_char(). Trailing-zero stripping applied by the FM specifier could strip zeroes to the left of the decimal point, for a format with no digit positions after the decimal point (such as "FM999."). Reported and diagnosed by Marti Raudsepp, though I didn't use his pat

[COMMITTERS] pgsql: Fix corner case bug in numeric to_char().

2011-09-07 Thread Tom Lane
Fix corner case bug in numeric to_char(). Trailing-zero stripping applied by the FM specifier could strip zeroes to the left of the decimal point, for a format with no digit positions after the decimal point (such as "FM999."). Reported and diagnosed by Marti Raudsepp, though I didn't use his pat

[COMMITTERS] pgsql: Fix corner case bug in numeric to_char().

2011-09-07 Thread Tom Lane
Fix corner case bug in numeric to_char(). Trailing-zero stripping applied by the FM specifier could strip zeroes to the left of the decimal point, for a format with no digit positions after the decimal point (such as "FM999."). Reported and diagnosed by Marti Raudsepp, though I didn't use his pat

[COMMITTERS] pgsql: One last round of copy-editing for the 9.1 release notes.

2011-09-07 Thread Tom Lane
One last round of copy-editing for the 9.1 release notes. Also set the documented release date to 2011-09-12. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/c7d60312fb661cdb212c63924249d623bd9d87c6 Modified Files -- doc/src/sgml/release-9.1.sgml

[COMMITTERS] pgsql: One last round of copy-editing for the 9.1 release notes.

2011-09-07 Thread Tom Lane
One last round of copy-editing for the 9.1 release notes. Also set the documented release date to 2011-09-12. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/09b68c70af855a0a69cede14da70968ddd97ba05 Modified Files -- doc/src/sgml/release-9.1.sgml | 81

Re: [COMMITTERS] pgsql: Add missing format argument to ecpg_log() call

2011-09-08 Thread Tom Lane
Peter Eisentraut writes: > Add missing format argument to ecpg_log() call Oh, fun. So why isn't there an __attribute__((format...)) decoration on ecpg_log()? regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make

[COMMITTERS] pgsql: round() is not portable. Use rint().

2011-09-08 Thread Tom Lane
round() is not portable. Use rint(). Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d63de337f3e235f02d79a1df79dddbb002e9fd4e Modified Files -- src/backend/access/gist/gistbuild.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) -- Sent vi

Re: [COMMITTERS] pgsql: Buffering GiST index build algorithm.

2011-09-08 Thread Tom Lane
X box too. I committed a quick fix using rint(), but on reflection I wonder if it shouldn't be ceil(). regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Stamp 9.1.0.

2011-09-08 Thread Tom Lane
Stamp 9.1.0. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/1f43001424a9da624a89b213d0be606a8212a50a Modified Files -- configure | 18 +- configure.in |2 +- doc/bug.template |

[COMMITTERS] pgsql: Move Timestamp/Interval typedefs and basic macros into datatype/

2011-09-09 Thread Tom Lane
Move Timestamp/Interval typedefs and basic macros into datatype/timestamp.h. As per my recent proposal, this refactors things so that these typedefs and macros are available in a header that can be included in frontend-ish code. I also changed various headers that were undesirably including utils/

[COMMITTERS] pgsql: Simplify handling of the timezone GUC by making initdb choose th

2011-09-09 Thread Tom Lane
Simplify handling of the timezone GUC by making initdb choose the default. We were doing some amazingly complicated things in order to avoid running the very expensive identify_system_timezone() procedure during GUC initialization. But there is an obvious fix for that, which is to do it once duri

[COMMITTERS] pgsql: Try to un-break MSVC build.

2011-09-09 Thread Tom Lane
Try to un-break MSVC build. I thought we had enough infrastructure to absorb CPPFLAGS changes from the makefiles, but buildfarm says otherwise. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5a8de2f2e7fd5d2265f30206743ba2dd51bff222 Modified Files -- src

[COMMITTERS] pgsql: Fix permissions on pg_largeobject_metadata.h in 9.0 branch.

2011-09-11 Thread Tom Lane
Fix permissions on pg_largeobject_metadata.h in 9.0 branch. For some reason it was 0755 instead of 0644. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/4de174d4bfa8e162cf64fb9bf7393fea05b0dee7 Modified Files -- 0 files changed, 0 insertions(+), 0

[COMMITTERS] pgsql: Remove no-longer-used variable.

2011-09-11 Thread Tom Lane
Remove no-longer-used variable. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5f42e5945b3dd96c228531c0730f418846ced04e Modified Files -- contrib/pgbench/pgbench.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) -- Sent via pgsql-committers

[COMMITTERS] pgsql: Invent a new memory context primitive, MemoryContextSetParent.

2011-09-11 Thread Tom Lane
Invent a new memory context primitive, MemoryContextSetParent. This function will be useful for altering the lifespan of a context after creation (for example, by creating it under a transient context and later reparenting it to belong to a long-lived context). It costs almost no new code, since

[COMMITTERS] pgsql: Propagate with_system_tzdata setting into initdb build.

2011-09-13 Thread Tom Lane
Propagate with_system_tzdata setting into initdb build. findtimezone.c needs to know this setting too. Per Peter Eisentraut. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3f3304408cb103745ee0722d303c526594a8046c Modified Files -- src/bin/initdb/Makefi

[COMMITTERS] pgsql: deflist_to_tuplestore dumped core on an option with no value.

2011-09-13 Thread Tom Lane
deflist_to_tuplestore dumped core on an option with no value. Make it return NULL for the option_value, instead. Per report from Frank van Vugt. Back-patch to 8.4 where this code was added. Branch -- REL9_0_STABLE Details --- http://git.postgresql.org/pg/commitdiff/cac73320ef0f35304e2d

[COMMITTERS] pgsql: deflist_to_tuplestore dumped core on an option with no value.

2011-09-13 Thread Tom Lane
deflist_to_tuplestore dumped core on an option with no value. Make it return NULL for the option_value, instead. Per report from Frank van Vugt. Back-patch to 8.4 where this code was added. Branch -- REL8_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/5d68fe14fcc6012cd9e7

[COMMITTERS] pgsql: deflist_to_tuplestore dumped core on an option with no value.

2011-09-13 Thread Tom Lane
deflist_to_tuplestore dumped core on an option with no value. Make it return NULL for the option_value, instead. Per report from Frank van Vugt. Back-patch to 8.4 where this code was added. Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/663bee0d5c1e3ff23803

[COMMITTERS] pgsql: deflist_to_tuplestore dumped core on an option with no value.

2011-09-13 Thread Tom Lane
deflist_to_tuplestore dumped core on an option with no value. Make it return NULL for the option_value, instead. Per report from Frank van Vugt. Back-patch to 8.4 where this code was added. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/6693c9a5ed3ac9c07160039742d

[COMMITTERS] pgsql: gistendscan() forgot to free so->giststate.

2011-09-16 Thread Tom Lane
gistendscan() forgot to free so->giststate. This oversight led to a massive memory leak --- upwards of 10KB per tuple --- during creation-time verification of an exclusion constraint based on a GIST index. In most other scenarios it'd just be a leak of 10KB that would be recovered at end of query

[COMMITTERS] pgsql: gistendscan() forgot to free so->giststate.

2011-09-16 Thread Tom Lane
gistendscan() forgot to free so->giststate. This oversight led to a massive memory leak --- upwards of 10KB per tuple --- during creation-time verification of an exclusion constraint based on a GIST index. In most other scenarios it'd just be a leak of 10KB that would be recovered at end of query

[COMMITTERS] pgsql: gistendscan() forgot to free so->giststate.

2011-09-16 Thread Tom Lane
gistendscan() forgot to free so->giststate. This oversight led to a massive memory leak --- upwards of 10KB per tuple --- during creation-time verification of an exclusion constraint based on a GIST index. In most other scenarios it'd just be a leak of 10KB that would be recovered at end of query

[COMMITTERS] pgsql: gistendscan() forgot to free so->giststate.

2011-09-16 Thread Tom Lane
gistendscan() forgot to free so->giststate. This oversight led to a massive memory leak --- upwards of 10KB per tuple --- during creation-time verification of an exclusion constraint based on a GIST index. In most other scenarios it'd just be a leak of 10KB that would be recovered at end of query

[COMMITTERS] pgsql: gistendscan() forgot to free so->giststate.

2011-09-16 Thread Tom Lane
gistendscan() forgot to free so->giststate. This oversight led to a massive memory leak --- upwards of 10KB per tuple --- during creation-time verification of an exclusion constraint based on a GIST index. In most other scenarios it'd just be a leak of 10KB that would be recovered at end of query

[COMMITTERS] pgsql: gistendscan() forgot to free so->giststate.

2011-09-16 Thread Tom Lane
gistendscan() forgot to free so->giststate. This oversight led to a massive memory leak --- upwards of 10KB per tuple --- during creation-time verification of an exclusion constraint based on a GIST index. In most other scenarios it'd just be a leak of 10KB that would be recovered at end of query

[COMMITTERS] pgsql: Redesign the plancache mechanism for more flexibility and effici

2011-09-16 Thread Tom Lane
Redesign the plancache mechanism for more flexibility and efficiency. Rewrite plancache.c so that a "cached plan" (which is rather a misnomer at this point) can support generation of custom, parameter-value-dependent plans, and can make an intelligent choice between using custom plans and the trad

[COMMITTERS] pgsql: Ensure generic plan gets used for a plpgsql expression with no p

2011-09-16 Thread Tom Lane
Ensure generic plan gets used for a plpgsql expression with no parameters. Now that a NULL ParamListInfo pointer causes significantly different behavior in plancache.c, be sure to pass it that way when the expression is known not to reference any plpgsql variables. Saves a few setup cycles anyway

[COMMITTERS] pgsql: Avoid unnecessary page-level SSI lock check in heap_insert().

2011-09-16 Thread Tom Lane
Avoid unnecessary page-level SSI lock check in heap_insert(). As observed by Heikki, we need not conflict on heap page locks during an insert; heap page locks are only aggregated tuple locks, they don't imply locking "gaps" as index page locks do. So we can avoid some unnecessary conflicts, and a

[COMMITTERS] pgsql: Avoid unnecessary page-level SSI lock check in heap_insert().

2011-09-16 Thread Tom Lane
Avoid unnecessary page-level SSI lock check in heap_insert(). As observed by Heikki, we need not conflict on heap page locks during an insert; heap page locks are only aggregated tuple locks, they don't imply locking "gaps" as index page locks do. So we can avoid some unnecessary conflicts, and a

[COMMITTERS] pgsql: Add FORCE_NOT_NULL support to the file_fdw foreign data wrapper.

2011-09-16 Thread Tom Lane
Add FORCE_NOT_NULL support to the file_fdw foreign data wrapper. This is implemented as a per-column boolean option, rather than trying to match COPY's convention of a single option listing the column names. Shigeru Hanada, reviewed by KaiGai Kohei Branch -- master Details --- http://gi

[COMMITTERS] pgsql: Remove debug logging for pgstat wait timeout.

2011-09-16 Thread Tom Lane
Remove debug logging for pgstat wait timeout. This reverts commit 79b2ee20c8a041a85dd230c4e787bef22edae57b, which proved to not be very informative; it looks like the "pgstat wait timeout" warnings in the buildfarm are just a symptom of running on heavily loaded machines, and there isn't any weird

[COMMITTERS] pgsql: Fix Assert failure in new plancache code.

2011-09-17 Thread Tom Lane
Fix Assert failure in new plancache code. The regression tests were failing with CLOBBER_CACHE_ALWAYS enabled, as reported by buildfarm member jaguar. There was an Assert in BuildCachedPlan that asserted that the CachedPlanSource hadn't been invalidated since we called RevalidateCachedQuery, whic

<    4   5   6   7   8   9   10   11   12   13   >