[COMMITTERS] pgsql: Remove dead code in pg_dump.

2016-10-13 Thread Tom Lane
Remove dead code in pg_dump. I'm not sure if this provision for "pg_backup" behaving a bit differently from "pg_dump" ever did anything useful in a released version. But it's definitely dead code now. Michael Paquier Branch -- master Details ---

[COMMITTERS] pgsql: Remove dead code in pg_dump.

2016-01-17 Thread Tom Lane
Remove dead code in pg_dump. Coverity quite reasonably complained that this check for fout==NULL occurred after we'd already dereferenced fout. However, the check is just dead code since there is no code path by which CreateArchive can return a null pointer. Errors such as can't-open-that-file

[COMMITTERS] pgsql: Remove dead code in pg_dump.

2016-01-17 Thread Tom Lane
Remove dead code in pg_dump. Coverity quite reasonably complained that this check for fout==NULL occurred after we'd already dereferenced fout. However, the check is just dead code since there is no code path by which CreateArchive can return a null pointer. Errors such as can't-open-that-file