pgsql: Update documentation to mention huge pages on other OSes

2018-01-25 Thread Peter Eisentraut
Update documentation to mention huge pages on other OSes Previously, the docs implied that only Linux and Windows could use huge pages. That's not quite true: it's just that we only know how to request them explicitly on those OSes. Be more explicit about what huge_pages really does and mention

pgsql: Improve pg_dump's handling of "special" built-in objects.

2018-01-25 Thread Tom Lane
Improve pg_dump's handling of "special" built-in objects. We had some pretty ad-hoc handling of the public schema and the plpgsql extension, which are both presumed to exist in template0 but might be modified or deleted in the database being dumped. Up to now, by default pg_dump would emit a

pgsql: Ignore partitioned indexes where appropriate

2018-01-25 Thread Alvaro Herrera
Ignore partitioned indexes where appropriate get_relation_info() was too optimistic about opening indexes in partitioned tables, which would raise errors when any queries were planned on such tables. Fix by ignoring any indexes of the partitioned kind. CLUSTER (and ALTER TABLE CLUSTER ON) had a

pgsql: Clean up some aspects of pg_dump/pg_restore item-selection logic

2018-01-25 Thread Tom Lane
Clean up some aspects of pg_dump/pg_restore item-selection logic. Ensure that CREATE DATABASE and related commands are issued when, and only when, --create is specified. Previously there were scenarios where using selective-dump switches would prevent --create from having any effect. For

pgsql: Add missing "static" markers.

2018-01-25 Thread Tom Lane
Add missing "static" markers. Per buildfarm. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bb415675d8ab6e776321a96f9c0e77c12fda96ea Modified Files -- src/backend/executor/nodeModifyTable.c | 2 +- src/bin/pg_dump/pg_dump.c | 2 +- 2 files

pgsql: Support --no-comments in pg_dump, pg_dumpall, pg_restore.

2018-01-25 Thread Tom Lane
Support --no-comments in pg_dump, pg_dumpall, pg_restore. We have switches already to suppress other subsidiary object properties, such as ACLs, security labels, ownership, and tablespaces, so just on the grounds of symmetry we should allow suppressing comments as well. Also, commit 0d4e6ed30

pgsql: Fix C comment typo

2018-01-25 Thread Bruce Momjian
Fix C comment typo Reported-by: Masahiko Sawada Discussion: https://postgr.es/m/cad21aobgnhy2ykauub6ivg4ibvlyephr+rdrkr1arqwwc1a...@mail.gmail.com Author: Masahiko Sawada Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6588a43bcacca872fafba10363d346b806964d90

pgsql: Allow spaces in connection strings in SSL tests

2018-01-25 Thread Peter Eisentraut
Allow spaces in connection strings in SSL tests Connection strings can have items with spaces in them, wrapped in quotes. The tests however ran a SELECT '$connstr' upon connection which broke on the embedded quotes. Use dollar quotes on the connstr to protect against this. This was hit during

pgsql: Remove use of byte-masking macros in record_image_cmp

2018-01-25 Thread Peter Eisentraut
Remove use of byte-masking macros in record_image_cmp These were introduced in 4cbb646334b3b998a29abef0d57608d42097e6c9, but after further analysis and testing, they should not be necessary and probably weren't the part of that commit that fixed anything. Reviewed-by: Michael Paquier