pgsql: Fix error message on short read of pg_control

2018-05-18 Thread Magnus Hagander
Fix error message on short read of pg_control Instead of saying "error: success", indicate that we got a working read but it was too short. Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/830e8e3609d003e320b963a7fa7c1432e10d8766 Modified Files

pgsql: Fix error message on short read of pg_control

2018-05-18 Thread Magnus Hagander
Fix error message on short read of pg_control Instead of saying "error: success", indicate that we got a working read but it was too short. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/29ce50091d128faaabd0a4044e91a7d0da11bb8e Modified Files

pgsql: Fix error message on short read of pg_control

2018-05-18 Thread Magnus Hagander
Fix error message on short read of pg_control Instead of saying "error: success", indicate that we got a working read but it was too short. Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/048caa5560da33d63bbcbb2063c8ecd48994c99b Modified Files

pgsql: Fix error message on short read of pg_control

2018-05-18 Thread Magnus Hagander
Fix error message on short read of pg_control Instead of saying "error: success", indicate that we got a working read but it was too short. Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b5f096d50bee5c20023ed05390fdc52aa44a1404 Modified Files

pgsql: Fix error message on short read of pg_control

2018-05-18 Thread Magnus Hagander
Fix error message on short read of pg_control Instead of saying "error: success", indicate that we got a working read but it was too short. Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/714d8e5fa1b21a1113d6cd444af5cbc9d67d566f Modified Files

pgsql: Small improvement for plpgsql regression test.

2018-05-18 Thread Tom Lane
Small improvement for plpgsql regression test. Use DISCARD PLANS instead of a reconnect to force reconstruction of a cached plan; this corresponds more nearly to what people might actually do in practice. Branch -- master Details ---

pgsql: MSVC builds must use a separate stamp file for copying generated

2018-05-18 Thread Tom Lane
MSVC builds must use a separate stamp file for copying generated headers. Commit bad51a49a tried to use a shortcut with just one stamp file recording the actions of generating the pg_*_d.h headers and copying them to the src/include/catalog/ directory. That doesn't work in all scenarios though,

pgsql: Prevent possibly spurious error when running perl -cw

2018-05-18 Thread Andrew Dunstan
Prevent possibly spurious error when running perl -cw Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3dacd9bf32873c80045a2b758d64c031d70dac83 Modified Files -- src/tools/msvc/Mkvcbuild.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Further adjust comment in get_partition_dispatch_recurse.

2018-05-18 Thread Robert Haas
Further adjust comment in get_partition_dispatch_recurse. In editing 09b12d52db1cf1a4c72d876f3fb6c9d06919e51a I made it wrong; fix that and try to more clearly explain the situation. Patch by me, reviewed by David Rowley and Amit Langote Discussion:

pgsql: Recognize that MSVC can support strtoll() and strtoull().

2018-05-18 Thread Tom Lane
Recognize that MSVC can support strtoll() and strtoull(). This is needed for full support of "long long" variables in ecpg, but the previous patch for bug #15080 (commits 51057feaa et al) missed it. In MSVC versions where the functions don't exist under those names, we can nonetheless use

pgsql: Recognize that MSVC can support strtoll() and strtoull().

2018-05-18 Thread Tom Lane
Recognize that MSVC can support strtoll() and strtoull(). This is needed for full support of "long long" variables in ecpg, but the previous patch for bug #15080 (commits 51057feaa et al) missed it. In MSVC versions where the functions don't exist under those names, we can nonetheless use

pgsql: Add some test coverage for ecpg's "long long" support.

2018-05-18 Thread Tom Lane
Add some test coverage for ecpg's "long long" support. This will only actually exercise the "long long" code paths on platforms where "long" is 32 bits --- otherwise, the SQL bigint type maps to plain "long", and we will test that code path instead. But that's probably sufficient coverage, and

pgsql: Recognize that MSVC can support strtoll() and strtoull().

2018-05-18 Thread Tom Lane
Recognize that MSVC can support strtoll() and strtoull(). This is needed for full support of "long long" variables in ecpg, but the previous patch for bug #15080 (commits 51057feaa et al) missed it. In MSVC versions where the functions don't exist under those names, we can nonetheless use

pgsql: Recognize that MSVC can support strtoll() and strtoull().

2018-05-18 Thread Tom Lane
Recognize that MSVC can support strtoll() and strtoull(). This is needed for full support of "long long" variables in ecpg, but the previous patch for bug #15080 (commits 51057feaa et al) missed it. In MSVC versions where the functions don't exist under those names, we can nonetheless use

pgsql: Add some test coverage for ecpg's "long long" support.

2018-05-18 Thread Tom Lane
Add some test coverage for ecpg's "long long" support. This will only actually exercise the "long long" code paths on platforms where "long" is 32 bits --- otherwise, the SQL bigint type maps to plain "long", and we will test that code path instead. But that's probably sufficient coverage, and

pgsql: Recognize that MSVC can support strtoll() and strtoull().

2018-05-18 Thread Tom Lane
Recognize that MSVC can support strtoll() and strtoull(). This is needed for full support of "long long" variables in ecpg, but the previous patch for bug #15080 (commits 51057feaa et al) missed it. In MSVC versions where the functions don't exist under those names, we can nonetheless use

pgsql: Add some test coverage for ecpg's "long long" support.

2018-05-18 Thread Tom Lane
Add some test coverage for ecpg's "long long" support. This will only actually exercise the "long long" code paths on platforms where "long" is 32 bits --- otherwise, the SQL bigint type maps to plain "long", and we will test that code path instead. But that's probably sufficient coverage, and

pgsql: Hot-fix ecpg regression test for missing ecpg_config.h inclusion

2018-05-18 Thread Tom Lane
Hot-fix ecpg regression test for missing ecpg_config.h inclusion. I don't think this is really the best long-term answer, and in particular it doesn't fix the pre-existing hazard in sqltypes.h. But for the moment let's just try to make the buildfarm green again. Discussion:

pgsql: Hot-fix ecpg regression test for missing ecpg_config.h inclusion

2018-05-18 Thread Tom Lane
Hot-fix ecpg regression test for missing ecpg_config.h inclusion. I don't think this is really the best long-term answer, and in particular it doesn't fix the pre-existing hazard in sqltypes.h. But for the moment let's just try to make the buildfarm green again. Discussion:

pgsql: Hot-fix ecpg regression test for missing ecpg_config.h inclusion

2018-05-18 Thread Tom Lane
Hot-fix ecpg regression test for missing ecpg_config.h inclusion. I don't think this is really the best long-term answer, and in particular it doesn't fix the pre-existing hazard in sqltypes.h. But for the moment let's just try to make the buildfarm green again. Discussion:

pgsql: Hot-fix ecpg regression test for missing ecpg_config.h inclusion

2018-05-18 Thread Tom Lane
Hot-fix ecpg regression test for missing ecpg_config.h inclusion. I don't think this is really the best long-term answer, and in particular it doesn't fix the pre-existing hazard in sqltypes.h. But for the moment let's just try to make the buildfarm green again. Discussion:

pgsql: Hot-fix ecpg regression test for missing ecpg_config.h inclusion

2018-05-18 Thread Tom Lane
Hot-fix ecpg regression test for missing ecpg_config.h inclusion. I don't think this is really the best long-term answer, and in particular it doesn't fix the pre-existing hazard in sqltypes.h. But for the moment let's just try to make the buildfarm green again. Discussion:

pgsql: Fix for globals.c- c.h must come first

2018-05-18 Thread Stephen Frost
Fix for globals.c- c.h must come first Commit da9b580 mistakenly put a system header before postgres.h (which includes c.h). That can cause portability issues and broke (at least) builds with older Windows compilers. Discovered by Mark Dilger. Discussion:

pgsql: Arrange to supply declarations for strtoll/strtoull if needed.

2018-05-18 Thread Tom Lane
Arrange to supply declarations for strtoll/strtoull if needed. Buildfarm member dromedary is still unhappy about the recently-added ecpg "long long" tests. The reason turns out to be that it includes "-ansi" in its CFLAGS, and in their infinite wisdom Apple have decided to hide the declarations

pgsql: Arrange to supply declarations for strtoll/strtoull if needed.

2018-05-18 Thread Tom Lane
Arrange to supply declarations for strtoll/strtoull if needed. Buildfarm member dromedary is still unhappy about the recently-added ecpg "long long" tests. The reason turns out to be that it includes "-ansi" in its CFLAGS, and in their infinite wisdom Apple have decided to hide the declarations

pgsql: Arrange to supply declarations for strtoll/strtoull if needed.

2018-05-18 Thread Tom Lane
Arrange to supply declarations for strtoll/strtoull if needed. Buildfarm member dromedary is still unhappy about the recently-added ecpg "long long" tests. The reason turns out to be that it includes "-ansi" in its CFLAGS, and in their infinite wisdom Apple have decided to hide the declarations

pgsql: Arrange to supply declarations for strtoll/strtoull if needed.

2018-05-18 Thread Tom Lane
Arrange to supply declarations for strtoll/strtoull if needed. Buildfarm member dromedary is still unhappy about the recently-added ecpg "long long" tests. The reason turns out to be that it includes "-ansi" in its CFLAGS, and in their infinite wisdom Apple have decided to hide the declarations

pgsql: Arrange to supply declarations for strtoll/strtoull if needed.

2018-05-18 Thread Tom Lane
Arrange to supply declarations for strtoll/strtoull if needed. Buildfarm member dromedary is still unhappy about the recently-added ecpg "long long" tests. The reason turns out to be that it includes "-ansi" in its CFLAGS, and in their infinite wisdom Apple have decided to hide the declarations

pgsql: Arrange to supply declarations for strtoll/strtoull if needed.

2018-05-18 Thread Tom Lane
Arrange to supply declarations for strtoll/strtoull if needed. Buildfarm member dromedary is still unhappy about the recently-added ecpg "long long" tests. The reason turns out to be that it includes "-ansi" in its CFLAGS, and in their infinite wisdom Apple have decided to hide the declarations