pgsql: Raise some timeouts to 180s, in test code.

2018-12-10 Thread Noah Misch
Raise some timeouts to 180s, in test code. Slow runs of buildfarm members chipmunk, hornet and mandrill saw the shorter timeouts expire. The 180s timeout in poll_query_until has been trouble-free since 2a0f89cd717ce6d49cdc47850577823682167e87 introduced it two years ago, so use 180s more widely.

pgsql: Raise some timeouts to 180s, in test code.

2018-12-10 Thread Noah Misch
Raise some timeouts to 180s, in test code. Slow runs of buildfarm members chipmunk, hornet and mandrill saw the shorter timeouts expire. The 180s timeout in poll_query_until has been trouble-free since 2a0f89cd717ce6d49cdc47850577823682167e87 introduced it two years ago, so use 180s more widely.

pgsql: Raise some timeouts to 180s, in test code.

2018-12-10 Thread Noah Misch
Raise some timeouts to 180s, in test code. Slow runs of buildfarm members chipmunk, hornet and mandrill saw the shorter timeouts expire. The 180s timeout in poll_query_until has been trouble-free since 2a0f89cd717ce6d49cdc47850577823682167e87 introduced it two years ago, so use 180s more widely.

pgsql: Raise some timeouts to 180s, in test code.

2018-12-10 Thread Noah Misch
Raise some timeouts to 180s, in test code. Slow runs of buildfarm members chipmunk, hornet and mandrill saw the shorter timeouts expire. The 180s timeout in poll_query_until has been trouble-free since 2a0f89cd717ce6d49cdc47850577823682167e87 introduced it two years ago, so use 180s more widely.

pgsql: Remove dead code in toast_fetch_datum_slice

2018-12-10 Thread Stephen Frost
Remove dead code in toast_fetch_datum_slice In toast_fetch_datum_slice(), we Assert() that what is passed in isn't compressed, but we then later had a check to see what the length of if what was passed in is compressed. That later check is rather confusing since toast_fetch_datum_slice() is only

pgsql: Add additional partition tests to pg_dump

2018-12-10 Thread Stephen Frost
Add additional partition tests to pg_dump This adds a few tests for non-inherited constraints. Author: Amit Langote Discussion: https://postgr.es/m/20181208001735.GT3415%40tamriel.snowman.net Branch -- master Details ---

pgsql: Make TupleDescInitBuiltinEntry throw error for unsupported types

2018-12-10 Thread Tom Lane
Make TupleDescInitBuiltinEntry throw error for unsupported types. Previously, it would just pass back a partially-uninitialized tupdesc, which doesn't seem like a safe or useful behavior. Backpatch to v10 where this code came in. Discussion: https://postgr.es/m/30830.1544384...@sss.pgh.pa.us

pgsql: Make TupleDescInitBuiltinEntry throw error for unsupported types

2018-12-10 Thread Tom Lane
Make TupleDescInitBuiltinEntry throw error for unsupported types. Previously, it would just pass back a partially-uninitialized tupdesc, which doesn't seem like a safe or useful behavior. Backpatch to v10 where this code came in. Discussion: https://postgr.es/m/30830.1544384...@sss.pgh.pa.us

pgsql: Make TupleDescInitBuiltinEntry throw error for unsupported types

2018-12-10 Thread Tom Lane
Make TupleDescInitBuiltinEntry throw error for unsupported types. Previously, it would just pass back a partially-uninitialized tupdesc, which doesn't seem like a safe or useful behavior. Backpatch to v10 where this code came in. Discussion: https://postgr.es/m/30830.1544384...@sss.pgh.pa.us

pgsql: Doc: remove obsolete reference to recursive expression evaluatio

2018-12-10 Thread Tom Lane
Doc: remove obsolete reference to recursive expression evaluation. John Naylor Discussion: https://postgr.es/m/cajvsvguph-0q5fep4v9b+y8k3hgtn3bed5kv7vbyuj-ofds...@mail.gmail.com Branch -- master Details ---

pgsql: Add stack depth checks to key recursive functions in backend/nod

2018-12-10 Thread Tom Lane
Add stack depth checks to key recursive functions in backend/nodes/*.c. Although copyfuncs.c has a check_stack_depth call in its recursion, equalfuncs.c, outfuncs.c, and readfuncs.c lacked one. This seems unwise. Likewise fix planstate_tree_walker(), in branches where that exists. Discussion:

pgsql: Add stack depth checks to key recursive functions in backend/nod

2018-12-10 Thread Tom Lane
Add stack depth checks to key recursive functions in backend/nodes/*.c. Although copyfuncs.c has a check_stack_depth call in its recursion, equalfuncs.c, outfuncs.c, and readfuncs.c lacked one. This seems unwise. Likewise fix planstate_tree_walker(), in branches where that exists. Discussion:

pgsql: Add stack depth checks to key recursive functions in backend/nod

2018-12-10 Thread Tom Lane
Add stack depth checks to key recursive functions in backend/nodes/*.c. Although copyfuncs.c has a check_stack_depth call in its recursion, equalfuncs.c, outfuncs.c, and readfuncs.c lacked one. This seems unwise. Likewise fix planstate_tree_walker(), in branches where that exists. Discussion:

pgsql: Add stack depth checks to key recursive functions in backend/nod

2018-12-10 Thread Tom Lane
Add stack depth checks to key recursive functions in backend/nodes/*.c. Although copyfuncs.c has a check_stack_depth call in its recursion, equalfuncs.c, outfuncs.c, and readfuncs.c lacked one. This seems unwise. Likewise fix planstate_tree_walker(), in branches where that exists. Discussion:

pgsql: Add stack depth checks to key recursive functions in backend/nod

2018-12-10 Thread Tom Lane
Add stack depth checks to key recursive functions in backend/nodes/*.c. Although copyfuncs.c has a check_stack_depth call in its recursion, equalfuncs.c, outfuncs.c, and readfuncs.c lacked one. This seems unwise. Likewise fix planstate_tree_walker(), in branches where that exists. Discussion:

pgsql: Add stack depth checks to key recursive functions in backend/nod

2018-12-10 Thread Tom Lane
Add stack depth checks to key recursive functions in backend/nodes/*.c. Although copyfuncs.c has a check_stack_depth call in its recursion, equalfuncs.c, outfuncs.c, and readfuncs.c lacked one. This seems unwise. Likewise fix planstate_tree_walker(), in branches where that exists. Discussion: