Re: pgsql: Fix gratuitous error message variation

2019-11-09 Thread Peter Eisentraut
On 2019-11-09 02:20, Tom Lane wrote: Peter Eisentraut writes: Fix gratuitous error message variation Hm, as long as you're touching that ... OIDs should be formatted with %u not %d. This is just a fixup of the recent patch 8f75e8e44609335e6bdd73123284682235f242a2. Replication origin IDs

pgsql: Fix negative bitmapset member not allowed error in logical repli

2019-11-09 Thread Peter Eisentraut
Fix negative bitmapset member not allowed error in logical replication This happens when we add a replica identity column on a subscriber that does not yet exist on the publisher, according to the mapping maintained by the subscriber. Code that checks whether the target relation on the subscriber

pgsql: Fix negative bitmapset member not allowed error in logical repli

2019-11-09 Thread Peter Eisentraut
Fix negative bitmapset member not allowed error in logical replication This happens when we add a replica identity column on a subscriber that does not yet exist on the publisher, according to the mapping maintained by the subscriber. Code that checks whether the target relation on the subscriber

pgsql: Fix negative bitmapset member not allowed error in logical repli

2019-11-09 Thread Peter Eisentraut
Fix negative bitmapset member not allowed error in logical replication This happens when we add a replica identity column on a subscriber that does not yet exist on the publisher, according to the mapping maintained by the subscriber. Code that checks whether the target relation on the subscriber

pgsql: Fix negative bitmapset member not allowed error in logical repli

2019-11-09 Thread Peter Eisentraut
Fix negative bitmapset member not allowed error in logical replication This happens when we add a replica identity column on a subscriber that does not yet exist on the publisher, according to the mapping maintained by the subscriber. Code that checks whether the target relation on the subscriber

pgsql: doc: Further tweak recovery parameters documentation

2019-11-09 Thread Peter Eisentraut
doc: Further tweak recovery parameters documentation Remove one sentence that was deemed misleading. Discussion: https://www.postgresql.org/message-id/flat/E1iEgSp-0004R5-2E%40gemulon.postgresql.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/27b59d619ddfb512e

pgsql: doc: Further tweak recovery parameters documentation

2019-11-09 Thread Peter Eisentraut
doc: Further tweak recovery parameters documentation Remove one sentence that was deemed misleading. Discussion: https://www.postgresql.org/message-id/flat/E1iEgSp-0004R5-2E%40gemulon.postgresql.org Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/175571923c

Re: pgsql: doc: Further clarify how recovery target parameters are applied

2019-11-09 Thread Peter Eisentraut
On 2019-11-07 18:10, Fujii Masao wrote: After reading this again and again, I think the best fix to get PG12 into "correct" shape is to just remove the offending sentence: +1 done -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, T

pgsql: doc: Clarify documentation about SSL passphrases

2019-11-09 Thread Peter Eisentraut
doc: Clarify documentation about SSL passphrases The previous statement that using a passphrase disables the ability to change the server's SSL configuration without a server restart was no longer completely true since the introduction of ssl_passphrase_command_supports_reload. Branch -- mast

pgsql: doc: Clarify documentation about SSL passphrases

2019-11-09 Thread Peter Eisentraut
doc: Clarify documentation about SSL passphrases The previous statement that using a passphrase disables the ability to change the server's SSL configuration without a server restart was no longer completely true since the introduction of ssl_passphrase_command_supports_reload. Branch -- REL_

pgsql: doc: Clarify documentation about SSL passphrases

2019-11-09 Thread Peter Eisentraut
doc: Clarify documentation about SSL passphrases The previous statement that using a passphrase disables the ability to change the server's SSL configuration without a server restart was no longer completely true since the introduction of ssl_passphrase_command_supports_reload. Branch -- REL_

Re: pgsql: Add backtrace support for error reporting

2019-11-09 Thread Julien Rouhaud
On Fri, Nov 8, 2019 at 11:30 PM Amit Langote wrote: > > On Sat, Nov 9, 2019 at 3:52 Alvaro Herrera wrote: >> >> Add backtrace support for error reporting > > > Yay, thanks! +1 that's very cool!

Re: pgsql: Fix negative bitmapset member not allowed error in logical repli

2019-11-09 Thread Peter Eisentraut
On 2019-11-09 09:17, Peter Eisentraut wrote: Fix negative bitmapset member not allowed error in logical replication I see that there are timing errors in the tests on the build farm. I'm working on a fix. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 2

pgsql: Fix subscription test

2019-11-09 Thread Peter Eisentraut
Fix subscription test After altering a subscription, we should wait until the updated table sync data has been fetched by the subscriber. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ef8fcbff56e8904ba83b2659e9d0290e6106928e Modified Files -- src/test

Re: pgsql: Fix gratuitous error message variation

2019-11-09 Thread Euler Taveira
Em sáb., 9 de nov. de 2019 às 05:02, Peter Eisentraut escreveu: > > On 2019-11-09 02:20, Tom Lane wrote: > > Peter Eisentraut writes: > >> Fix gratuitous error message variation > > > > Hm, as long as you're touching that ... OIDs should be formatted > > with %u not %d. > > This is just a fixup o

pgsql: Fix subscription test

2019-11-09 Thread Peter Eisentraut
Fix subscription test After altering a subscription, we should wait until the updated table sync data has been fetched by the subscriber. Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/aa988457848fc153bfc85b4d240c0a020f9cdfe8 Modified Files -- s

pgsql: Fix subscription test

2019-11-09 Thread Peter Eisentraut
Fix subscription test After altering a subscription, we should wait until the updated table sync data has been fetched by the subscriber. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/806f9dc02aea2e45a522bf3c7ed68154f6970e15 Modified Files -- s

pgsql: Fix subscription test

2019-11-09 Thread Peter Eisentraut
Fix subscription test After altering a subscription, we should wait until the updated table sync data has been fetched by the subscriber. Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f967563045334c3f660805c6ad83068b5f76a00d Modified Files -- s

pgsql: Remove test case that doesn't work with --disable-integer-timest

2019-11-09 Thread Tom Lane
Remove test case that doesn't work with --disable-integer-timestamps. Commits a7145f6bc et al. added a test to verify integer overflow detection in interval_mul. That only applies with integer timestamps, of course, so it's problematic in pre-v10 branches where we supported float timestamps. The

pgsql: Remove test case that doesn't work with --disable-integer-timest

2019-11-09 Thread Tom Lane
Remove test case that doesn't work with --disable-integer-timestamps. Commits a7145f6bc et al. added a test to verify integer overflow detection in interval_mul. That only applies with integer timestamps, of course, so it's problematic in pre-v10 branches where we supported float timestamps. The

pgsql: Remove test case that doesn't work with --disable-integer-timest

2019-11-09 Thread Tom Lane
Remove test case that doesn't work with --disable-integer-timestamps. Commits a7145f6bc et al. added a test to verify integer overflow detection in interval_mul. That only applies with integer timestamps, of course, so it's problematic in pre-v10 branches where we supported float timestamps. The