Re: pgsql: Centralize json and jsonb handling of datetime types

2018-01-16 Thread Erik Rijkers
, int *tzp); No errors, and 'make check' and 'make check-world' are both OK. thanks, Erik Rijkers

Re: pgsql: Support INOUT arguments in procedures

2018-03-14 Thread Erik Rijkers
On 2018-03-14 17:09, Peter Eisentraut wrote: Support INOUT arguments in procedures gcc 6.3.0 (on debian stretch) mutters: pl_exec.c: In function ‘exec_stmt_call’: pl_exec.c:2089:10: warning: variable ‘numargs’ set but not used [-Wunused-but-set-variable] int numargs; ^~~

Re: pgsql: Support INOUT arguments in procedures

2018-03-14 Thread Erik Rijkers
On 2018-03-14 19:28, Tom Lane wrote: Peter Eisentraut writes: On 3/14/18 12:45, Erik Rijkers wrote: pl_exec.c: In function ‘exec_stmt_call’: pl_exec.c:2089:10: warning: variable ‘numargs’ set but not used [-Wunused-but-set-variable] I don't get that, and buildfarm animals of si

Re: pgsql: Indexes with INCLUDE columns and their support in B-tree

2018-04-07 Thread Erik Rijkers
, Alexander Korotkov I've put quite some time in testing this patch, and although I don't really mind not being mentioned, I think it's better to err on the side of including too many names than too few. Erik Rijkers

Re: pgsql: Indexes with INCLUDE columns and their support in B-tree

2018-04-07 Thread Erik Rijkers
On 2018-04-07 22:51, Teodor Sigaev wrote: Ooops, sorry, if it possible, I'd like to change list of reviewers to add you, but I don't know how do it. No problem, really. Thanks, great feature! I'm glad it got in.

Re: pgsql: Improve error messages for incorrect types of logical replicatio

2019-01-13 Thread Erik Rijkers
g("cannot use relation \"%s.%s\" as logical replication target" Do you agree? Thanks, Erik Rijkers

Re: pgsql: Try to fix compiler warnings.

2021-03-12 Thread Erik Rijkers
> On 2021.03.12. 21:06 Robert Haas wrote: > On Fri, Mar 12, 2021 at 2:52 PM wrote: > > > On 2021.03.12. 20:36 Robert Haas wrote: > > ../../../src/Makefile.global:919: recipe for target 'pg_amcheck.o' failed > > Makefile:43: recipe for target 'all-pg_amcheck-recurse' failed > > Makefile:42: recip

fix old confusing JSON example

2021-04-03 Thread Erik Rijkers
master. Thanks, Erik Rijkers--- doc/src/sgml/json.sgml.orig 2021-04-03 13:47:29.484510936 +0200 +++ doc/src/sgml/json.sgml 2021-04-03 13:47:53.028866752 +0200 @@ -489,7 +489,7 @@ SELECT jdoc->'guid', jdoc->'name' FROM api WHERE jdoc @@ '$.tags[*] == "qui"

Re: pgsql: JSON_TABLE

2022-04-04 Thread Erik Rijkers
ch is as near I have to a SQL Standard description. FWIW, I attach example sql+data from that .pdf from ISO (which is not online anymore). Thanks, Erik Rijkers bugmaybe.sh Description: application/shellscript

gcc 12.1.0 warning

2022-05-06 Thread Erik Rijkers
bool create_placeholders, bool skip_errors, | ^~~~ (Compiling with gcc 6.3.0 does not complain.) Below are the two configure lines, FWIW. Erik Rijkers # cassert-build: no warning/note ./configure \ --prefix=/home/aardvark/pg_stuff/pg_installations/pgsql.HEAD \ -

Re: pgsql: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST

2019-09-19 Thread Erik Rijkers
On 2019-09-19 21:11, Alexander Korotkov wrote: Improve handling of NULLs in KNN-GiST and KNN-SP-GiST Oops: create_index ... ok 634 ms create_index_spgist ... FAILED 438 ms create_view ... ok 329 ms

Re: pgsql: pg_dump: Add FOREIGN to ALTER statements, if appropriate

2020-03-20 Thread Erik Rijkers
On 2020-03-20 21:35, Alvaro Herrera wrote: pg_dump: Add FOREIGN to ALTER statements, if appropriate Author: Luis Carril Reviewed-by: Tomas Vondra, Daniel Gustafsson, Álvaro Herrera Discussion: https://postgr.es/m/lejpr01mb0185a19b2e7c98e5e2a031f5e7...@lejpr01mb0185.deuprd01.prod.outlook.de Bran

Re: pgsql: Some refactoring of logical/worker.c

2020-03-24 Thread Erik Rijkers
:22: warning: unused variable ‘remoterel’ [-Wunused-variable] 791 | LogicalRepRelation *remoterel = &relmapentry->remoterel; | Otherwise the build is fine (documentation build too, including .pdf, thanks Tom) Erik Rijkers

Re: pgsql: Fix default text search parser's ts_headline code for phrase que

2020-04-09 Thread Erik Rijkers
re is quite a lot of traffic on postgres-lists already; please let me know if it's maybe better to only report 'real' errors. Thanks, Erik Rijkers

git.postgresql.org ok?

2020-06-20 Thread Erik Rijkers
others see the same thing? Thanks, Erik Rijkers

Re: git.postgresql.org ok?

2020-06-20 Thread Erik Rijkers
On 2020-06-20 17:08, Stefan Kaltenbrunner wrote: the root issue should be fixed as of a few minutes ago but it might take a bit until everything is synced up again. Thanks!

Re: pgsql: docs: mention that expression indexes need analyze

2020-11-12 Thread Erik Rijkers
d, 10 insertions(+) Hi, This change contains: 'The regularly system' where probably was meant: 'The regular system' I think that dropping the word 'regular' entirely is even better. thanks, Erik Rijkers

Re: pgsql: docs: mention that expression indexes need analyze

2020-11-12 Thread Erik Rijkers
On 2020-11-12 21:29, Erik Rijkers wrote: On 2020-11-12 21:01, Bruce Momjian wrote: docs: mention that expression indexes need analyze Expression indexes can't benefit from pre-computed statistics on columns. This change contains: 'The regularly system' where probably w

Re: pgsql: Multirange datatypes

2020-12-19 Thread Erik Rijkers
On 2020-12-20 05:21, Alexander Korotkov wrote: Multirange datatypes Multiranges are basically sorted arrays of non-overlapping ranges with set-theoretic operations defined over them. With --enable-cassert gcc 10.1.0 gives me: typecmds.c: In function ‘DefineRange’: typecmds.c:1367:16: warni

Re: pgsql: Multirange datatypes

2020-12-20 Thread Erik Rijkers
On 2020-12-20 14:18, Alexander Korotkov wrote: On Sun, Dec 20, 2020 at 9:06 AM Erik Rijkers wrote: On 2020-12-20 05:21, Alexander Korotkov wrote: > Multirange datatypes > > Multiranges are basically sorted arrays of non-overlapping ranges with > set-theoretic operations defin

Re: pgsql: Add glossary entries related to superusers

2022-11-18 Thread Erik Rijkers
Op 18-11-2022 om 12:01 schreef Alvaro Herrera: Add glossary entries related to superusers Extracted from a more ambitious patch. Author: David G. Johnston Discussion: https://postgr.es/m/cakfquwzc4k0xybm0bwbmdozysbqhosekdhluaw4vpi+ozi8...@mail.gmail.com In initdb.sgml, 'boostrap' shou

Re: pgsql: Fix the display of lock information for specktoken.

2023-01-10 Thread Erik Rijkers
On 1/10/23 04:34, Amit Kapila wrote: Fix the display of lock information for specktoken. A transaction id is now displayed in the transactionid field and speculative insertion token is displayed in the objid field. Hi, 'A specualtive insertion lock' should be 'A speculative insertion lock'

Re: pgsql: Add basic JSON_TABLE() functionality

2024-04-04 Thread Erik Rijkers
Op 4/4/24 om 13:21 schreef Amit Langote: Add basic JSON_TABLE() functionality Great that it's now committed. Congrats! There is one 'uninitialized' muttering during compile (gcc 13.2.0): In function ‘transformJsonFuncExpr’, inlined from ‘transformExprRecurse’ at parse_expr.c:373:13: par