Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

On Fri, Dec 15, 2017 at 11:30 AM, Andres Freund wrote: > Alvaro, Michael, Peter, and everyone else I'd greatly appreciate if you > could have a look at the backported version, just about everything but > v10 had conflicts, some of them not insubstantial. I have gone through

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

On Thu, Dec 7, 2017 at 5:23 AM, Alvaro Herrera wrote: > Looking at 0002: I agree with the stuff being done here. The level of details you are providing with a proper error code is an improvement over the first version proposed in my opinion. > I think a > couple of

Re: [HACKERS] [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

On Wed, Dec 6, 2017 at 5:03 PM, Andres Freund wrote: > Ping. I'm a bit surprised that a bug fixing a significant data > corruption issue has gotten no reviews at all. Note that I was planning to look at this problem today and tomorrow my time, getting stuck for CF handling

pgsql: Fix and document lock handling for in-memory replication slot da

introduced, but as those race conditions are really unlikely going to happen as those concern code paths for slot and decoding creation, just fix the problem on HEAD. Author: Michael Paquier Discussion: https://postgr.es/m/20180528085747.ga27...@paquier.xyz Branch -- master Details

pgsql: Fix grammar in REVOKE documentation

Fix grammar in REVOKE documentation Reported-by: Erwin Brandstetter Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6620b0faf3d18460037fe0922b7f0a355ca021d2 Modified Files -- doc/src/sgml/ref/revoke.sgml | 2 +- 1 file changed, 1 insertion(+), 1

pgsql: Fix grammar in REVOKE documentation

Fix grammar in REVOKE documentation Reported-by: Erwin Brandstetter Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c83e2029909c5411ca11fd841851016f1f9810e6 Modified Files -- doc/src/sgml/ref/revoke.sgml | 2 +- 1 file changed, 1 insertion(+), 1

pgsql: Fix grammar in REVOKE documentation

Fix grammar in REVOKE documentation Reported-by: Erwin Brandstetter Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/50dfe3a44c65e8abf853d7bdc222002151c7046b Modified Files -- doc/src/sgml/ref/revoke.sgml | 2 +- 1 file changed, 1 insertion(+), 1

pgsql: Fix grammar in REVOKE documentation

Fix grammar in REVOKE documentation Reported-by: Erwin Brandstetter Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5bb08c7000db0f3f6621316105de1711f7b559a5 Modified Files -- doc/src/sgml/ref/revoke.sgml | 2 +- 1 file changed, 1 insertion(+), 1

pgsql: Fix grammar in REVOKE documentation

Fix grammar in REVOKE documentation Reported-by: Erwin Brandstetter Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/25a85613b77b9c8b894be2a238ead3716f56a68c Modified Files -- doc/src/sgml/ref/revoke.sgml | 2 +- 1 file changed, 1 insertion(+), 1

pgsql: Fix grammar in REVOKE documentation

Fix grammar in REVOKE documentation Reported-by: Erwin Brandstetter Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fd73508fd15937da6580bed7080ed77563e7e39f Modified Files -- doc/src/sgml/ref/revoke.sgml | 2 +- 1 file changed, 1 insertion(+), 1

pgsql: Fix a couple of bugs with replication slot advancing feature

this is left for a future exercise. Author: Michael Paquier Reviewed-by: Petr Jelinek, Simon Riggs Discussion: https://postgr.es/m/CANP8+jLyS=X-CAk59BJnsxKQfjwrmKicHQykyn52Qj-Q=9g...@mail.gmail.com Discussion: https://www.postgresql.org/message-id/2840048a-1184-417a-9da8-3299d207a1d7%40postgrespro.ru

pgsql: Fix grammar in documentation related to checkpoint_flush_after

Fix grammar in documentation related to checkpoint_flush_after Reported-by: Christopher Jones Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/256d43128d21891b6090e6fc19668e27da04764b Modified Files -- doc/src/sgml/wal.sgml | 4 ++-- 1 file

pgsql: Fix grammar in documentation related to checkpoint_flush_after

Fix grammar in documentation related to checkpoint_flush_after Reported-by: Christopher Jones Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/858571843c8a5a69527faa3e57f8adfa4165 Modified Files -- doc/src/sgml/wal.sgml | 4 ++-- 1 file

pgsql: Fix grammar in documentation related to checkpoint_flush_after

Fix grammar in documentation related to checkpoint_flush_after Reported-by: Christopher Jones Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d61bfdda8c2cae671ca4a252993bb8feaa619285 Modified Files -- doc/src/sgml/wal.sgml | 4 ++-- 1 file changed, 2

pgsql: Track new configure flags introduced for version 11 in pg_config

the flags mentioned above need to be enabled in pg_config.h.win32. Author: Michael Paquier Reviewed-by: Andrew Dunstan Discussion: https://postgr.es/m/20180529211559.gf6...@paquier.xyz Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bde64eb6107622e8438dd61b93afd4

Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue()

On Fri, Jun 15, 2018 at 10:25:27AM -0400, Tom Lane wrote: > Alexander Korotkov writes: >> It doesn't contain something particular wrong, but it's just badly >> formatted. As I can see, we're keeping lines in commit messages no >> longer than 80 characters when possible. I've commit message with

Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue()

On Fri, Jun 15, 2018 at 11:01:26AM -0400, Tom Lane wrote: > David Fetter writes: >> Perhaps we could acquire the short.pg domain and run it off that. > > We're already using postgr.es, so it's not going to get much shorter > just from mucking with the domain part. We'd need to set up some >

pgsql: Prevent hard failures of standbys caused by recycled WAL segment

Reviewed-by: Tsunakawa Takayuki Author: Michael Paquier Discussion: https://postgr.es/m/0A3221C70F24FB45833433255569204D1F8B57AD@G01JPEXMBYT05 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5860b22c455ff197d568dabcea591d2afc769f34 Modified Files

pgsql: Prevent hard failures of standbys caused by recycled WAL segment

Reviewed-by: Tsunakawa Takayuki Author: Michael Paquier Discussion: https://postgr.es/m/0A3221C70F24FB45833433255569204D1F8B57AD@G01JPEXMBYT05 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/70b4f82a4b5cab5fc12ff876235835053e407155 Modified Files -- src

pgsql: Prevent hard failures of standbys caused by recycled WAL segment

Reviewed-by: Tsunakawa Takayuki Author: Michael Paquier Discussion: https://postgr.es/m/0A3221C70F24FB45833433255569204D1F8B57AD@G01JPEXMBYT05 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e41c7954820955c7517b019e2a31d112668ea119 Modified Files

pgsql: Prevent hard failures of standbys caused by recycled WAL segment

Reviewed-by: Tsunakawa Takayuki Author: Michael Paquier Discussion: https://postgr.es/m/0A3221C70F24FB45833433255569204D1F8B57AD@G01JPEXMBYT05 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/fb28104a4baa5488e89fbd7ec2cc7dce1a90fce6 Modified Files

Re: pgsql: Fix and document lock handling for in-memory replication slot da

On Mon, Jun 11, 2018 at 09:49:52AM -0700, Andres Freund wrote: > Same is true for the codepaths calling GetRedoRecPtr(). You are right. I'll fix in a minute. A first commit's stress make things really harder to get right... > I don't object to the general idea of adding locking - although the

pgsql: Use optimized bitmap set function for membership test in postgre

Use optimized bitmap set function for membership test in postgres_fdw Deparsing logic in postgres_fdw for locking, FROM clause (alias) and Var (column qualification) does not need to know the exact number of members involved, which can be calculated with bms_num_members(), but just if there is

pgsql: Add tests for inheritance trees mixing permanent and temporary r

. A lot of cross-checks happen in MergeAttributes() which is not designed for this purpose, so the tests added in this commit will make sure that any kind of future refactoring will limit the amount of compatibility breakage. Author: Michael Paquier Reviewed-by: Ashutosh Bapat Discussion: https

Re: Tips on committing

On Fri, Jun 29, 2018 at 06:02:07PM -0400, Bruce Momjian wrote: > On Thu, Jun 28, 2018 at 09:46:17AM -0700, Peter Geoghegan wrote: >> * Don't assume that you haven't broken the doc build if you make even >> a trivial doc change. Removing a GUC can break instances in the >> release notes where

pgsql: Add wait event for fsync of WAL segments

Knizhnik Author: Konstantin Knizhnik Reviewed-by: Craig Ringer, Michael Paquier Discussion: https://postgr.es/m/4a243897-0ad8-f471-aa40-242591f24...@postgrespro.ru Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c55de5e5123ce58ee19a47c08425949599285041 Modified

pgsql: Correct handling of fsync failures with tar mode of walmethods.c

this code has been introduced. Reported by: Michael Paquier, Kuntal Ghosh Author: Michael Paquier Reviewed-by: Kuntal Ghosh, Magnus Hagander Discussion: https://postgr.es/m/20180625024356.gd1...@paquier.xyz Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Correct handling of fsync failures with tar mode of walmethods.c

this code has been introduced. Reported by: Michael Paquier, Kuntal Ghosh Author: Michael Paquier Reviewed-by: Kuntal Ghosh, Magnus Hagander Discussion: https://postgr.es/m/20180625024356.gd1...@paquier.xyz Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Fix description and documentation related to pg_restore --no-com

Fix description and documentation related to pg_restore --no-comments These descriptions have been referring to object dump, but a restore operation is done. Reported-by: Andrey Lizenko Author: Andrey Lizenko Discussion:

pgsql: Address set of issues with errno handling

uses the brute-force approach of correcting all those code paths. Some refactoring could happen in the future, but this is let as future work, which is not targeted for back-branches anyway. Author: Michael Paquier Reviewed-by: Ashutosh Sharma Discussion: https://postgr.es/m/20180622061535.gd5

pgsql: Address set of issues with errno handling

uses the brute-force approach of correcting all those code paths. Some refactoring could happen in the future, but this is let as future work, which is not targeted for back-branches anyway. Author: Michael Paquier Reviewed-by: Ashutosh Sharma Discussion: https://postgr.es/m/20180622061535.gd5

pgsql: Address set of issues with errno handling

uses the brute-force approach of correcting all those code paths. Some refactoring could happen in the future, but this is let as future work, which is not targeted for back-branches anyway. Author: Michael Paquier Reviewed-by: Ashutosh Sharma Discussion: https://postgr.es/m/20180622061535.gd5

pgsql: Address set of issues with errno handling

uses the brute-force approach of correcting all those code paths. Some refactoring could happen in the future, but this is let as future work, which is not targeted for back-branches anyway. Author: Michael Paquier Reviewed-by: Ashutosh Sharma Discussion: https://postgr.es/m/20180622061535.gd5

pgsql: Address set of issues with errno handling

uses the brute-force approach of correcting all those code paths. Some refactoring could happen in the future, but this is let as future work, which is not targeted for back-branches anyway. Author: Michael Paquier Reviewed-by: Ashutosh Sharma Discussion: https://postgr.es/m/20180622061535.gd5

pgsql: Address set of issues with errno handling

uses the brute-force approach of correcting all those code paths. Some refactoring could happen in the future, but this is let as future work, which is not targeted for back-branches anyway. Author: Michael Paquier Reviewed-by: Ashutosh Sharma Discussion: https://postgr.es/m/20180622061535.gd5

pgsql: Clarify use of temporary tables within partition trees

there. Documentation also includes limitations related to the use of temporary tables with partition trees. Reported-by: David Rowley Author: Amit Langote, Michael Paquier Reviewed-by: Ashutosh Bapat, Amit Langote, Michael Paquier Discussion: https://postgr.es/m/CAKJS1f94Ojk0og9GMkRHGt8wHTW=ijq5kzjkuoboqwlwsvw

Re: pgsql: Clarify use of temporary tables within partition trees

On Mon, Jul 02, 2018 at 02:07:37PM -0400, Robert Haas wrote: > I'd rather keep an elog(ERROR) than completely remove the check. +1. > Also, for the record, I think the subject line of Michael's commit > message was pretty unclear about what it was actually doing. How would you formulate it?

Re: pgsql: Add wait event for fsync of WAL segments

On Mon, Jul 02, 2018 at 12:23:35PM -0400, Alvaro Herrera wrote: > I wonder if we should backpatch this one all the way to pg10. I don't > see no reason not to. ABI breakage (if that's the correct wording?). Simply cherry-picking the patch from master to back-branches would cause extensions and

Re: pgsql: Clarify use of temporary tables within partition trees

On Tue, Jul 03, 2018 at 09:05:41PM +1200, David Rowley wrote: > > [...] > > I'd categorise this one the same as I have #1 above, i.e. not > backpatch material. It seems like something useful to look into for > v12 though. I assumed this was done for a reason and that I just > didn't understand

Re: pgsql: Clarify use of temporary tables within partition trees

On Tue, Jul 03, 2018 at 09:30:20PM +1200, David Rowley wrote: > On 3 July 2018 at 21:15, Michael Paquier wrote: > > Yeah. Actually I'd like to add a test as well to test the recursion > > call of expand_partitioned_rtentry. If you have an idea, please let me > > know o

Re: pgsql: Clarify use of temporary tables within partition trees

On Tue, Jul 03, 2018 at 11:16:55PM +1200, David Rowley wrote: > Oh okay. Yeah, you can hit that with a partitionless sub-partitioned > table. Thanks for the patch and fixing the typo ;) +create table list_parted_tbl (a int,b int) partition by list (a); +create table list_parted_tbl1 partition of

pgsql: Fix typo in comment of commit_ts.c for incorrect reference to CL

Fix typo in comment of commit_ts.c for incorrect reference to CLOG Author: Shao Bret Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0aa5e65ab4fd2695f0e4108b9ec53a0546261e1f Modified Files -- src/backend/access/transam/commit_ts.c | 3 ++- 1 file

pgsql: Add verbosity to pg_basebackup for sync

Add verbosity to pg_basebackup for sync This is useful to know when the data copy has been finished. The current situation can be confusing for users as the last message is "waiting for background process to finish streaming", so it looks like this is taking time but the final sync is instead.

pgsql: Fix two oversights from 9ebe0572 which refactored cluster_rel

Fix two oversights from 9ebe0572 which refactored cluster_rel The recheck option became a no-op as ClusterOption failed to set proper values for each element. There was a second code path where local options got overwritten. Both issues have been spotted by Coverity. Branch -- master

pgsql: Make error message of pageinspect more consistent for raw page i

Make error message of pageinspect more consistent for raw page inputs There is a copy-paste error from bt_page_items() which got into bt_page_items_bytea(). A second message in get_raw_page_internal() was inconsistent with all the other sub-modules. Author: Ashutosh Sharma Discussion:

Re: pgsql: Refactor geometric functions and operators

On Sun, Jul 29, 2018 at 12:43:29AM +, Tomas Vondra wrote: > Refactor geometric functions and operators > > The primary goal of this patch is to eliminate duplicate code and share > code between different geometric data types more often, to prepare the > ground for additional patches. Until

pgsql: Fix handling of pgbench's hash when no argument is provided

Fix handling of pgbench's hash when no argument is provided Depending on the platform used, this can cause a crash in the worst case, or an unhelpful error message, so fail gracefully. Author: Fabien Coelho Discussion: https://postgr.es/m/alpine.DEB.2.21.1807262302550.29874@lancre Backpatch:

pgsql: Fix handling of pgbench's hash when no argument is provided

Fix handling of pgbench's hash when no argument is provided Depending on the platform used, this can cause a crash in the worst case, or an unhelpful error message, so fail gracefully. Author: Fabien Coelho Discussion: https://postgr.es/m/alpine.DEB.2.21.1807262302550.29874@lancre Backpatch:

Re: pgsql: Address set of issues with errno handling

On Sat, Aug 04, 2018 at 11:21:28AM -0400, Tom Lane wrote: > That looks good as far as it goes. I didn't cross-check that you > hit everyplace that needs this, but if you grepped for references to > ENOSPC then you presumably found them all. That's exactly how the history goes. > IMO, it's OK to

pgsql: Reset properly errno before calling write()

. Reported-by: Tom Lane Author: Michael Paquier Reviewed-by: Tom Lane Discussion: https://postgr.es/m/31797.1533326...@sss.pgh.pa.us Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5a23c74b63ec9f63c648f79b13a900c37332ee55 Modified Files -- src/backend/access

pgsql: Reset properly errno before calling write()

. Reported-by: Tom Lane Author: Michael Paquier Reviewed-by: Tom Lane Discussion: https://postgr.es/m/31797.1533326...@sss.pgh.pa.us Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/afd5fde856675f54a7b5d857f7a173f9a3237b57 Modified Files -- src/backend

pgsql: Reset properly errno before calling write()

. Reported-by: Tom Lane Author: Michael Paquier Reviewed-by: Tom Lane Discussion: https://postgr.es/m/31797.1533326...@sss.pgh.pa.us Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7124e64520834cd238c9f0efcfe429c28696b11d Modified Files -- src/backend

pgsql: Reset properly errno before calling write()

. Reported-by: Tom Lane Author: Michael Paquier Reviewed-by: Tom Lane Discussion: https://postgr.es/m/31797.1533326...@sss.pgh.pa.us Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/58673b4a5fdff4d0d327c2d07e0cf8743f86f44c Modified Files -- src/backend

pgsql: Reset properly errno before calling write()

. Reported-by: Tom Lane Author: Michael Paquier Reviewed-by: Tom Lane Discussion: https://postgr.es/m/31797.1533326...@sss.pgh.pa.us Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e69a3ac4a3e0ba640264a94dded197c21c33aa11 Modified Files -- src/backend

pgsql: Reset properly errno before calling write()

. Reported-by: Tom Lane Author: Michael Paquier Reviewed-by: Tom Lane Discussion: https://postgr.es/m/31797.1533326...@sss.pgh.pa.us Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f5b4bb88120f8945ead702bec0e4eaf46542e8f3 Modified Files -- src/backend

pgsql: Improve TRUNCATE by avoiding early lock queue

for CLUSTER, no back-patch is done. Reported-by: Lloyd Albin, Jeremy Schneider Author: Michael Paquier Reviewed by: Nathan Bossart, Kyotaro Horiguchi Discussion: https://postgr.es/m/152512087100.19803.12733865831237526...@wrigleys.postgresql.org Discussion: https://postgr.es/m/20180806165816.ga19

pgsql: Restrict access to reindex of shared catalogs for non-privileged

is the table owner - The user is the database/schema owner, only if the relation worked on is not shared. Robert has worded most the documentation changes, and I have coded the core part. Reported-by: Lloyd Albin, Jeremy Schneider Author: Michael Paquier, Robert Haas Reviewed by: Nathan Bossart

pgsql: Restrict access to reindex of shared catalogs for non-privileged

is the table owner - The user is the database/schema owner, only if the relation worked on is not shared. Robert has worded most the documentation changes, and I have coded the core part. Reported-by: Lloyd Albin, Jeremy Schneider Author: Michael Paquier, Robert Haas Reviewed by: Nathan Bossart

pgsql: Update comment in header of errcodes.txt

Update comment in header of errcodes.txt This file mentions all the files generated from it, but missed that errcodes-list.sgml is no more, while errcodes-table.sgml is. Author: Noriyoshi Shinoda Discussion:

pgsql: Mention ownership requirements for REFRESH MATERIALIZED VIEW in

Mention ownership requirements for REFRESH MATERIALIZED VIEW in docs Author: Dian Fay Discussion: https://postgr.es/m/745abbd2-a1a0-ead8-2cb2-768c16747...@gmail.com Backpatch-through: 9.3 Branch -- REL9_3_STABLE Details ---

pgsql: Mention ownership requirements for REFRESH MATERIALIZED VIEW in

Mention ownership requirements for REFRESH MATERIALIZED VIEW in docs Author: Dian Fay Discussion: https://postgr.es/m/745abbd2-a1a0-ead8-2cb2-768c16747...@gmail.com Backpatch-through: 9.3 Branch -- REL_11_STABLE Details ---

pgsql: Mention ownership requirements for REFRESH MATERIALIZED VIEW in

Mention ownership requirements for REFRESH MATERIALIZED VIEW in docs Author: Dian Fay Discussion: https://postgr.es/m/745abbd2-a1a0-ead8-2cb2-768c16747...@gmail.com Backpatch-through: 9.3 Branch -- REL9_6_STABLE Details ---

pgsql: Mention ownership requirements for REFRESH MATERIALIZED VIEW in

Mention ownership requirements for REFRESH MATERIALIZED VIEW in docs Author: Dian Fay Discussion: https://postgr.es/m/745abbd2-a1a0-ead8-2cb2-768c16747...@gmail.com Backpatch-through: 9.3 Branch -- REL9_5_STABLE Details ---

pgsql: Mention ownership requirements for REFRESH MATERIALIZED VIEW in

Mention ownership requirements for REFRESH MATERIALIZED VIEW in docs Author: Dian Fay Discussion: https://postgr.es/m/745abbd2-a1a0-ead8-2cb2-768c16747...@gmail.com Backpatch-through: 9.3 Branch -- master Details ---

pgsql: Mention ownership requirements for REFRESH MATERIALIZED VIEW in

Mention ownership requirements for REFRESH MATERIALIZED VIEW in docs Author: Dian Fay Discussion: https://postgr.es/m/745abbd2-a1a0-ead8-2cb2-768c16747...@gmail.com Backpatch-through: 9.3 Branch -- REL9_4_STABLE Details ---

pgsql: Mention ownership requirements for REFRESH MATERIALIZED VIEW in

Mention ownership requirements for REFRESH MATERIALIZED VIEW in docs Author: Dian Fay Discussion: https://postgr.es/m/745abbd2-a1a0-ead8-2cb2-768c16747...@gmail.com Backpatch-through: 9.3 Branch -- REL_10_STABLE Details ---

pgsql: Make autovacuum more aggressive to remove orphaned temp tables

been written in its first version by Tsunakawa Takayuki, then heavily reviewed by me. Author: Tsunakawa Takayuki Reviewed-by: Michael Paquier, Kyotaro Horiguchi, Andres Freund Discussion: https://postgr.es/m/0A3221C70F24FB45833433255569204D1F8A4DC6@G01JPEXMBYT05 Backpatch: 11-, as PGPROC gains

pgsql: Make autovacuum more aggressive to remove orphaned temp tables

been written in its first version by Tsunakawa Takayuki, then heavily reviewed by me. Author: Tsunakawa Takayuki Reviewed-by: Michael Paquier, Kyotaro Horiguchi, Andres Freund Discussion: https://postgr.es/m/0A3221C70F24FB45833433255569204D1F8A4DC6@G01JPEXMBYT05 Backpatch: 11-, as PGPROC gains

pgsql: Clarify comment about assignment and reset of temp namespace ID

Clarify comment about assignment and reset of temp namespace ID in MyProc The new wording comes from Álvaro, which I modified a bit. Reported-by: Andres Freund, Álvaro Herrera Author: Álvaro Herrera, Michael Paquier Discussion: https://postgr.es/m/20180809165047.gk13...@paquier.xyz Backpatch

pgsql: Clarify comment about assignment and reset of temp namespace ID

Clarify comment about assignment and reset of temp namespace ID in MyProc The new wording comes from Álvaro, which I modified a bit. Reported-by: Andres Freund, Álvaro Herrera Author: Álvaro Herrera, Michael Paquier Discussion: https://postgr.es/m/20180809165047.gk13...@paquier.xyz Backpatch

pgsql: Fix set of NLS translation issues

with future features. - GSSAPI authentication missed two translations. - vacuumdb handles non-translated strings. Reported-by: Kyotaro Horiguchi Author: Kyotaro Horiguchi Reviewed-by: Michael Paquier, Tom Lane Discussion: https://postgr.es/m/20180810.152131.31921918.horiguchi.kyot...@lab.ntt.co.jp

pgsql: Fix typo in description of enable_parallel_hash

Fix typo in description of enable_parallel_hash Author: Kyotaro Horiguchi Discussion: https://postgr.es/m/20180821.115841.93250330.horiguchi.kyot...@lab.ntt.co.jp Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/87c596cda6d7c79266cde44a1e9fc8ea1b8acefa

pgsql: Fix typo in description of enable_parallel_hash

Fix typo in description of enable_parallel_hash Author: Kyotaro Horiguchi Discussion: https://postgr.es/m/20180821.115841.93250330.horiguchi.kyot...@lab.ntt.co.jp Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d8c83800c3ed2f0d677eb6620a9e9dc7b81a678b Modified

pgsql: Fix set of NLS translation issues

with future features. - GSSAPI authentication missed two translations. - vacuumdb handles non-translated strings. Reported-by: Kyotaro Horiguchi Author: Kyotaro Horiguchi Reviewed-by: Michael Paquier, Tom Lane Discussion: https://postgr.es/m/20180810.152131.31921918.horiguchi.kyot...@lab.ntt.co.jp

pgsql: Fix set of NLS translation issues

with future features. - GSSAPI authentication missed two translations. - vacuumdb handles non-translated strings. Reported-by: Kyotaro Horiguchi Author: Kyotaro Horiguchi Reviewed-by: Michael Paquier, Tom Lane Discussion: https://postgr.es/m/20180810.152131.31921918.horiguchi.kyot...@lab.ntt.co.jp

pgsql: Fix set of NLS translation issues

with future features. - GSSAPI authentication missed two translations. - vacuumdb handles non-translated strings. Reported-by: Kyotaro Horiguchi Author: Kyotaro Horiguchi Reviewed-by: Michael Paquier, Tom Lane Discussion: https://postgr.es/m/20180810.152131.31921918.horiguchi.kyot...@lab.ntt.co.jp

pgsql: Fix set of NLS translation issues

: Kyotaro Horiguchi Reviewed-by: Michael Paquier, Tom Lane Discussion: https://postgr.es/m/20180810.152131.31921918.horiguchi.kyot...@lab.ntt.co.jp Backpatch-through: 9.3 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/72be8c29a18812975fcc8765a122faf0e4d0c755 Modified

pgsql: Fix set of NLS translation issues

Fix set of NLS translation issues While monitoring the code, it has been noticed that GSSAPI authentication missed two translations. Reported-by: Kyotaro Horiguchi Author: Kyotaro Horiguchi Reviewed-by: Michael Paquier, Tom Lane Discussion: https://postgr.es/m/20180810.152131.31921918

pgsql: Add regression tests for VACUUM and ANALYZE with relation skips

refactoring related to ownership checks for relations vacuumed or analyzed. Author: Michael Paquier Reviewed-by: Nathan Bossart Discussion: https://postgr.es/m/2018081142.ga6...@paquier.xyz Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Do not dump identity sequences with excluded parent table

if the parent table is defined as such. Knowing about such sequences has no meaning without their parent table anyway. Reported-by: Andy Abelisto Author: David Rowley Reviewed-by: Peter Eisentraut, Michael Paquier Discussion: https://postgr.es/m/153479393218.1316.8472285660264976

pgsql: Do not dump identity sequences with excluded parent table

if the parent table is defined as such. Knowing about such sequences has no meaning without their parent table anyway. Reported-by: Andy Abelisto Author: David Rowley Reviewed-by: Peter Eisentraut, Michael Paquier Discussion: https://postgr.es/m/153479393218.1316.8472285660264976

pgsql: Do not dump identity sequences with excluded parent table

if the parent table is defined as such. Knowing about such sequences has no meaning without their parent table anyway. Reported-by: Andy Abelisto Author: David Rowley Reviewed-by: Peter Eisentraut, Michael Paquier Discussion: https://postgr.es/m/153479393218.1316.8472285660264976

pgsql: Add more tests for VACUUM skips with partitioned tables

tables is present since 10. Author: Nathan Bossart Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/dc186201-b01f-4a66-9ec4-f855a957c...@amazon.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a569eea6998a26689409ff6eb5fce2c1eab0f5e1 Modified Files

pgsql: Fix documentation for run-time partition pruning

Fix documentation for run-time partition pruning Since 5220bb7, not only Append, but also MergeAppend support the operation. Author: Amit Langote Discussion: https://postgr.es/m/59d8eb92-4536-c44e-54e2-305b9b3d8...@lab.ntt.co.jp Branch -- master Details ---

pgsql: Rework option set of vacuumlo

consistent. A basic set of TAP tests has been added while on it. Author: Tatsuro Yamada Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/c7e7f25c-1747-cd0f-9335-390bc97b2...@lab.ntt.co.jp Branch -- master Details --- https://git.postgresql.org/pg/commitdiff

pgsql: Rework option set of oid2name

with other things. Author: Tatsuro Yamada Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/c7e7f25c-1747-cd0f-9335-390bc97b2...@lab.ntt.co.jp Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1aaf532deabfa356c99abc80fc78d988ad1f1355 Modified Files

Re: pgsql: Rework option set of vacuumlo

On Tue, Aug 28, 2018 at 05:08:25PM -0400, Tom Lane wrote: > I wrote: >> Digging, this is because the "make check" processing isn't actually >> installing oid2name (resp. vacuumlo) into the temp installation tree :-(. >> >> I don't think this is the fault of your tests, exactly --- there's >>

pgsql: Improve VACUUM and ANALYZE by avoiding early lock queue

implemented vacuum for partitioned tables. The original problem reported related to early lock queue for critical relations is fixed anyway, so priority is given to avoiding a backward-incompatible behavior. Reported-by: Lloyd Albin, Jeremy Schneider Author: Michael Paquier Reviewed by: Nathan Bossart

pgsql: Fix re-parameterize of MergeAppendPath

to that. Author: Michael Paquier Reviewed-by: Ashutosh Bapat Discussion: https://postgr.es/m/20180718062202.gc8...@paquier.xyz Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c6598b8b0514bcb9b4c99f2412927368a7514180 Modified Files -- src/backend/optimizer/util

pgsql: Fix re-parameterize of MergeAppendPath

to that. Author: Michael Paquier Reviewed-by: Ashutosh Bapat Discussion: https://postgr.es/m/20180718062202.gc8...@paquier.xyz Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6365ebacdd08f988cd31572c7190c8f08194bf5d Modified Files -- src/backend/optimizer

pgsql: Fix print of Path nodes when using OPTIMIZER_DEBUG

and additions. Author: Sawada Masahiko Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CAD21AoBQMLoc=ohh-oocuapselrmk8_esrjjoyr8fqlzkbe...@mail.gmail.com Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/164ed1532f78574a904b4bd080c28105a45e2765 Modified

pgsql: Fix print of Path nodes when using OPTIMIZER_DEBUG

and additions. Author: Sawada Masahiko Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CAD21AoBQMLoc=ohh-oocuapselrmk8_esrjjoyr8fqlzkbe...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b33ef397a1698ddd06f325d0f92a6643ec55577f Modified Files

pgsql: Fix print of Path nodes when using OPTIMIZER_DEBUG

and additions. Author: Sawada Masahiko Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CAD21AoBQMLoc=ohh-oocuapselrmk8_esrjjoyr8fqlzkbe...@mail.gmail.com Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bc62aef53d686b282f164277da0f2405a4fd0ac3 Modified

pgsql: Fix print of Path nodes when using OPTIMIZER_DEBUG

and additions. Author: Sawada Masahiko Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CAD21AoBQMLoc=ohh-oocuapselrmk8_esrjjoyr8fqlzkbe...@mail.gmail.com Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3ecd6c4ab9ddfe22e0c6df0fba412c900614aa23 Modified

pgsql: Fix print of Path nodes when using OPTIMIZER_DEBUG

and additions. Author: Sawada Masahiko Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CAD21AoBQMLoc=ohh-oocuapselrmk8_esrjjoyr8fqlzkbe...@mail.gmail.com Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/49d506dd2162c1798150bab18d7c332d29b4aa93 Modified

pgsql: Bump catalog version for recent toast table additions

Bump catalog version for recent toast table additions This has been forgotten in 96cdeae. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f2b1316a94796b69eed6773cfb38267947ea19ac Modified Files -- src/include/catalog/catversion.h | 2 +- 1 file changed,

pgsql: Add toast tables to most system catalogs

, exclude pg_largeobject and pg_largeobject_metadata from the set as large object data is handled as user data. Those relations have no reason to use a toast table anyway. Author: Joe Conway, John Naylor Reviewed-by: Michael Paquier, Tom Lane Discussion: https://postgr.es/m/84ddff04-f122-784b

Re: pgsql: Rework error messages around file handling

On Wed, Jul 18, 2018 at 09:14:14AM +0900, Michael Paquier wrote: > Thanks for double-checking, pushed. This attempt made longfin happier for the path patched, but there were a couple of other ones which were hidden behind. I got them fixed now, which should bring the machine back to gr

pgsql: Fix more portability issues with casts to Size when using off_t

Fix more portability issues with casts to Size when using off_t This should tame the beast, as there are no other places where off_t is used in the new error messages. Reported again by longfin, which complained about walsender.c while I spotted the other two ones while double-checking. Branch

Re: pgsql: Rework error messages around file handling

On Tue, Jul 17, 2018 at 07:23:04PM -0400, Tom Lane wrote: > Michael Paquier writes: > > Rework error messages around file handling > > longfin thinks you missed at least one cast ... Hm, I checked that. Just casting to (Size) should do it. I cannot get a warning with neithe

  1   2   3   4   5   6   7   8   9   10   >