Re: pgsql: Fix behavior of ~> (cube, int) operator

2018-04-10 Thread Teodor Sigaev
Pushed, thank you Alexander Korotkov wrote: On Sun, Jan 21, 2018 at 11:20 PM, Tom Lane > wrote: Teodor Sigaev mailto:teo...@sigaev.ru>> writes: > Fix behavior of ~> (cube, int) operator This patch has caused Coverity to complain, correctly AFAICS, about

Re: pgsql: Fix behavior of ~> (cube, int) operator

2018-04-10 Thread Teodor Sigaev
inverse variable becomes unused, will remove Alexander Korotkov wrote: Seems to be due to sloppy division of changes between f50c80dbb (which was not back-patched) and 563a053bd.  Please fix. Thank you for catching this.  You diagnosis is right. I propose to commit the attached patch

Re: pgsql: Fix behavior of ~> (cube, int) operator

2018-04-10 Thread Alexander Korotkov
On Sun, Jan 21, 2018 at 11:20 PM, Tom Lane wrote: > Teodor Sigaev writes: > > Fix behavior of ~> (cube, int) operator > > This patch has caused Coverity to complain, correctly AFAICS, about > dead code in cube_coord_llur in the back branches: > > 1628/* Inverse value if needed */ > 1

Re: pgsql: Fix behavior of ~> (cube, int) operator

2018-01-21 Thread Tom Lane
Teodor Sigaev writes: > Fix behavior of ~> (cube, int) operator This patch has caused Coverity to complain, correctly AFAICS, about dead code in cube_coord_llur in the back branches: 1628/* Inverse value if needed */ 1629if (inverse) >>> CID 1463943: Control flow iss