Peter Eisentraut <pete...@gmx.net> writes: > Remove byte-masking macros for Datum conversion macros
Looking at the code now, I think there's at least one bad outcome of this change: the behavior of CharGetDatum() is now ill-defined, because we'll (probably) get different results on signed-char and unsigned-char compilers. I think we'd be well advised to make that macro be #define CharGetDatum(X) ((Datum) ((unsigned char) (X))) regards, tom lane